From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E085C25B75 for ; Thu, 6 Jun 2024 03:24:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00D9C6B0085; Wed, 5 Jun 2024 23:24:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F002B6B00A0; Wed, 5 Jun 2024 23:24:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9F8C6B00A2; Wed, 5 Jun 2024 23:24:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BD2936B0085 for ; Wed, 5 Jun 2024 23:24:45 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 694F24068E for ; Thu, 6 Jun 2024 03:24:45 +0000 (UTC) X-FDA: 82199021730.22.3697CF9 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf24.hostedemail.com (Postfix) with ESMTP id AB8CD180006 for ; Thu, 6 Jun 2024 03:24:41 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717644283; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1KwFRM0LwHxm/QAzhm4p4dUi0VzFz7fJGkp+Hk01OTA=; b=8dmc8y3dMnfYzl3nKjzBXowo3+bTVHx13wtIw1499SJ/cDWSwfBtV962R9bFCpFBUnB0kw +UD09yUrYwVKQFypmctxrU+Bk+q9PmdO8ZpDBbJZPKFLP42V7ucJOqpqy8gDCVx4fJsGN0 wPOCF1KacU9YNDQ1aq1HE9SyPdxvRxU= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717644283; a=rsa-sha256; cv=none; b=1LsMLhZMCUbGU88pU8eVzCwfiWln5r5YQXp5EnHxNBidC0qK9ilZ7D2hxaspTkikxsptUz eNqoDodZYbFkpMcvkKJwA+17Eq1dPgo0UahNTrC9ZxE3FhbSAknYoY/YpkYV5zp1tUg5nt 4xT0yj4uMv23SlbN4jBHFVaUx2qPqLU= Received: from mail.maildlp.com (unknown [172.19.163.235]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4VvqST0pvVz4f3nKP for ; Thu, 6 Jun 2024 11:24:25 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.252]) by mail.maildlp.com (Postfix) with ESMTP id 48D061A0904 for ; Thu, 6 Jun 2024 11:24:36 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP3 (Coremail) with SMTP id _Ch0CgAnMJjyK2Fmz2rqOQ--.40149S2; Thu, 06 Jun 2024 11:24:36 +0800 (CST) Subject: Re: [PATCH v2 8/8] writeback: factor out balance_wb_limits to remove repeated code To: Tejun Heo Cc: willy@infradead.org, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240514125254.142203-1-shikemeng@huaweicloud.com> <20240514125254.142203-9-shikemeng@huaweicloud.com> From: Kemeng Shi Message-ID: <6d5e260e-4910-92d1-faf4-8aee0b78b16d@huaweicloud.com> Date: Thu, 6 Jun 2024 11:24:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit X-CM-TRANSID:_Ch0CgAnMJjyK2Fmz2rqOQ--.40149S2 X-Coremail-Antispam: 1UD129KBjvdXoWruFyrWFW8JF4UCF43Zr4DXFb_yoW3Wwb_WF s29aykKw4UuFs7ta1vyF45J34xGFWrXryUZ348Way7C34fAa1UWay5WFyav3WxJr4IkF9x W3Z2g340kry2vjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbzAYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwV A0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWDJVCq3wA2z4x0Y4vE2Ix0cI8IcVCY1x02 67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I 0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40E x7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x 0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07AlzVAYIcxG8wCF04k20xvY0x0E wIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E74 80Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0 I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04 k26cxKx2IYs7xG6rW3Jr0E3s1lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY 1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjxUzsqWUUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: AB8CD180006 X-Stat-Signature: 64pb7xeuayfitxz4fn7jgpox19x7jwgo X-HE-Tag: 1717644281-295508 X-HE-Meta: U2FsdGVkX18GV00PsU0S0Rd1RVqzREgm2R02Ukn7Gn74qcHaHbewXfaCBf8l0eVyFcwXqklcbfimcyKFK65veBoe3OgStVizv2KI6OtCizCeHCrkxRFqR6cSNzyfUeBtJqKTtCXlgm028d2fRQcCTerbyaG5hPkJRIS7vPe1tR3rBJrPEv5v9EUr4TOreQYb50nSN8+E3H+ouWUhKQ/5YhW1pn2+FHkixlG5+0HWnayjj/pXrKI6Fa0aHgYgpNuhzBicTllxMUQb7+291JWSgxok0whaylWoNfUtJsaKWEpS5lg90+i+Vmq1dKHzZDHKoIIYEz7MuCCSXoqEluUs56wuYX7UCpdFDFiAFMsN0N7qUoRWH15UqDWfKE0acWMCpZ6LO93ScnFiIRw29ResWecqQLtP77oZIfL2Q24Rd/CaeJkV9MOMtyTX9met2RWuES5YoBsPVX+gi00MPiCmv4Xjr2vKK5fb8CQ8rsRp5ifyq/rr+GsTZhDImBs0Z0vThOJ+++MHEOOdop0lXkLkK08UNx7D8JnmZLqdR/idI82rtQbOZzI5zxk0gALEujm3OvRljm9Cu4pmurdHZHl/iCQCXSGdE4y81k6qaUmxSprdHqS7TMhGZrnS/twf3TPvcGhWGinIBgdYhZW5YqoIP4vFQ0vOEzAq76UrUdKJqnQ5eaPpJyor4tD9hJKOcJ8JlA1QUigJ8tNDp1xNn/JEL0Gvtpr4a0BW94uEVCM4NMBEZFWQ2e562PYAW74y2mhLRGnB6Nx9wEmho3jrxHwdgSHsV8tWIp2AtHrZV+5wKVgwksT5nVVXXNBHNkMisZzoXdEAZm80TIie2pRzjrKWOzHRXUxb7W1tF4ABo7m2cPwvXAwriRvrTACiQbR5YDS9SXW7cw+zh4SQod/cHN13tWmNH3ypJt0xDkPls41D0C1aAe5GIt0sIyXWa5RmyIRCEQaM8gu4tN/zZTDu0Dr Yvw4DS3d zilaHNYb89m/c3sdE7rbGwnIQ/9JnrjjdgW3PxmwaUyTIeDMUC7zN5WKc1LFdRulMZfWJqt8eqOxAmnvTAt4brMB9YCRfiiRb5eJ0wxayf3Wx+D+GnmBd48T/gZ2pidJni/rFnhPH/M1ir/CPh+pqn1Zh3ARNukNjJE2+0bau41jTYeg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000531, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: on 6/4/2024 2:09 AM, Tejun Heo wrote: > Hello, > > On Mon, Jun 03, 2024 at 02:39:18PM +0800, Kemeng Shi wrote: >>> Isn't this a bit nasty? The helper skips updating states because it knows >>> the caller is not going to use them? I'm not sure the slight code reduction >>> justifies the added subtlety. >> >> It's a general rule that wb should not be limited if the wb is in freerun state. >> So I think it's intuitive to obey the rule in both balance_wb_limits and it's >> caller in which case balance_wb_limits and it's caller should stop to do anything >> when freerun state of wb is first seen. >> But no insistant on this... > > Hmm... can you at least add comments pointing out that if freerun, the > limits fields are invalid? Sure, will add it in next version. Thanks > > Thanks. >