From: David Hildenbrand <david@redhat.com>
To: Miaohe Lin <linmiaohe@huawei.com>, akpm@linux-foundation.org
Cc: isimatu.yasuaki@jp.fujitsu.com, toshi.kani@hp.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/memory_hotplug: fix kfree() of bootmem memory
Date: Mon, 7 Feb 2022 15:33:34 +0100 [thread overview]
Message-ID: <6d4ab70e-b944-5f7d-e9a3-979ac66c70f7@redhat.com> (raw)
In-Reply-To: <20220207135618.17231-1-linmiaohe@huawei.com>
On 07.02.22 14:56, Miaohe Lin wrote:
> We can't use kfree() to release the resource as it might come from bootmem.
> Use release_mem_region() instead.
How can this happen? release_mem_region() is called either from
__add_memory() or from add_memory_driver_managed(), where we allocated
the region via register_memory_resource(). Both functions shouldn't ever
be called before the buddy is up an running.
Do you have a backtrace of an actual instance of this issue? Or was this
identified as possibly broken by code inspection?
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-02-07 14:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 13:56 Miaohe Lin
2022-02-07 14:33 ` David Hildenbrand [this message]
2022-02-08 1:59 ` Miaohe Lin
2022-02-08 9:19 ` David Hildenbrand
2022-02-08 11:20 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d4ab70e-b944-5f7d-e9a3-979ac66c70f7@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=toshi.kani@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox