From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07FD2C47258 for ; Thu, 25 Jan 2024 11:53:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3792F6B00A1; Thu, 25 Jan 2024 06:53:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 328246B00A2; Thu, 25 Jan 2024 06:53:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C9C36B00A3; Thu, 25 Jan 2024 06:53:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 09BA56B00A1 for ; Thu, 25 Jan 2024 06:53:52 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A4A4D80812 for ; Thu, 25 Jan 2024 11:53:51 +0000 (UTC) X-FDA: 81717674262.18.5FCCBA5 Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by imf01.hostedemail.com (Postfix) with ESMTP id AABA44001B for ; Thu, 25 Jan 2024 11:53:46 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.32 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706183628; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eZYGBz7mHHKbenEg9oDD4GcpfNFQGytCNrL2uloe2IU=; b=Kr59iWNQlBIw/YeUQ0fC+xzVWnvG1+XH625SRVmyPkqnNCCHqeilu2Tdy8X6PGbVwCs+WQ KijhcmiwaEQAbXVoPtQA9KMnIdPCXyeJtpCFsY01xOuZFgfZVMPCm4s8Pk8q0E/LJXzlyP J/ygAeX8/LrEXMW40iunG0TB8mW+vuc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706183628; a=rsa-sha256; cv=none; b=RBI6fQEOeEqc69jLOz1waIxwZrw/pPTC1i956P6OGmCub+Jab4ah5pH8fUmf6tiDYNlqVE f51JJGhUUmlbyz4oZCfGzRQ6r8OloZ5NRj93F9lj88kHfjesRAWBEgAKC1dZ3q8QdL7aFo 66+NrdikPvZ/kaSgspLZBXj0qMMu0bI= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.32 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4TLK3268B1z1vshF; Thu, 25 Jan 2024 19:53:18 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id 626981A016F; Thu, 25 Jan 2024 19:53:26 +0800 (CST) Received: from [10.173.135.154] (10.173.135.154) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 25 Jan 2024 19:53:25 +0800 Subject: Re: [PATCH v2] mm/memory-failure: fix crash in split_huge_page_to_list from soft_offline_page To: Matthew Wilcox CC: , , , References: <20240124084014.1772906-1-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: <6d3f4822-8bc1-1551-b088-0a6d4c13f049@huawei.com> Date: Thu, 25 Jan 2024 19:53:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.135.154] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-Stat-Signature: mjupsbttfznzfgqeqzdcz9n55bysmw14 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: AABA44001B X-Rspam-User: X-HE-Tag: 1706183626-450837 X-HE-Meta: U2FsdGVkX1+42kzXgnpO0/imlgjG9rfgazSWqKOvhy4Ua3pYWS3RaUbV9tfJe3gG7xZe7l1Nk0w8xkYjk+mz8wa/fmjdZRXCL8cd0VWgnHiS0qhuhqnVFePUCeFihcCvQkO9pkcmuEir9vcac2cnm13O4s/7x2XYlCPVXYvI0FCv2xc/zKtg7EIZoViH91tsBfX8OG4uLNkn4DL7XVq81w1ake2XxsYebidlyOHxwv8qH44pMpP4KDfVZ9SWuJfBMOvBwdEyUthD92m2i4xOnDxhJF4qyWKiOb8TUkueyzw+flNpL306zDkaT2zC9xkGT3XX5Y+u8O6klYM1Z1ZtjHiLXNtlQIpguMbR5ttS23wGu6kmELJQYW6PEheaC6x+dPNY55lf5O6MCgXwIHwxcDh5R2v4kku5Bb0tHNT5S3JmfUvhffSxvhD7kFr14NeWTvm30pG/XPPqJ8+u1ABgdHN+Pph8vWTHknlJ7L1VVGtwbaiTS4dlhP0gq+xC4xXC7Fu4Eq299FcDz+SgDrVUst+K3zzXZkZbsHhRjErbaK1zfEhl2zK2dQp89c4WlNTGklGnu6/QxpkrL+JU0KjSNfiTlhdaT+jYynpu5Ks64pTkVEg/gIdqI2zs1/CK7+vJoNoWGLnPoZEvbGkuspNEaTqXU4Oiln059wcQ7s6z828xRU1ZnGO+GGgvtq48uU/2+3Q0Wsalr5culIdIP/pYwUTO/Cl2oMe6Iq5PixN/CRTykK3Wce8iCNnvx2UbD6WqrNQcprHaW1EOgNiRhET/77v1EudUDKcWhmEAlr3Btu3k+Mocg2IdneKvpIfaS3aOIlG9dCkmvKmxoza0MGNmToPVQTNk6fap X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/1/24 21:15, Matthew Wilcox wrote: > On Wed, Jan 24, 2024 at 04:40:14PM +0800, Miaohe Lin wrote: >> When I did soft offline stress test, a machine was observed to crash with >> the following message: >> >> kernel BUG at include/linux/memcontrol.h:554! >> invalid opcode: 0000 [#1] PREEMPT SMP NOPTI >> CPU: 5 PID: 3837 Comm: hwpoison.sh Not tainted 6.7.0-next-20240112-00001-g8ecf3e7fb7c8-dirty #97 >> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014 >> RIP: 0010:folio_memcg+0xaf/0xd0 >> Code: 10 5b 5d c3 cc cc cc cc 48 c7 c6 08 b1 f2 b2 48 89 ef e8 b4 c5 f8 ff 90 0f 0b 48 c7 c6 d0 b0 f2 b2 48 89 ef e8 a2 c5 f8 ff 90 <0f> 0b 48 c7 c6 08 b1 f2 b2 48 89 ef e8 90 c5 f8 ff 90 0f 0b 66 66 >> RSP: 0018:ffffb6c043657c98 EFLAGS: 00000296 >> RAX: 000000000000004b RBX: ffff932bc1d1e401 RCX: ffff933abfb5c908 >> RDX: 0000000000000000 RSI: 0000000000000027 RDI: ffff933abfb5c900 >> RBP: ffffea6f04019080 R08: ffffffffb3338ce8 R09: 0000000000009ffb >> R10: 00000000000004dd R11: ffffffffb3308d00 R12: ffffea6f04019080 >> R13: ffffea6f04019080 R14: 0000000000000001 R15: ffffb6c043657da0 >> FS: 00007f6c60f6b740(0000) GS:ffff933abfb40000(0000) knlGS:0000000000000000 >> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >> CR2: 0000559c3bc8b980 CR3: 0000000107f1c000 CR4: 00000000000006f0 >> Call Trace: >> >> ? die+0x32/0x90 >> ? do_trap+0xde/0x110 >> ? folio_memcg+0xaf/0xd0 >> ? do_error_trap+0x60/0x80 >> ? folio_memcg+0xaf/0xd0 >> ? exc_invalid_op+0x53/0x70 >> ? folio_memcg+0xaf/0xd0 >> ? asm_exc_invalid_op+0x1a/0x20 >> ? folio_memcg+0xaf/0xd0 >> ? folio_memcg+0xae/0xd0 > > I might trim these ? lines out of the backtrace ... Do you mean make backtrace looks like something below? Call Trace: split_huge_page_to_list+0x4d/0x1380 ? sysvec_apic_timer_interrupt+0xf/0x80 try_to_split_thp_page+0x3a/0xf0 soft_offline_page+0x1ea/0x8a0 soft_offline_page_store+0x52/0x90 kernfs_fop_write_iter+0x118/0x1b0 vfs_write+0x30b/0x430 ksys_write+0x5e/0xe0 do_syscall_64+0xb0/0x1b0 entry_SYSCALL_64_after_hwframe+0x6d/0x75 RIP: 0033:0x7f6c60d14697 > >> split_huge_page_to_list+0x4d/0x1380 >> ? sysvec_apic_timer_interrupt+0xf/0x80 >> try_to_split_thp_page+0x3a/0xf0 >> soft_offline_page+0x1ea/0x8a0 >> soft_offline_page_store+0x52/0x90 >> kernfs_fop_write_iter+0x118/0x1b0 >> vfs_write+0x30b/0x430 >> ksys_write+0x5e/0xe0 >> do_syscall_64+0xb0/0x1b0 >> entry_SYSCALL_64_after_hwframe+0x6d/0x75 >> RIP: 0033:0x7f6c60d14697 >> Code: 10 00 f7 d8 64 89 02 48 c7 c0 ff ff ff ff eb b7 0f 1f 00 f3 0f 1e fa 64 8b 04 25 18 00 00 00 85 c0 75 10 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 51 c3 48 83 ec 28 48 89 54 24 18 48 89 74 24 >> RSP: 002b:00007ffe9b72b8d8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 >> RAX: ffffffffffffffda RBX: 000000000000000c RCX: 00007f6c60d14697 >> RDX: 000000000000000c RSI: 0000559c3bc8b980 RDI: 0000000000000001 >> RBP: 0000559c3bc8b980 R08: 00007f6c60dd1460 R09: 000000007fffffff >> R10: 0000000000000000 R11: 0000000000000246 R12: 000000000000000c >> R13: 00007f6c60e1a780 R14: 00007f6c60e16600 R15: 00007f6c60e15a00 >> >> The problem is that page->mapping is overloaded with slab->slab_list or >> slabs fields now, so slab pages could be taken as non-LRU movable pages >> if field slabs contains PAGE_MAPPING_MOVABLE or slab_list->prev is set >> to LIST_POISON2. These slab pages will be treated as thp later leading >> to crash in split_huge_page_to_list(). >> >> Signed-off-by: Miaohe Lin >> Fixes: 130d4df57390 ("mm/sl[au]b: rearrange struct slab fields to allow larger rcu_head") > > Reviewed-by: Matthew Wilcox (Oracle) Many thanks for your review.