From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED082C433DB for ; Tue, 30 Mar 2021 07:58:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5660661953 for ; Tue, 30 Mar 2021 07:58:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5660661953 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C1EB56B0080; Tue, 30 Mar 2021 03:58:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BCDAA6B0081; Tue, 30 Mar 2021 03:58:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6D686B0082; Tue, 30 Mar 2021 03:58:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0174.hostedemail.com [216.40.44.174]) by kanga.kvack.org (Postfix) with ESMTP id 89AAA6B0080 for ; Tue, 30 Mar 2021 03:58:47 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 3EC9B180AD811 for ; Tue, 30 Mar 2021 07:58:47 +0000 (UTC) X-FDA: 77975789094.09.0CDBBDA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id ED9DCC0007CD for ; Tue, 30 Mar 2021 07:58:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617091126; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AHycToD1Mf7hFAxeW6WBmmMHgJcTRe0/4cO3FJSif84=; b=AomGgYsJoF3NX5t94/rOq8kp7EDv/S1k2UeJ51ORRFrcLKwgtRKO6UP4ip0GfwJedz333Y d8dTUHAJwUzeIT++m8s6KufyYtnqI/jA1qK+B5Css5QFnDqTNkoIiHEC8qkLaG5hkdQhvu DL4cXE9jayUtUZ9Oe+VU23OeOf7MQDg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-404-mJQ-MeRpML6rufcRb-jMoQ-1; Tue, 30 Mar 2021 03:58:41 -0400 X-MC-Unique: mJQ-MeRpML6rufcRb-jMoQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EDD53801814; Tue, 30 Mar 2021 07:58:39 +0000 (UTC) Received: from [10.36.114.210] (ovpn-114-210.ams2.redhat.com [10.36.114.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7E3815C239; Tue, 30 Mar 2021 07:58:38 +0000 (UTC) Subject: Re: [PATCH] mm: change size_t to unsigned int for cma_alloc To: Minchan Kim , Matthew Wilcox Cc: Andrew Morton , linux-mm , LKML References: <20210329182553.3129234-1-minchan@kernel.org> <20210329184431.GJ351017@casper.infradead.org> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <6d305211-c956-ad80-5908-703d07fca441@redhat.com> Date: Tue, 30 Mar 2021 09:58:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: ED9DCC0007CD X-Stat-Signature: ig19f446s41re34a9wuu8fi1rgxz3fji Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf22; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=170.10.133.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617091123-701073 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 29.03.21 22:12, Minchan Kim wrote: > On Mon, Mar 29, 2021 at 07:44:31PM +0100, Matthew Wilcox wrote: >> On Mon, Mar 29, 2021 at 11:25:53AM -0700, Minchan Kim wrote: >>> size_t in cma_alloc is confusing since it makes people think >>> it's byte count, not pages. Fix it. >> >> i think it has to be unsigned long. >> >> 67a2e213e7e937c41c52ab5bc46bf3f4de469f6e Right. Fortunately, we don't have such large allocations yet via CMA/alloc_contig_range > > Thanks for the pinter. I wanted to have the smallest change. > The commit leads me to change cma_release, trace_cma_alloc, > cma_clear_bitmap and front_contig_range as well.(Not sure > we have more. Will check). > > Ccing david@redhat.com for upcoming changing free_contig_range. While at it, we might want to convert free_contig_range() to eat "unsigned long start, unsigned long end" like alloc_contig_range(), instead of "unsigned long pfn, unsigned int nr_pages" like alloc_contig_pages() ... -- Thanks, David / dhildenb