[PATCH 0/3] arch: include asm/cacheflush.h in asm/hugetlb.h

linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed

* [PATCH 0/3] arch: include asm/cacheflush.h in asm/hugetlb.h
@ 2023-08-14  4:50 Hugh Dickins
  2023-08-14  4:52 ` [PATCH 1/3] arm: " Hugh Dickins
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Hugh Dickins @ 2023-08-14  4:50 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Mike Kravetz, Russell King, Catalin Marinas, Will Deacon,
	Palmer Dabbelt, linux-arm-kernel, linux-riscv, linux-mm

Three architectures are using PG_dcache_clean in their asm/hugetlb.h,
but relying on accident to include the asm/cacheflush.h which defines it.

1/3 arm: include asm/cacheflush.h in asm/hugetlb.h
2/3 arm64: include asm/cacheflush.h in asm/hugetlb.h
3/3 riscv: include asm/cacheflush.h in asm/hugetlb.h

 arch/arm/include/asm/hugetlb.h   | 1 +
 arch/arm64/include/asm/hugetlb.h | 1 +
 arch/riscv/include/asm/hugetlb.h | 1 +
 3 files changed, 3 insertions(+)

Hugh


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/3] arm: include asm/cacheflush.h in asm/hugetlb.h
  2023-08-14  4:50 [PATCH 0/3] arch: include asm/cacheflush.h in asm/hugetlb.h Hugh Dickins
@ 2023-08-14  4:52 ` Hugh Dickins
  2023-08-14  4:53 ` [PATCH 2/3] arm64: " Hugh Dickins
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Hugh Dickins @ 2023-08-14  4:52 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Mike Kravetz, Russell King, Catalin Marinas, Will Deacon,
	Palmer Dabbelt, linux-arm-kernel, linux-riscv, linux-mm

PG_dcache_clean is used in asm/hugetlb.h but defined in asm/cacheflush.h:
builds rely on an accident of that being included via linux/mempolicy.h,
but better include it directly (like arch/sh/include/asm/hugetlb.h does).

Signed-off-by: Hugh Dickins <hughd@google.com>
---
 arch/arm/include/asm/hugetlb.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/include/asm/hugetlb.h b/arch/arm/include/asm/hugetlb.h
index d02d6ca88e92..a3a82b7158d4 100644
--- a/arch/arm/include/asm/hugetlb.h
+++ b/arch/arm/include/asm/hugetlb.h
@@ -10,6 +10,7 @@
 #ifndef _ASM_ARM_HUGETLB_H
 #define _ASM_ARM_HUGETLB_H
 
+#include <asm/cacheflush.h>
 #include <asm/page.h>
 #include <asm/hugetlb-3level.h>
 #include <asm-generic/hugetlb.h>
-- 
2.35.3



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 2/3] arm64: include asm/cacheflush.h in asm/hugetlb.h
  2023-08-14  4:50 [PATCH 0/3] arch: include asm/cacheflush.h in asm/hugetlb.h Hugh Dickins
  2023-08-14  4:52 ` [PATCH 1/3] arm: " Hugh Dickins
@ 2023-08-14  4:53 ` Hugh Dickins
  2023-08-14  4:53 ` [PATCH 3/3] riscv: " Hugh Dickins
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Hugh Dickins @ 2023-08-14  4:53 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Mike Kravetz, Russell King, Catalin Marinas, Will Deacon,
	Palmer Dabbelt, linux-arm-kernel, linux-riscv, linux-mm

PG_dcache_clean is used in asm/hugetlb.h but defined in asm/cacheflush.h:
builds rely on an accident of that being included via linux/mempolicy.h,
but better include it directly (like arch/sh/include/asm/hugetlb.h does).

Signed-off-by: Hugh Dickins <hughd@google.com>
---
 arch/arm64/include/asm/hugetlb.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/include/asm/hugetlb.h b/arch/arm64/include/asm/hugetlb.h
index a91d6219aa78..f43a38ac1779 100644
--- a/arch/arm64/include/asm/hugetlb.h
+++ b/arch/arm64/include/asm/hugetlb.h
@@ -10,6 +10,7 @@
 #ifndef __ASM_HUGETLB_H
 #define __ASM_HUGETLB_H
 
+#include <asm/cacheflush.h>
 #include <asm/page.h>
 
 #ifdef CONFIG_ARCH_ENABLE_HUGEPAGE_MIGRATION
-- 
2.35.3



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 3/3] riscv: include asm/cacheflush.h in asm/hugetlb.h
  2023-08-14  4:50 [PATCH 0/3] arch: include asm/cacheflush.h in asm/hugetlb.h Hugh Dickins
  2023-08-14  4:52 ` [PATCH 1/3] arm: " Hugh Dickins
  2023-08-14  4:53 ` [PATCH 2/3] arm64: " Hugh Dickins
@ 2023-08-14  4:53 ` Hugh Dickins
  2023-08-30 13:20 ` [PATCH 0/3] arch: " patchwork-bot+linux-riscv
  2023-08-30 13:24 ` (subset) " Palmer Dabbelt
  4 siblings, 0 replies; 6+ messages in thread
From: Hugh Dickins @ 2023-08-14  4:53 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Mike Kravetz, Russell King, Catalin Marinas, Will Deacon,
	Palmer Dabbelt, linux-arm-kernel, linux-riscv, linux-mm

PG_dcache_clean is used in asm/hugetlb.h but defined in asm/cacheflush.h:
builds rely on an accident of that being included via linux/mempolicy.h,
but better include it directly (like arch/sh/include/asm/hugetlb.h does).

Signed-off-by: Hugh Dickins <hughd@google.com>
---
 arch/riscv/include/asm/hugetlb.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/riscv/include/asm/hugetlb.h b/arch/riscv/include/asm/hugetlb.h
index ce1ebda1a49a..34e24f078cc1 100644
--- a/arch/riscv/include/asm/hugetlb.h
+++ b/arch/riscv/include/asm/hugetlb.h
@@ -2,6 +2,7 @@
 #ifndef _ASM_RISCV_HUGETLB_H
 #define _ASM_RISCV_HUGETLB_H
 
+#include <asm/cacheflush.h>
 #include <asm/page.h>
 
 static inline void arch_clear_hugepage_flags(struct page *page)
-- 
2.35.3



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/3] arch: include asm/cacheflush.h in asm/hugetlb.h
  2023-08-14  4:50 [PATCH 0/3] arch: include asm/cacheflush.h in asm/hugetlb.h Hugh Dickins
                   ` (2 preceding siblings ...)
  2023-08-14  4:53 ` [PATCH 3/3] riscv: " Hugh Dickins
@ 2023-08-30 13:20 ` patchwork-bot+linux-riscv
  2023-08-30 13:24 ` (subset) " Palmer Dabbelt
  4 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+linux-riscv @ 2023-08-30 13:20 UTC (permalink / raw)
  To: Hugh Dickins
  Cc: linux-riscv, akpm, mike.kravetz, linux, catalin.marinas, will,
	palmer, linux-arm-kernel, linux-mm

Hello:

This series was applied to riscv/linux.git (for-next)
by Palmer Dabbelt <palmer@rivosinc.com>:

On Sun, 13 Aug 2023 21:50:34 -0700 (PDT) you wrote:
> Three architectures are using PG_dcache_clean in their asm/hugetlb.h,
> but relying on accident to include the asm/cacheflush.h which defines it.
> 
> 1/3 arm: include asm/cacheflush.h in asm/hugetlb.h
> 2/3 arm64: include asm/cacheflush.h in asm/hugetlb.h
> 3/3 riscv: include asm/cacheflush.h in asm/hugetlb.h
> 
> [...]

Here is the summary with links:
  - [1/3] arm: include asm/cacheflush.h in asm/hugetlb.h
    (no matching commit)
  - [2/3] arm64: include asm/cacheflush.h in asm/hugetlb.h
    (no matching commit)
  - [3/3] riscv: include asm/cacheflush.h in asm/hugetlb.h
    https://git.kernel.org/riscv/c/3aaad36808b5

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: (subset) [PATCH 0/3] arch: include asm/cacheflush.h in asm/hugetlb.h
  2023-08-14  4:50 [PATCH 0/3] arch: include asm/cacheflush.h in asm/hugetlb.h Hugh Dickins
                   ` (3 preceding siblings ...)
  2023-08-30 13:20 ` [PATCH 0/3] arch: " patchwork-bot+linux-riscv
@ 2023-08-30 13:24 ` Palmer Dabbelt
  4 siblings, 0 replies; 6+ messages in thread
From: Palmer Dabbelt @ 2023-08-30 13:24 UTC (permalink / raw)
  To: Andrew Morton, Hugh Dickins
  Cc: Mike Kravetz, Russell King, Catalin Marinas, Will Deacon,
	Palmer Dabbelt, linux-arm-kernel, linux-riscv, linux-mm


On Sun, 13 Aug 2023 21:50:34 -0700, Hugh Dickins wrote:
> Three architectures are using PG_dcache_clean in their asm/hugetlb.h,
> but relying on accident to include the asm/cacheflush.h which defines it.
> 
> 1/3 arm: include asm/cacheflush.h in asm/hugetlb.h
> 2/3 arm64: include asm/cacheflush.h in asm/hugetlb.h
> 3/3 riscv: include asm/cacheflush.h in asm/hugetlb.h
> 
> [...]

Applied, thanks!

[3/3] riscv: include asm/cacheflush.h in asm/hugetlb.h
      https://git.kernel.org/palmer/c/3aaad36808b5

Best regards,
-- 
Palmer Dabbelt <palmer@rivosinc.com>



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-08-30 13:24 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-14  4:50 [PATCH 0/3] arch: include asm/cacheflush.h in asm/hugetlb.h Hugh Dickins
2023-08-14  4:52 ` [PATCH 1/3] arm: " Hugh Dickins
2023-08-14  4:53 ` [PATCH 2/3] arm64: " Hugh Dickins
2023-08-14  4:53 ` [PATCH 3/3] riscv: " Hugh Dickins
2023-08-30 13:20 ` [PATCH 0/3] arch: " patchwork-bot+linux-riscv
2023-08-30 13:24 ` (subset) " Palmer Dabbelt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox