From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 460C4C54EBD for ; Mon, 9 Jan 2023 15:25:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9314A8E0006; Mon, 9 Jan 2023 10:25:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E0D18E0001; Mon, 9 Jan 2023 10:25:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A9388E0006; Mon, 9 Jan 2023 10:25:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6AD188E0001 for ; Mon, 9 Jan 2023 10:25:27 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 296801209ED for ; Mon, 9 Jan 2023 15:25:27 +0000 (UTC) X-FDA: 80335634694.21.03813FA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id EE41714000F for ; Mon, 9 Jan 2023 15:25:24 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=R4+NkaTi; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of jlayton@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jlayton@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673277925; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iSHJ39UTkLU0ZKUxggYvT11vZ4w5IzaivSjgqD6AlBI=; b=bcaPlhd6y9rMeSesUQ4dSMj5RXxWIfbgMQNVy3nqmxr/cmyKni/2xV1reqp+7Igy8NUWEj 4Odz77hcszqHM13oaJdQw6ROPxjX4SjdyKRezYXEtxhz/g5DunTYQCXVId7wrft9iGGvUA j1Jw0cWcapd/M0t3nXtdWRt8zMATcz4= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=R4+NkaTi; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of jlayton@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jlayton@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673277925; a=rsa-sha256; cv=none; b=Yx8mcHPI3K1N+gDeDT0L4+yW/fhxoXtu63zUpEvvizmVdLAn5qfDkj/dXPWI2/EV8lgnqd z/2AMRMcxaBwJPp08O/xsSiH60rSLQ/nXX2kOe6CyqA2iLiPXtM1m6v8DUfghesDjAhmqe zB4Vrqy0fYnWUdyg4apERMWzaU7pSv4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673277924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iSHJ39UTkLU0ZKUxggYvT11vZ4w5IzaivSjgqD6AlBI=; b=R4+NkaTiNZ6UVqUC0qA2hpEXdaGj114755zp3my4bykZGdnPl8JRmH8fZ/2Ih8bycMNGHQ JqbG9RTXQKcKfyfTfluVOAcBCl5A64qLF+PjVSh60uUA/CQ5MP6gv2cLckR+09WRRVMHSB YH84sKP8cewqa3fdvbuKCOQCoRdC9dU= Received: from mail-yb1-f198.google.com (mail-yb1-f198.google.com [209.85.219.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-640-YHUGoQDVPeCB90eyygYdrw-1; Mon, 09 Jan 2023 10:25:15 -0500 X-MC-Unique: YHUGoQDVPeCB90eyygYdrw-1 Received: by mail-yb1-f198.google.com with SMTP id h66-20020a252145000000b0071a7340eea9so9280006ybh.6 for ; Mon, 09 Jan 2023 07:25:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=2cwtPm83DzPm/dNeuelfshMOy2ruVKr8GdHiKUI1wQ4=; b=l2v8Hd4uHz50bLCTl9F8NbPMPUaajbDYLTsk9CGgTolkq2ELVfq4NITdX2Q3YGyLzs AgshoxjDrpWoelctrtlFmNK/A4MWL7Lxgb/oOYvTfKZ8aYMY4ZQsa34cThlazo1OLrmJ WqM4LusJDji6LXqdvUVlGVFIeBgqv3Q5M07Xq9zmNp/fBGCwhL8Ft8be/l443wMgqWgX /4tQhNym68fCW2zYthdVKNwNC4jnIPs6Do+pWf/oua21iC3sR94IqPjKJUxhNFqoImCx AdAykUv/4Hz8ukOLr67bA5JX1GkMQNb5tYRzqyADyEblexBQZbDADA3V/PJqLiNPlBgC ZhMw== X-Gm-Message-State: AFqh2kr0WnrCXTMIVyBiSJxSkv4iAa+XqxqDWv2lAUk/T4u9g/DkldSR ye5lWt61EgTWJ17lJ5VN8WOuJ7qev3QU+7jKgE67Xt5133fTy7DcV2d/eashRBtPVbFtdwvD3+c VbYIzc4XpWMY= X-Received: by 2002:a81:1252:0:b0:4a4:e76b:7160 with SMTP id 79-20020a811252000000b004a4e76b7160mr24182488yws.18.1673277914969; Mon, 09 Jan 2023 07:25:14 -0800 (PST) X-Google-Smtp-Source: AMrXdXuk+uM5VkDIcmYpnZqGv6C7Pu+cSJXlnrOuWyuHdaV8aegf77WPib+gB5SzG40m4PLEvJ5eqw== X-Received: by 2002:a81:1252:0:b0:4a4:e76b:7160 with SMTP id 79-20020a811252000000b004a4e76b7160mr24182473yws.18.1673277914758; Mon, 09 Jan 2023 07:25:14 -0800 (PST) Received: from [192.168.1.3] (68-20-15-154.lightspeed.rlghnc.sbcglobal.net. [68.20.15.154]) by smtp.gmail.com with ESMTPSA id g16-20020a05620a40d000b007055fa93060sm5536060qko.79.2023.01.09.07.25.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 07:25:14 -0800 (PST) Message-ID: <6d1cd7ca1f2ea0f022af1d43999a61e6b17685c0.camel@redhat.com> Subject: Re: [PATCH 04/11] fuse: Convert fuse_flush() to use file_check_and_advance_wb_err() From: Jeff Layton To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Hellwig Date: Mon, 09 Jan 2023 10:25:13 -0500 In-Reply-To: <20230109051823.480289-5-willy@infradead.org> References: <20230109051823.480289-1-willy@infradead.org> <20230109051823.480289-5-willy@infradead.org> User-Agent: Evolution 3.46.2 (3.46.2-1.fc37) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: EE41714000F X-Stat-Signature: qtwodgkggomqyuexbzfq89zifnxbs738 X-HE-Tag: 1673277924-22841 X-HE-Meta: U2FsdGVkX19lJ/kz5Q+0ej3oD8hIiPnmnc5VQxJGkKO+Cb8ZUvoJL+9gCaiMLOwxysf0zzcvpWdQ/ZPFTvnUN9ZyagFTzOA0DbIXvknEF7kCDsAF4hlu2FkcWCI4oB7KhIdjaJ0nb29Y/mneKV4OKAjXSrVqjN2gzhXVAxDYBNARZvJY2+GRXV1HJ6mODk+fDPRgRvHhVMUCWD/4Z2aHOhGtZYEfQ3jSzsUJDMEurbNlsdwtqaRseRg0IHOj7WDpmjsTSctN7GSHJs4A0jTBmDCGNS+HWBXoWNPqTFBF6rp9/6Quk/G2QQIV9qdeLnGi7gxn3lmclsEIXSSSzQk4G0BzyL9QySLAHIfy/BVdf4Cga417bxnzeULBJGXWDvzKmAgKUJcmcAERnfrIHbvv1SQcXb/zVzlnCO5WCeMwlbg192ycKlBh6ZOaJcrgknxJg/acSG0XrixrOWqqv8xK3XXS7jWMb1TJeeSOE2ibw6ldTrzekT6AQtgYGFjjzxy31WKFECzN1IqIg21Vaxp788KuYqXAcxFmgKb8B1kWFzBWr+dl3tHJCeGOxGpobbBpv0fjbQsDZ4pRYkGk1gpmjgwAioPzhUUuDSriSb9CeQJmfGwsvuZ1cYjnrsOI/EgEn75fEzHrPpFKjP8bPr4mfm62jhcSoYNlAHaqGEPNc9o38pF2hdHLLQ/3a758Jok7Kf135LkPYlP6mGL5lwUv2lp6CzePTCpMI3uiDJhNN7Z2p4g2Jjelk37iYDaGnfdgZ8KHVsdrM6G2eX+jzoMeE2DCrrTXkeQI5mpEzspmsWd08cw0oRrrdSpDBP5nC+qm3JYZcEXDhpUGjaRSCtOPTbyF8PXbwBN4zNJ6cczPKFbsSDdPzpH8baqzin4IfoDzLrB1lAuUCGJRx3FyxkBVHbqHZXV1qbAdIO6OVzfPzIvOJXnDV3MdIDkLbwZxsj18dmHNtSRMviY5TIwF7Aq xgYR0nPu 5EkQAFLXJifaiFBczHi5EFkNG1BTtV9hfqs9u2JApU4//f57uL1xKaExl3L9TWJwU6mmMvqLWuoocKaU8FGrL82Ujf6Y3O2SkwVspIThaKJJwo/05H22fsgAAWHxW0MYBs7GRclL4JBXYOzmxqqqkHgqRuA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 2023-01-09 at 05:18 +0000, Matthew Wilcox (Oracle) wrote: > As with fsync, use the newer file_check_and_advance_wb_err() instead > of filemap_check_errors(). >=20 > Signed-off-by: Matthew Wilcox (Oracle) > --- > fs/fuse/file.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/fs/fuse/file.c b/fs/fuse/file.c > index 875314ee6f59..7174646ddf09 100644 > --- a/fs/fuse/file.c > +++ b/fs/fuse/file.c > @@ -500,11 +500,10 @@ static int fuse_flush(struct file *file, fl_owner_t= id) > =09fuse_sync_writes(inode); > =09inode_unlock(inode); > =20 > -=09err =3D filemap_check_errors(file->f_mapping); > +=09err =3D file_check_and_advance_wb_err(file); > =09if (err) > =09=09return err; >=20 >=20 I think it'd be best to not advance the f_wb_err here. ->flush is called on filp_close which is mainly close() syscalls, but there are some other callers too, and an error reported by ->flush can be discarded. > =20 > -=09err =3D 0; > =09if (fm->fc->no_flush) > =09=09goto inval_attr_out; > =20 --=20 Jeff Layton