* Re: linux-next: Tree for Nov 30 (mm/zswap.c)
[not found] <20231130140330.55de96cd@canb.auug.org.au>
@ 2023-11-30 17:15 ` Randy Dunlap
2023-11-30 18:51 ` Nhat Pham
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2023-11-30 17:15 UTC (permalink / raw)
To: Stephen Rothwell, Linux Next Mailing List
Cc: Linux Kernel Mailing List, linux-mm, Seth Jennings,
Dan Streetman, Vitaly Wool
On 11/29/23 19:03, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20231129:
>
on i386, loongarch, ppc64, riscv32:
when CONFIG_MEMCG is not set.
../mm/zswap.c: In function 'mem_cgroup_from_entry':
../mm/zswap.c:313:31: error: implicit declaration of function 'obj_cgroup_memcg'; did you mean 'obj_cgroup_put'? [-Werror=implicit-function-declaration]
313 | return entry->objcg ? obj_cgroup_memcg(entry->objcg) : NULL;
| ^~~~~~~~~~~~~~~~
| obj_cgroup_put
../mm/zswap.c:313:62: warning: pointer/integer type mismatch in conditional expression
313 | return entry->objcg ? obj_cgroup_memcg(entry->objcg) : NULL;
| ^
../mm/zswap.c: In function 'shrink_worker':
../mm/zswap.c:984:31: error: invalid use of undefined type 'struct mem_cgroup'
984 | css_get(&memcg->css);
| ^~
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: linux-next: Tree for Nov 30 (mm/zswap.c)
2023-11-30 17:15 ` linux-next: Tree for Nov 30 (mm/zswap.c) Randy Dunlap
@ 2023-11-30 18:51 ` Nhat Pham
0 siblings, 0 replies; 2+ messages in thread
From: Nhat Pham @ 2023-11-30 18:51 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, Linux Next Mailing List,
Linux Kernel Mailing List, linux-mm, Seth Jennings,
Dan Streetman, Vitaly Wool
On Thu, Nov 30, 2023 at 9:16 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
>
>
> On 11/29/23 19:03, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20231129:
> >
>
> on i386, loongarch, ppc64, riscv32:
> when CONFIG_MEMCG is not set.
>
>
> ../mm/zswap.c: In function 'mem_cgroup_from_entry':
> ../mm/zswap.c:313:31: error: implicit declaration of function 'obj_cgroup_memcg'; did you mean 'obj_cgroup_put'? [-Werror=implicit-function-declaration]
> 313 | return entry->objcg ? obj_cgroup_memcg(entry->objcg) : NULL;
> | ^~~~~~~~~~~~~~~~
> | obj_cgroup_put
> ../mm/zswap.c:313:62: warning: pointer/integer type mismatch in conditional expression
> 313 | return entry->objcg ? obj_cgroup_memcg(entry->objcg) : NULL;
> | ^
> ../mm/zswap.c: In function 'shrink_worker':
> ../mm/zswap.c:984:31: error: invalid use of undefined type 'struct mem_cgroup'
> 984 | css_get(&memcg->css);
> | ^~
>
>
>
> --
> ~Randy
>
Thanks for the report, Randy! I'm fixing this for the !CONFIG_MEMCG
case. A new version of this patch series should be sent out in a short
while.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-30 18:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20231130140330.55de96cd@canb.auug.org.au>
2023-11-30 17:15 ` linux-next: Tree for Nov 30 (mm/zswap.c) Randy Dunlap
2023-11-30 18:51 ` Nhat Pham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox