From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD2F9C47077 for ; Tue, 16 Jan 2024 21:25:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 056AF6B00A6; Tue, 16 Jan 2024 16:25:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0066B6B00A8; Tue, 16 Jan 2024 16:25:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E37306B00A9; Tue, 16 Jan 2024 16:25:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D543B6B00A6 for ; Tue, 16 Jan 2024 16:25:50 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A5DC81C0EEA for ; Tue, 16 Jan 2024 21:25:50 +0000 (UTC) X-FDA: 81686456460.29.4EC9308 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by imf26.hostedemail.com (Postfix) with ESMTP id CD4C2140004 for ; Tue, 16 Jan 2024 21:25:46 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=apNkbijq; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705440346; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ucvEqlwX+aOdzo8fM1tdvFKFaldc4mizPJaj9Q2q6P8=; b=oIKzr3RBcjotZ8YHEttEQ5Xqmivqya6DueZKH0x4WO9HR2ENaEu7pDcPZe+u33T6D0tr8E IgEhc7m7GMMtRjsuauriJUQL+3P28cLgbNXKqRab7uIsaD8UnS4w/uK7EcVkLWWk1gPqho hp5t1PcFolsUrLEu0J+WvSy6MZgXGG8= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=apNkbijq; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705440346; a=rsa-sha256; cv=none; b=W2fGvgtXOw6/UqvZldfKKYX/PKRkjkJEOd/ao1OFiU5FPavg2KB/51V4cRb1dz0hTTUZdx QdV6FzfuLsvAwBhpg7lJWaRwIMA60nvHicTKsYNfFWPuSHeOP4DurIFkCYD731vtsneofl wNlsK6obwsIkNvJQwMWZiky+rT0E3lE= Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-336dcebcdb9so9897309f8f.1 for ; Tue, 16 Jan 2024 13:25:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705440345; x=1706045145; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ucvEqlwX+aOdzo8fM1tdvFKFaldc4mizPJaj9Q2q6P8=; b=apNkbijqzaylaN3yl/9slomEJvQTmmZC8TcUsdidxcXwgNi4XXuHvEa41SqmAzP7ge INFKdRBC4229kaxcDsSU45BHd06k411jL930mHL6RcR4lXimDTC/KFF0dNKfW/Ge7LG0 TNUCMaYcNIBJl2lGnwxwE/Aq56MD8Lxva0iDmJk2FTMXMb5OC2wedwTwYMh4SZLtObRG z7rUlO6mrATd7ca0emfDN+Y6sOUDtiISCqV00BdPCu4vvCByz72eQI6UjyRY3bwMmjEK o1v5NwKQPagpTEEGHt+BN1apf+mlj1BmkihCwIkvSSXALyxYTvfGYJbyulNj5qEwAAvP 1SMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705440345; x=1706045145; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ucvEqlwX+aOdzo8fM1tdvFKFaldc4mizPJaj9Q2q6P8=; b=EKU/41PwUrryTVxn3xHOL65lQQ99hbcn09pUaWKF42OpMOGNtMD8/PJjWmo2yblfIv uCaPy0j4s7PxwPk316va7bjZ+IkhrFmuRr8eTQqHbRMDL1htPh6fD1CuWtfCPMEStHzg +pOgDNbsvQ0WNYOytCUjtvDBTtFGoQuByn7pGloEg8c5VfmzJCVGhi8nehRxOAGkBz71 6UpUMlAuahBDgCCL0c/CRN+slsJtHC9E9CsEEUrW7dSGF4FQMqQ19ahvUZkLJoBtjEBA fIGDSR6BRwzUDrJ+Yb8GsIPEfCLTpwP9PQ/Nmq3KWV0REnGm1FMWQkPY1cVJMzmnf6sT JxEg== X-Gm-Message-State: AOJu0Yx4WuO37s+zDmk3vOACwCxKtiGaNnuGq/ZIC+plGj2LQ5dh2nB7 tsIG91QqS0l3NwX95IuLNrQ= X-Google-Smtp-Source: AGHT+IGUpm4v0VccrEqtEaIXaoB4qyH5YiZh+EJc9iAON3+YhDLhkYnJlXUSQ/phXyCl9ja9j7qAbg== X-Received: by 2002:a5d:6d05:0:b0:337:8bc6:dc5 with SMTP id e5-20020a5d6d05000000b003378bc60dc5mr2657084wrq.165.1705440345062; Tue, 16 Jan 2024 13:25:45 -0800 (PST) Received: from localhost (host86-162-136-255.range86-162.btcentralplus.com. [86.162.136.255]) by smtp.gmail.com with ESMTPSA id z6-20020a056000110600b003367a5b6b69sm61968wrw.106.2024.01.16.13.25.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jan 2024 13:25:43 -0800 (PST) Date: Tue, 16 Jan 2024 21:23:29 +0000 From: Lorenzo Stoakes To: "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , Oleksiy Avramchenko , kernel test robot Subject: Re: [PATCH 1/1] mm: vmalloc: Mark vmap_init_free_space() with __init tag Message-ID: <6d09807d-0476-4d9d-8753-dd6520c9a2eb@lucifer.local> References: <20240111132628.299644-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240111132628.299644-1-urezki@gmail.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: CD4C2140004 X-Stat-Signature: x4xs9acr6bpy9kg3nzrw5abcb9aiok4f X-Rspam-User: X-HE-Tag: 1705440346-806787 X-HE-Meta: U2FsdGVkX1/3D2Bu2mdzBk0Cthww5EFExUiQRmH/HfX3qz3A/H0NoxpASrzretLbgOHUim5IlXTEqq/NalqCKgzvsdW6bbn+EEh4XkT6/KXtSNpUcomWM3ITwBHYhszEblXNVW8Sf7O09qF82cLJOXpP22HusmUUmyOCEeYs65o1iX77FUf0OfHmVO0jvXuIwyS6cE1mtKWjpeHf3eRwiICDXjGbFATLJXCFNDkcfaLYZmD9tV114gcAOKBpQLF2oNYsBVe71Ubgye5lEa8/gabNGNwCpEPr8u3BgFjkB/jFFmMup7qZBZVmrjrD9GJa3Oi+AcFcHgULVYb6mOlTXmR9XaujWQ0cwviJNoTH8FVYjxqABu/UUERqQZ2NRN6/L1tlHeZ0xJim7EB+nwYMEFSOloQEFJVZqgUT4x9bnyDCiXAleyJc726nKZ6qzaLOtXdtXpLtmhZaDQgI2AWDP87Nw8bCy4FzEn3NGqwJqEMhPAvrCTzq2Vq+isZiIaWozovdWJtHqgFvWiDehuP4BHDVrz1y2bllA9jHRH2Y01Wi2jem00a0+vM8ksP5gx3e4oXlzDmZ8KzWUD1Uhp6N5vUzBCgt6kEQuiTEBo92d/IYUzGWgjGHjFbQhQAGq9ShHRVujJyA26iMiZj0HJwgtUX7k9tORsvrz1sPsEVqaOxX7C0ajKS1wQHNV+XGKTNr6Ttem1NA2CExo309frts6mTBY4zY8rhuyTPKwWLWj+xuKOVus66wjAmsKI5JJ3K4QPBdF5HWceXmE982gdgHh32BY0fLHrWNu11JqaD4AYv7sabNV9FBziIhMhWFhcHEXEsStNo3Eq1uyw3djNZTM/7Dv1ntMAkZuOCFvFx2m5E/xd2DHVPwzvu7oEDC4Iqf0IeRUYQLbA1gW92qqxa/SnwX5LdGsqXzH5lmP97gCU3fIptSah1UbuxlT+pSVCHt4ou1jC3AL8LStj8F46A qLCOhcWj GhDNwoiOPn8i7Wm3b/zPZ1Yp+VLtVELj9lc0U5iAIpZ03mCxEAKW1RGbnzdnHcWk3LPrWwUifWH4ZpgRmKlltLanoB25xE7Lpimfvg4e/4JOugyB/RHNvlEfeZL1eGJ7ogq7VqUInUOqfsce0jwRUNpY7ZkML6v7Nh4Kgldu61ULCUROdEDRHkWxBdbca1WGp5OdHURzEnI7fSeBTpwo0Pr+pbxkF9F5EJoB+pv6UJGG02rHzLjUfT8Qy4rMJc/J8l5d3HR7Y5ky8c3xibOVoQbnKFR93jt8ufPA2QlIW16TuMKSSqKHaVGyXFj5vdQnDmA5GI/aziNicBJnGI7xeUfwhinwsBYDZiEF+1agUxdugJCjCPUVMafNs/bANV9KRij3ZBcPbd/GH4VxvDvrEPKWNCgZRI00MZMxNtH0xncXX4TPm1zAFQVDXm946bnu2Phzj+3dva6M4pcpwtu+54e5yGZ0+ppInrqoIn5evG5iZ3rgeR7gHBHBPCzac2VrE6kv8zoZiMjMbue+oCcAaWig6SH54hTZ97Ig0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 11, 2024 at 02:26:28PM +0100, Uladzislau Rezki (Sony) wrote: > The vmap_init_free_space() function is called only once > therefore tag it with __init. Apart of that it access the > "vmlist" variable that is located in ".init.data" section. > > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202401112056.I41bELL4-lkp@intel.com/ > Fixes: 86817057732 ("mm: vmalloc: remove global vmap_area_root rb-tree") > Signed-off-by: Uladzislau Rezki (Sony) > --- > mm/vmalloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 43a6608e1397..257981e37936 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -4834,7 +4834,7 @@ module_init(proc_vmalloc_init); > > #endif > > -static void vmap_init_free_space(void) > +static void __init vmap_init_free_space(void) > { > unsigned long vmap_start = 1; > const unsigned long vmap_end = ULONG_MAX; > -- > 2.39.2 > Looks good to me too. Feel free to add: Reviewed-by: Lorenzo Stoakes