From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78070C3DA6D for ; Tue, 20 May 2025 13:46:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12E0C6B0093; Tue, 20 May 2025 09:46:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DF336B0095; Tue, 20 May 2025 09:46:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F36816B0096; Tue, 20 May 2025 09:46:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D38C46B0093 for ; Tue, 20 May 2025 09:46:19 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 72B1714035F for ; Tue, 20 May 2025 13:46:19 +0000 (UTC) X-FDA: 83463410478.04.A119D3F Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf22.hostedemail.com (Postfix) with ESMTP id 5E560C0011 for ; Tue, 20 May 2025 13:46:17 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Gp5tEQhe; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747748777; a=rsa-sha256; cv=none; b=rraG2U52zGUEQzW9NShXBCvOtrFYilftXxJDuZi2DyOUdWRvP17JWtsSGTbY+gXdyMwi4b eM2JjVNfRfU7Fo7g3hsxBlhyocG0Jft1BcObrlsoJHBb9v+A4QsOk6th7nVmqGonmy+IXs vGo1lBdxsZLO+mEcSzf3jXaQEWydhCw= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Gp5tEQhe; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747748777; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x63hT6SO5GsWt+J4N7rT5dncXL6uLcyTmJsrqz9Z+Ls=; b=8ruDx28GkwC4ie4OSzULZSXpCvsQzri7CkC/oyJiER9Xu9dPlONv+F8OC6JByvuvnVlNLM NS9WRimJ2IYSj+03I45PZgQxGh/fOwIFy32C3dBjI0VOn9Qy/rkuVhHesV6Y9IZS4TShoE YyKx8mqm6a6LpsNmBdBHygSorkDRZuk= Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-ad5740dd20eso337862966b.0 for ; Tue, 20 May 2025 06:46:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747748776; x=1748353576; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=x63hT6SO5GsWt+J4N7rT5dncXL6uLcyTmJsrqz9Z+Ls=; b=Gp5tEQheInk0CKITNtH9Ar3i2OgYKWxbfBe1Dc3YX0KIGcxSNY5K9/MflkZfWayHH8 AiZJrcEGf2h7kUQGRGE0vRa3OeoT77cPH2v/EQdBKKFRBZ5plQ3RRo8SgWeZtJtvjzjq 3lGR44W1UA2pqc/UsY6EauAltPBTCiJopUn467Qf6HsEAUXl2pAK3QsGjqfXSbU5V2oN OSzG2MalFY1D8UofLIAa1iY0Bm29D+2YqE8SfoUy4pT23sNDfm9wVnAIlgre6lUPb9MZ sTzq/xED8umD8nb3m6nh1/VTaErJ40HFDbOmbu1h35hH6CsyCeVStgEcJCXmhlMTxlqd CaOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747748776; x=1748353576; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=x63hT6SO5GsWt+J4N7rT5dncXL6uLcyTmJsrqz9Z+Ls=; b=Xc5lcPG48R2Pp+Dnx/LmXUh00hGS62WfIqw1+n/9lolFfVlELEKC1B5JJr1l/wYRK3 KwFQku1BanT11r4oTr5f4TLX3NjCfB34ylznMs7dGvkD6e4d5L6/EZ48Znl3JWPTaMzZ qzTp+fQGYCZ4SftoY7eG01sRLad2RrXZYy43bsdw+7dwGQREHwo41TehT1tlEZlt3BMj cKMRma7jYdLlcStzHs8w53sjGX6tZxnzDHXC3VB+Nuvzx4a6QzXnKxvsW+j0aXhQypnw wBCzF6KoxYi+jVcoah7OyP8ThAhSoMP3UJ8sCvkKzSXvUt4XD28ATsUWbc5ILwfZzkzJ 1GoA== X-Forwarded-Encrypted: i=1; AJvYcCUdScWEn+JsIRkUewdta57J6pMyclQ1/Xzkjta/H1OKVLOXyXGFS0qFQs8g1MT7Cl/PNSf3X2+KNg==@kvack.org X-Gm-Message-State: AOJu0YwW2G2j8FRe1uEOBdhEYtkmpTbJ/ngneZcks2v/thrmQ8F1Lu6o USyvIIG8ctBEjU+MXgQYTv3dRtaRjgEB0DalC/jLTIkOjw4bvShSoxt6 X-Gm-Gg: ASbGnctY10O6uFKxJFMJVlPk3E2r7gkjMhm49PprePO/CDy8leajSuJ0aFGAzff5tkz X2avdFZANgsfNB9t3Xptq13rwGLSOXqIeeVNNWg8bPGEBx6nMvEp9txJJRdU2Z0DjT4mmkWWRTX RuupzEhJ3+BwF9ay0rmDEUi7KP6j4aV9JI/Cfkvki2JL++vrNi0B1JLM+wtBUqXlI1Iq5YU/pnv T1qKiEB44ri+Q0BT2Y3ULVWuNuxn/B2juSOyoof5ozccD+eRpSoNwDoIKAfQEaUuntk/+FmhXxR VAviyt+mT0z/w9N26x9Dw8cySAbydHyapjJcVxZo0qBlBXzwQHXN/dK2mXtzU2Xh6iXx+2ny6P+ zcUfqAUsK5kXkSYohpkMeZhPo X-Google-Smtp-Source: AGHT+IF1em6fQ+dQmzsQ58BrTPYM6PFztA3fy3AGPzn1H3XqZ+KObnhKheRQYGrFfIvF4334SIkJWQ== X-Received: by 2002:a17:907:3e20:b0:ad5:6d1a:6fa4 with SMTP id a640c23a62f3a-ad56d1a72c0mr763299466b.44.1747748775442; Tue, 20 May 2025 06:46:15 -0700 (PDT) Received: from ?IPV6:2a03:83e0:1126:4:1c0a:f3ac:4087:51c8? ([2620:10d:c092:500::7:66a9]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad52d06b497sm727382466b.42.2025.05.20.06.46.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 May 2025 06:46:15 -0700 (PDT) Message-ID: <6d015d91-e74c-48b3-8bc3-480980a74f9b@gmail.com> Date: Tue, 20 May 2025 14:46:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm: slub: allocate slab object extensions non-contiguously To: Kent Overstreet Cc: Andrew Morton , surenb@google.com, hannes@cmpxchg.org, shakeel.butt@linux.dev, vlad.wing@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com References: <20250520122547.1317050-1-usamaarif642@gmail.com> <3divtzm4iapcxwbzxlmfmg3gus75n3rqh43vkjnog456jm2k34@f3rpzvcfk3p6> Content-Language: en-US From: Usama Arif In-Reply-To: <3divtzm4iapcxwbzxlmfmg3gus75n3rqh43vkjnog456jm2k34@f3rpzvcfk3p6> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5E560C0011 X-Rspam-User: X-Stat-Signature: kcw4xmog1iiyqae8rdayrfbiguwozdcq X-HE-Tag: 1747748777-908308 X-HE-Meta: U2FsdGVkX1+6iKKvSYDS2ldnVFLnWNZHQcz+zrsLpAh6IZOMDYgLstB4okzD8kuEEFFSpnRjlMNWE7TKEra1EQ6hxm0nRDCioL3huV7543KwHkjBowYH2ktC4cNY2Ptwm60/S4lMgNc4ZGtlD5lKQrrRFR27I9hja4GKa89KF3EWs1RHlFqe0bQYEEDQhXR9WmjVQAVdIWFX0ZWj1kmXBOI7cIBSj/wC2ytVm+jOP9IsvYG5YI3KYXogsqdlBN6CohgKJU13t9uyQHCnv7ZJD8lQc1kVlPtdr0K8R57qpV6bEPoL69czIrVC5MnmvAFMaKyQZQ8mQL4QYDOtdxhzYU9feemQ7psULn6Qjk74Upzs27PLs3vhrzvxPPz/DGdovbRjrB90WdhKYUXPIMwhld5VxxF5V55TZ5AD22MCPkv3Tlg2kx4VMIxBp8qQY1sSSXr73TeSb7swSdWv25xNkDfEQVzymbpWNaJgFmPqT2Bn+nFZ7v6gwDvL+N22TE2Uc9G3s2wQv5nQoZC3NCjB34M0JpfScuz8Gy2GnHwmo1aHDJdqufVBlQUFCcjiNhbzL1JgutCECNhvCDyuvDayK/U7penh5nPawyqIEx/f2+F5ea1vclQ3Ib2EyGu/hfxUTZTXUBE0wE+LjbyFi6SXnWh3+WMkNKltLcrDufJcdXebfmoI9Dp3gBlRaab48e03Dlr3krPxcqF4TosEocS9SOIFOAOQ++YfrTfIav1poQDI924Fi9WJbOC7DxxrZdg0/+Nb8988Jwvn3ABK2qHQE9AO2MUVPloEQMaDVyrrr4ql8/DXEw2F/h2rkWvpZ1ODRB66X0OXTYaJYSmU4P2S5zQF4ile8UcrJeqgAwUVqj6y+nMuKL7OFgHeVvNB5fOlpUIrWPiTxnrnAAQF0pG9o4kNc/45LQtpfB9TyK1JGRLBJYgWkomUVQgaSNXg+ie2rtbleJ7L73VPYzcYJlR QeV/oNjx pAl6QD5+9Yp5u4bgRgVlTFTjkA3pNC4pdlOQZizODXBt+RazghuhYb7n2lS3LQb2YijIAr8JTsR5DRYW+iXKM2msGepb58+i2G18lCJNnjU/K/vlvagkzCVRJEyiRlJcYEriu1XW/qO8BqzMdcQAn4rygM2//OTaJKBUXNF42rHjFBaZKQz6gZXp/L1JL79zFIq5MkKzMY/hYsl4IAyAzaXWBQneaspCfahCbTn4FhsgdMGoC1o/gsw3tYgAdhYL2B0KMxb0tgu/e4QPOwU1gvopG+r0UG29jNHVDBLhk0Q2gHGD/pRNwwQn/d69SkhlQWUET01fKFDRXR/dtcpaHeMUWguDdmIJkxNKEC2xGvzLg0AYjpluZT5Lx6/q2HzdBnWLbUrFu+3n1VWSi6qVTPktK4DO+Mc1ge7968N+UX2H/dRXh1j15C/HqqXr/zoH8mbNuaI742bWKcotn+22yzzxKhCK+AzEb84ba+4t7T/3CmKw7eTIflDugOq7sLaH55j7gMdDKaI5HV40J6E+PYTi81jr7pavIuNFxqWokO+8744I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20/05/2025 14:44, Kent Overstreet wrote: > On Tue, May 20, 2025 at 01:25:46PM +0100, Usama Arif wrote: >> When memory allocation profiling is running on memory bound services, >> allocations greater than order 0 for slab object extensions can fail, >> for e.g. zs_handle zswap slab which will be 512 objsperslab x 16 bytes >> per slabobj_ext (order 1 allocation). Use kvcalloc to improve chances >> of the allocation being successful. >> >> Signed-off-by: Usama Arif >> Reported-by: Vlad Poenaru >> Closes: https://lore.kernel.org/all/17fab2d6-5a74-4573-bcc3-b75951508f0a@gmail.com/ >> --- >> mm/slub.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/slub.c b/mm/slub.c >> index dc9e729e1d26..bf43c403ead2 100644 >> --- a/mm/slub.c >> +++ b/mm/slub.c >> @@ -1989,7 +1989,7 @@ int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s, >> gfp &= ~OBJCGS_CLEAR_MASK; >> /* Prevent recursive extension vector allocation */ >> gfp |= __GFP_NO_OBJ_EXT; >> - vec = kcalloc_node(objects, sizeof(struct slabobj_ext), gfp, >> + vec = kvcalloc_node(objects, sizeof(struct slabobj_ext), gfp, >> slab_nid(slab)); > > And what's the latency going to be on a vmalloc() allocation when we're > low on memory? Would it not be better to get the allocation slighly slower than to not get it at all?