From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF0A8CFC501 for ; Tue, 15 Oct 2024 01:14:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5456E6B0089; Mon, 14 Oct 2024 21:14:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F46A6B008A; Mon, 14 Oct 2024 21:14:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 347006B008C; Mon, 14 Oct 2024 21:14:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 114B86B0089 for ; Mon, 14 Oct 2024 21:14:21 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4E0FAA872E for ; Tue, 15 Oct 2024 01:14:04 +0000 (UTC) X-FDA: 82674065796.02.8ECABA1 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf30.hostedemail.com (Postfix) with ESMTP id B0E6080002 for ; Tue, 15 Oct 2024 01:14:04 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=jRcnagN7; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Y1HRaDj2; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf30.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728954716; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PxIl4ojnAKf788yVQ4111xH4y6sw91BL88gpNszgrUM=; b=V4jfCoCCKzjOoCe6nJ81XYSaM3TwFNMFZHTu6KUz5KI2IUnEmXWyrLhFdRFm/qhBt9EaM6 t12yEo1hEDIWHKW7inDX5/8HDQk4ADE9U8BUYV6THSnau8nIaRhQNH+OpNVg+M4UdJ6DMr 7VOXvycyBDcLiw50KwIh7EmPRHMP70Q= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1728954716; a=rsa-sha256; cv=pass; b=WZXp+k7vAof8gIMb0EJPOj70SS87CI6SFbWFmAsQXkJJXsYDgBundlX4O6j85E6wccRm5P SvFCuwvpOPwqk7dyzcSDEwXsvDSLDU6bQG4DSaXhZ8R7hGL9ARfjjdh5ICcDPlUxNjpn88 42QV7Jr9jALhbaZ+771kkufeB0rlw/0= ARC-Authentication-Results: i=2; imf30.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=jRcnagN7; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Y1HRaDj2; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf30.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49F1Becr003584; Tue, 15 Oct 2024 01:14:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=PxIl4ojnAKf788yVQ4 111xH4y6sw91BL88gpNszgrUM=; b=jRcnagN7+6FRlf65OMMb9cw9+Z16NISNQ9 4NCyX4/FOUjEGEzBZNlv5pZAfv0pcfB77g14dKJsqUQJxBef/fqot7BmLMe+MrWS FdemB8WC0+hshH5LAUJMsLPgUGFSkLnkO417lYMh2BAFavd9gSdTgXhZ9rBot8bg hWjc0rLw8RkDKcelghwttbrTpyzQxHfaicr2qmo6gCBhhTV3UJKrtnIAHSaozkQ/ /C4igmSyJQony59BCzHRIQiFMyJ09c2t8JJAJYAjx5rdCn1KhAMJmKtQRi9oTfPh BG6SRb0VBG4YB8hjbRnc/Pi9y6N6JVvBJk7heiNCMO8L/ciR27zA== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 427h5cftcn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Oct 2024 01:14:15 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49EMGbe9019937; Tue, 15 Oct 2024 01:14:15 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2048.outbound.protection.outlook.com [104.47.70.48]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 427fj6sn46-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Oct 2024 01:14:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pIdTpHu1vAxHbrhg3nR7Vr3+fCDn+1NV88yzQeKdfp1uwx96y4xwj2ECYe+/PmTyWDFT5Mi477yvac1Oi1Q57fZvMe8amB03EO0tB40jhllYvayoJ72xfpO/ZZcBZzxPln2KT95FAnANhYtyQ9w7dfvdvJlGQwJMh8YSXWz7A9V96uWurgrksMjIkp95/scyProVGh31xvLf8TGdJNRS+0uUrg8fczOlaE1c5iazdKSMqOaaB41wqLNwqiG4+W70H7z+e55mnPnoN7vo+UTQVpLP978QC5LLWAvsRULHP43XyHH9kqmMAl0JJSmtG6QinVt7JVK4cIOYJ9REP5047Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PxIl4ojnAKf788yVQ4111xH4y6sw91BL88gpNszgrUM=; b=j1C/fKA8r5tmS7utOgirWGhaaSEGPh7uXaGX+yMHmwdKdx+3HeFvUYZGkFUdskRCr/YPskD8HQdKIXCdJBNA6gT0fDlbFwZQKFy3GRzBL2/H1IfX4VQQKqtcChLARQ67fOog2ML5+bYKB49eyk3+PopBeT+VvxzWXCtWxL8CYXxg2kmuLSkwPqzOLI0UpkQ4AdB12ZxmKuGrD0JaAimsOG1wNc4GeoHh/0AklV4kEUhOKw2UPQ76GI4T6F20pS4YxVQefbxqjWervw7Qg1Yu8QFHGvmFJuquxj8OvmknarhrjDkGELgrjz2B7cGaflryLCURdRK5H4kOtwnaWZVxHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PxIl4ojnAKf788yVQ4111xH4y6sw91BL88gpNszgrUM=; b=Y1HRaDj2Bt7iaGTJCt7BXm9vdejvweOXzkh+rVCCwSNFiL5RjqcldTHKj7NLVQaW0VPc2nNaNcNj+YUxsjvgRsWrlZGl+f9PJ0CdRG4MgkC0lJBS3npQQ9KAO/v5BHOY52+/GzqIkuqPoBtA7X5cWgcne+2QNtdudQsrcqxIjiI= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by DS7PR10MB5901.namprd10.prod.outlook.com (2603:10b6:8:87::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.26; Tue, 15 Oct 2024 01:14:12 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490%6]) with mapi id 15.20.8048.020; Tue, 15 Oct 2024 01:14:12 +0000 Date: Mon, 14 Oct 2024 21:14:10 -0400 From: "Liam R. Howlett" To: Wei Yang Cc: akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, Sidhartha Kumar Subject: Re: [PATCH 4/4] maple_tree: fix potential allocation failure even has memory Message-ID: <6cf4vg767brbutspihxrtoaifvfba5kh3l7ambcveabzsclg35@yodji3nrlspw> Mail-Followup-To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, Sidhartha Kumar References: <20240924123954.18933-1-richard.weiyang@gmail.com> <20240924123954.18933-5-richard.weiyang@gmail.com> <20241011012725.ffof6uh4huffz73q@master> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241011012725.ffof6uh4huffz73q@master> User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT3PR01CA0039.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:82::16) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|DS7PR10MB5901:EE_ X-MS-Office365-Filtering-Correlation-Id: 23fbdb28-c6c3-4345-c6d6-08dcecb6adaa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?BYff3J3oJmruJIHv7gkJZacS0y+XHQPoLaqkzXJ5ajeoUDI5DGZvnEfcrDQT?= =?us-ascii?Q?sMxuxskupe/0yaICsrOAS6Im3HWdcbMVErsR4VBYozZtv3Gp7WINH4akUrF1?= =?us-ascii?Q?4O7crw18JSqQ+BsTk1ef6/37CAJzzlinzqaRRjufqzXcPoIFzZQHpe3yWbOp?= =?us-ascii?Q?0kSD3ZdLihOrp7ediwxirP7LwhEix0TiRZMuCGPvO6Ih0bjgKnz22ShGywha?= =?us-ascii?Q?FdEY+NdmiSLbIJf/suOBw7CRIy2NS9fiCpJosIjmR5gA51Qfnn2buJM4+q0W?= =?us-ascii?Q?eBgOzRyiVIY+BZqgDMT2Ds445Nf5JrVNKw/XlZWpgnUCr0DuGmT5sAjbYCBT?= =?us-ascii?Q?Fi3QIur6YnYE6OB6s/dXGg9HHuuV8ts9MTo9ebf/QNErXEp6ej4a1rKmVefF?= =?us-ascii?Q?JNeWr2XQTlCpEUcID90d3v/sbX465IYYucYtIFawsynFAwSCXBGv4YmrTqc/?= =?us-ascii?Q?8Z3xBlQtFs19p4obsaLoPdg6j7k3msrXYAd8lRWf3v1VLH1bK1xsalY54slx?= =?us-ascii?Q?DK8g/UjxGs1WUeGFQ8VLnj0b2+wPEWZ96+pVnUtwOchVu1HjoEQj+2/Ezdum?= =?us-ascii?Q?rilxkHgbETn39776fGgnvMv4nZBMY1MqXLQrFLkHbb/N2BHRnuHRHNeIEMZs?= =?us-ascii?Q?gVMN/ZFW+YHpesl1b1KTt8TsAIAaskJNF6nfhBioJ3YfEc8MN7cMpzkvZjH+?= =?us-ascii?Q?YEL87YXB/YOiNgGiv0svfYx3TNvTTJ9eXlOBZZVosiGh8EopW9Vdeai0Cbjz?= =?us-ascii?Q?XwkMmqU1tbC4h7MTcFW8w/4SRwNO1Kq58yx5XUX1E7Zqz9g1ZY0TuFHgNS84?= =?us-ascii?Q?s3GUITu+Qr2bEo9hIGv1GQ7Z91cokXzqVWs6kE5PutIsI1Qzoh6Db+i046c1?= =?us-ascii?Q?amFpt2z/WIVBqtaAHvK2KwgdOh+DtV2GcI/pZjLiAbm9WYo01cTaFIE+tugk?= =?us-ascii?Q?xPsL1oM67rnjgYTc6ymJ0xquwy0QgCMvJwBEconqidSe5Pb8az1tZALI8ilG?= =?us-ascii?Q?ZXO+mkrrsNv3lb+Di3KhN0Mc3tiBvpuSLcN9XeFICBPgR8vmNxb3Ga9FSHxW?= =?us-ascii?Q?VkSF9dnqjw6xmPh4g3aQOSQgka7EJrc655A6OvFdSu4obUR/GusMSpDdVoaR?= =?us-ascii?Q?1wj6z2Uuz4h06lmsa54ZdFtESWn7nR7yDYLzjuz3+zRCGgQIPrYDOTIa1q+4?= =?us-ascii?Q?iEj+MiyPAeTVxrytPJOZrOthJR5ItEDpLnjOzbW5DevIT6tuhxeWtJB1xMA?= =?us-ascii?Q?=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?itR/k3Mqhx4f+EAh/H3/keHEa345aCW/fvVQxP1m4kPTNba9drThzxOiiwSW?= =?us-ascii?Q?al0dS9ToJRpIrp+645KtdG5n/gc1/ge4hboAet4SFB3KOqz+n4U6NKnmuW+Y?= =?us-ascii?Q?Jnh0RWMmXl2jx2jIchRGbeKMq90IQGaZoXr69YfDFcsU5LMO+X5uGvc6w6zU?= =?us-ascii?Q?wWx4xQIhIeFH6u3zn1WHzTobcKaYfcDxCsbncj1kXn2lhMlVS8ZMM+y8mu0s?= =?us-ascii?Q?qvl3jje6D3BgoRfoTYlMyfOrV8RCzrUsMqyCGF5CptSWqyqHHw/j+43yslJ1?= =?us-ascii?Q?x5GjttrSRllWwY4DfLH2hq4JkpkczCzMDYzJUGEsmP5tTsxXJz8iSomb5VGX?= =?us-ascii?Q?dgf46iymk8pXtf6ClOSS+rb4umYvePVTlO8VSEDtmj7Sf++x4a07lsKe0N2d?= =?us-ascii?Q?+i8fPBW4AaKH/oZeeq/kCDKkzrF4zHGM9lCocu9O5oSW0HHuUWh4sDlB88jt?= =?us-ascii?Q?ub5bCoo08viCyvE2rTKCSqKzJloUsjYfqiCuqPkG3xicWgDr6f23LEh0Mb+T?= =?us-ascii?Q?/U06fQB7kvQOrtXMT0zWSXuC7clEikSXgHQ1gsbJimhjOmemyBuIaDaMuqOn?= =?us-ascii?Q?dvvnhMwEku02iNMTP16T4xMKDreeStmR/xh4FSmTX6mVkHIBuX+Y1vXvF4s+?= =?us-ascii?Q?Vznb3jVX1RXhe5Grioz7Sxxz4V36ml9o0UZS0+SrnXJ92HEpJ7/MzqK4JBxV?= =?us-ascii?Q?ynvnoN95H9JCOcSTYeO2Dvb0EO3MdRGl/tzY934tei2wa0Ze9xZSt2mGSbY4?= =?us-ascii?Q?5KTlIpMAGSOgo5hirluk0V7AoTtpReytm/ynKu+ucnqLzJ26hc4VvRx3avpQ?= =?us-ascii?Q?blO3w+gqzvKNzereEWgRZzIJH2/rMPi3a/ElPZNQ2I+lLtJjO1gT6GRmYZb+?= =?us-ascii?Q?B/wWHgB98ANVIRWwYYrBJuvgoVT2+9yJjN57nSxWaCDYiYLBjdF7wxpvMtaB?= =?us-ascii?Q?djGInVcKtG/N2dKGFaCkcwzLzE7M2TnhUqL8jsTKgjXLThjHgaQr+HphXlzL?= =?us-ascii?Q?X6dePNXCnK3eS57RJk+CopKKAm6yv1wUtOl4TBaR6BleNh2mjc30jf+n+OBh?= =?us-ascii?Q?6/Yz7/QfC5cT5Xtb6JuW6uDdWCQAkcKALLnzalPhBXl2BPN/0gcoxSuVYqV3?= =?us-ascii?Q?9RRYAUp5cGhmUFAppXZxBf/bvNhjZOiSSQbVoU9Q+6wcYEwSJ1ZEkk1K1Yfu?= =?us-ascii?Q?6hpCRzp7FwPHbvgHyAgUanCtENMgUNKVYL34aZeUPHBUiMTbdCOkai1KUV53?= =?us-ascii?Q?9ZdkSpq6PNQ+7AN9BX26GM2dj+yX2g8lkiGutoUeGkuj4buuC8up5fN/S+lA?= =?us-ascii?Q?sZq2qaliZOA/iszJRLRxcQoUanJfb1qW5oXJUMGZLWvk69HcMwYIg8fuEJJe?= =?us-ascii?Q?d5eIieHE7ivNemiUi8xqktiC+JOVnJuv61aH58e73R1lu5cTWOna+Athutkm?= =?us-ascii?Q?4xAprt+D7B+0xf8A8xKxg/yeOFBfvA+nzwSzs7jqEnkjyYRxk+2pEgtEiLIi?= =?us-ascii?Q?ZTelc1aT4v4TW6+ZzREbZ1nnpy7sp21rdZxJM9BD5XboUqsvUmi4hGQl8Lgz?= =?us-ascii?Q?C/bQPUyJnAth3DFRVnSmiykuzZQZnlSRI2pg7nvr?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: xK0O+A6YK8z3VxTQM85N6eUDZ/SKykpxIka8+kDZQpuj/nkYb6Sz08ISjSjGx83FLgAuzjTozqJ0fttsli4Ky3UN0eD5m3v/afq2ZS7ozedGol9/W8EM5AIKrfwi5pC5FmAe6Fw3YHprnbF4aVnv7H5s81gVAUGYhkmKO5yNfr0UErbNsqn0K4Y9MSc37xT5eqlEnCbgl23TiWRe9K3JERvK3pfSiM/dVbVaRGMheo6ZasfgCRITlRmIRoVAioi6XgxLHoBdghLifTyJ6yO4Wst+XdMsCdAh4TsctkC2k5gzlx0pvAifrNGx7P32l1QL/nbXKd/BJsT8ZcR+aGWOB2TO8j93PytGwOJ2sPY6kxze5OpRg0HhJtm0/pOj5G37E2rz0YV/coXqQgbcEUTRN6x89X8V5jjyoF+KSODJ23XPGeimh1RB3SwFX3FWDth0UmtqsON4baWYCTGCqRli9nr+rZnCw2Wg20fRvSg/osffjkgnJ325xi0cJm286zfrxzWVPtRdfswecuUQq6KdgEyZxq3+zOfPYoA/aOLl3ifgtKtqFW6uP1hV032QEXM0sKBC+We4YrXDQY7d0Rd7gJ5e6pCfrQg0cGJ6hguj+wo= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23fbdb28-c6c3-4345-c6d6-08dcecb6adaa X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2024 01:14:12.2635 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H03RebL1CI6kroNERY17QNsjlJ1OTcWqCJpX6xWIdWWRr60Znw8lcb8MplrEO1Ir71L9UWKOawUuwehTMKfe9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5901 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-14_19,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 phishscore=0 adultscore=0 bulkscore=0 suspectscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410150007 X-Proofpoint-ORIG-GUID: tw3KqCUo7Ufg4WQBMJAhN40pZDqkA9X6 X-Proofpoint-GUID: tw3KqCUo7Ufg4WQBMJAhN40pZDqkA9X6 X-Rspamd-Queue-Id: B0E6080002 X-Stat-Signature: m3fgy6xk9zqppesb97yq9bnrrrabjrdk X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1728954844-871946 X-HE-Meta: U2FsdGVkX1/i854cP4I47XwPg7pmn3pCebKKOGnMhY9ZlRREfbFab9pKdQ5q+1SjIBTlIe/lQD90DlK/gS3XrUbFwZ3Cq3fXh7sxO9+JX9V57Uncwt7es/vM2fMwpWvjTe0/mL2p79IAqXHoAJR7ad1e2e1UXLO/JqKDq+uMXdZzrYCdSmY1HBaTSmcaT/8UHR89gcIrzfTwJFtnluVw7u1dVdqXmcIppchNzGsiHaggSOPyJZ6o3fk7BYL5F3/o2kEBkl9rvk4x1czA6ykBMmVEk5KQezIm8D9jrB3s1ZfSt4HMkiDlhWlnXYg6Fn1oSQ1H+BHv3FfUUxrNfOIgAAPJA/4YcSMN7yJN6UlOz0ntVuUHMXV8rmtVDdz0zBM05CSUApXE/FcIos18L+VmcghhtxUqYVpeuNvpOratTebrfKv6uBKZropnboZppfdzt/sMUmcjbpxheHwWLRmFubh9DvyoU5WSWKEe9CwCUle0kXfsxdkd5UFOzSrs2A6w510ML6j5WV4LfNtSt/eB2HToIYxU0Pm8c3/5NHOd0NLyaFvinwYrm8fDgoG9Z72jUCro6mqi/H7bDM2+vyjVlcJ59NHSCRoEKn85spouiErakUJlJFLxT1JdqBgck1uc58ReJoXB4TG5kmCoII6CPYPFzSYqAtcb3MAZfwvdAvUsHw1SDxilKnSplEgQyHkRn6gvicyLiu6io0ywdwjgUNNSfNTUOcpM7gEEYqxvJ93/dkt8ZS6Xg/FvU8/l7i9RcNabGHkzuBoXh1hUPsxAz/2F8IHZrTy1qOa5kGQqX68EYA4OYFBrAMrt2pQfDaI+myVH4RwtxBvOwfMtNenakXmfZf8uCbGnl8MOoTlwKQkgTSBzJdpJx8psLTRVUgH5qzQbSQ3pwIqWB/JBz+GkF6Xpks6PF4NeZiI458lFgjjq/EeyKEb78ETQgBcc2kiUMMtqku3KsK1p+S7ni8A LSWwZdCI F3mz9Fi2WNUT2fP7A1O8VozWq17MUQypV9SVpPAS5Nap3C1lokLJiKeIz5a8BFgLecaVCL0+475MGSflGgxw2HJHfctKEoN3ifSrnLwXMkVBa3rYTytwaTj/m2K1hcvhNBly/phPVZcQcdwGZ1MBwId4ZM6bvO26Rij/917EdU9xC7JCSn+29du2iCH+V6wE886uXwnrZP1niRyTcogq6JuFq2pJrfW9SOno6+npEMEeW1UwDprJOhMV76972l/rdzwnqrQSqFrb5kDqUipVvHPC2Tqplir6QhsEbzMGz9aXYXvltJVLLN2oOpD/2f/ZUrsh9KqELahbVzHFFgxn/Rsi+qQf1lK59hxK7o7/32GoNyiSZf0tl+zxsNwUf+jBNIPQY2HRXkqtN5elpwaPiEqFeTBtqU+S0FkRnd1dZkeetQLS2L+NPxGTgIle/AyU/WUxyB81VFG/IPVgqzlR9h01PeWvBX3lz4HfAl4dI6717v9uyj2Jjg2GQLbcHkr6YYqvoMJOs83inZ8svKgzy/+lGT5RsUEzzdyzE/GIM62xts3wZPgtEHm1JpAUXEJdYCY8/UVS8rRJx3zOavuA7rWfDshGqJfEyvlzNeUtzjVxB+xPnBrmWtsL2NAQUYdKeGnN0ZzcJknlAjq/HUDjt3SBJMzLrt2jpscO/ZWzbhzmN6lP3H6JF95Z6Ng== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Wei Yang [241010 21:27]: > > Related fix has been posted, but not merged yet. > > lkml.kernel.org/r/20240626160631.3636515-1-Liam.Howlett@oracle.com > > May drop this one. Yes, I thought we had fixed this already. > > On Tue, Sep 24, 2024 at 12:39:54PM +0000, Wei Yang wrote: > >We got an rare case when mas_node_count() would fail even there is > >enough memory. > > > >The reason is the maple_alloc grows downward. And when hit a full > >maple_alloc, the max_req would be 0. This leads to mt_alloc_bulk() > >return 0, which means failure here. > > > >For example, here is the test code: > > > > expect = MAPLE_ALLOC_SLOTS + 1; > > mas_node_count(&ms, expect); > > pr_info("expect %d allocated %lu\n", expect, mas_allocated(&ms)); > > expect = MAPLE_ALLOC_SLOTS * 2 + 2; > > mas_node_count(&ms, expect); > > pr_info("expect %d allocated %lu\n", expect, mas_allocated(&ms)); > > > >We will get the following output, which shows we fail to allocate the > >required number of nodes. > > > > expect 31 allocated 31 > > expect 62 allocated 61 > > > >The straight forward way to fix it is go down one level more. > > > >Signed-off-by: Wei Yang > >CC: Liam R. Howlett > >CC: Sidhartha Kumar > >--- > > lib/maple_tree.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > >diff --git a/lib/maple_tree.c b/lib/maple_tree.c > >index 1cbc5f7ca40d..dd33d0793dd1 100644 > >--- a/lib/maple_tree.c > >+++ b/lib/maple_tree.c > >@@ -1253,8 +1253,10 @@ static inline void mas_alloc_nodes(struct ma_state *mas, gfp_t gfp) > > } > > > > node = mas->alloc; > >- while (requested) { > >+ for (; requested; node = node->slot[0]) { > > max_req = MAPLE_ALLOC_SLOTS - node->node_count; > >+ if (unlikely(!max_req)) > >+ continue; > > slots = (void **)&node->slot[node->node_count]; > > max_req = min(requested, max_req); > > count = mt_alloc_bulk(gfp, max_req, slots); > >@@ -1268,7 +1270,6 @@ static inline void mas_alloc_nodes(struct ma_state *mas, gfp_t gfp) > > > > node->node_count += count; > > allocated += count; > >- node = node->slot[0]; > > requested -= count; > > } > > mas->alloc->total = allocated; > >-- > >2.34.1 > > -- > Wei Yang > Help you, Help me >