From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AA39C25B78 for ; Tue, 4 Jun 2024 20:01:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EAE4A6B0088; Tue, 4 Jun 2024 16:01:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E36FC6B008A; Tue, 4 Jun 2024 16:01:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB09B6B0092; Tue, 4 Jun 2024 16:01:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AD30E6B0088 for ; Tue, 4 Jun 2024 16:01:44 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 57712C0D25 for ; Tue, 4 Jun 2024 20:01:44 +0000 (UTC) X-FDA: 82194276528.13.8566107 Received: from smtp-out.cvt.stuba.sk (smtp-out.cvt.stuba.sk [147.175.1.21]) by imf20.hostedemail.com (Postfix) with ESMTP id 39E401C000B for ; Tue, 4 Jun 2024 20:01:41 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=stuba.sk header.s=20180406 header.b=RoiU1XS6; dmarc=pass (policy=none) header.from=stuba.sk; spf=pass (imf20.hostedemail.com: domain of matus.jokay@stuba.sk designates 147.175.1.21 as permitted sender) smtp.mailfrom=matus.jokay@stuba.sk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717531302; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OzD8eiGhu04GmQy5cDB6iwlOJ1sKBpFqwfQpiANZgQs=; b=QuAopLfIdQqbvpmX4oczytM38+7wM0fbUdyrGdjbe4Sjw4D7yVEnV7Fo7pi+5NZ/GFwhQ5 2fJW7Mnae/21GW7fxiWA+L3L29H7rEAkTsjGNYKvLwLGC2hm3/YgU+loUa1PReBrOd1uEd Cr290qW61OfQ3jQEG6ym1sef2Ii8Hfo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717531302; a=rsa-sha256; cv=none; b=mirILWaJzV4+kp9rXP7vAQGRpmwNjMXh7S2KQVqB6FrWzDxYno4ixJeovx+xaKYaK6BhfU fYAQSQaioE1K7QsofaoLWBXHfYD0v75G3SnmxZ/9lqK7LA1AAZGzaNDrFFwyaxv6LaCrSR weg7qQ+cQVxH8YkGXuMfvKlPIBbIJLU= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=stuba.sk header.s=20180406 header.b=RoiU1XS6; dmarc=pass (policy=none) header.from=stuba.sk; spf=pass (imf20.hostedemail.com: domain of matus.jokay@stuba.sk designates 147.175.1.21 as permitted sender) smtp.mailfrom=matus.jokay@stuba.sk DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stuba.sk; s=20180406; h=Content-Transfer-Encoding:Content-Type:From:To:Subject: MIME-Version:Date:Message-ID; bh=OzD8eiGhu04GmQy5cDB6iwlOJ1sKBpFqwfQpiANZgQs= ; t=1717531302; x=1717963302; b=RoiU1XS6EhzSDf09oyYzywSNGFz8JaMeIms5Ttmc9CrmA K46kprcWX743g67XvJYCRjIurWRbwNnDdr4DOyw1rMHgzeb7gEemvX1+8MZ9ROB2mV797paJsF2xH 0qrNun3ZOEe/rQM6FvNOgUZx0g7z1l1d+MUuKCWRf7lmBamgs2HWibosk3p26gw/hHR16Fd8Vpq0g PzWcKzwh2tUA5zeUSkeukEnt4Kspa6w6AdMIkNVxwflYyVa3en3xGBmnFTXUZbUN12jz2gdNu05hf ntL71IV33u7PpZMpXdtZF1b03JmOI+1T66dEqCkw1/0ThU9PaLO6S/FMiMu7849yUQ==; X-STU-Diag: 9f3e1a9c84f4ccb1 (auth) Received: from ellyah.uim.fei.stuba.sk ([147.175.106.89]) by mx1.stuba.sk (Exim4) with esmtpsa (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (envelope-from ) id 1sEaLi-0000iB-Fy; Tue, 04 Jun 2024 22:01:38 +0200 Message-ID: <6cf37b34-c5e4-4d92-8a60-6c083e109439@stuba.sk> Date: Tue, 4 Jun 2024 22:01:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] fs/exec: Drop task_lock() inside __get_task_comm() To: Yafang Shao , torvalds@linux-foundation.org Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, Alexander Viro , Christian Brauner , Jan Kara , Eric Biederman , Kees Cook References: <20240602023754.25443-1-laoar.shao@gmail.com> <20240602023754.25443-2-laoar.shao@gmail.com> Content-Language: en-US From: Matus Jokay In-Reply-To: <20240602023754.25443-2-laoar.shao@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: xkjumjrhkjkwu66mcfutrk9pihzpco8m X-Rspamd-Queue-Id: 39E401C000B X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1717531301-375839 X-HE-Meta: U2FsdGVkX1/XG/qCURE+i7a+T1rq+kJNZ4p45Fr2NQkvfzBYVZTL3EE14XAkxBV4UmaNqPCv50qotnU7eAJ8bILHvlnGbW3wlk+TXZ5zohZa99MRhk0ZKwN8j9Nb+5g7tEr1MZM8CIn/5VNF6OSqhwUC/9Uek5KDEq4Qh1gdimNtt0saD4weQG6MU9VoYqV4RfoHB4gqsGNmc5MqlT8AqqIJ2hi1ZBHLl3W+N0Ow94u7vWX3evy5tJi8RauOY/6h0C1Febo6JdscbEu+5a6ZJgY/QL//loG2ip5EfbSScvdRaA+wFxl+ENlbvjhfRwDzDCxGAu6KvxatOrPDZSRkz7coP3UB9UeKfwGrUl3ai0T0yow8n0HFPGS8/VV431ZjaGzmAEuMYe1LFPzA3BQG1NR9WEL/qEQrvqpgu761rDst14YMfvUbW+U2LVPcrYZsGXWO4oaTr0s7pLewApFuzlZ0LcU46j7BXRAxOCu097Ky3oaZCT79zQQ3AxZAgAcP7aQdCwrDXKLuGZxHcedSu62TH5ELml/Hvk2Z61lI2vsK98lXLlkGYutQIt0UOuuq1Q7GvrsOhE9NaqnrtiNkCsABKBbq+RbsrgIzoT2Qwt0+2Zp1ohap5ssJRV6TYVkYeOq1mEIIXmlylN0c2V6K3j5PVegCSFEflpMl0cPE0tyXt1WHqvkT+PaLN67gbrVQBAUUrFTnvqCNwvtiDJE6Q99I83A/r8ZOc7bPJSKC1KuSTD2WJ8MIUAmDupp2I1h1DOmybTKzKaSrbRBxHevKlmd+YP2JZM03TTNgRKl5QZMi4VuT457n/mVAH7LDauRT919A/2nd5knlZWPB7BrlKxeVPaHSUhU4jBGwYSD3phJhSQtbIxq0Y7HA6OE+UnxI3csLIIJ1RUEBOwTvoHt08RPrYvFqkui+v2/vxhCoNeE9KsL7ifzygCoxeqbUTD5oKkKOQLiRULDOlluu3we s0Al+o0+ PEaX0aWIqHJaZkesaZu6lTXJR6b0x0xI5EPF7/Qm2LHGon3Gt0HmQVydoBqXYugluTDbngXbxJqX+tDJHMceIoRBZQqIswcP2r4TGs34+7vGrXumBSpz4vIl8/LydJdYfR1wfmzKsNtZIPr1soS/FSh5pik/1h1q7f3qeAUOJ8BECPa/c1Z+j+AYZnYf4Pz0P+Koeflfd6lNpboSGQ2fzy0Oy2na7m+B7Z2O8huKSZ0kvL6QHDWPJS8orUbdZr78BbEVCXMmAb64Dj4ior1Ww4/7O85ww0kEa+BygNGID0MmT7VTLhfaal9o1hYcLjSf2cwF8JFML9fsLolkG5sZN3wmGiA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Sorry guys for the mistake, > diff --git a/include/linux/sched.h b/include/linux/sched.h > index c75fd46506df..56a927393a38 100644 > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -1083,7 +1083,7 @@ struct task_struct { > * > * - normally initialized setup_new_exec() > * - access it with [gs]et_task_comm() > - * - lock it with task_lock() > + * - lock it with task_lock() for writing there should be fixed only the comment about ->comm initialization during exec. diff --git a/include/linux/sched.h b/include/linux/sched.h index c75fd46506df..48aa5c85ed9e 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -1081,9 +1081,9 @@ struct task_struct { /* * executable name, excluding path. * - * - normally initialized setup_new_exec() + * - normally initialized begin_new_exec() * - access it with [gs]et_task_comm() - * - lock it with task_lock() + * - lock it with task_lock() for writing */ char comm[TASK_COMM_LEN]; Again, sorry for the noise. It's a very minor fix, but maybe even a small fix to the documentation can help increase the readability of the code. -- Thanks mY