From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D222DC54E60 for ; Thu, 14 Mar 2024 16:19:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63EB5800BF; Thu, 14 Mar 2024 12:19:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EE6B800B4; Thu, 14 Mar 2024 12:19:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48E81800BF; Thu, 14 Mar 2024 12:19:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 39F04800B4 for ; Thu, 14 Mar 2024 12:19:22 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E5003121517 for ; Thu, 14 Mar 2024 16:19:21 +0000 (UTC) X-FDA: 81896154522.26.D8FE72A Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by imf02.hostedemail.com (Postfix) with ESMTP id CD3B08000F for ; Thu, 14 Mar 2024 16:19:18 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="aJ/jD+fd"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf02.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.14 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710433159; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z+cfjXv27WngzqIVIGxPjPnXPMw27WIzcMcbWECaD/A=; b=pTZIqO+MMlwC1IaRGb42nDJZBZX01VCpZUlsTnHLreKWcxY2sQN6VnOQXBctVc7mWeP9G8 Hj/mtE3dQcpGPXhkMMvQMTgf/F5b0BQapv5Tg0YuK0Aons7aIkIQmj62xEonSCC9hl+PFT SrqLm0Q3QUr4eIeZyjis9x/WRb1xhr0= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="aJ/jD+fd"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf02.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.14 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710433159; a=rsa-sha256; cv=none; b=tYOcD49GYo7OW/MgqwitWP4PL+VO1i6bAHxNya+ohXkLVOIGon61Uj+XiB5nAzlcOtjEH5 jwsiQAkDQ+e6l/7EMoqcUYEDWYRVEATPf37pF+yC+5II3Wx6kYBbxe1jgnNhC0cPkT8LC2 gMBKNIYsErdSKUh985vvPeCDYcfXtyk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710433159; x=1741969159; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=s99HHxZBXzZk9cxzGguqQQ4N8Es8DeZ5bwewpR7hcH8=; b=aJ/jD+fdnDJ9i50XhTMrCs4lfrkheyKGcC83XDX2/KeTR1Y7XBImkaFf 8KZgQhgy4CjRfLwuZm++AtigVX3YmT26rH/oa8G6f83iuUjZox3o5I7qs tpdrM1ANTapYwS6V6Y+QyUUOrW1EwG+ogesz50Nte45/+U2BpVJ8xrZGZ NyrJToT5tIwtF3v9XX3MgWU4HzJYq4/3g2L/KemcSQAaWiG0JjFUaagwh 8/iFwPKM0qAERxGatTk6Bog7psbMRFebcDiO6Rk2Rdd0zD4Vuv78mx273 W1xBPvNHFSILcrDuCeddEeqkJEFriqK5KUa0y8Vjwjyj6BdoQK6CuGUDE g==; X-IronPort-AV: E=McAfee;i="6600,9927,11013"; a="5464821" X-IronPort-AV: E=Sophos;i="6.07,125,1708416000"; d="scan'208";a="5464821" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2024 09:19:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,125,1708416000"; d="scan'208";a="16938306" Received: from laallen-mobl.amr.corp.intel.com (HELO [10.209.21.198]) ([10.209.21.198]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2024 09:19:13 -0700 Message-ID: <6ce6aa20-25d2-4784-823f-2a18f592e002@intel.com> Date: Thu, 14 Mar 2024 09:19:15 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] x86/elf: Add a new .note section containing Xfeatures information to x86 core files Content-Language: en-US To: Borislav Petkov Cc: Vignesh Balasubramanian , linux-kernel@vger.kernel.org, linux-toolchains@vger.kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, aneesh.kumar@kernel.org, naveen.n.rao@linux.ibm.com, ebiederm@xmission.com, keescook@chromium.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, bpetkov@amd.com, jinisusan.george@amd.com, matz@suse.de, binutils@sourceware.org, jhb@freebsd.org, felix.willgerodt@intel.com References: <20240314112359.50713-1-vigbalas@amd.com> <20240314112359.50713-2-vigbalas@amd.com> <20240314160824.GDZfMg-J1VOyjxIMiV@fat_crate.local> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240314160824.GDZfMg-J1VOyjxIMiV@fat_crate.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CD3B08000F X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 4iwf9kjubqte74ugy1abjedceoaus5fo X-HE-Tag: 1710433158-967192 X-HE-Meta: U2FsdGVkX1/nnWs+roengpMr7Rz7y84Rjms7ijqQpTDM7vjWQcKV8+XDJAz/z8g4w3hNUSBNvCjVoW2PJ1o9ahjjVuj9Xff2eZBTeIVODycoWqDTphxNSKvc9+M/vRR/UYZ7Nl1VcNwD9htRc3ZG+TOU68k6kvxpJpeGZzxOo+eOWlGVRjXxt1o44cdxe9HviyfT3ZOAc/dmx/AyVRGwTKLrMTcI8c4Cbo8KQ7kouDlHeRIvjemQBZ3Uy88zuzNwbMpDOiGObkbdiWzUP5Hsks+jDAYV6HXv+PeIXj/Alel9oTatAoWT/sdfqUh0qLuvNhUqmmAYj+V7m+TdYKCDDDY+qQwr8p4S6HXU/ABF+xB2aQLM7qpmqjCsOLdoW5lA/R5Gupz8mNxFf0Tj4ubdwCN+Z6LCizC4flGpJARckom0h9CuiPUurRY86Vg6LV+RmuqD7KCjeD8QkLnrC3/6DDCSevTM6BsCzjTDCu3LccBpQfHwdOPIOK8/LOEFrraGL14suG4YfRAAQ1wjZ/BA6pz32P+xxneSN0xCw4cqhAIFUmRIWHjgoETufEsg1J5UHHMaPj0HbVSARAPxmo2TbB3spmD13jxkrdbTQ58xwgMap9PaGubrYH00ucIM5Wut64Q8gNWgM7dROUJyjKQYJqza8Us1Ted3QyXHviBxWX0/1aA5NTHMjJ+8sBFNF6PpHKqG2ufQYebkCjhnS69kzEkBMxeWJTcUByg/1Px9O5suWC2oeAL6MDS6mDwFJGUHIiuvvoNGC06UFPsxlROAHkLw4C0hoEmeheZ3SlmXpSp0tCQmdLWuoT2ezIfvZ1sLryEVs3PIzwp3yljd+nNAs/8GISid8rHjUP0HuCoxJBPxsn+qyFppLLSjr+TCbkGkhK5ZVlZQNT5VppqPpWiXVG+hx/lU6mHp8svm1Jm9OqFqoBO7z9U8jjj89MIYWYgFPyxD2SzyFsywK3XFg8m Y/juGykQ YZRAwUlqY980PRYwzfFiPsqKUE2fGFiEekGVbDD7D2o24+ic5ITRNuJozXbuj3w1lsWGcP60Falx7EQ7Wk/uqvv4iFTU7XDnBf+kncZH6K4PRjsdtxipGCwrJeoTp5GfyxpESmo+JkvEo+4o1CtdoqcpLjKu6TpUXTs9yyGJvVbuLwu420FePRQ72RYEPAq0W83+k1o3+eacpFDqO+ctmZz+vNw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/14/24 09:08, Borislav Petkov wrote: > On Thu, Mar 14, 2024 at 08:37:09AM -0700, Dave Hansen wrote: >> This is pretty close to just a raw dump of the XSAVE CPUID leaves. >> Rather than come up with an XSAVE-specific ABI that depends on CPUID >> *ANYWAY* (because it dumps the "flags" register aka. ECX), maybe we >> should just bite the bullet and dump out (some of) the raw CPUID space. > > Funny you should say that. This was what they had done originally but if > you dump CPUID and you want to add another component in the future which > is *not* described by CPUID, your scheme breaks. Are you envisioning an *XSAVE* state component that's not described by CPUID? Or some _other_ (non-XSAVE) component in a core dump that isn't described by CPUID? > So the idea is to have a self-describing buffers layout, independent > from any x86-ism. You can extend this in a straight-forward way then > later. That argument breaks down a bit on the flags though: xc.xfeat_flags = xstate_flags[i]; Because it comes _directly_ from CPUID with zero filtering: cpuid_count(XSTATE_CPUID, i, &eax, &ebx, &ecx, &edx); ... xstate_flags[i] = ecx; So this layout is quite dependent on what's in x86's CPUID.