From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 217F5C001DB for ; Mon, 14 Aug 2023 07:20:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C1428D0003; Mon, 14 Aug 2023 03:20:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 74A2E8D0001; Mon, 14 Aug 2023 03:20:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C4AD8D0003; Mon, 14 Aug 2023 03:20:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 449DC8D0001 for ; Mon, 14 Aug 2023 03:20:20 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 15D4140AF7 for ; Mon, 14 Aug 2023 07:20:20 +0000 (UTC) X-FDA: 81121861800.12.2E20F89 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id B7B9C1A0017 for ; Mon, 14 Aug 2023 07:20:17 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JYYt21Sk; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691997617; a=rsa-sha256; cv=none; b=J6XmdRLjqVwehn52zP0/eBKrdBbrP5UqiWYo4zdFecjE94n6Kejjkt4RoMi6gLMMQPJruW DlFaHXr/wcjJXqWnsEHxt0j9L1NChhkGG0o0gP4ZQaAfiqe+EohKeJnHuV5pRMmlQ12RN6 lpIzYNMP6lZ2Li5spK1SLJfz1jF+h3U= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JYYt21Sk; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691997617; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BKY0cWansTn2sEL2WxZ0Fij0kBQM026mOZKicS65Eq4=; b=cT9zwaFLswlEPkh+LEsSPk3frv4bOABV/F+I+lvJabyiojoK71JrJzjHMy3Ntn0IfpDnrw SeVV0bo+LqC8ny7cTJd12Rl3FOLWWDdei3H9PsAgki4deiHNRNVtmw4MNPpR0G6wFSQUVD 3CiUhAP/BZy6zt5lfruTLud180ERwp4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691997616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BKY0cWansTn2sEL2WxZ0Fij0kBQM026mOZKicS65Eq4=; b=JYYt21SkCFoWmNVj1kWjInmYAIJC3xbR5t82tArdueFfA7/u+3myeebvtG6vl6uq6UrPJm kO8nDRZkH+FFPprYPVW1J46iCT+7I3dMWsQFpyBGO+ft0gDw0BTReAW6FQn61yMYnmNlFF qMWm3xsQam8JYc1t+k19M9R6CzqpmNk= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-22-y48GqYCCMxiTsIeFegC80w-1; Mon, 14 Aug 2023 03:20:15 -0400 X-MC-Unique: y48GqYCCMxiTsIeFegC80w-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2ba1949656bso38819431fa.0 for ; Mon, 14 Aug 2023 00:20:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691997613; x=1692602413; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BKY0cWansTn2sEL2WxZ0Fij0kBQM026mOZKicS65Eq4=; b=QI/KWDk3gBLEDJQ988KiyR1yqaWJuHQMWGOC1CBCP1h5EJ/Kr/Yhv/ffvWirMq299z Odk4qa/dUQ5YBB7jgEqqNTedwusVyfFMRnr8RpaRxzY2vjnpKa+XRA71Vi5NC6rjYD75 QnV6ySITKqB8VrO3uJjyesVJ7FxSXRiFPfxxBZ/oMctK0NRrVk6HLINybcLFAyBOWSnu uLj66s/yFd3sPxY38qQ55+spCKDcucBfTJxuM24rR3LpoM0OJmuwYe49F2WlssHWhu+R 135b/XI2XLZb1ddMep1Zgo1zeCITg0vSgQjYKdAcTbBQd9Tnh6uIIEyzwUaoKrbiNMfo 1JkA== X-Gm-Message-State: AOJu0YwSM9Xwwe8uVYggWGNxwdYtNXZkZGgRaAdaE2Dn99I4Qkbo4Cpa eh6ojoE0IRoPAoIENn///kGana0uLj9Oq4u+AkolvtdzB+lXYpeMLFcM0Var3dXXcLqtHJz0nn5 k4xP19Q3hic8= X-Received: by 2002:a05:6512:3985:b0:4fd:f77d:5051 with SMTP id j5-20020a056512398500b004fdf77d5051mr7102546lfu.26.1691997613538; Mon, 14 Aug 2023 00:20:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFxFH/xSsrS7cCDMRZUmdj0b6BcGtlavDhBDrFjlcKGEEig3zD2C6+9p5Bp+5A4BT4BRvhHWQ== X-Received: by 2002:a05:6512:3985:b0:4fd:f77d:5051 with SMTP id j5-20020a056512398500b004fdf77d5051mr7102519lfu.26.1691997613136; Mon, 14 Aug 2023 00:20:13 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2b:d900:2d94:8433:b532:3418? (p200300d82f2bd9002d948433b5323418.dip0.t-ipconnect.de. [2003:d8:2f2b:d900:2d94:8433:b532:3418]) by smtp.gmail.com with ESMTPSA id n20-20020a7bc5d4000000b003fe2a40d287sm13602203wmk.1.2023.08.14.00.20.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Aug 2023 00:20:12 -0700 (PDT) Message-ID: <6ce08d40-332b-217e-6203-c73dd7203e96@redhat.com> Date: Mon, 14 Aug 2023 09:20:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 2/3] mm/memory_hotplug: split memmap_on_memory requests across memblocks To: "Huang, Ying" , "Verma, Vishal L" Cc: "Jiang, Dave" , "linux-mm@kvack.org" , "osalvador@suse.de" , "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "Williams, Dan J" , "dave.hansen@linux.intel.com" , "Jonathan.Cameron@Huawei.com" , "nvdimm@lists.linux.dev" , "aneesh.kumar@linux.ibm.com" , "jmoyer@redhat.com" , "linux-cxl@vger.kernel.org" , Greg Kroah-Hartman , Mike Rapoport , Bernhard Walle References: <20230720-vv-kmem_memmap-v2-0-88bdaab34993@intel.com> <20230720-vv-kmem_memmap-v2-2-88bdaab34993@intel.com> <87wmyp26sw.fsf@yhuang6-desk2.ccr.corp.intel.com> <87jzty9l6w.fsf@yhuang6-desk2.ccr.corp.intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <87jzty9l6w.fsf@yhuang6-desk2.ccr.corp.intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B7B9C1A0017 X-Stat-Signature: kxc8r6ps3g7i9nnqpnoi9jt7g8mp5447 X-HE-Tag: 1691997617-898660 X-HE-Meta: U2FsdGVkX19i/4RL/tbo/DhDzL1PWtWp8xfskN0uBbAwtDeJR8vnXazwVd7OknHDQCEsK9k4HoFVZqnPVXyZlShJhRaB5engd2mCzcHnqeIjfcm2GbsyrMcKTq3hTuij28TWZnCL2YJLDVIEqvR63lH1SLoYfjvwr4auQlNh843727Wmt3IeUeSEMWNtQzaVg1G+tWjw4K7M4FIjQdwUwqdgx14+Fb6lK9TX5duLGhnhESXDZu0/NPrFKf0tWZgTe+9/pADCEtDGmjsYH082YgaIoDcNIUVePaHZXGqlcXCZlROOhU286faQkMpL+ajPvifF27W/ok1nPk91SdEZohO9C+QwzbMTMsVP78FBJLCTNGCHAK+1YNZ1M9Btf3geLR+gnQxEhidoEYFMCii6WcC2LhtPmvURVbgBZteXsC5j7EoAVGvKxMFxACvOMYRmG7xfYoxvxZE5c3or5vBc0DtHJk77+Mgp9vRhnaQ0pmZ2ECRNL8wkbVPMVTZAfWwlfFQILgwvZzosOEjZQmI4HqbjA4InC00wg8uZHD+O6aZUg8NdrR69+32x6gJSUJIZi1WBcKJMvA/+cGCW1NAXiQT4JzzRbNtR7FUBk/Wvi9vADuHjtHU24xMhSlnjdE8Lziq9uPbi3iI9oJpR9k+LoXuQ7cuda1MecXScvaLIkOS4KWak16FTWfzLwhF3h8RnxOugz6/WNpEuQa149P0W3/M0LVOBLwywt+gNQNF3W1PKMH5cTFckh3XK50Fpo1/hW9amKqGyPMbVuQEMiH6Q+fQ/wp8mJtrQmI4R2wcdxq7W4TTb1n0TDVxIii0x0dCSdEbhhg0N1dzZpzKyj8wATY3ZCT2NwS2TxB3LimY0MMlAX/tpZem6+g+EelXXBvtAE/S5ijuhfYf7OIN7PciYcuiiD1N5b5YDuJ9dKhlYlUJkGKK6tzSpy9l0dVkLZp7erFcKgr9DKOfFrICoaJe UCLeryQd wZtNb+jBIbJjMhbtVRjQ48wK8bLo1qFuEfIF8MkGDS5wTTp7dA+dqfHCe6mu0gXJnV355emZOdtyTjJ/YC2/soKqZ7lpcCWF62mqSPnduKnn+bhKw/LYNEcAoRVLO75Id4TFhlPI+0HkGJRGicmIa5AaEVjIt+Ke97H7RyUeJwCwLID/IYZcvRsE4fjcluDxH+QJDfV/GGbc6zhwctVHwGb0auXwaRVNu7FZmH7uv3sq3+p0v8BDcds4MRTkIgOG3/cPruGKlruaC6V2eOZpJwofbIElfNG+Z7VrrCfFnMkG0/+T2q9a4q7ehEXwBFXFcff6rdyIo8wjdo0uwTSlx527UDiG/JnUfCtmtFRsxw0sIBpXED+Zja4uVhIagXt30i2Gz2fyildpu6268JC5NSwEdcL2GzKocdTcPyD8ER+oyDI3XBxmX/wLmgl0g5Zk06/FsWzniiLkLnjjQrRyAp5NXjCIVOX4NY2ltFFSeUGD/omWWhv1ZB3YAuw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 14.08.23 08:45, Huang, Ying wrote: > "Verma, Vishal L" writes: > >> On Mon, 2023-07-24 at 13:54 +0800, Huang, Ying wrote: >>> Vishal Verma writes: >>> >>>> >>>> @@ -2035,12 +2056,38 @@ void try_offline_node(int nid) >>>> } >>>> EXPORT_SYMBOL(try_offline_node); >>>> >>>> -static int __ref try_remove_memory(u64 start, u64 size) >>>> +static void __ref __try_remove_memory(int nid, u64 start, u64 size, >>>> + struct vmem_altmap *altmap) >>>> { >>>> - struct vmem_altmap mhp_altmap = {}; >>>> - struct vmem_altmap *altmap = NULL; >>>> - unsigned long nr_vmemmap_pages; >>>> - int rc = 0, nid = NUMA_NO_NODE; >>>> + /* remove memmap entry */ >>>> + firmware_map_remove(start, start + size, "System RAM"); >>> >>> If mhp_supports_memmap_on_memory(), we will call >>> firmware_map_add_hotplug() for whole range. But here we may call >>> firmware_map_remove() for part of range. Is it OK? >>> >> >> Good point, this is a discrepancy in the add vs remove path. Can the >> firmware memmap entries be moved up a bit in the add path, and is it >> okay to create these for each memblock? Or should these be for the >> whole range? I'm not familiar with the implications. (I've left it as >> is for v3 for now, but depending on the direction I can update in a >> future rev). > > Cced more firmware map developers and maintainers. > > Per my understanding, we should create one firmware memmap entry for > each memblock. Ideally we should create it for the whole range, ti limit the ranges. But it really only matters for DIMMs; for dax/kmem, we'll not create any firmware entries. -- Cheers, David / dhildenb