From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77BB1C636CC for ; Mon, 20 Feb 2023 12:58:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0481F6B0071; Mon, 20 Feb 2023 07:58:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 022236B0072; Mon, 20 Feb 2023 07:58:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E291D6B0073; Mon, 20 Feb 2023 07:58:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D4C576B0071 for ; Mon, 20 Feb 2023 07:58:46 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A451214020D for ; Mon, 20 Feb 2023 12:58:46 +0000 (UTC) X-FDA: 80487674652.06.784AF37 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 73ED9A0026 for ; Mon, 20 Feb 2023 12:58:44 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="MPpQr/fP"; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676897924; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5AKvjdo8vNmSKS+z7HPo/X/JWX/EOdQCIVgjr3Q6aZc=; b=jQeXwfOeRuOeIgsMS296oj0bTTTTOjvhf/tMCnQBoBst0n7UiefEN9NypYDeaoFC/S/dJr K1OhiONw68U4MjZwpBHpNc0zd7/3Rtc1x9CkXDz04/ASzoj2fhNcubXb6YQWBiDt+CsVgL Z546C4WxJuynmyJRI0CN/NVOk/dN0vQ= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="MPpQr/fP"; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676897924; a=rsa-sha256; cv=none; b=Ox/iTl8ph/SLa9VKqb1Cp7K6yHgW9oPxb94i72jEDmdBYeGylYBZYz0bhGgsGBCit2iFx2 5tQpXnBCH4GNs5eDkmbb6DyhYTHBGjIS/8DpFK3pAnE+q4864La4KPWePoCl+KwPSMiTTa KkmgSl1Ig5Ukk4FT2ZtbXL7c1MAudD8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676897923; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5AKvjdo8vNmSKS+z7HPo/X/JWX/EOdQCIVgjr3Q6aZc=; b=MPpQr/fPELoz3eGJgrQzS337HzUUrUmSJtXHwe0/VI0tHFNqsSA0+2hlELGkZqR7P9JaEa N9JB3jK8D9iycXFr9PUUT+d4xgziSXUKF/73673UHaxBGtH/z1fhNA3L8bKe4ADex9zZF0 EjJWL2QaU5fHMlAT540H5RmbN8Aqo7w= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-19--4OyfVKIPUiGokmlY5OvRw-1; Mon, 20 Feb 2023 07:58:42 -0500 X-MC-Unique: -4OyfVKIPUiGokmlY5OvRw-1 Received: by mail-wm1-f69.google.com with SMTP id e22-20020a05600c219600b003e000facbb1so472479wme.9 for ; Mon, 20 Feb 2023 04:58:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5AKvjdo8vNmSKS+z7HPo/X/JWX/EOdQCIVgjr3Q6aZc=; b=tYTTGNTP1ylldQ3CoCpQrsZ6pNu4KkzqowuloRlxlQrxNZT45RSahUeMRcqlI1xwpw kiKWnWG+632BbR/tyn3vq89NwujQh3batffR8hbuud3+j1rZkorA9PIQUMOUREI+sptu 7TIDeziNQVh+1TmVR13V/TzW+yrACBAyDRvsAD4MnNTa5od+ufOgdr70LD0gIzstk1GM INpQZ5nYVbY5o9Oy28Eu5KixdtIMqc1A1rtRoDquQI1p5Zt2O4sBQSn2hEfG+XzS6efT ajmn6iOrGhqtTvsvzAgOyZlVuJUB1SxL7RnfBMCqEX4s09/i4nYhl8bSUB/tX7PwWv44 Rflw== X-Gm-Message-State: AO0yUKUcr9c+8bN95GkyJ5yjezjD0P/k37F7Xv/r89pGary/JK04IaBS Hb1rkkj6QcOQnmPfdgG8YlgDaDvSXJGxYURPQFtRyNfKK85Ji5HQhZBEvyEAs40k20S+RndsAQO AzBVPkVyaPdI= X-Received: by 2002:a05:6000:1866:b0:2c4:669:fda4 with SMTP id d6-20020a056000186600b002c40669fda4mr629386wri.0.1676897921375; Mon, 20 Feb 2023 04:58:41 -0800 (PST) X-Google-Smtp-Source: AK7set/e+EH7H8iOfIcBc3Hls/umJBU/aGvav4lBivPqpX1AbbE4EERHr1HRg6ifH06VjqfdXoHU7w== X-Received: by 2002:a05:6000:1866:b0:2c4:669:fda4 with SMTP id d6-20020a056000186600b002c40669fda4mr629366wri.0.1676897921034; Mon, 20 Feb 2023 04:58:41 -0800 (PST) Received: from ?IPV6:2003:cb:c705:8300:e519:4218:a8b5:5bec? (p200300cbc7058300e5194218a8b55bec.dip0.t-ipconnect.de. [2003:cb:c705:8300:e519:4218:a8b5:5bec]) by smtp.gmail.com with ESMTPSA id z3-20020adff1c3000000b002c559def236sm76762wro.57.2023.02.20.04.58.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Feb 2023 04:58:40 -0800 (PST) Message-ID: <6ccc8d30-336a-12af-1179-5dc4eca3048d@redhat.com> Date: Mon, 20 Feb 2023 13:58:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v6 22/41] mm/mmap: Add shadow stack pages to memory accounting To: Rick Edgecombe , x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, debug@rivosinc.com Cc: Yu-cheng Yu References: <20230218211433.26859-1-rick.p.edgecombe@intel.com> <20230218211433.26859-23-rick.p.edgecombe@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230218211433.26859-23-rick.p.edgecombe@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 73ED9A0026 X-Stat-Signature: rf5t7ut11mqgek3rdyypioan4umx8fqa X-HE-Tag: 1676897924-212963 X-HE-Meta: U2FsdGVkX19vR+k5q7+9/c2IQ5OmmT2xvyWcTEuWpRcs6bLn9KwL9jvxwwCEWH49sKN6t2eZCaa7aNHUjoBAGOzKsRNuHTR6Bh8vtjgT1tHyy75YnPhIK47zdwUXJpl7ZaAY1Hlp0OQFfo98uIlHUb4wxjszTAzPOWDNgXDu+daczcnp4LJI4GhE3ni/ai2kHb/NsAp7R2hhJc2H7KoIPICYfSZcKawdawnOKqvyfzUc04jWP0QktGDpZ504KWFrklsWdVrLlgnFF3vvtMnvR1QJ76Ea90FGswjs75jOOAY/5JG7LjF9JvFUtbfUyN5OOvvIVd+7NzoYXzeZTxCBl7I9Qa7LfPvtd9IBQfZCGDHtfl64jC/SmhoZlQEja9VcIjiYf0y4qH+xZANWKnGZ0aUV3xDirObI0KKirMNKgGQfaFy6ZhOEMxzMwDDRxOf1oaKco2hRPw9iCV+l7/7xQg2Ak6xDqJogLDNLaqcLOYPetkW7tpnstXxY7+1PJWDuYeewPKsWl7gvjF8AL0kXSpKAE1RU6bhU2pxD0bYfRdDXEuT7gS8YKwJkONbFn6saoZMMs3w4AoyXpD4z1enm+rhZ4dkBQzfDRW3fU4nS4qxQzDlCVHgZ8hA3Y7IJ/Ul/AsWVu8UTHucPEdCWIFhDfPt2sM4I8MvvFbi/vfSrj8PGQ3d9kr9HIniXHYec9egpuTG6KLLlRpFev7eL6voEBfbfTdc7U6BYBJqFwd3lUVlUvbDRcrbVJsmDAfXZqhiXJh8YTD88apLd1pEWkuSKDmIRk9Jd9oE6zjzS2dPG68dPTYTS5+AeHrvjVbjE7QWneagz7gfhjROgyrnFmBEzHmAb2rXIIaP2F1NIJCUrLiOajrO40WulJc+TbXcE8cToRjdMuYBM2rd0ZYKHf3rLqBbp0QQXPmcl494KdmZKbl3o4dyWT2Zk9mZvGzg9VpJBtLnMhhEvCkdkGbY4Ip2 RgnHK7AE 0UCZkPcN+vkQKCHBf1LWeJbjdul7Vpe4eiTqUqp8tsbuJ01q+BPscmufjSX9prSI244bTeKT5ODVyVd/5zFs61NAfOYNQRJrDFJL962VYQrh+3coB1MTY4XSFg8MqRsl4M9Xo4RtBf6hou3JLrH/wn7xVEaTloQii++s6+Oh2uDZGPDwn8oiBw53lNAdeHFRBPnG4IpPzu6ptRK3DM6up5o76s86bpxZo2bWryXdBYvv6+o9dJb4OoM/uTHCmssjrCUUZGWxHguVCbAl1eQwVAO9dhcA47six87RwKHLEAluAtIMEyX6kMnMZQ3GK94KkE6dMscOL2GCMrN07ourwMO0cF9WnVHMS0hVLUCwly2Jm+chUXY7x9ttFnCXrWbaRfSGtxj3wKxDJFHch/NlJ1cPvuNvs9nSZW6ysx5GpXhxtAMtn7FnWA/ZByAeW1RENfvOFM+iZVRQzHqxShThxvsXmEAp0fE4wfAFh/8tIYY2q0fmuGm1gB3tOp5T0QKDO7+xHsjOz3qrGFM9zdNRZowYhL4KNBXY4uQbDMsLjGRTUBObF9NZ1xPBJmJojhGqW9ttZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 18.02.23 22:14, Rick Edgecombe wrote: > From: Yu-cheng Yu > > The x86 Control-flow Enforcement Technology (CET) feature includes a new > type of memory called shadow stack. This shadow stack memory has some > unusual properties, which requires some core mm changes to function > properly. > > Account shadow stack pages to stack memory. > > Reviewed-by: Kees Cook > Tested-by: Pengfei Xu > Tested-by: John Allen > Signed-off-by: Yu-cheng Yu > Co-developed-by: Rick Edgecombe > Signed-off-by: Rick Edgecombe > Cc: Kees Cook > > --- > v3: > - Remove unneeded VM_SHADOW_STACK check in accountable_mapping() > (Kirill) > > v2: > - Remove is_shadow_stack_mapping() and just change it to directly bitwise > and VM_SHADOW_STACK. > > Yu-cheng v26: > - Remove redundant #ifdef CONFIG_MMU. > > Yu-cheng v25: > - Remove #ifdef CONFIG_ARCH_HAS_SHADOW_STACK for is_shadow_stack_mapping(). > --- > mm/mmap.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/mmap.c b/mm/mmap.c > index 425a9349e610..9f85596cce31 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -3290,6 +3290,8 @@ void vm_stat_account(struct mm_struct *mm, vm_flags_t flags, long npages) > mm->exec_vm += npages; > else if (is_stack_mapping(flags)) > mm->stack_vm += npages; > + else if (flags & VM_SHADOW_STACK) > + mm->stack_vm += npages; Why not modify is_stack_mapping() ? -- Thanks, David / dhildenb