From: Dave Hansen <dave.hansen@intel.com>
To: Baoquan He <bhe@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
pagupta@redhat.com, linux-mm@kvack.org,
kirill.shutemov@linux.intel.com
Subject: Re: [PATCH v4 3/4] mm/sparse: Add a new parameter 'data_unit_size' for alloc_usemap_and_memmap
Date: Fri, 8 Jun 2018 09:13:54 -0700 [thread overview]
Message-ID: <6cb5f16f-68a6-84af-c7e6-1a563133fac8@intel.com> (raw)
In-Reply-To: <20180608151748.GE16231@MiWiFi-R3L-srv>
On 06/08/2018 08:17 AM, Baoquan He wrote:
>
> Then inside alloc_usemap_and_memmap(), For each node, we get how many
> present sections on this node, call hook alloc_func(). Then we update
> the pointer to point at a new position of usemap_map[] or map_map[].
I think this is the key.
alloc_usemap_and_memmap() is passed in a "void *" that it needs to
update as things get consumed. But, it knows only the quantity of
objects consumed and not the type. This effectively tells it enough
about the type to let it update the pointer as objects are consumed.
Right?
Can we get that in the changelog?
next prev parent reply other threads:[~2018-06-08 16:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 10:15 [PATCH v4 0/4] mm/sparse: Optimize memmap allocation during sparse_init() Baoquan He
2018-05-21 10:15 ` [PATCH v4 1/4] mm/sparse: Add a static variable nr_present_sections Baoquan He
2018-06-07 22:46 ` Dave Hansen
2018-05-21 10:15 ` [PATCH v4 2/4] mm/sparsemem: Defer the ms->section_mem_map clearing Baoquan He
2018-06-07 22:47 ` Dave Hansen
2018-05-21 10:15 ` [PATCH v4 3/4] mm/sparse: Add a new parameter 'data_unit_size' for alloc_usemap_and_memmap Baoquan He
2018-06-07 22:48 ` Dave Hansen
2018-06-08 6:27 ` Baoquan He
2018-06-08 14:20 ` Dave Hansen
2018-06-08 15:17 ` Baoquan He
2018-06-08 16:13 ` Dave Hansen [this message]
2018-06-10 23:32 ` Baoquan He
2018-05-21 10:15 ` [PATCH v4 4/4] mm/sparse: Optimize memmap allocation during sparse_init() Baoquan He
2018-06-07 22:46 ` Dave Hansen
2018-06-08 7:28 ` Baoquan He
2018-06-08 7:41 ` Baoquan He
2018-06-07 22:17 ` [PATCH v4 0/4] " Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cb5f16f-68a6-84af-c7e6-1a563133fac8@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pagupta@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox