From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45BF0C5B549 for ; Fri, 30 May 2025 09:17:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8A296B0085; Fri, 30 May 2025 05:17:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3BC56B0089; Fri, 30 May 2025 05:17:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C29DD6B008A; Fri, 30 May 2025 05:17:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A29C06B0085 for ; Fri, 30 May 2025 05:17:00 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4575E1C9BFF for ; Fri, 30 May 2025 09:17:00 +0000 (UTC) X-FDA: 83499019800.21.313B09B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id CD74C80005 for ; Fri, 30 May 2025 09:16:57 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZVBT9cRu; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748596617; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9y9kTb+lqmmaSukGtEqz0HE9z0BD3W51Gpy3XyW7nPI=; b=8YzVqEZ7zMy232eZKNcdrF2iol+lPlS/8a9w5z6BPClGRSJJ+vgYyQnZNdUV2zaOI0Xklv Gx79Yjet5vH9VdLI2WUf5r/gJFu61Plui/E7CfVJwslsNP/CfrK4hzMTacuToiwGIxduQU fsTpbwcKg7FtDOh8gQJE3YV7t9TzLuk= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZVBT9cRu; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748596617; a=rsa-sha256; cv=none; b=QpzQrbLhZuANnbQrTRcYk/oNj/hM665HEvnJlmiXX88syLl00tv8dVPpr0kk6uVTKddg2R 5adBFjb2ttu873Ag8By6JS86cGFLnRyr+4qijJNqb//yutlY0lROXbcqI2B0ip6rr4U0mR PcZLJTsgjIAmRQOhw6Esf6vYGzeTlsY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748596617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9y9kTb+lqmmaSukGtEqz0HE9z0BD3W51Gpy3XyW7nPI=; b=ZVBT9cRuln+8PoKhISJ63JzBFRobxVNxZ4q6o/Iy+ANHfBUY2tdAVVh2cLK3rJz/WvID7o 0573EfRTuy8qI1Fj3Ta3QlDqj2zZc8ObWTk8zkDdY2SkjN8sapKXEkfMhpN215M/OOjzRC khUqi4qPfMiLQ9xSSnT6eI5U7S/czX0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-148-tNgl_r-aPWag5JEvgG5sKA-1; Fri, 30 May 2025 05:16:54 -0400 X-MC-Unique: tNgl_r-aPWag5JEvgG5sKA-1 X-Mimecast-MFC-AGG-ID: tNgl_r-aPWag5JEvgG5sKA_1748596613 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-450d9f96f61so2908915e9.1 for ; Fri, 30 May 2025 02:16:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748596613; x=1749201413; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=9y9kTb+lqmmaSukGtEqz0HE9z0BD3W51Gpy3XyW7nPI=; b=Mck7X6c69F5jKIsEAgvIVqnZkOOcqpZmXk+xiqoGCA/nQVnTXe1TNIdejWnxwZHvBR 6kmWNWPwZQ8jZxNlAeYPuuDANI+TlMrUgR48aTahDzSh7MsbyizY6tSMVaqFeFrt/S9I TfCFn4j/v+PooFvKHYrsVA4d0RC/uAVXMfzer2KxbNRPCnnVF0QTZSzRffZ5G1jKW6pq z/9S7V+4ib2BDFizpdweDf394BuyAZjgS58jBLnVai3LdZQ0cqlXYqzMpg1sx56nQnZc c0XQcFuopqFasrde1N2ey3gwJZ9z1mQdWouVfwcHx/WuVhJe7Mc/CPEMbE5EXjmVKlnN ruqA== X-Forwarded-Encrypted: i=1; AJvYcCVJ5bv73Oe2xdT2/eYVdIoxfHAJ3XMLQ5WLHLRMU2246bgiDz99SyzZ6ljGlhJjhBSNDtMJ2A6xpg==@kvack.org X-Gm-Message-State: AOJu0Yxc+AjGj+k3TquwwdiTRc+Y1oJ1wcYNcUeHahAvJD6/n7OclCWP THxUnVjvHQ/M9Y6dXkkRORbMn8cvrYRbu02oLMKvpzs4G0XPJRNjOqi5U5gVLmhSh/5MxYQA7GH Beasf2s3PxX6WDpwwqQiWUeQuUEPX5HkF9s2qnoyVj6YznR1bwhQ1 X-Gm-Gg: ASbGncul7IKkFVa7c6yZLS0Uzl4MReBAhPBykSHeXAAlekMUuAjWJRVh+Q4/xr7AjRL BENGWpeoDdULC0W5/slcl2J+ntDsGrYEbQ9zUJx9OmxVx1czNIQiAUCgm7R4gmq+7e8QZUswKQ6 p0TxzOzDoy2rgfQ0zCzo+si40VBR3kYIgtyTyhuYf8RXTxfM2S7PIjEk7aDyDWr8pcg/tTnULNl 2CETsD7nuoJSh+Qx9lzdpkuBpX3dbY1+jVgykiReXUh/MD7O3Rrgi2E2ElySFFw0K6h/OJ3DzoL Ch1YrnXykE9gUWlKUnvvnaCEwKpu4hz1q3BGaHsQsZzh8j6d5U5/4bau/pZt3Mq43Ul2RtEatG/ vvSECkwJyhy240uKl3blAgva9UYzdJcv8HqRsloA= X-Received: by 2002:a05:600c:524a:b0:450:cf01:7310 with SMTP id 5b1f17b1804b1-450d6515d10mr26944955e9.12.1748596612869; Fri, 30 May 2025 02:16:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEBWocUY/6KmmmRLvQVhuH3iQB0i/0E2uSc2uf1qdijy9zo03eEStvS9QwvnvaE6XwuVgirMQ== X-Received: by 2002:a05:600c:524a:b0:450:cf01:7310 with SMTP id 5b1f17b1804b1-450d6515d10mr26944665e9.12.1748596612442; Fri, 30 May 2025 02:16:52 -0700 (PDT) Received: from ?IPV6:2003:d8:2f03:5b00:f549:a879:b2d3:73ee? (p200300d82f035b00f549a879b2d373ee.dip0.t-ipconnect.de. [2003:d8:2f03:5b00:f549:a879:b2d3:73ee]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450d7fb8751sm12473845e9.29.2025.05.30.02.16.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 May 2025 02:16:52 -0700 (PDT) Message-ID: <6caefe0b-c909-4692-a006-7f8b9c0299a6@redhat.com> Date: Fri, 30 May 2025 11:16:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] fix MADV_COLLAPSE issue if THP settings are disabled From: David Hildenbrand To: Ryan Roberts , Baolin Wang , akpm@linux-foundation.org, hughd@google.com Cc: lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, dev.jain@arm.com, ziy@nvidia.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <05d60e72-3113-41f0-b81f-225397f06c81@arm.com> <9b1bac6c-fd9f-4dc1-8c94-c4da0cbb9e7f@arm.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: wU5Ba3sk5tgcl4o0PspsJfIPfLy-32EAXQJluwU4rRk_1748596613 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CD74C80005 X-Stat-Signature: emkfk7g3kt3rzzbjtkgxggss5xq19u8r X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1748596617-692286 X-HE-Meta: U2FsdGVkX1/kpHfpJ6XwbgNAe+nrwAA8CPLkCkdbmdrfN5bkrHViBECf8Tc6+FX6Ar097iViDOpCXpc0btFYlrwZuoSoZyDmlMMEtuO3I1MIVcE5134Y8heLKnxtZHI/ne5xicZtJ2L6MI1HN3Itctge3UI6zhiQhg+zPnSVEf/INeOLL6AbLNiLE//XbQO6u2pjX2Jhk4ZHgqofBaC+DC7FfGivwfO0ZdDcMI4kFplib0OgJ/jpJ/sNQxz7ZmZ2CmNbiKVbIJZYmVDkcj43rXc5+xYTqq70Q6VkbOOcqjkS1mEwnIucNHJCTiQsUaOaCJmbSDix09YQ35GkfvFA/vHv9R5cLvFAEt0VcXUXl7mhLbag+0QraR9Zkzcc4HfS8A+ZMP71J9a6Ftm3gdw+1oiwOyyJYLUABNn2FjH4tGBkyvaLdvyf8Q0i09bMI7t1QJg0ZZnbGBS209PkRsChJmQ4uPOlpfFdgid8wvGqvRMSktzM800OUOPAuPUWYWhEpc+9aGCBBL0ZpK6X/WQ7RYcmzNegcldrZJ2i+fv5AIuFTYzjfgVfLMY4Yi0XDh5oRM0qxYfMvnuO22iA0wJfgX/gUX2yp1NknLvfCx9EdBYa1JYefAFR0n7IZt4WHH3j3QSJAJ33Hi4a97TIeUcOpNf+zhPG3wpojNdRnQooQm+QPtW13O3o5hE8JUVuMOG25+SdpFBG8XI8qOyQlc3AqJV9+BK9BoD0HhOHguSK+K0QrZ8XyyItFgwdthV+HjxSdSLgEyu6xDw5VKDpPGIX24SFDbnFven16p9punxaWJX2lWl/s6lLtzO0+0P/qCwQy7aT0GHS7TADnEkk40hLZ48p8r7JN88OZ+ngpLXWDHPYZKJo7YLRXLUy8ItN7Bp62htnTyyyp0ibMdlkRcvFAMyxTreeLI19it8XfsittMLCyXwb8BtERJVMUBOfZV91TOX0h8hj8Y2VHYEFXWK fLBMrjao ywQdIrcFJosQlpYjZRSvwxRjHnClcP49qq1FOSI6ej+g9cZM5Mh1AENXX6OujGleKbjV1jaEyJWwYQw6bL7B3tO6gmPBnsD7RrcJaacTJJcER+kisIak+Sw7U6rlCPH0l8z2EtUI3pIsvLSkg59bJPwBEvL/8BjEc8iLqF0vgjWypD17LAjEvcn8tufyvttd2BfnAq+45IoJGWFuPpvCNu+lRcfk+ug2Jc4r19vOUj5h2xm2NUmTACEXvgwc/RoadMYnJ896ngDlHhQ9gAFPK2wXk/wjm+mp81mKhYjtmw7xlW0QSuq6oACNiTKSkZZ6SY4lQHmIwMXR7o76gYsY4s3RqrXSebSOWExN/5qscLzJWRLSuVvKr2sexX7e6r/110bpMndVF/uL++9wAoaMdxEQk8TBzuv+SC/jpdqjgYl7gG6sjegGVizH2Fry7bUt7gC/vTKB16q2U8aI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.05.25 11:10, David Hildenbrand wrote: > On 30.05.25 10:59, Ryan Roberts wrote: >> On 30/05/2025 09:44, David Hildenbrand wrote: >>> On 30.05.25 10:04, Ryan Roberts wrote: >>>> On 29/05/2025 09:23, Baolin Wang wrote: >>>>> As we discussed in the previous thread [1], the MADV_COLLAPSE will ignore >>>>> the system-wide anon/shmem THP sysfs settings, which means that even though >>>>> we have disabled the anon/shmem THP configuration, MADV_COLLAPSE will still >>>>> attempt to collapse into a anon/shmem THP. This violates the rule we have >>>>> agreed upon: never means never. This patch set will address this issue. >>>> >>>> This is a drive-by comment from me without having the previous context, but... >>>> >>>> Surely MADV_COLLAPSE *should* ignore the THP sysfs settings? It's a deliberate >>>> user-initiated, synchonous request to use huge pages for a range of memory. >>>> There is nothing *transparent* about it, it just happens to be implemented using >>>> the same logic that THP uses. >>>> >>>> I always thought this was a deliberate design decision. >>> >>> If the admin said "never", then why should a user be able to overwrite that? >> >> Well my interpretation would be that the admin is saying never *transparently* >> give anyone any hugepages; on balance it does more harm than good for my >> workloads. The toggle is called transparent_hugepage/enabled, after all. > > I'd say it's "enabling transparent huge pages" not "transparently > enabling huge pages". After all, these things are ... transparent huge > pages. > > But yeah, it's confusing. > >> >> Whereas MADV_COLLAPSE is deliberately applied to a specific region at an >> opportune moment in time, presumably because the user knows that the region >> *will* benefit and because that point in the execution is not sensitive to latency. > > Not sure if MADV_HUGEPAGE is really *that* different. > >> >> I see them as logically separate. >> >>> >>> The design decision I recall is that if VM_NOHUGEPAGE is set, we'll ignore that. >>> Because that was set by the app itself (MADV_NOHUEPAGE). >> >> Hmm, ok. My instinct would have been the opposite; MADV_NOHUGEPAGE means "I >> don't want the risk of latency spikes and memory bloat that THP can cause". Not >> "ignore my explicit requests to MADV_COLLAPSE". >> >> But if that descision was already taken and that's the current behavior then I >> agree we have an inconsistency with respect to the sysfs control. >> >> Perhaps we should be guided by real world usage - AIUI there is a cloud that >> disables THP at system level today (Google?). > The use case I am aware of for disabling it for debugging purposes. > Saved us quite some headake in the past at customer sites for > troubleshooting + workarounds ... > > > Let's take a look at the man page: > > MADV_COLLAPSE is independent of any sysfs (see sysfs(5)) setting > under /sys/kernel/mm/transparent_hugepage, both in terms of determining > THP eligibility, and allocation semantics. > > I recall we discussed that it should ignore the max_ptes_none/swap/shared. > > But "any" setting would include "enable" ... It kind-of contradicts the linked Documentation/admin-guide/mm/transhuge.rst, where we have this *beautiful* comment "Transparent Hugepage Support for anonymous memory can be entirely disable (mostly for debugging purposes". I mean, "entirely" is also pretty clear to me. I would assume that the man page of MADV_COLLAPSE should have talked about ignoring *khugepaged* toggles (max_ptes_none ...), at least that's what I recall from the discussions back then. -- Cheers, David / dhildenb