From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B9FDC46CD2 for ; Wed, 24 Jan 2024 12:03:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 052486B0089; Wed, 24 Jan 2024 07:03:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 002B36B008A; Wed, 24 Jan 2024 07:03:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E10F66B008C; Wed, 24 Jan 2024 07:03:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D30206B0089 for ; Wed, 24 Jan 2024 07:03:03 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 94B84C0CA3 for ; Wed, 24 Jan 2024 12:03:03 +0000 (UTC) X-FDA: 81714068646.05.43BB742 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf22.hostedemail.com (Postfix) with ESMTP id 9A6B6C0026 for ; Wed, 24 Jan 2024 12:03:00 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf22.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706097780; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=elFA7NL4UjMstRrip52mS1TF1IeOoIkRthQkg2HPkiU=; b=UQhuGIMIDmncFALWPf8f79AgcJPbUK+hkE7tJhAQdXqfQW2l1dnjXMDGAknZYQADNIK3BZ XUuux+gvecaArMec/oPW/3ZzMFFMaFPBKrWW50IfMjdD4mTZ/aOnr2vclHLKjS1DN/VIVE 98TuYvimGfPmKnB9Ez/ZF79Sa7SxJJU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf22.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706097780; a=rsa-sha256; cv=none; b=tZ5PgSnV8MmQhf6Cj9qEz/8p4yoCI5Hs20dX+iBEDav2km60En9pUrqbYW8Vi6n+W2krtT H05kEm3cF4vQE4q0FgSZeueEEfrcd7estQFrdhZxfroI0lRRqvEULeYJagpGFWczYbLmBx Pyxrn/aZE9UtQ284g+oNocMGhanJgpM= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 66C231FB; Wed, 24 Jan 2024 04:03:44 -0800 (PST) Received: from [10.57.77.165] (unknown [10.57.77.165]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4C88E3F5A1; Wed, 24 Jan 2024 04:02:55 -0800 (PST) Message-ID: <6caaced7-a9d7-4fe4-823a-11b96be83e46@arm.com> Date: Wed, 24 Jan 2024 12:02:53 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 02/10] mm: Non-pmd-mappable, large folios for folio_add_new_anon_rmap() Content-Language: en-GB To: Jiri Olsa , Sven Schnelle Cc: David Hildenbrand , Andrew Morton , Matthew Wilcox , Yin Fengwei , Yu Zhao , Catalin Marinas , Anshuman Khandual , Yang Shi , "Huang, Ying" , Zi Yan , Luis Chamberlain , Itaru Kitayama , "Kirill A. Shutemov" , John Hubbard , David Rientjes , Vlastimil Babka , Hugh Dickins , Kefeng Wang , Barry Song <21cnbao@gmail.com>, Alistair Popple , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Barry Song , linux-s390@vger.kernel.org References: <20231207161211.2374093-1-ryan.roberts@arm.com> <20231207161211.2374093-3-ryan.roberts@arm.com> <41dc7dff-1ea8-4894-a487-88d46ec2b2d8@redhat.com> <1188e67e-5c04-4bb5-b242-78d92c3fc85c@arm.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9A6B6C0026 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: khobphoikt6jbehiamk6r3mefhigybs1 X-HE-Tag: 1706097780-441462 X-HE-Meta: U2FsdGVkX1+z6CAZEV7ZFQSRexbq7Glo8OmdSf1ruyxDXaowVYzp/zgA4rR+zDbBOVGLmhoCF0xEs3Xn70gZXh5xIsVMI5jvNcKWkOQN32+6qmVjbjKp1vhEdVDlVAdJfUWEpvignrPJ5+lHwvLyqeyz17Cc0CJNkenFpXCRVqE4mqlrMpcyabH3vIbQLXZ+Pc/tJDuPLkgAZtNjdiHqmy50RvNu6yCv5I/omp2m4cZ21na5SNtY/VOIH39d9mHh1kBP8U9lZDFQIXF2pbZFMDktpq/dmh1ufRhwGcdXygtuBBSkHH9H6bGXegSh3Sunl+wGVddHIA3nOCW5iaIIf5phUP0iltfJQ7kGEHUzuGTmQYN3Nb26JxzITVO8Bw1aEbdgrFndpa27mQ0DdrTwEQSilMs2awCCMOmK/SIrfiW2Giwmnmdk6NJNgxOgB9HHpcTbJD9irMDbrqsrpQ43aYuicx664FgFxeSsL+RMgceNr4F7T2g4vwn9p3Fu7cbdsCKmlSqI4ZZvWsBj0jseRM5OZTAjaoemPD7/oFRMzt2nsrIUcveVUNVPYkIhAWeFXhtB2p2aKR054XpH8IB/mDGSAX4K38VKfklAAT/WphrHhQMmWXajT6GXhrLxm1LOtu2JgzfxlSBnHhdKYv9oERbGPLswg+PWpBv8PGSyHTcENvBd46MrdvI32pUfyVO/mYk4I3A0MLSBw3ZO6xUXrblxSuMWSL5bpiQSz9iYVDeAqHIM0/MOReEij3Jg/yo7UTFh4hOvNhlkSvSp+THDBdjH9g600bhUDRySd5dz9N76RZTPthU2EZcO80wqJBjoRmMtH1zPVK8X24QgLcZBuFhBtCTMUvL4bIydxBzTDDGj5Eh9ukgdTZmBiEqLSzHcZlwoChc4wpxWvUTyarsySjey3PFzCYfYIXswe0o6wPhwlf5zDa2HPw8++b0dRhOznUxo28QcAuZltnLjPWt KK+EvOGk WvNEQ1wnulpFpZZNgFePYK6Q0Yn5gCMxlqQAESOIcbOg7X3tmxrHqbFsNQ6m05zugOMoz8HanMeRTO/r7kcdKWjgD+b8tQGdAbs7rjhi07SyRnC5NT0LO2ruyzBQm74G8lE61KoZzVWtweRSiUfaQqbDNJq433KJZtb1Jf92Krc1zBTA+4TXqkVCt8cskH4I/37VA2gz8bY92QEcqH7owT4CW44qhvDkaWi2ajm7Xn4SmDKp3S15E7/Cpdgl4TcydlSbYCRBYafmWIa1UtaduqnBV/ruZZnyLBOnNIeIkACG1BE60mDSHdlXF9rJDMdiGLgxGbcnYeQ0OSOFaCYov4brljDNUQB4N0NGyOEnKQrViBjR+qPO2fq7wCgVCEaYWgNIzbQQ8aGqZXHA4njBanwqC2DbOblFs/cUJMUwlqA1wrL4yIs9MG9SSjMcaw2QlZ8Jf07y3qPCfRGomf50oaJ+uEYispJDJ5osDCTi/yJZ0MsKIFLNyBeFq33u9YDl2MxsxLHTNL0/0qslPLZKxKjDeSWi/wR75biV+mzegGQWEunGxlNPgZiAn+Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24/01/2024 11:19, Jiri Olsa wrote: > On Wed, Jan 24, 2024 at 12:15:52PM +0100, Sven Schnelle wrote: >> Ryan Roberts writes: >> >>> On 14/01/2024 20:55, Jiri Olsa wrote: >>>> On Sun, Jan 14, 2024 at 06:33:56PM +0100, David Hildenbrand wrote: >>>>> On 13.01.24 23:42, Jiri Olsa wrote: >>>>>> On Thu, Dec 07, 2023 at 04:12:03PM +0000, Ryan Roberts wrote: >>>>>>> In preparation for supporting anonymous multi-size THP, improve >>>>>>> folio_add_new_anon_rmap() to allow a non-pmd-mappable, large folio to be >>>>>>> passed to it. In this case, all contained pages are accounted using the >>>>>>> order-0 folio (or base page) scheme. >>>>>>> >>>>>>> Reviewed-by: Yu Zhao >>>>>>> Reviewed-by: Yin Fengwei >>>>>>> Reviewed-by: David Hildenbrand >>>>>>> Reviewed-by: Barry Song >>>>>>> Tested-by: Kefeng Wang >>>>>>> Tested-by: John Hubbard >>>>>>> Signed-off-by: Ryan Roberts >>>>>>> --- >>>>>>> mm/rmap.c | 28 ++++++++++++++++++++-------- >>>>>>> 1 file changed, 20 insertions(+), 8 deletions(-) >>>>>>> >>>>>>> diff --git a/mm/rmap.c b/mm/rmap.c >>>>>>> index 2a1e45e6419f..846fc79f3ca9 100644 >>>>>>> --- a/mm/rmap.c >>>>>>> +++ b/mm/rmap.c >>>>>>> @@ -1335,32 +1335,44 @@ void page_add_anon_rmap(struct page *page, struct vm_area_struct *vma, >>>>>>> * This means the inc-and-test can be bypassed. >>>>>>> * The folio does not have to be locked. >>>>>>> * >>>>>>> - * If the folio is large, it is accounted as a THP. As the folio >>>>>>> + * If the folio is pmd-mappable, it is accounted as a THP. As the folio >>>>>>> * is new, it's assumed to be mapped exclusively by a single process. >>>>>>> */ >>>>>>> void folio_add_new_anon_rmap(struct folio *folio, struct vm_area_struct *vma, >>>>>>> unsigned long address) >>>>>>> { >>>>>>> - int nr; >>>>>>> + int nr = folio_nr_pages(folio); >>>>>>> - VM_BUG_ON_VMA(address < vma->vm_start || address >= vma->vm_end, vma); >>>>>>> + VM_BUG_ON_VMA(address < vma->vm_start || >>>>>>> + address + (nr << PAGE_SHIFT) > vma->vm_end, vma); >>>>>> >>>>>> hi, >>>>>> I'm hitting this bug (console output below) with adding uprobe >>>>>> on simple program like: >>>>>> >>>>>> $ cat up.c >>>>>> int main(void) >>>>>> { >>>>>> return 0; >>>>>> } >>>>>> >>>>>> # bpftrace -e 'uprobe:/home/jolsa/up:_start {}' >>>>>> >>>>>> $ ./up >>>>>> >>>>>> it's on top of current linus tree master: >>>>>> 052d534373b7 Merge tag 'exfat-for-6.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/linkinjeon/exfat >>>>>> >>>>>> before this patch it seems to work, I can send my .config if needed >>> >>> Thanks for the bug report! >> >> I just hit the same bug in our CI, but can't find the fix in -next. Is >> this in the queue somewhere? > > we hit it as well, but I can see the fix in linux-next/master > > 4c137bc28064 uprobes: use pagesize-aligned virtual address when replacing pages Yes that's the one. Just to confirm: you are still hitting the VM_BUG_ON despite having this change in your kernel? Could you please send over the full bug log? > > jirka