From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6B74C369CB for ; Tue, 29 Apr 2025 04:03:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70DF86B000A; Tue, 29 Apr 2025 00:03:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BBC06B000C; Tue, 29 Apr 2025 00:03:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AAC86B000D; Tue, 29 Apr 2025 00:03:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3E5806B000A for ; Tue, 29 Apr 2025 00:03:49 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 48A31B8C9F for ; Tue, 29 Apr 2025 04:03:50 +0000 (UTC) X-FDA: 83385737820.26.B0F96D8 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf01.hostedemail.com (Postfix) with ESMTP id 40C4C4000E for ; Tue, 29 Apr 2025 04:03:48 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf01.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745899428; a=rsa-sha256; cv=none; b=etnUVsYdn16zC+m9+zZZJYnHz7G1Ujy2iHLjLQ1fUfR4XkWZAD7KajJoemTcS83BE/0ck3 QtK5CtkRoZZUv1V1LGRkKWfVk9UQ6TQ2QmdnkDTh5L/Md1b/4FzzaiE3nNBaQ7K29l66kT 0o1UkZtBfalxmgoGFK/6bQoMrBbwcJ4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf01.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745899428; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/iCyKdc8Wsn1gHO/pILxWQAMF04jAEDcGWxYrBPXomQ=; b=GizJ02R/fQBOfV31arHev8jeniwv7MTwxbIPl33YzcAjIaQnfvE+/bNB/7eezf/JPz2daw JT68EYHew4qPgV0ry8UT7h9texKWwUVid87hMc5jVnEUG7fQAwmdaE4vnwBp5EaYL/uN3Q TJyRFq48CjhY1KC9EyoRHpmAjqn860w= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 853E81515; Mon, 28 Apr 2025 21:03:40 -0700 (PDT) Received: from [10.163.52.122] (unknown [10.163.52.122]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A9D3B3F66E; Mon, 28 Apr 2025 21:03:42 -0700 (PDT) Message-ID: <6ca17b28-f779-478d-bea1-0c4739731e20@arm.com> Date: Tue, 29 Apr 2025 09:33:36 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] mm/numa: remove unnecessary local variable in alloc_node_data() To: Ye Liu , akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, rppt@kernel.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, david@redhat.com, harry.yoo@oracle.com, riel@surriel.com, vbabka@suse.cz, liuye@kylinos.cn References: <20250427100442.958352-1-ye.liu@linux.dev> <20250427100442.958352-4-ye.liu@linux.dev> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20250427100442.958352-4-ye.liu@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 40C4C4000E X-Stat-Signature: rw9cn8f9wmdkw811srg85faotgh6bigb X-Rspam-User: X-HE-Tag: 1745899428-865919 X-HE-Meta: U2FsdGVkX19CAbY2axOhFOtBUsxhNDBI3bL3whl+owgEAGDOyudElcWHwYd/vW24yVb7m31taE/DlRBFtWrvcr74MJthhLVbNckcx18Nhb7oT9p/T9v+WPYED/zZQut4E4gdi/c+kMtNT19uHWYbpPMRtPXcxNz55D1B3QJ9Y0vY0AAH3CExPfzEfRC1cubztMUPY0aYYLsF5k/JOQAdOB1C1YREhZqR4xOz7DlnW03YFUENA580vJqj2q6z/UnW0Sh4f5+scskX85gvrZB04iIqAMPgAs2jw05p1I8HZ3GaS/KQz3Q1XYsVK3gJVI61vGqdUgSsSPlx+vvlfj2M+xi9bb4s/k5qZGjsbDyvJ7Q3X0p+vfz8YcKK23ik4YvBsb9YUVvwevOB5n+FxzlOqtyp0UBLZGMtFR7+aszlFsMke7sFyJp5tHIKxyIQvyVO2+2jG3FTye0ytB1MJuzbW4Be4/yNgU+pusAvAYCpP8pkULVGIsMRifR7ioegVenA3iwEQ7VlfNmZn0i72pH7ez/KY87U6jo+qBxWYGUuNoWDtVwdoHZTDUCbJxWkErGsjsJ7E3cxKAbxaR1UJK8C6Y0VNRpDGSz9xZ4VSohZ1NDqqYvUodczVOeVLjnhL6wvBCSVC/ZM+5fGF3jmrAo79qUqdScYIe6mfB3d0lzIc/+0CmJv9fzqQkRqC3/xAsQGs5zGhlbm6z2otl3dxOCkVKuTiVpUNQFF12mTMz96Z3wWJKc4vp2qFzf/Pv8RNqF1/m67KnJ2var88KfuZRdLElS8uosxjE21jMLiu/578H24MF1l0PvV4DbsliJkBng3yq9Ye5Sc0p2QYhJsr+xDdCgTxL62WLD+BP460/5hwS1qwb0rirkkpXY2PAzbQBs5vK9iIyY0mtqSYGtFNfyNUkJQyica90PTE7qAv9Ip4WwAUzhtVe43fcKC1qbc7c0Uezr5KF3pfFGRuXctpTG rBX6Waye Um3pdA946JZ+2gzGO7fSKalWZ0GIILJRVhizkUybw9lkw5TxWna4hLPO6eXb7+tslOqvFkKVyLkkTy/1UygerFyGNuh2FDXBCipTSWNzwtlw/IbBcf4gOnz8GNoeul9Lh6XTJeQtYX3zIhzqB3CZi+2m7s7/1pze+GK54aGbPgtuPieyOhCHrjI2urCQ7+z0mn7YfKPDdEDrWOwR0K1Cly4dac7WZCZBi5BG3b2hP16rHhYs+7w52tmaBAw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/27/25 15:34, Ye Liu wrote: > From: Ye Liu > > The temporary local variable 'nd' is redundant. Directly assign the > virtual address to node_data[nid] to simplify the code. > > No functional change. > > Signed-off-by: Ye Liu > --- > mm/numa.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/numa.c b/mm/numa.c > index f1787d7713a6..7d5e06fe5bd4 100644 > --- a/mm/numa.c > +++ b/mm/numa.c > @@ -13,7 +13,6 @@ void __init alloc_node_data(int nid) > { > const size_t nd_size = roundup(sizeof(pg_data_t), SMP_CACHE_BYTES); > u64 nd_pa; > - void *nd; > int tnid; > > /* Allocate node data. Try node-local memory and then any node. */ > @@ -21,7 +20,6 @@ void __init alloc_node_data(int nid) > if (!nd_pa) > panic("Cannot allocate %zu bytes for node %d data\n", > nd_size, nid); > - nd = __va(nd_pa); > > /* report and initialize */ > pr_info("NODE_DATA(%d) allocated [mem %#010Lx-%#010Lx]\n", nid, > @@ -30,7 +28,7 @@ void __init alloc_node_data(int nid) > if (tnid != nid) > pr_info(" NODE_DATA(%d) on node %d\n", nid, tnid); > > - node_data[nid] = nd; > + node_data[nid] = __va(nd_pa); > memset(NODE_DATA(nid), 0, sizeof(pg_data_t)); > } > Reviewed-by: Anshuman Khandual