From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCF4DC433DB for ; Thu, 25 Mar 2021 18:42:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 47F2861A39 for ; Thu, 25 Mar 2021 18:42:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47F2861A39 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shipmail.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B2D386B006C; Thu, 25 Mar 2021 14:42:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADD206B006E; Thu, 25 Mar 2021 14:42:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9567D6B0070; Thu, 25 Mar 2021 14:42:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0126.hostedemail.com [216.40.44.126]) by kanga.kvack.org (Postfix) with ESMTP id 745836B006C for ; Thu, 25 Mar 2021 14:42:22 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2E7ED181D75CA for ; Thu, 25 Mar 2021 18:42:22 +0000 (UTC) X-FDA: 77959266924.31.AFE96A8 Received: from ste-pvt-msa1.bahnhof.se (ste-pvt-msa1.bahnhof.se [213.80.101.70]) by imf04.hostedemail.com (Postfix) with ESMTP id 7F769138 for ; Thu, 25 Mar 2021 18:42:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ste-pvt-msa1.bahnhof.se (Postfix) with ESMTP id 435E03F3B2; Thu, 25 Mar 2021 19:42:19 +0100 (CET) Authentication-Results: ste-pvt-msa1.bahnhof.se; dkim=pass (1024-bit key; unprotected) header.d=shipmail.org header.i=@shipmail.org header.b=Wj1JOJcd; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at bahnhof.se Received: from ste-pvt-msa1.bahnhof.se ([127.0.0.1]) by localhost (ste-pvt-msa1.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MF524rY7BNQG; Thu, 25 Mar 2021 19:42:18 +0100 (CET) Received: by ste-pvt-msa1.bahnhof.se (Postfix) with ESMTPA id 4DA9D3F27F; Thu, 25 Mar 2021 19:42:17 +0100 (CET) Received: from [10.249.254.165] (unknown [192.198.151.44]) by mail1.shipmail.org (Postfix) with ESMTPSA id E75B436059E; Thu, 25 Mar 2021 19:42:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=shipmail.org; s=mail; t=1616697736; bh=8GFYWnQPYCiN2M+PBNjHsNO3soivwm3ln02svNRajX8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Wj1JOJcdbTP/JTvFBvpvJy9mle9Q6w++mH7KUmgFoeLdDz0gEgltJCQEOYtHkHlQw oGzJznK3W4yJK20Ft0Qqqa2v52HBleZr7q2Ikla8PDvw9pgO/my42DJuvmzxnOVfLq iz7nc9TafMwV7HJONjvuCiUULNZFa0+d3ethgJo8= Subject: Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages To: Jason Gunthorpe Cc: Dave Hansen , "Williams, Dan J" , "dri-devel@lists.freedesktop.org" , "christian.koenig@amd.com" , "airlied@linux.ie" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" References: <75423f64-adef-a2c4-8e7d-2cb814127b18@intel.com> <6b0de827-738d-b3c5-fc79-8ca9047bad35@intel.com> <9f789d64-940f-c728-8d5e-aab74d562fb6@shipmail.org> <20210325175504.GH2356281@nvidia.com> <1ed48d99-1cd9-d87b-41dd-4169afc77f70@shipmail.org> <20210325182442.GI2356281@nvidia.com> From: =?UTF-8?Q?Thomas_Hellstr=c3=b6m_=28Intel=29?= Message-ID: <6c952be3-8be8-c4c9-a1f9-ddec027645bf@shipmail.org> Date: Thu, 25 Mar 2021 19:42:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210325182442.GI2356281@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Stat-Signature: hqopd6g3dwgcmewyc45ie8hpgyoqigeg X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 7F769138 Received-SPF: none (shipmail.org>: No applicable sender policy available) receiver=imf04; identity=mailfrom; envelope-from=""; helo=ste-pvt-msa1.bahnhof.se; client-ip=213.80.101.70 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616697739-251406 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/25/21 7:24 PM, Jason Gunthorpe wrote: > On Thu, Mar 25, 2021 at 07:13:33PM +0100, Thomas Hellstr=C3=B6m (Intel)= wrote: >> On 3/25/21 6:55 PM, Jason Gunthorpe wrote: >>> On Thu, Mar 25, 2021 at 06:51:26PM +0100, Thomas Hellstr=C3=B6m (Inte= l) wrote: >>>> On 3/24/21 9:25 PM, Dave Hansen wrote: >>>>> On 3/24/21 1:22 PM, Thomas Hellstr=C3=B6m (Intel) wrote: >>>>>>> We also have not been careful at *all* about how _PAGE_BIT_SOFTW*= are >>>>>>> used.=C2=A0 It's quite possible we can encode another use even in= the >>>>>>> existing bits. >>>>>>> >>>>>>> Personally, I'd just try: >>>>>>> >>>>>>> #define _PAGE_BIT_SOFTW5=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= 57=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* available for programmer */ >>>>>>> >>>>>> OK, I'll follow your advise here. FWIW I grepped for SW1 and it se= ems >>>>>> used in a selftest, but only for PTEs AFAICT. >>>>>> >>>>>> Oh, and we don't care about 32-bit much anymore? >>>>> On x86, we have 64-bit PTEs when running 32-bit kernels if PAE is >>>>> enabled. IOW, we can handle the majority of 32-bit CPUs out there. >>>>> >>>>> But, yeah, we don't care about 32-bit. :) >>>> Hmm, >>>> >>>> Actually it makes some sense to use SW1, to make it end up in the sa= me dword >>>> as the PSE bit, as from what I can tell, reading of a 64-bit pmd_t o= n 32-bit >>>> PAE is not atomic, so in theory a huge pmd could be modified while r= eading >>>> the pmd_t making the dwords inconsistent.... How does that work with= fast >>>> gup anyway? >>> It loops to get an atomic 64 bit value if the arch can't provide an >>> atomic 64 bit load >> Hmm, ok, I see a READ_ONCE() in gup_pmd_range(), and then the resultin= g pmd >> is dereferenced either in try_grab_compound_head() or __gup_device_hug= e(), >> before the pmd is compared to the value the pointer is currently point= ing >> to. Couldn't those dereferences be on invalid pointers? > Uhhhhh.. That does look questionable, yes. Unless there is some tricky > reason why a 64 bit pmd entry on a 32 bit arch either can't exist or > has a stable upper 32 bits.. > > The pte does it with ptep_get_lockless(), we probably need the same > for the other levels too instead of open coding a READ_ONCE? > > Jason Yes, unless that comment before local_irq_disable() means some magic is=20 done to prevent bad things happening, but I guess if it's needed for=20 ptes, it's probably needed for pmds and puds as well. /Thomas