From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E77AD6911A for ; Thu, 28 Nov 2024 15:49:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B4C6C6B0083; Thu, 28 Nov 2024 10:49:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AFC796B0085; Thu, 28 Nov 2024 10:49:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94E7B6B0088; Thu, 28 Nov 2024 10:49:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 76A816B0083 for ; Thu, 28 Nov 2024 10:49:02 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 02E1112037A for ; Thu, 28 Nov 2024 15:49:01 +0000 (UTC) X-FDA: 82835936778.17.0342BD6 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf24.hostedemail.com (Postfix) with ESMTP id DE123180009 for ; Thu, 28 Nov 2024 15:48:57 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=Mc261XB1; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=tddKK7yQ; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf24.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732808935; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s6Gudigv3w8YLIJnqaWpBInfGBHKCA8YN+0AisqMtvg=; b=duZE+zKePpEgcsPp4Nd26Ld6JHTl4KKt7uunmFt6A38m2Pkn4OVVvVH4AeG7zrPT+Bn+Ro EdRTJXswKe+9JfCeRRXM+uY7xXQFPp1TB1eLc2V7VLvTKJ2vC5y/SLOEO40SHHVVslTLWQ kvqlwokZx5ZyIeQY6B6JaJiSUE0EKao= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1732808935; a=rsa-sha256; cv=pass; b=E3nko1h8Szvx3rMNF+1I0aYtd+I2wjXy+zOdcHUE/fClUs0AlyPSyG7FH17L03QORuWn5K 8BgZ0KSZy/LtcvjLnKTANexetPiEHCBLpfb8T4aUYREgo3Vmn2U31+R5lIzWzhopgrt7fc ab5zWHZ+BPDVxpRlZEW09NQ8UpOMPXQ= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=Mc261XB1; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=tddKK7yQ; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf24.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4ASE6SGS009151; Thu, 28 Nov 2024 15:48:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=s6Gudigv3w8YLIJnqa WpBInfGBHKCA8YN+0AisqMtvg=; b=Mc261XB1kDmP5MOVCJ07dU2NY3+Xdbhu6R WGWlu8NWBQJraFiwbF9ad2PxiBlLiO0622UAoOT8PX7xrz+1xkcQXburyh/8wZK3 4cQ/ifbjRDbdWPR33S08zfvNdUpnaxnxv7KiLYv5Iw9w2pJoEgXzXxaxPcCF/Rgh tu5XgVUekgpNsCya11V3XhDpuX+YF+sgnVDoUi63LBWNIK6q5Nfk224RwTFMD0yZ 2x2DXxvyBnCuuO9Up3G7zhwxYQVj/QZg2lsReIrXCM9Gwaj2/Pn6+aeDutc0FQb5 85ujZ8p+wOw+PGQjDz8GnPWw6mbReHKqWjq3MJBEdY4m4Idv5LvQ== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4366xya19k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 Nov 2024 15:48:55 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 4ASEbt4H018125; Thu, 28 Nov 2024 15:48:55 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2177.outbound.protection.outlook.com [104.47.59.177]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 436705s5jm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 Nov 2024 15:48:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BFEuUG07y4WuzVM94S3+TJh7+8FsL0H0jHIA90izr1STcX7+aKbXTt2BLo8jmLux1e/lhNeuQ23nzl96oZWZGHp4wtGMH2jVfY+mmBrNel3lB4C2dSxPuNIsW9PuJYBwI7KnfoL/tgwObaqMy3bPeGQJXqXfMOyJHwbFNLXhD0PStrKhLXg0h6PHvvWylC5EyfSXmMK36yjeyIKY95Ejv1svAUfgPGbPs5nbwgU+2Wp5vKFNLuprH5pkat66XP2XNZtuDW3o9Y/X5rWFfCV0viKlRNyiEnMhIvyigaRz/dYOdiS8JLMHBXOGm8Sw2lw6GN483G9g508w1M0oXeED4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s6Gudigv3w8YLIJnqaWpBInfGBHKCA8YN+0AisqMtvg=; b=OYeWA4R1Qs5u64AX+U+TKXIacEsIIQr0CxOXHaRLbOiOS+qm8wpJqkQGbvdaZ+60dqiONWxeMqaVJtHnUnReYRsc9emJoMwTBjetCYF4HBAFz04HacIwKmWdni7qsgMKp7TlV2U+s4kt4t1t8hudKI5XxjNBnpIxgq+/LOLvxjZj19qY0xAv9+VA/dgNjCbNPgA8SvecfdzKC6Weg/n5QEFryxoSOxqlNq9DRV1xcndhbSWUqNGPkeofcSu6i8xU1hSU7oKdggXrUlFjUBDM2EtEmNNPkd0sgR87m4DTOhuJh8JXC7JuWIZ1oOFEKEOsCBztDzmEl+b+9jZQ4YfM1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s6Gudigv3w8YLIJnqaWpBInfGBHKCA8YN+0AisqMtvg=; b=tddKK7yQPnfEDmkznS/Rks1f6txiA7jBsr61PBumYwXQEnIgHKHCKiBTvv9OB0P1eAgbYNkN1LAyl6JE26o9EuPYEJIC1MPfGAhBrPDiYZ5KypaIswG0Tp404C+VYW/eV8L2TAvYVDJndl3Zwjb1GhJXNI7kz7Mf5A/PlL79Vq4= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by PH0PR10MB5819.namprd10.prod.outlook.com (2603:10b6:510:141::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8207.13; Thu, 28 Nov 2024 15:48:52 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%7]) with mapi id 15.20.8207.010; Thu, 28 Nov 2024 15:48:51 +0000 Date: Thu, 28 Nov 2024 15:48:48 +0000 From: Lorenzo Stoakes To: Wei Yang Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org Subject: Re: [PATCH] mm/vma: next is already retrieved Message-ID: <6c943018-1b84-4371-8c5e-7c8062af948d@lucifer.local> References: <20241127114302.9650-1-richard.weiyang@gmail.com> <60e4372d-a1ab-4ffc-a778-8de29f53b3d5@lucifer.local> <20241128011059.4pr2mpbzg4cg5mag@master> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241128011059.4pr2mpbzg4cg5mag@master> X-ClientProxiedBy: LO2P265CA0502.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13b::9) To MN2PR10MB3374.namprd10.prod.outlook.com (2603:10b6:208:12b::29) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|PH0PR10MB5819:EE_ X-MS-Office365-Filtering-Correlation-Id: c78dea27-4f4d-45a4-e4c7-08dd0fc4275f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?yxfJcXXMzxCg76qFv4EzKWbqen9eSz5kKOg5+8ZD0H/AcQzdGh5RH41N33oD?= =?us-ascii?Q?GJ4xdkx/z9AW+GRdlSskH3zpn488iZ5e90nQZP56tXwpajtzhZhn34MtQ2BL?= =?us-ascii?Q?zzjgmBGPBawtpQhMsyL74FlhYuR3sXt5QqbkkCkNvEV1Zpf+DLhon33aipEt?= =?us-ascii?Q?Ph0O3EdVuuLjZASBM0rDGMobPeNFLUDtbITzSe+YgQE7mzDoQxn5rGm05udT?= =?us-ascii?Q?9tqWCuJfw1pJPib+G+6mZhO77oMDN5bXAeO4XBpoLNZihHBC1lttoVsOw9rB?= =?us-ascii?Q?oR5bR8JnIRJ0MLc7xh2OWKtK05g5ZwnbCYdq56BTAtoXqekeZPlhPJzay6G6?= =?us-ascii?Q?8Ql0DxXVZJBr/DQqtc06BzKFGa++aMostqz8jq6qR6BOFbhBMdgdsCnq7756?= =?us-ascii?Q?AIiCZ4deAIQPdVLKQkyqy66FmbdypKMC8z2UH+mHNmV1mBI58ax2sz8andU0?= =?us-ascii?Q?6OC2I/PQrddcNj1BXMFY9xTCfbNZYmHfrVtR+tGPoVZF+c0G+hB8r+olWlP8?= =?us-ascii?Q?p3ddPeiCSxyBH+yyoiljzsFy0ewDGcEDKrQ91teqi8p32nDb0QPT+FkXhbWI?= =?us-ascii?Q?neFlyRFUMtrbWyFpWOzLoviUJ12MeO+EbUUieSUh46WG6ET22P5wElbGVWho?= =?us-ascii?Q?nh7C62mnAf84DUb3Uydc+56sff7YDq+puVBoUZDbQK7G8O4EakMr0WwkgWBI?= =?us-ascii?Q?qyvCcvdXFaUre5gxpCMLaTln0S/2cZhsaFhHFiGibEF/E8n9dRKN0ToY0l3J?= =?us-ascii?Q?4jjZjC/uZS5nvVupR0ReJY97XHdpehKlykX5MmPcIQ3MbNaDxYzBTCwc5ZOl?= =?us-ascii?Q?yjESbcECrO7MqNfAvmtNIejJvMP785/D3Ig5xWVDUt830hqxtNOetxRYfwp+?= =?us-ascii?Q?LFSqcYRIvHSEHse+4Os1TxJwLy5N4c9MZ2EGRnDAtZ2DeXaU5on7jTx25Xki?= =?us-ascii?Q?Pg34/Vj9xRSowromm0e7cMfYITZS8EMw+hTkMXeHfNwzuZk/uExuHmPm4KQK?= =?us-ascii?Q?2jVVSKBYbx9LFO0TRRpEO26BfaBj+VYDWFcqE4ufGpOhC4gNflyUrHajOxJN?= =?us-ascii?Q?JrU4B4Wmxf+lWZNx0949Mx8E+5O6A5MudQ++iBKMF9UHXdVSt7f1T4L7VEzV?= =?us-ascii?Q?LRbet3mUMmj5roqJcZ1NOXWNwvc9pKrhRh6HCiLzI2MW/+mghJbo7tZ7t7sv?= =?us-ascii?Q?vokLj/+LqYgHdtAV1EUxR4ZcHp5/URo2a00isCYH2lfo6mZJR8MaOn5FUQ6P?= =?us-ascii?Q?dCUaJgT1KshYK9vtwYUw4/yWcN8Q7AcQy+Fk01uC9k8BbkTH/NVwrmAYGaOo?= =?us-ascii?Q?QaiCDiW/I8sKiuPgBR3gnop+pRERhghKm6xM+aDf3D+NBg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KstMynUZtFakTUTgtVIggfHDmcGCINw7YyRVwwIbjHETYZUjC22CNaDsDE8k?= =?us-ascii?Q?ciGY7tivNZIg5i4QmWze4MW+i3Zzld/eaB2JjYym2u17emD+vIOFrr8w5m7A?= =?us-ascii?Q?486C0UVvWpzEdWGJNdCZoqH92iTud3LlHnLBFBJz+mC67ailJSMviCEy8LeS?= =?us-ascii?Q?u2gvSq70eilV5f2fjsqtZfvTYQp0A23kuorxPAh1wHGW6I7uFgxxmJ2SlAiW?= =?us-ascii?Q?V82f0woeI1gG/wXLwsPNbWertBJzvV2nu6o6Mi+U6ffp5NXde/nhkyy2oSIX?= =?us-ascii?Q?Xi8kuWe88dqI2RWwAjo31qphalzzX6AY0in5nqqOOme9Zb3lHObw3PxupiMb?= =?us-ascii?Q?GDKtA0sKEjFIqd8jCP0+SzAznkwsQ++l5GjiZAFRaxphbQ+tW/L20sduOfS2?= =?us-ascii?Q?fcO2bdPRJkNnV0yQ/xy6kCgwwfQDOJzse27solF800shbidKT6A13n5c0YVn?= =?us-ascii?Q?7LSJ7GplMCL/yg7YFqGPXE735yvn4i8VNAjZvLE6RaPTynyTKJssUee7Apik?= =?us-ascii?Q?h1ESteZuFrjVh7hdBQE9R1GIfloVr7vl3Z0xdZHTKXktqxf5ryPtMEw57o5x?= =?us-ascii?Q?/M1pZXEiiGFBjhUG9+e3kxwi23y7VipO/1nms2zPV8i7M9roH5tHIps7dwN9?= =?us-ascii?Q?R0DdyKMcPRtL44vBXeNPKVzgJ/8N84B1IdOB4OYIlkwDbqI6BIOMtjxWlmcW?= =?us-ascii?Q?jxtn1KCkz+Rz50IpB2PvwjP8lakeFW+J4P/P/K2iyKFjE1uhvWUeTUTOOLoA?= =?us-ascii?Q?+YEhCub9BV0IMUGnvdCiY3vOvvsfj8M9F+AfMWePx6TVxijq25SGe+V7Hltb?= =?us-ascii?Q?Q1aCuBLlcYcFM0gUe8zLZqFdfr7qGB/bhRtsnOzSooSM5z2/nJDazp3d3b0c?= =?us-ascii?Q?Y1Ni83wiaosOABPO7V1ceZRnYXM5J11hbfPCwfUd32v8RqUu3uEGU9GKle1G?= =?us-ascii?Q?NebemkKvvjouH3qcDEM3l9KSBzCh2DjNvltt4h6dv9aLcY8CuEc2A7KTBw53?= =?us-ascii?Q?0HMmSTPBnODb9tIdA0+MVn3bdBPU9KoTgsEDLNGOiEf5F/daaL+F1z3qG3sn?= =?us-ascii?Q?GRE+W2XcBAKqosbRT8ctrp5F5lbykKKn6BXu7LHE2qto6a5pHI4bYG5LdwpT?= =?us-ascii?Q?A9TC/xyvuTrKU+XYWlOlIIHSI4MU7xxU0ekUroj5NNQJrNmhkxUvHvlI6S2s?= =?us-ascii?Q?hXt2uhBnMArtEI9zkUNdDCfsEucIgY2gbmI02aDnWlQ/j2uFw11dUr64SrRY?= =?us-ascii?Q?Lrb+8T0U2ostpHu7n58e1+R4WbWrzQvJX895kRLVvPHBMCrC3ZYv6Vls+kFW?= =?us-ascii?Q?HBxkbW6NxxIg02DzfSnropXW/96cpM/bD6xpzu62RHTJs5gUGxWmyk5F+/9L?= =?us-ascii?Q?/j+rt3zDH6wCnypvbMhNArSNHZ/tVVBhEmkLtcMXpVcTKz0JzMjhCIeGUZwK?= =?us-ascii?Q?qcNd8zN3Qud7RjK4rR4yebTKrY3081duEr1laZsPfyw3qPBUA4NiK6v8aCdX?= =?us-ascii?Q?Bj8N5FLYlmBYmZkmpOkwzG3gHj0APp6xAabLNhzDA9MWw4eb+3TU+ulcJivd?= =?us-ascii?Q?E4TG+lU/0JJYqhMCXH6T7O5KruY7glYxMHHx4NBCYO8VTdKrzpgu8FEvK7K6?= =?us-ascii?Q?ug=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: pb1lLUspCt7kxRusy2e3vmMWxD/qLA5qkrgn4indgxkFRsWdzDCBst0JHwxBK81Lv+zkMsVrTsl56vcqkr+4i9jv7rfYQOmZ/dlJsE4BEM4FtCYv4SFbKsByaflPBhX9W4QCVpmeL2UHf9f2H/9lipRoFc0Ch5ZMVV7vvYmPjqTiwcrynKVq/IAZeDcOgy6KEC6Cqs54gGv4PJ6jusrlhwmvha+PAuezTl944R+UoyZLMRqBWuHt2kR49opEZXeGu0dNeIuYp+0v9CVHbnE/3mg+I/+P5ZTVPUVMn2C8+rZ+8t7KrjAxUve2u0H1lxVhbHznMcsJSU05JNjiNOyngyHGEqu2A4CzdkgIpqaiJRuqBLPDtXEfm7OyBvwKg0ITw1licWQLfPoReyPZAmxhJSYpvJVZ7l/5BH9HooPhDWPrY6q1nnanAyoAin+PA64+Uz7jmOb6zjIibQ/F+Dia7pge6OeF5DQ7qTFAkQFfZu56+M4ORqPvC2Uhzz7fzug4ZAtUPctDr0jmbqBB7wn9GBJ+PgvuQj3PtEwSVayBwFctvXlXVHBF4g5y6MspdUPwKBbXukq5a5GOXqlX/4pGbFfVIUYjz5+19NPwG2QYZeo= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c78dea27-4f4d-45a4-e4c7-08dd0fc4275f X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB3374.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2024 15:48:51.6566 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a5lXNZpid/cAHlPGlYyH8kNTPFioKsUjkKG5DFWy3aMkl8DkVmyeYj+xzVWDTL5fGztb6R1YwMs+lbC3+Xpc6DNfjI94v8f35RyDez/KmAY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5819 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2024-11-28_14,2024-11-28_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 suspectscore=0 mlxscore=0 spamscore=0 malwarescore=0 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2411280124 X-Proofpoint-GUID: aD90OdiC9enTmbBhbwYF5nzZMxvncMDd X-Proofpoint-ORIG-GUID: aD90OdiC9enTmbBhbwYF5nzZMxvncMDd X-Stat-Signature: 99ja5ip9mw8x5sjpchh1jmiu37gb61et X-Rspamd-Queue-Id: DE123180009 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1732808937-589139 X-HE-Meta: U2FsdGVkX182qBfQrXFfloIz8S7idDqlASiBDTaaJGHKxkEwTXAmRQZ2s6MXaHfqwjLofhYJrKYdqbBBksKq67kxN661gnQcna/Qxx+Zzo0hIT56kJK4hgDW655j7JS+0OWC/vy9BuQZL9sBkQr9/0EnPUrgYNKZUePdj3FjzXML5QDoNqzq5V/WQITS2BKQikfwSouEX+fPzhLFkhLX/WZqvTbzPoT/XZM1uXkR5rvRvmdjSsvRYF8TgL9QeKYUpROqOK8EywKnVXI2fy6NbAKCn6fG4HqVH3PwAMPAXm3ImUl4LicXJ4TsDdif6IZGHnjq9h/ahhTt9UCYErUJ3fYri0Uwqfc9fZJ0QoCb1pWzjM4M2fvRzPhDo5FV81CIn5Nv755lksXtsEtl0AxCDeFwjGZt4ofLRc6zU7YNRIMlwZITRn8LWOs1SwM5uPUS9F+0ErH4ocY/4TbnWhpAIyTql2rMmsZy7Ps7+FoRn/dU5W7OUyNFo8I5VCkNkSS/FhYWapVxKbTtf3DHxa/R6Uv4XLfGkFwB0j2/l3nLVtiJUx9HT7cY6SRf5v/reCJ1ltQCPZWkEcyOJ6Wrap4IEDkIL2DX/TqvnmnjmQiAUXN/i70e1JablUvl0EnN28wgf16O9herJEoZt1fei41k3ZviMJrcbdZlOKqkT2+Ng3VHNpiD1h7ZOEown1XbTraKVJ7Qacv6P8CkeMMC1vJoQnuFLFjRkgVk/JQRF3c7B6fi1XhrvbReZ03HJ9UYqrBRCAtq+7UrH7+zJckK4fZVWBGLUY4/TnoFA1/sIR4yITvIF60G7y2UPG4PcidWoy1jjh87AhKGXb7srnhR6qjkX2hR5w7YRk0G2v4Djax7qk6QTxpbwB5KzPnRPuaXBL7bPQVxFXVMmDpKpMkhKbxk0oc8FdHKEJPyVIYzeAsnF2Fk/aNZ1/pk1KBBR+DLUYasuCNKTfc+fO8AdwLu6Nf oJcysDkE iQf+1eCixPJ660xLnL0Q38UD+kFDh9K/6K+Rwjm7h4w2FO9FhX+J70O7gMR8BphTWPaOCq3kj0lkBGVbR85n/uE7Nl0FSr56vhlI+ysUfCvfy4UFNcCcjP/i6jQ4sLk5eyuo47VqN+cu12ngC1JjwfcqzOmB+uAEfBzg6oLCtNSVLDgf/JzNvwHHph8Hoek1KUQsgc7JJjHiUihzNLsEY6eoSe9TClBldUdOpwrlkILZzrkZmL2Ze9ofcvf0HVHlD4zRqSr9MTKHS1zCQV3rytSZWpz6siA7COxUnnW0BDpU368Wj8poIiCL9TXKg8wesl4DGlGYhontf6je5c+0mIKN/FVObsdVbKH+1av974kukhvpR4oRli4mFo2knrY7r6NFvo8SvmPk7L5kvNJ9sJi2osEXpxkWZEIrCkyQiMa6iS3nSlS362/Cb13kYrjvMnxQO6tvxKUfB3v9XuUXbPh9fA6ewc5qfynD0Nq9y8+SpVLPDa7+Z1IA1FqCCzpo3jCnWX/HgT1hSfsBuan9VpX1jvG3z8MEVpkEoYzGRTrVvt1Ub5orR1QFeDDZcxybBmB+zGGAIG8h+7nL1pHzvIknjoWXmZGJavsqaMnieb/nD8scF3LMtw122rycHj/VmpR/YY04cW2+mzrJpggRzLFvu36XmRy1VhqYFMbMqMu/+a57AbhY7j23NJg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 28, 2024 at 01:10:59AM +0000, Wei Yang wrote: > On Wed, Nov 27, 2024 at 12:21:24PM +0000, Lorenzo Stoakes wrote: > >Hi Wei, > > > >Thanks for the patch, though I would again ask if you could please stop > >fiddling around with the VMA stuff until things are a _little_ more > >settled, perhaps best to leave until the new year? > > > > Sure. Thanks. > > >I'm talking about small refactorings and optimisations here - for bugs or > >major issues - please do, of course, submit immediately. Though if you find any bugs or serious problems, please do report them right away! > > > >On Wed, Nov 27, 2024 at 11:43:02AM +0000, Wei Yang wrote: > >> vma_iter_next_rewind() here gets next vma and rewind iterator. > >> > >> Actually the next vma is already been retrieved to new_vma. Since the > >> iterator is initialized to addr, we don't need to adjust it. > >> > >> Signed-off-by: Wei Yang > >> CC: Liam R. Howlett > >> CC: Lorenzo Stoakes > >> CC: Vlastimil Babka > >> CC: Jann Horn > >> --- > >> mm/vma.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/mm/vma.c b/mm/vma.c > >> index 8a454a7bbc80..d419e3700fa7 100644 > >> --- a/mm/vma.c > >> +++ b/mm/vma.c > >> @@ -1727,7 +1727,7 @@ struct vm_area_struct *copy_vma(struct vm_area_struct **vmap, > >> > >> vmg.vma = NULL; /* New VMA range. */ > >> vmg.pgoff = pgoff; > >> - vmg.next = vma_iter_next_rewind(&vmi, NULL); > >> + vmg.next = new_vma; > > > >HOWEVER, this is a good spot and you're right (I mean we explicitly _check_ > >that the found VMA is after the point at which we intend to insert the new > >one). > > > >But while we're here, can we fix this HORRIBLE variable naming? We reuse > >'new_vma' to refer to the _next_ VMA and newly merged one/one we have to > >create. > > > >So could you update your code to do something like: > > > > vmg.next = find_vma_prev(mm, addr, &vmg.prev); > > if (vmg.next && ... > > > > Sure. I thought you may prefer a small footprint, so I did current version. > > Will update it in next version next year. Thanks! > > >This self-documents your fix, avoids the need for the > >vma_iter_next_rewind(), fixes the inefficiency you've found, and avoids > >stupidly overloading what new_vma refers to. > > > >Also update the commit message to refer to this. > > > >And can you update the test_copy_vma() test in tools/testing/vma/vma.c to > >explicitly test for VMAs that come afterwards both merge and non-merge > >cases? > > > > Currently we have two scenario with merge/non-merge after copy_vma(). > > I am not sure what exact case you want to have. Would you mind giving more > detail? Both please, I don't believe this is curently tested. It may also be worth testing the 'should never get here' error case. > > >It's time to really start taking advantage of this huge power we have to > >userland test things! :) > > > >> new_vma = vma_merge_new_range(&vmg); > >> > >> if (new_vma) { > >> -- > >> 2.34.1 > >> > >> > > > >Thanks, Lorenzo > > -- > Wei Yang > Help you, Help me >