From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 911EFEE49BC for ; Wed, 11 Sep 2024 15:34:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 193D194005E; Wed, 11 Sep 2024 11:34:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1442794004F; Wed, 11 Sep 2024 11:34:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F278094005E; Wed, 11 Sep 2024 11:34:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D608094004F for ; Wed, 11 Sep 2024 11:34:22 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 558A81C4AD2 for ; Wed, 11 Sep 2024 15:34:22 +0000 (UTC) X-FDA: 82552853964.20.68E4964 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by imf10.hostedemail.com (Postfix) with ESMTP id 500C6C0002 for ; Wed, 11 Sep 2024 15:34:18 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=GIrlUqm5; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf10.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.7 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726068832; a=rsa-sha256; cv=none; b=F0Ys/ClTXGfsHxsr1RdOqsEL732N5/9t5VC7r9+wWriPXVzN75yOh/W+17J/QftJw61s6f QIFmuLhCrHZESqqDkbeMLzEm1Ipv+OQbKQlSaMr9UC0SF24Kxg85BB2UvCqraxqIy5CFW2 9q6YH3r0s6Pa6M++j8YLsJFh3+TQ4RM= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=GIrlUqm5; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf10.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.7 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726068832; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6JN/I4bL6s6dgRFkY0IpiNaKCd9PQLmGhSRS4MrzIzs=; b=xHw3uLqFms5MbSuC2ObdHBEI5bCqQyxK+Y8KmbfhFaoGYJtmyS1JERWEx0YUU+1JxiEv6c IoBDRlSHZPMmdx2Xb6o8zuP5dAP5F+RJmSKEsuZrAqAyqJ3EVvrF4eCuaEazQfkWKzhDpa mylKs5lw75HDtjlcTq4QwG1FRc9JlVc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1726068859; x=1757604859; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=U5gkwqWSbp1sFQyghj837wzL9/RMU5SpmsvBvs4bWic=; b=GIrlUqm5fqCvZz3Ip8eQ/JbalOsc1M1YIHaBsKL7Mt53vn4HVohdyrhq RN1kHGthd2icQpGHgAKggHw9Y6hMcLIaYlbq1Lmvf+TJ9ECIitsROq8yp 6SXVNvlw3wewk8coHCCAbXZfR7J9sYUKXSTFK6040B281/YnVHtr+k/5S DZ7Ea8JcOCJQ0WfTvLIG7sH6379v5DbrJQcbux4VJWidMrKQsgxOR8XP9 tdkxLCagPpNLvHsPG8l43wD3TVhT9ovu8TLt+xDK75+kDaoygxtueZis6 LnIX4add5inWO7lN9LeaCfu/8JjM8RMdGcULt92Lr7hgxd2jcBlvpY3VH A==; X-CSE-ConnectionGUID: Ci7qrt14Q/iE28Ejj8yW1Q== X-CSE-MsgGUID: +e/IEFDMTU+W2M5UdiW8ww== X-IronPort-AV: E=McAfee;i="6700,10204,11192"; a="50292826" X-IronPort-AV: E=Sophos;i="6.10,220,1719903600"; d="scan'208";a="50292826" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2024 08:34:15 -0700 X-CSE-ConnectionGUID: xtMlID7QSvGxgDWBJblWeA== X-CSE-MsgGUID: yGu1fCIvQ3i5mupTuAQdXw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,220,1719903600"; d="scan'208";a="67023420" Received: from dgramcko-desk.amr.corp.intel.com (HELO [10.124.223.221]) ([10.124.223.221]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2024 08:34:14 -0700 Message-ID: <6c8ad091-a56b-41ba-b403-2e3c2e578100@intel.com> Date: Wed, 11 Sep 2024 08:33:54 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 06/30] arm64: context switch POR_EL0 register To: Kevin Brodsky , Joey Gouly , linux-arm-kernel@lists.infradead.org Cc: nd@arm.com, akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, anshuman.khandual@arm.com, bp@alien8.de, broonie@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, skhan@linuxfoundation.org, szabolcs.nagy@arm.com, tglx@linutronix.de, will@kernel.org, x86@kernel.org, kvmarm@lists.linux.dev, linux-kselftest@vger.kernel.org References: <20240822151113.1479789-1-joey.gouly@arm.com> <20240822151113.1479789-7-joey.gouly@arm.com> <425b8f8c-b6b5-422a-b5f4-41dd2d1ae3bb@arm.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <425b8f8c-b6b5-422a-b5f4-41dd2d1ae3bb@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 500C6C0002 X-Rspamd-Server: rspam01 X-Stat-Signature: 1grojshxx91im483ezszpobah5kezss5 X-HE-Tag: 1726068858-726966 X-HE-Meta: U2FsdGVkX1/Sdj5oY9Hqwr8qKzGze7sg1bcgmpK7yT40dnHGzlkM+TiiKdNk/RqBccz9rPC+1azx7AgFq945pllKKwhq4Gh+tAkbtnqcfKfTHhxMdF7RFAJRe+p10IAEfoBFOQGy9yQhAkc8HefmhlQZhH15a3707M8YoFkhPAHOokPfufy5chPLuMfe+JvFAs4UKPbo8FwisuyXL4Ft/zcZ/ssq75NcwDRqG1BPhY7ECcBwQhu1T5bQMLlqjLLDL9ZG0sDineq4UwMSZFtBZJel/oAu4qW45ZVOogOmZz9YKLPnL+KDNumcRHlG5ZJKcQJoV2HG1WWxQYRkAgB5AEi0tHNkhG9A1wJ4t/zHwnYXNQJRwD61okXIoKuXJdFdY4erCUs+vkb7nddmrFyTskFmuZYP2rnuQT6D527HSb+EmTT1GXi3ZYaPwXgM4LdhIe1e0ridijL0C1ax65XTE6OGqIw/G0LH3AMRAU80P8i3OI/vx3Bv5sRwKEJ5qp2+9RKTxLLSJr8X4J6klszvOwc5Ix2e0rtVms0Wua+cnJ2bsJB49GbAuKl5H6RtFNKrXz6zfaPFKxVuVSLYFDFJX9ZBDbQqqu2nb4Lr+iC6uu+MCHw8b04eXlciLYlGaYoRzRpQkFK0Mo7ocp/LmfuuCgVyRrnMF7lPEJn49LshumqIJBrOpdMakc5xVqgCgU/iFCOTO6an/M0GK80OP+jfPL+OLt45wq5C02Eh24VKyjFg1wGPLegcG71OvKAwUJP7NOIOST35bkN+IkbEsgRhQmoDAox6p5trh0lgpOco0mSIADcU2hbIZUvYrvRbBhdOHjCj9BtHseTYrr4d38q3eRz3z8lsZiswxQBLzF6p0PvBvo1Sc/sKd9XmlxrnUAmDW+I51sw8aaP55cf/joRnXB1DHpChz/oqI6KxjkvCbBeolM/r3AlEiYKojwLEEhUt/SJtN+8tfH4cqCPbaMa +v9G/Gr0 or06ejF5qF3xIzeUgRvdoxEgAbFUwz9sLW3buVR60cxMhBEkAVm18WsPwcF4/LIB7vpWvOlafUdFAOY9xe/CDzLXIoP5pBuNnu9TgvJ7MpEFOG2zztvW2APUaUHfHJ/LLYdbNMn4IF+YZtFVogLwfGA8/MdgkQDHsPnq6AFACh+Yt2wI1kTDJ1jS561cg30IqTY3GgSadIescrxM5VwcEmOlMXlhtYNurImfjNfrP7yU3f5tV2NU7b2SEC4kla6q7yQCZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/11/24 08:01, Kevin Brodsky wrote: > On 22/08/2024 17:10, Joey Gouly wrote: >> @@ -371,6 +382,9 @@ int copy_thread(struct task_struct *p, const struct kernel_clone_args *args) >> if (system_supports_tpidr2()) >> p->thread.tpidr2_el0 = read_sysreg_s(SYS_TPIDR2_EL0); >> >> + if (system_supports_poe()) >> + p->thread.por_el0 = read_sysreg_s(SYS_POR_EL0); > Here we are only reloading POR_EL0's value if the target is a user > thread. However, as this series stands, POR_EL0 is also relevant to > kthreads, because any uaccess or GUP done from a kthread will also be > checked against POR_EL0. This is especially important in cases like the > io_uring kthread, which accesses the memory of the user process that > spawned it. To prevent such a kthread from inheriting a stale value of > POR_EL0, it seems that we should reload POR_EL0's value in all cases > (user and kernel thread). The problem with this is trying to figure out which POR_EL0 to use. The kthread could have been spawned ages ago and might not have a POR_EL0 which is very different from the current value of any of the threads in the process right now. There's also no great way for a kthread to reach out and grab an updated value. It's all completely inherently racy. > Other approaches could also be considered (e.g. resetting POR_EL0 to > unrestricted when creating a kthread), see my reply on v4 [1]. I kinda think this is the only way to go. It's the only sensible, predictable way. I _think_ it's what x86 will end up doing with PKRU, but there's been enough churn there that I'd need to go double check what happens in practice. Either way, it would be nice to get an io_uring test in here that actually spawns kthreads: tools/testing/selftests/mm/protection_keys.c