From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E29BC432BE for ; Tue, 17 Aug 2021 14:03:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 14B8B60E09 for ; Tue, 17 Aug 2021 14:03:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 14B8B60E09 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 6AFA0900002; Tue, 17 Aug 2021 10:03:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 660606B0075; Tue, 17 Aug 2021 10:03:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54E26900002; Tue, 17 Aug 2021 10:03:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0138.hostedemail.com [216.40.44.138]) by kanga.kvack.org (Postfix) with ESMTP id 37D656B0074 for ; Tue, 17 Aug 2021 10:03:41 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9D1A81802294F for ; Tue, 17 Aug 2021 14:03:40 +0000 (UTC) X-FDA: 78484740600.19.173F18C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id ADA5F30000B0 for ; Tue, 17 Aug 2021 14:03:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629209019; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZfdIig2A38w0Tkc5U+l6+f2xruLZRnenJrdR3B6v0U8=; b=IS9TUBcVCdZKzD4rCpFRb5eNkrXfwlGqcK3m95TUC4MYJxT1e9t6xZgTxxsBdamHwO0HuW VN1g/5qJ7pLcsp0l6DCpwXpSePjf6Ci0UfV9MEYQR0vP4B/fbAhBji74OVIaapoDSooMgJ tQmCRf7Q7Xr5dHOIaLj90dw9fxwar4w= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-156-isii8sr0PESy0boh0pSKjQ-1; Tue, 17 Aug 2021 10:03:34 -0400 X-MC-Unique: isii8sr0PESy0boh0pSKjQ-1 Received: by mail-wr1-f71.google.com with SMTP id t15-20020a5d42cf000000b001565f9c9ee8so4463273wrr.2 for ; Tue, 17 Aug 2021 07:03:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=ZfdIig2A38w0Tkc5U+l6+f2xruLZRnenJrdR3B6v0U8=; b=cUenM45qJjWUKml1I99pYpDzaAos8jS4dho2KCtu927DmIveL+Slv2SHHCdgcVcSIv jJDTUk2COfezRiBG4AnBLOuYfLgJEUjHwafxohdb6keNs4MnPfBkOBRsaiC66swCRAOr tgDnt/OkxpWzOc2e+85JxVgctECdWJ2p3E5yEBQ4qseV8464v/L+/Itv+qcdTsr9QZrS yyksCWJfTFyXPJbLNaxL+5HKfUM6ojp9mJfdyMQuAMk2zFu/5zPUPFgqILTRqODpp5bS w6b8Qhv3GDrcEanBkOgPA6TsHqSj5wd/DIuG1xjf4OOpR4qyMtQoBTP3SU/rHM2ptAyy v2GA== X-Gm-Message-State: AOAM532lqX4SOT0rM58yCBCw4+y4MHMZPtlRliZgXMBysOMHBV3fI7kH rWtGHXwNlxEPieuB/TksG2ea0ONIvINitO8CQNYHDh/kN+/wa31i2IDzX0Vcne4cF8jFBxtJ1Fp t/oEAYTrQhBE= X-Received: by 2002:a5d:4389:: with SMTP id i9mr3495433wrq.74.1629209013263; Tue, 17 Aug 2021 07:03:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw3/Ox+IlPMvqUKk+VG3uabY9nF4377Z3HbdDT8QLHV0jefClHrYQiPtPepVUzaFmgn79TQwA== X-Received: by 2002:a5d:4389:: with SMTP id i9mr3495406wrq.74.1629209013061; Tue, 17 Aug 2021 07:03:33 -0700 (PDT) Received: from [192.168.3.132] (p5b0c65c6.dip0.t-ipconnect.de. [91.12.101.198]) by smtp.gmail.com with ESMTPSA id u5sm2525530wrr.94.2021.08.17.07.03.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Aug 2021 07:03:32 -0700 (PDT) Subject: Re: [PATCH] remap_file_pages: Use vma_lookup() instead of find_vma() To: Liam Howlett , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton References: <20210817135234.1550204-1-Liam.Howlett@oracle.com> From: David Hildenbrand Organization: Red Hat Message-ID: <6c7e2274-98d7-721b-498b-6c5fac2a3561@redhat.com> Date: Tue, 17 Aug 2021 16:03:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210817135234.1550204-1-Liam.Howlett@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IS9TUBcV; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf08.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Stat-Signature: eb4bom3swgnw78a69aues65hagrxwpeu X-Rspamd-Queue-Id: ADA5F30000B0 X-Rspamd-Server: rspam05 X-HE-Tag: 1629209019-461489 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17.08.21 15:52, Liam Howlett wrote: > From: "Liam R. Howlett" > > Using vma_lookup() verifies the start address is contained in the found vma. > This results in easier to read code. > > Signed-off-by: Liam R. Howlett > --- > mm/mmap.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/mm/mmap.c b/mm/mmap.c > index d9aa54be6244..1a23d4575cc4 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -2994,14 +2994,11 @@ SYSCALL_DEFINE5(remap_file_pages, unsigned long, start, unsigned long, size, > if (mmap_write_lock_killable(mm)) > return -EINTR; > > - vma = find_vma(mm, start); > + vma = vma_lookup(mm, start); > > if (!vma || !(vma->vm_flags & VM_SHARED)) > goto out; > > - if (start < vma->vm_start) > - goto out; > - > if (start + size > vma->vm_end) { > struct vm_area_struct *next; > > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb