From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 754F9C433EF for ; Thu, 31 Mar 2022 08:42:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00BB86B0073; Thu, 31 Mar 2022 04:42:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EFD426B0074; Thu, 31 Mar 2022 04:42:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC5D76B0075; Thu, 31 Mar 2022 04:42:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0190.hostedemail.com [216.40.44.190]) by kanga.kvack.org (Postfix) with ESMTP id D06066B0073 for ; Thu, 31 Mar 2022 04:42:17 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 8777AA4A45 for ; Thu, 31 Mar 2022 08:42:17 +0000 (UTC) X-FDA: 79304039514.27.F658E77 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 04B7580017 for ; Thu, 31 Mar 2022 08:42:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648716136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8O7P4V32LmLKx1/fyryDQWDDIa4z/qPMVAMMY5dYyBQ=; b=fwSAFIkwTjUptP6NbC637pJcQbm8Pm8RR+QW6Woo0zvn5LOsB8zJ58RvomqWYR0fvDdL7b VTu0wvvRKDN+zHxvipl/XlQ0e1ke5izDtdytBZ5RmR5aMrap6P+AkgZ54HsFvAbJCx+eaw GdRdzUd4OQQb7z8orrM/bvoqmYNQNvo= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-193-dZtPIQXvPZSBWTsbIbi4Vg-1; Thu, 31 Mar 2022 04:42:14 -0400 X-MC-Unique: dZtPIQXvPZSBWTsbIbi4Vg-1 Received: by mail-wr1-f69.google.com with SMTP id 5-20020adf8105000000b002059d8f085bso4688153wrm.0 for ; Thu, 31 Mar 2022 01:42:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=8O7P4V32LmLKx1/fyryDQWDDIa4z/qPMVAMMY5dYyBQ=; b=SAGyrEu2I74LVhVEIDalyrAa7eLi+ekodhKYUBdh2S0D7noL9Wc1kRRreEv+Cqk4Za 6vYd9YY0P9uWtUmzzd8D+alsiTNQDO6KehCzupZqRLCmQmaiG+5y5yF62fZqaDRloevQ OyIIwwi6T0i1VewaX5gnkH2AG8Bupe3YbuySBAOgoBXH9RWuQwsXyjASWWZg6WLX/snv /N//bjhgYjKqOMG8mLI2lRkWWq2uK1EdQSqZJynfZ2mafBk3wVjqs1RMxlW0m6hYdrbE Jb8DnmulVYpI5giS2Ld+YPo2Cr+zAEWCl6ESyoFGiftWubu0fFdy4vKAc0D5OFqVvnUp hN4g== X-Gm-Message-State: AOAM533JCZmO0bpMhbQQUyH8vTedXOGAa1gZpjbYAH+E4oVllHpa4ZTL aBBI+T5AOyBj6XOCB5FclRU+xGy5BwYf0Nhc/L8MG+97RKK0NivTYJE/iL/V8+oJqJbg1Pie6GX 7r3RriTQ4Bmk= X-Received: by 2002:adf:ef50:0:b0:204:3be:aaa0 with SMTP id c16-20020adfef50000000b0020403beaaa0mr3308607wrp.632.1648716133768; Thu, 31 Mar 2022 01:42:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzjvWfhy26tdh9LbPeR/3J64W85TY6O95IiKd5tQtgVqbXVualxL5wjcfLbfWcZcWN0wgW5Q== X-Received: by 2002:adf:ef50:0:b0:204:3be:aaa0 with SMTP id c16-20020adfef50000000b0020403beaaa0mr3308583wrp.632.1648716133302; Thu, 31 Mar 2022 01:42:13 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:ac00:381c:2e8b:3b48:488e? (p200300cbc707ac00381c2e8b3b48488e.dip0.t-ipconnect.de. [2003:cb:c707:ac00:381c:2e8b:3b48:488e]) by smtp.gmail.com with ESMTPSA id u11-20020a056000038b00b00203e5c9aa09sm28212335wrf.27.2022.03.31.01.42.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Mar 2022 01:42:12 -0700 (PDT) Message-ID: <6c774e27-26d2-6c45-65f9-8a5b8acd6433@redhat.com> Date: Thu, 31 Mar 2022 10:42:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v4 1/2] mm: hugetlb_vmemmap: introduce ARCH_WANT_HUGETLB_PAGE_FREE_VMEMMAP To: Muchun Song , will@kernel.org, akpm@linux-foundation.org, bodeddub@amazon.com, osalvador@suse.de, mike.kravetz@oracle.com, rientjes@google.com, mark.rutland@arm.com, catalin.marinas@arm.com, james.morse@arm.com, 21cnbao@gmail.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, fam.zheng@bytedance.com, smuchun@gmail.com References: <20220331065640.5777-1-songmuchun@bytedance.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220331065640.5777-1-songmuchun@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fwSAFIkw; spf=none (imf02.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 04B7580017 X-Stat-Signature: w5y66pm9yf8zfwkhqf1gnfso4a1uehm4 X-HE-Tag: 1648716136-281681 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 31.03.22 08:56, Muchun Song wrote: > The feature of minimizing overhead of struct page associated with each > HugeTLB page is implemented on x86_64, however, the infrastructure of > this feature is already there, we could easily enable it for other > architectures. Introduce ARCH_WANT_HUGETLB_PAGE_FREE_VMEMMAP for other > architectures to be easily enabled. Just select this config if they > want to enable this feature. > > Suggested-by: Andrew Morton > Signed-off-by: Muchun Song > --- > arch/x86/Kconfig | 1 + > fs/Kconfig | 10 +++++++++- > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 9f5bd41bf660..e69d42528542 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -119,6 +119,7 @@ config X86 > select ARCH_WANTS_DYNAMIC_TASK_STRUCT > select ARCH_WANTS_NO_INSTR > select ARCH_WANT_HUGE_PMD_SHARE > + select ARCH_WANT_HUGETLB_PAGE_FREE_VMEMMAP if X86_64 > select ARCH_WANT_LD_ORPHAN_WARN > select ARCH_WANTS_THP_SWAP if X86_64 > select ARCH_HAS_PARANOID_L1D_FLUSH > diff --git a/fs/Kconfig b/fs/Kconfig > index 6c7dc1387beb..f6db2af33738 100644 > --- a/fs/Kconfig > +++ b/fs/Kconfig > @@ -245,9 +245,17 @@ config HUGETLBFS > config HUGETLB_PAGE > def_bool HUGETLBFS > > +# > +# Select this config option from the architecture Kconfig, if it is preferred > +# to enable the feature of minimizing overhead of struct page associated with > +# each HugeTLB page. > +# > +config ARCH_WANT_HUGETLB_PAGE_FREE_VMEMMAP > + bool > + > config HUGETLB_PAGE_FREE_VMEMMAP > def_bool HUGETLB_PAGE > - depends on X86_64 > + depends on ARCH_WANT_HUGETLB_PAGE_FREE_VMEMMAP > depends on SPARSEMEM_VMEMMAP > > config HUGETLB_PAGE_FREE_VMEMMAP_DEFAULT_ON I think something like "HUGETLB_OPTIMIZE_VMEMMAP" might be more expressive, but that would imply renaming the existing config knob. Apart from that LGTM. -- Thanks, David / dhildenb