From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D2EAD6ACDF for ; Wed, 27 Nov 2024 14:25:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F0D546B0083; Wed, 27 Nov 2024 09:25:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EBD1E6B0085; Wed, 27 Nov 2024 09:25:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D85986B0088; Wed, 27 Nov 2024 09:25:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B84EA6B0083 for ; Wed, 27 Nov 2024 09:25:47 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3DB3A1C716E for ; Wed, 27 Nov 2024 14:25:47 +0000 (UTC) X-FDA: 82832098440.07.56743F1 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf22.hostedemail.com (Postfix) with ESMTP id 78F3DC0017 for ; Wed, 27 Nov 2024 14:25:38 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="h/CxOYee"; spf=pass (imf22.hostedemail.com: domain of broonie@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732717543; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WYPH20J6A10BHc7kI/E/juopwBALfkDE3/ikq6HJCZc=; b=o6rPp87WV3HpJGaBzaQb/vtMxFhjTC0qCsFTYj0L0E9zHomaR1uxq47pgSW4Lv+Gu+r3Np Hufd8pRA9F4zKGd8FvwkrIKCkQFDzg7ZJ93DS+tc4Q4EiEcBO9ImHmfVZxz5HE4G9lgE6A JfcZ4QmWziV1b5gdqaLY6XdOcXE4gFw= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="h/CxOYee"; spf=pass (imf22.hostedemail.com: domain of broonie@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732717543; a=rsa-sha256; cv=none; b=53euVe5IRfl+PMXUuHjQe4rIdD2AW4+8bv30MYmujMj5+B8gWld6Ce2PPFImvfDQqjrUj4 LEiUKHnLFUsUB1EAyLo9jXrWRvkVUNvPSMeLmYlfmnRBPmMkF6eISXb5StZypsAieX8eC8 TMWtpumXfgwSFhw0IMQijmOR7t/E2Vs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id D8C54A438D2; Wed, 27 Nov 2024 14:23:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B3E3C4CECC; Wed, 27 Nov 2024 14:25:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732717544; bh=3uPc2P+OMkq0tXJoXSIRKXPVE6RqrMCTk1ytqMl3lAY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h/CxOYee/L/uMwKD0fpEyp0kPE4JBauzNby4cW6ObYNdPktSTMFgrtJTjoO13bG30 1tUV1u66y1qT/rWLyR/mO4Q4C0EdZqow3DdvwbiSr+Ck1nAzQaHxqwdRJAQ545bHKF p8plZD905aI4oC3ZSXSLB8ePmQP4lRhhnp7NAtMlKcxkLCRnc3DETLhIRXMZic12/e Kv+EOWuWmk9lXGoWkejzwulU2dzM0QVHhDLXTQ1l0RbWI/3JErz4TX6ECY7oRVaCes NT0ZUPL87lxM8khD1ePECi5Q5tGEjqQhzlZbCeA/z9hFdwuGiQSWgRDo8IfIKl/LI/ i7tXZ0V9I2zFw== Date: Wed, 27 Nov 2024 14:25:29 +0000 From: Mark Brown To: Tycho Andersen Cc: Alexander Viro , Christian Brauner , Jan Kara , Eric Biederman , Kees Cook , Shuah Khan , Zbigniew =?utf-8?Q?J=C4=99drzejewski-Szmek?= , Aleksa Sarai , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Tycho Andersen Subject: Re: [PATCH 2/2] selftests/exec: add a test for execveat()'s comm Message-ID: <6c68dddb-84f3-4b73-987c-8334b2301d9b@sirena.org.uk> References: <20241030203732.248767-1-tycho@tycho.pizza> <20241030203732.248767-2-tycho@tycho.pizza> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cxLCvAJhB4t1mXeM" Content-Disposition: inline In-Reply-To: <20241030203732.248767-2-tycho@tycho.pizza> X-Cookie: With your bare hands?!? X-Rspamd-Queue-Id: 78F3DC0017 X-Stat-Signature: be3jmpbodrzunttfjpo9iahz44ftksdr X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1732717538-711713 X-HE-Meta: U2FsdGVkX1+9+w2cNVEGJq59dLwOf2+kve7hUlP/L3UiPrjR+HQV9K+NYIulc9zOIhpXw2+S7R3Q2EXvN3epgrqDfOJgf61MEftru9qdMYGxYNnhfd0Ee8ry8Dxau/rHqUUDq9o4H2ol/zF66oZxvpbp2WyNaS5R2mpp3CEeZzXNk7ak5vV06lBPff5qccV6DJKg1g7mnSDZvwVDbMsT0y4ywXmYkNjmkJCbVOg2WiMtwdR8iv6DY9Uid6/Qee1T0jD/586l8syW2pTiTwJHcNQfVWzpVLYdtHA+8Ud2a+04Ftm18ZU1Ghhe+4Vd1l/IDaN51xeGEV4YMfs0AMyLegxATxZb9mc4WLhfoq/K4u2o3zgTSaMSKnweSBgL8tVV3O2BxBbGrDr1TOqTbeoVZhJqzkhPrZwzIz2v+Pp6eEbQ2XOoKc5TVf4r1m9HwhO/DwXcaLplNasX5/wkTfUVZB1wTPSh+Dpww0vUsWUd3355axNqIFbHbJfAS7xzon4vfC1IeHfKcFJobNbp67Pys0MVUzptadqPvtk8fxAHgUKQ0minPgOWOPS8QgF7V9EAl25pEmw3ItnYBvbtp23rNzL0tVzvD3lU6kMouKtsELhhgNkfs+abpEqwrGD4qT7OiQziGyPsOr05Utkitx2RaalsYD2b1x0iqxqIyRBpvT6WdCovPVhEqxrTsBw4wznhRbwt0I8y997agM0tmkX7p9WSviYXwXmyi2ZNBYoqVmIWNoPaMpQejwM8s/ZYm91fPDKUBsYo97LIsXoI/Ew9Dz2jGUb4tpihNvM+kFxfI7KTX0OE3rCtmMhb0mxBF1vbwkFPTeKEdV/lUZZF1V9fft/vmyy8GsrUFBRXjfTKrodu1TVGExlvsShxMd36hpYZFGc6UdIYrdqdfa7gHAsOWkDd5Gl+O9tdm8isFeD0jUA1B72I85kifwx/us8+vKo5IIy5/T85BYTUOX7Uxe3 /65S+oQE V/sgAIxNzyVLcFZqodmjM5wKSxKNUR2Ws1QobXlN3p/ZGPbEPyyYgu0X9sUHD7cFhhD9MnC2CHKaKSDrn8jWYZGbDaWd0zFzfx80GlWTJ9jj6IBjd0svrlQDXIYVUcnSmnkIpQAhiQGQ8QJ1i9q2BBPym5YkoEocF7Ao4ERDhSqoe4qJNKFwxV+3fN+4K9+u+lKXsGm3rgFdRdopdHmymK1UTGyMW5A9hdVrKE5rOD16w5/JGE5WtAF28YkW9oECR/igSc/Tw6ju8tCxahqOIQ2Z0ni1v8u3C8rue481jT1osS5oTm9tcnlAxnqa5DOXK5qVDnRCmCc4Zn4EGwT3RDHy6lrZJ8ZTRwQzD+mMCtUGsFLa8qY6h9mHDIVMRg1oV5y5aN8rFYHaWG48= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --cxLCvAJhB4t1mXeM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 30, 2024 at 02:37:32PM -0600, Tycho Andersen wrote: > From: Tycho Andersen >=20 > In the previous patch we've defined a couple behaviors: >=20 > 1. execveat(fd, AT_EMPTY_PATH, {"foo"}, ...) should render argv[0] as > /proc/pid/comm > 2. execveat(fd, AT_EMPTY_PATH, {NULL}, ...) should keep the old behavior = of > rendering the fd as /proc/pid/comm >=20 > and just to be sure keeps working with symlinks, which was a concern in > [1], I've added a test for that as well. >=20 > The test itself is a bit ugly, because the existing check_execveat_fail() > helpers use a hardcoded envp and argv, and we want to "pass" things via t= he > environment to test various argument values, but it seemed cleaner than > passing one in everywhere in all the existing tests. This test doesn't pass in my CI, running on an i.MX8MP Verdin board. This is an arm64 system and I'm running the tests on NFS. > Output looks like: > ok 51 Check success of execveat(6, 'home/tycho/packages/...yyyyyyyyyy= yyyyyyyyyy', 0)... > # Check execveat(AT_EMPTY_PATH)'s comm is sentinel > ok 52 Check success of execveat(9, '', 4096)... > # Check execveat(AT_EMPTY_PATH)'s comm is sentinel > ok 53 Check success of execveat(11, '', 4096)... > # Check execveat(AT_EMPTY_PATH)'s comm is 9 > [ 25.579272] process 'execveat' launched '/dev/fd/9' with NULL argv= : empty string added > ok 54 Check success of execveat(9, '', 4096)... The output when things fail is: # # Check execveat(AT_EMPTY_PATH)'s comm is sentinel # # bad comm, got: 11 expected: sentinel# child 8257 exited with 1 neither = 0 nor 0 # not ok 52 Check success of execveat(11, '', 4096)...=20 # # Check execveat(AT_EMPTY_PATH)'s comm is sentinel # # bad comm, got: 13 expected: sentinel# child 8258 exited with 1 neither = 0 nor 0 # not ok 53 Check success of execveat(13, '', 4096)...=20 Full log from a failing job at: https://lava.sirena.org.uk/scheduler/job/993508 I didn't do any investigation beyond this. --cxLCvAJhB4t1mXeM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmdHK9kACgkQJNaLcl1U h9C2gwf+N5c+vZrIomxF6ng0FWDkSyPW8c5Ey2j5IGpsPBg4/Vv0mxv6z0vlH+mf EtchjFZfuht9PgmGwB38eWQanuc9NTKyi/K6xpGe1meJ+5iv/CHZ2kzisyL20koA N4U7MRNQAcbEGrpHDd96w9x7NZNaellM7UmVrG32wT7H+I8v24LKphJYlJnYs/sm ygkkLVuRo1Ez4YhvSUmT1lraYuPQzkKEzRVKHbku/qLsTIk6VUGhSaUsjaZETvg+ YtzILqFza8bD5lvogKfBHrsGsnDN1wtFVwDAvlGkbj3qu0rXDFRGKq/e92n6MnvG Xm1CkvsFtR/wvTTZY0OAPGL0xRKEZg== =s3fS -----END PGP SIGNATURE----- --cxLCvAJhB4t1mXeM--