From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 155FCC83F1A for ; Fri, 11 Jul 2025 01:57:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FEC78D0003; Thu, 10 Jul 2025 21:57:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AEE88D0001; Thu, 10 Jul 2025 21:57:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79E468D0003; Thu, 10 Jul 2025 21:57:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 684658D0001 for ; Thu, 10 Jul 2025 21:57:07 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2D8C9BECBA for ; Fri, 11 Jul 2025 01:57:07 +0000 (UTC) X-FDA: 83650320894.09.A8478F2 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf17.hostedemail.com (Postfix) with ESMTP id 5722240004 for ; Fri, 11 Jul 2025 01:57:05 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=b+yrik1Y; spf=pass (imf17.hostedemail.com: domain of alx@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=alx@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752199025; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FG5EU/f/hB5bUkYkfvMhOxqTQ8gFlOM0lPZIWF+q+cc=; b=y1DkaT48Cs42bPXa8r8jlnJBZ8FG9H8U40lqbEXI28QpUiFQxgui2XnpQGSWZk23HZgg2z g4JYTYpjXZozQz98E4KuGhMYiXrC6eoXD16Vx3HxrEeuuf1yNoSPadtQZjC8jBcnQIjTeE oPpz8UhWxV23Kaq5r03KD3G0wclbvLk= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=b+yrik1Y; spf=pass (imf17.hostedemail.com: domain of alx@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=alx@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752199025; a=rsa-sha256; cv=none; b=htAmULXYdvWvupsL3TYI/xAiLdonr8FENaqjpSX9ICnCtfe4kq+4MJSFOCtCvzVQAXdV4s 38BcccAvFtnIkZHlTRwaWdeHY1lf/j6imiy9i8f0yB/aZbw5kcQzEuOfhGA9bbdmYQOF52 MP5o5LENsApHeNOwovTDHl1fK6zSLwQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 6648D47053; Fri, 11 Jul 2025 01:57:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BD82C4CEF6; Fri, 11 Jul 2025 01:56:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752199024; bh=KFeH759S2pXUEgcinWQTZzWHu8P8w4ivkJjMDXMeyRQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b+yrik1Y7oQkJfNLgirKR+t+05Nr58BhPynA5GRvDE3dWL8dPFJxRPU/bK1SphqTI jvrRfyb2yeA1HvF5IQL1+rcY6ivhXJ8Mt+BvUBoZKD2BtH8AUqPgTZuuRvuOSLQvW4 W77M+enNSb+dvC8ziwysEDVyn0pd5qks1TkAzefJ/zpVaK5BoJDPVQ358UVhcxOfEP kv+Ovf3a+dKCSD9OhppknH5doJg5s5bVR1TyvAPBuHkfHQVVqOBa+HySpvvTr/xme1 VKqGqaCgIgtW71h6PNlgCxyVkRrnH1k6eqiH4eN6clJIhz4E6tT9ycqcwo5d1aB2L1 dk3mUG45HJgag== Date: Fri, 11 Jul 2025 03:56:57 +0200 From: Alejandro Colomar To: linux-mm@kvack.org, linux-hardening@vger.kernel.org Cc: Alejandro Colomar , Kees Cook , Christopher Bazley , shadow <~hallyn/shadow@lists.sr.ht>, linux-kernel@vger.kernel.org, Andrew Morton , kasan-dev@googlegroups.com, Dmitry Vyukov , Alexander Potapenko , Marco Elver , Christoph Lameter , David Rientjes , Vlastimil Babka , Roman Gushchin , Harry Yoo , Andrew Clayton , Rasmus Villemoes , Michal Hocko , Linus Torvalds , Al Viro , Martin Uecker , Sam James , Andrew Pinski Subject: [RFC v6 4/8] stacktrace, stackdepot: Add sprintf_end()-like variants of functions Message-ID: <6c5d8e6012f06f595fbb30e3c25a88a400538ad8.1752193588.git.alx@kernel.org> X-Mailer: git-send-email 2.50.0 References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 5722240004 X-Stat-Signature: 6ihw4d9jkt3t9d8ew5hcghatczm1iddh X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1752199025-16358 X-HE-Meta: U2FsdGVkX19j4EfQ1y3UIzU3b5dAhWae//toKFouOwRwOXmuCu6qG6SYF/oTWw6hIbpxS7Vpifehc1JJSGozaTacBMlC58MS2ZYK6n38+p48PGmfSxmAi64AyT1D99HDgb79RWJgqm296yVHoSNWOiYnTAticg1/wyRaeZBj8i0w2v8myKELX6iFxmSC10rP8+WDIgRfugAnr4C5gzvTCTvzfDEQPbyifNsMp7sk6JujdhxqX9R+LW7cMXckgZPSZnd5RDGc2uPwvZwdnqygJ/rs5Ey3aIFhqBRm1ZIOt49qxRff/1MOyoTtUgYJSFOYozrX6ifNEE1N4d61aBeIO1tukw0ulY91IiO5h10I72cBkAMit6y4o564/zGqw7wHrrQzS3Y4FiEqHo7VmDUJtu5FzGiaFZkBn4sPTTYBXF+cwzx3pBJcA3XoabGMOqgRj5Ps8i4kNAWMRFLl9It8RAwMZK8+hAMQvQySEPQLTskyrGvWmhsHqmz4SRHnZtWjjWv0WOBSLc2EnBUK5D0S4yhsTfBbOjj7Npx5YFZkRF8H9R6YOn80/ce3ayru20FRzBPCNk02O/lXm+t0xgTGuglExit5Aun6fhPOv5Ukeu2dFxxAkNzBQ5tcNCJvunREJkg0aFssw9/4e+UdAU98FXai8yexVIa5S4xwoS3tG14D+F6nCWTVish5pTRKXKxuhAzYwAWRhLmEsDR/kgtM2x3n1vUOM03NlkQ6wPhvDjGiHIM6djQG8LWWbSWUptWLGlYShpVWgVQJEW69P6ZUmsuEHx9nb4cJFx7yHUOiE8ejncGrM7B5H7o2jcBjwvHQuxOx2WRskJrOFoNj0WziLaDFyLH+tqf7xDw/LBn3EQmWqDnsW8xxU/G0BEz2wJ8XxTlDI2VntUmFdCTLakKtNC79UJ4XnClsQI5kfPYACMzVs4yGpx+TdEhP6HFvQ56o0oaKDAEBlQ1pZOpYhxV E8MScbVA YYqLGVCEFMD7O1/tmv7mOgMwu1D77bdZW7eZv9RDwfw8r8pN7QmhlkUJWBq02rzRm0h/HOqjxSJrdYpUIIjOSPxxKroUyy96V5uaJ/FWrSJVjbtGvOlap4JLvFL0V9bmMn6aWkybc3U+dhejHgo5qSXBRmalpdhpcWwHxXXeH0sU2rJIFoL+xwQp/8smHMyZvHQlkizlXf01JKWOnmEaYKSlGIKiS0bUNc7/DV7YZNRcHYNaYgRHqVEifNNCOtMX9OqAfDHc4GMeJrVL8dsaiupf9yWkJwWR0AYjOG9A4pjNXe+eYfc33wWng10WQbT1r2pftpoGmi0UAkiUrzvZr54MZeZzQFOBgTThf6vTSBgJ0kRFBhe7HA//RQtBTYFQWUpKpI2zwCRZll1d3+2mNLQvGrNaaVYP+9+Rl6A++fn26Q6ecJaVS0tS8KuDwSaSgBNZUUgDeGqrXUnwVT+eNDKK+11l0Py7kdNAgawQ1enIJAFnrgX87uyX+8km0ATeTDyjYZq4w1WhsdPJiD7VaJQY2jbbQElM6RmLtuBWovIQLjWSTDC6NfkiSGhxhtqVkvv+edLPSSqPuNHPJfzy7TSSF1Fp5jkbpxn6nDV1G8VHLpLI9FcvlwPCqgw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Cc: Kees Cook Cc: Christopher Bazley Cc: Rasmus Villemoes Cc: Marco Elver Cc: Michal Hocko Cc: Linus Torvalds Cc: Al Viro Signed-off-by: Alejandro Colomar --- include/linux/stackdepot.h | 13 +++++++++++++ include/linux/stacktrace.h | 3 +++ kernel/stacktrace.c | 28 ++++++++++++++++++++++++++++ lib/stackdepot.c | 13 +++++++++++++ 4 files changed, 57 insertions(+) diff --git a/include/linux/stackdepot.h b/include/linux/stackdepot.h index 2cc21ffcdaf9..76182e874f67 100644 --- a/include/linux/stackdepot.h +++ b/include/linux/stackdepot.h @@ -219,6 +219,19 @@ void stack_depot_print(depot_stack_handle_t stack); int stack_depot_snprint(depot_stack_handle_t handle, char *buf, size_t size, int spaces); +/** + * stack_depot_sprint_end - Print a stack trace from stack depot into a buffer + * + * @handle: Stack depot handle returned from stack_depot_save() + * @p: Pointer to the print buffer + * @end: Pointer to one past the last element in the buffer + * @spaces: Number of leading spaces to print + * + * Return: Pointer to trailing '\0'; or NULL on truncation + */ +char *stack_depot_sprint_end(depot_stack_handle_t handle, char *p, + const char end[0], int spaces); + /** * stack_depot_put - Drop a reference to a stack trace from stack depot * diff --git a/include/linux/stacktrace.h b/include/linux/stacktrace.h index 97455880ac41..79ada795d479 100644 --- a/include/linux/stacktrace.h +++ b/include/linux/stacktrace.h @@ -67,6 +67,9 @@ void stack_trace_print(const unsigned long *trace, unsigned int nr_entries, int spaces); int stack_trace_snprint(char *buf, size_t size, const unsigned long *entries, unsigned int nr_entries, int spaces); +char *stack_trace_sprint_end(char *p, const char end[0], + const unsigned long *entries, + unsigned int nr_entries, int spaces); unsigned int stack_trace_save(unsigned long *store, unsigned int size, unsigned int skipnr); unsigned int stack_trace_save_tsk(struct task_struct *task, diff --git a/kernel/stacktrace.c b/kernel/stacktrace.c index afb3c116da91..f389647d8e44 100644 --- a/kernel/stacktrace.c +++ b/kernel/stacktrace.c @@ -70,6 +70,34 @@ int stack_trace_snprint(char *buf, size_t size, const unsigned long *entries, } EXPORT_SYMBOL_GPL(stack_trace_snprint); +/** + * stack_trace_sprint_end - Print the entries in the stack trace into a buffer + * @p: Pointer to the print buffer + * @end: Pointer to one past the last element in the buffer + * @entries: Pointer to storage array + * @nr_entries: Number of entries in the storage array + * @spaces: Number of leading spaces to print + * + * Return: Pointer to the trailing '\0'; or NULL on truncation. + */ +char *stack_trace_sprint_end(char *p, const char end[0], + const unsigned long *entries, unsigned int nr_entries, + int spaces) +{ + unsigned int i; + + if (WARN_ON(!entries)) + return 0; + + for (i = 0; i < nr_entries; i++) { + p = sprintf_end(p, end, "%*c%pS\n", 1 + spaces, ' ', + (void *)entries[i]); + } + + return p; +} +EXPORT_SYMBOL_GPL(stack_trace_sprint_end); + #ifdef CONFIG_ARCH_STACKWALK struct stacktrace_cookie { diff --git a/lib/stackdepot.c b/lib/stackdepot.c index 73d7b50924ef..48e5c0ff37e8 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -771,6 +771,19 @@ int stack_depot_snprint(depot_stack_handle_t handle, char *buf, size_t size, } EXPORT_SYMBOL_GPL(stack_depot_snprint); +char *stack_depot_sprint_end(depot_stack_handle_t handle, char *p, + const char end[0], int spaces) +{ + unsigned long *entries; + unsigned int nr_entries; + + nr_entries = stack_depot_fetch(handle, &entries); + return nr_entries ? + stack_trace_sprint_end(p, end, entries, nr_entries, spaces) + : sprintf_end(p, end, ""); +} +EXPORT_SYMBOL_GPL(stack_depot_sprint_end); + depot_stack_handle_t __must_check stack_depot_set_extra_bits( depot_stack_handle_t handle, unsigned int extra_bits) { -- 2.50.0