From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 765A4E677FC for ; Sat, 2 Nov 2024 12:32:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 987A36B0082; Sat, 2 Nov 2024 08:32:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 937116B0085; Sat, 2 Nov 2024 08:32:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D6BE6B0089; Sat, 2 Nov 2024 08:32:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 59CC66B0082 for ; Sat, 2 Nov 2024 08:32:40 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D8FCDA1737 for ; Sat, 2 Nov 2024 12:32:39 +0000 (UTC) X-FDA: 82741092420.27.035AA4A Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by imf25.hostedemail.com (Postfix) with ESMTP id AAA39A0002 for ; Sat, 2 Nov 2024 12:32:16 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SuV4o75a; spf=pass (imf25.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730550675; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0cK9TQVWg7I+wIQ6YLPwhG/jCCQaaWlOYJF5K81kq2s=; b=UyuSbiketeCMia+75Ms1CH17l1STF5IwVoYzbz+xdLPgjGccK77wAGAqWiKIuxQc3xzQZa gIUq05F03OuXjxl86E/vq7eTtonpiy9tmGTF15Ga4uMlw5OwUucaMcMIuG4SW0rFddLk3/ jH8eteA6aOvQZ0ANhwwr4qKjmGhkZ6w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730550675; a=rsa-sha256; cv=none; b=P2jwYgc5vm9Mm2C1ffzEKNT5GiHsemS9dICPJ0jwxo/Pdn/d/s1cfa3imheYnwvsZ2qqqI o0XlT27YXnNLZnBNi9W5wCR7llyvGCMvyok51goYYAon8W2TtVicETGeVa+M1eOZv8CQfC VCfeAeQXsbx3GBx1SCTjZmTWGW3Whrw= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SuV4o75a; spf=pass (imf25.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-43163667f0eso22800395e9.0 for ; Sat, 02 Nov 2024 05:32:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730550756; x=1731155556; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0cK9TQVWg7I+wIQ6YLPwhG/jCCQaaWlOYJF5K81kq2s=; b=SuV4o75a20sCZ6hxnifqjXQd/nISaIKLqMM/xvJevVIxoG3PVkvYIODvLunfq6pVp6 nUZtyXx0EawwUNqr/+BQALiyou4pId8eO6J9HNPVtZRpNRhI9Um5o/hoZjRur+jdA6Ix awGMAfWRkdP19WuPwv14Ox5joDHp+WDcuND13LZAKho89yMN2hUQXkjGe08G062TevfD FbI6N6lvC23jJTgMQDYVaR8hV3LDlRmEqmAhvUzmv4tb263XdOinAxEsETGgbvqDmdmB 91Szzson9WW2i3VqFVLkUcgWEYcuAGeD/5/iw+LQ2mK5puodzXGzxEpnbR+CbROwzfck 4+BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730550756; x=1731155556; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0cK9TQVWg7I+wIQ6YLPwhG/jCCQaaWlOYJF5K81kq2s=; b=DPr6vlzvV0Rtm1DcBJ/oKNX0OjA3yFfxFDFQRSCcmbwRYWuQLktePVuknlEBYFy7ck GThfxukHiqG0jXWR3MMGcZeBdVzI0trBnPbgCS85jVzWPetnoz0+8P9kZ4OiCRa6GQTY q7UWEXe8Tpjlk1lAwMPl1MRx0pQVu1WvGj6wGTroLAQarWVFxp7JOuQ2ROBCm24khuzj PsLpPQYzWXG2M57CexEhvWm7RQPRr1P1Ab1VQcMAx8Mr6AKKCNkGA4D68HaMlrIwpYvF eTLTeikep5wFMmdSx1/IxKuYntvavD+4GmDmDRqHTFAleJkKrPOIrMqGT8EgQ5mJwtWT TIkg== X-Forwarded-Encrypted: i=1; AJvYcCU468bflhRA4fxprQYxeL76ETY0lnkCXEUh9Xm6vAYfy2jQTamh1VZmNh/YjaOAPnH5w2lcNopLtQ==@kvack.org X-Gm-Message-State: AOJu0YyC4PGurTFsAMis8xWcLBedX/9DUdYvUzHL1YAfX9S2mUaqTl4a DIFIvgsldeLyOwj+wiIKpz9fhKm15Zt1wypx5JyMZtl2duhqOsez X-Google-Smtp-Source: AGHT+IGkR2VlUBwhCZn8s/GdFQOSJrDGvhIE67MupKLsaLdsl5BO7ONzPYLUC7I8OnMc4kGAROOyVw== X-Received: by 2002:a05:600c:16ca:b0:431:5847:f63f with SMTP id 5b1f17b1804b1-43283246cb4mr54800135e9.13.1730550755887; Sat, 02 Nov 2024 05:32:35 -0700 (PDT) Received: from ?IPV6:2a02:6b67:d751:7400:c2b:f323:d172:e42a? ([2a02:6b67:d751:7400:c2b:f323:d172:e42a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4327d685278sm93123145e9.36.2024.11.02.05.32.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Nov 2024 05:32:35 -0700 (PDT) Message-ID: <6c14ab2c-7917-489b-b51e-401d208067f3@gmail.com> Date: Sat, 2 Nov 2024 12:32:34 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: count zeromap read and set for swapout and swapin To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Barry Song , Chengming Zhou , Yosry Ahmed , Nhat Pham , Johannes Weiner , David Hildenbrand , Hugh Dickins , Matthew Wilcox , Shakeel Butt , Andi Kleen , Baolin Wang , Chris Li , "Huang, Ying" , Kairui Song , Ryan Roberts References: <20241102101240.35072-1-21cnbao@gmail.com> Content-Language: en-US From: Usama Arif In-Reply-To: <20241102101240.35072-1-21cnbao@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam10 X-Stat-Signature: xxpfhbihp55norgd3uinwqejku74iso6 X-Rspamd-Queue-Id: AAA39A0002 X-Rspam-User: X-HE-Tag: 1730550736-502387 X-HE-Meta: U2FsdGVkX19JYNYWUwnFraX30Sbkpc7Ad+RIretgECS/2zEpSkBgzBlPfkke7hEk7NxicWEcVcMLVKqv2f81ko8mjVwggaYXo9TkiHHtH5hFtd89y5+KbBTXriVJH8ZWbpez7VoWF7b12BLgP8UopO/DZinssgZaIAw0s+olOOkgOd0Ed4qnHCIKcadcCKrCF3wZEER8H2VHOS+VRYdcgIHbxa/LzCOUytHXi9PqkG7W6CV0la7swToEaLT2kL71wkxqo4xs6zOlulg49oOm6F6qA8gp29YZJbvo6sZ4Y/lvqzTf64KLpr/IGZQUpZ3b8b5/frIaJwUVzbRbOtkFGL8cfVBbaT50snBHwXPByorWc+kIDset48L0PKMPjZ4j8lqwL+dXP6G3e46B+4U8uD8pV+uDqJecSIjoFpaFaCA2/OBfpRJMPdZr4tTCarvQQ5YeNVppYhHFU78i+p5e73kugm8Eiczbw/CxrvsbbYspvWb/wbcXaFMuU/zfUtmYst+r+zXslNegdJaPSBpdgLiwoBIODfgLq631r/rVmfE+0THHfwsukgBlmTe+Qa28GXSzfoKx2u+U56UqwYSTjJbE50+vhG+75LFlLCj5r5rljM8edxZn0MMXV/Z5F4mKmDZ/gwV7bEmX9GQM13QmRdICD0bRDOK6Jq1cNXDpeoYD5JetEuTEPiwlkwBvrVpzYi8TcXVoNfNS5wTML/h0gjjE7q+DjrRqT+hPnCBDxN7w0bc8Ge4PV5GSSf0rljti/ugrA9phRWD4yH8yTRbSnMgpXjXcL8r+pTuGyUHDlksC+lJzlQIsC5U2vxteTqgGGe/P7cL7glaTf0HQK9WCWT9Cu8msUG+NV28NF2xfPJLQ7Ytot6C00+MCJnvm1jtWBv7OmFcs/pXQ/4SFh0PF0UWZSaOGhuou3JcDFPYhimFWC0L6RblacfQiSmOqjbYBFz4RoRVQo+AnoqxpLB9 2m9nDZcB 4qxTh8p3+BM8DflJrrWfLDPehQwYMCA4ni7262pos1JxF5evjDnrjkcGtTTZCiR2YiEJGMIEVsq+KQDl2yrKCW68NYx08We3NuHpt7VY2zYjOmPHIpyORz5PZ56PyQBCVBKwR/7M7i0FNqmr8zr/a+NqM078DrJLpb2jwisotP+/72Z7f+KjY69Cfcx43wF/IeSIZd9iHS1nt5bmTb4+5d5ApfiEsOWKxOQQl9fmzxeSuwQgIJ57WScCnP1ChvBjszAoLv4PPSM1MVt18l8O4n2YrOrD1v5TlZOoYOZRH8Yb/rRz4y+3Sj5sN0AJo9uTRHx+I6C4ky44QVp3/+Hxgmkdxuc679A6QS+FGcqp+sEJDznYSpx0SC/SAkpTVvs81i/ZalZZfe8SBml8qZ1c/CdaH95Yrex6T9fkCv3i/qo3VQ12zadtzL/f4UPUtmDBmpBQhyGDN7RZkSVQwGv8BZ0oIP/wZ3P7Ps85V/Uqj0RpVPVK/Tpt9Sr2JGQSXjWQ8TK/gnajf6+7x4qfAwc4bMH335p4Y766jOY9jLSi3g9PJLjgwd5k4xg0j0cvO33hmlu/OoC8bBAsxd/I7SOCixSmADZayLKGqY9G9Pvj7yaTWDQN0DcQasEFWaIk+o0wTg6oPQ6NOsI1PoAsc0RKOeh6njKHYSX20wdm6b4Gef2JCxwdikpEqOUreHc2vK4EEZ3d+g9Vw696fTLI8Q0xNTiacBMB7vfFvlzQJOObdB7mpnYC59go4cJCcDylLZkK2HGwLYrkLGhNZFT7teEqDSGTiHymG4BP0nwwQdanZOnBL/to7QluNPz6R4OGfu+2KSU7v X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02/11/2024 10:12, Barry Song wrote: > From: Barry Song > > When the proportion of folios from the zero map is small, missing their > accounting may not significantly impact profiling. However, it’s easy > to construct a scenario where this becomes an issue—for example, > allocating 1 GB of memory, writing zeros from userspace, followed by > MADV_PAGEOUT, and then swapping it back in. In this case, the swap-out > and swap-in counts seem to vanish into a black hole, potentially > causing semantic ambiguity. > > We have two ways to address this: > > 1. Add a separate counter specifically for the zero map. > 2. Continue using the current accounting, treating the zero map like > a normal backend. (This aligns with the current behavior of zRAM > when supporting same-page fills at the device level.) > > This patch adopts option 1 as pswpin/pswpout counters are that they > only apply to IO done directly to the backend device (as noted by > Nhat Pham). > > We can find these counters from /proc/vmstat (counters for the whole > system) and memcg's memory.stat (counters for the interested memcg). > > For example: > > $ grep -E 'swpin_zero|swpout_zero' /proc/vmstat > swpin_zero 1648 > swpout_zero 33536 > > $ grep -E 'swpin_zero|swpout_zero' /sys/fs/cgroup/system.slice/memory.stat > swpin_zero 3905 > swpout_zero 3985 > > Fixes: 0ca0c24e3211 ("mm: store zero pages to be swapped out in a bitmap") I don't think its a hotfix (or even a fix). It was discussed in the initial series to add these as a follow up and Joshua was going to do this soon. Its not fixing any bug in the initial series. > Cc: Usama Arif > Cc: Chengming Zhou > Cc: Yosry Ahmed > Cc: Nhat Pham > Cc: Johannes Weiner > Cc: David Hildenbrand > Cc: Hugh Dickins > Cc: Matthew Wilcox (Oracle) > Cc: Shakeel Butt > Cc: Andi Kleen > Cc: Baolin Wang > Cc: Chris Li > Cc: "Huang, Ying" > Cc: Kairui Song > Cc: Ryan Roberts > Signed-off-by: Barry Song > --- > -v2: > * add separate counters rather than using pswpin/out; thanks > for the comments from Usama, David, Yosry and Nhat; > * Usama also suggested a new counter like swapped_zero, I > prefer that one be separated as an enhancement patch not > a hotfix. will probably handle it later on. > I dont think either of them would be a hotfix. > Documentation/admin-guide/cgroup-v2.rst | 10 ++++++++++ > include/linux/vm_event_item.h | 2 ++ > mm/memcontrol.c | 4 ++++ > mm/page_io.c | 16 ++++++++++++++++ > mm/vmstat.c | 2 ++ > 5 files changed, 34 insertions(+) > > diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst > index db3799f1483e..984eb3c9d05b 100644 > --- a/Documentation/admin-guide/cgroup-v2.rst > +++ b/Documentation/admin-guide/cgroup-v2.rst > @@ -1599,6 +1599,16 @@ The following nested keys are defined. > pglazyfreed (npn) > Amount of reclaimed lazyfree pages > > + swpin_zero > + Number of pages moved into memory with zero content, meaning no > + copy exists in the backend swapfile, allowing swap-in to avoid > + I/O read overhead. > + > + swpout_zero > + Number of pages moved out of memory with zero content, meaning no > + copy is needed in the backend swapfile, allowing swap-out to avoid > + I/O write overhead. > + Maybe zero-filled pages might be a better term in both. > zswpin > Number of pages moved in to memory from zswap. > > diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h > index aed952d04132..f70d0958095c 100644 > --- a/include/linux/vm_event_item.h > +++ b/include/linux/vm_event_item.h > @@ -134,6 +134,8 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, > #ifdef CONFIG_SWAP > SWAP_RA, > SWAP_RA_HIT, > + SWPIN_ZERO, > + SWPOUT_ZERO, > #ifdef CONFIG_KSM > KSM_SWPIN_COPY, > #endif > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 5e44d6e7591e..7b3503d12aaf 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -441,6 +441,10 @@ static const unsigned int memcg_vm_event_stat[] = { > PGDEACTIVATE, > PGLAZYFREE, > PGLAZYFREED, > +#ifdef CONFIG_SWAP > + SWPIN_ZERO, > + SWPOUT_ZERO, > +#endif > #ifdef CONFIG_ZSWAP > ZSWPIN, > ZSWPOUT, > diff --git a/mm/page_io.c b/mm/page_io.c > index 5d9b6e6cf96c..4b4ea8e49cf6 100644 > --- a/mm/page_io.c > +++ b/mm/page_io.c > @@ -204,7 +204,9 @@ static bool is_folio_zero_filled(struct folio *folio) > > static void swap_zeromap_folio_set(struct folio *folio) > { > + struct obj_cgroup *objcg = get_obj_cgroup_from_folio(folio); > struct swap_info_struct *sis = swp_swap_info(folio->swap); > + int nr_pages = folio_nr_pages(folio); > swp_entry_t entry; > unsigned int i; > > @@ -212,6 +214,12 @@ static void swap_zeromap_folio_set(struct folio *folio) > entry = page_swap_entry(folio_page(folio, i)); > set_bit(swp_offset(entry), sis->zeromap); > } > + > + count_vm_events(SWPOUT_ZERO, nr_pages); > + if (objcg) { > + count_objcg_events(objcg, SWPOUT_ZERO, nr_pages); > + obj_cgroup_put(objcg); > + } > } > > static void swap_zeromap_folio_clear(struct folio *folio) > @@ -507,6 +515,7 @@ static void sio_read_complete(struct kiocb *iocb, long ret) > static bool swap_read_folio_zeromap(struct folio *folio) > { > int nr_pages = folio_nr_pages(folio); > + struct obj_cgroup *objcg; > bool is_zeromap; > > /* > @@ -521,6 +530,13 @@ static bool swap_read_folio_zeromap(struct folio *folio) > if (!is_zeromap) > return false; > > + objcg = get_obj_cgroup_from_folio(folio); > + count_vm_events(SWPIN_ZERO, nr_pages); > + if (objcg) { > + count_objcg_events(objcg, SWPIN_ZERO, nr_pages); > + obj_cgroup_put(objcg); > + } > + > folio_zero_range(folio, 0, folio_size(folio)); > folio_mark_uptodate(folio); > return true; > diff --git a/mm/vmstat.c b/mm/vmstat.c > index 22a294556b58..c8ef7352f9ed 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -1418,6 +1418,8 @@ const char * const vmstat_text[] = { > #ifdef CONFIG_SWAP > "swap_ra", > "swap_ra_hit", > + "swpin_zero", > + "swpout_zero", > #ifdef CONFIG_KSM > "ksm_swpin_copy", > #endif