From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3A79C636CC for ; Mon, 20 Feb 2023 07:15:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F8976B0071; Mon, 20 Feb 2023 02:15:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A8EB6B0072; Mon, 20 Feb 2023 02:15:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16F586B0073; Mon, 20 Feb 2023 02:15:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 077EC6B0071 for ; Mon, 20 Feb 2023 02:15:43 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AA9AB1C66E0 for ; Mon, 20 Feb 2023 07:15:42 +0000 (UTC) X-FDA: 80486810124.29.ACECF5C Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by imf17.hostedemail.com (Postfix) with ESMTP id B262E4000E for ; Mon, 20 Feb 2023 07:15:39 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=HjkC4gWA; spf=pass (imf17.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=reject) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676877340; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/YHlcXC7ADVnX6vpWwthDRmPGtTHi6/3jLQTSKh4i5M=; b=Qq9yqPZ2B8ANvFUS+VraiI+xZ5nfk2lK3pwUFpy0W0Jlv7NcWjOZ+EI0+9HxNQm6lu6FcH kpWBM2VmlGZg53gTlULSCpbNTDKf3sSnwRpVfYuPXd1i0rQnhPVbSXDiS8jCRHqBpk/25c MiwXUqnEIvxv8a9ELHihAePSpp1Am/g= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=HjkC4gWA; spf=pass (imf17.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=reject) header.from=collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676877340; a=rsa-sha256; cv=none; b=iuEIQ2aTEFUiLr7zrZSIpZ2NdRZ91KxZS4SaQr0xG5N1ux05HbRJebIhTNBZpj8f2Teh/B h4zt3Lz6qlDOLGv5q2+zO08ndgXxqhYfxSSrERoFj3Ub+aLRXQ2r9PQKr+mkwC98sFKcKG fXpCHb8YzJR/lGfp9O3u0ULMTLMzaqg= Received: from [192.168.10.12] (unknown [39.45.217.110]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id CCAC666018CA; Mon, 20 Feb 2023 07:15:35 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1676877338; bh=GaQ8q2yWSZQVknoEXEBxDV7yMaL3s3t9rakelGBhOcE=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=HjkC4gWARwV/Y2CWqKu5d+rvsEnEpgscgjDG/HyIP2DHTKGEW+5At98iXUeK5HhRD D4vHLtbia8rysGOjxHU5i2gKLiaiU/3OxoTV1Ua/AxNYMUhPv0Pv5k2Gbs6WaYLxkM aLO/rnyGiIAbW+o0wnJbq3Q5hg9PZuNKVLLQ6RCrnghGyNEqkE3JWLEMlsrCjdy6qc 45ehs4WqNLkZTXuw6dOI3v0NHKNXgdQyLJ76YAvQRJ9CfiT1OUIinBGXWoVxrbp55C ect//Zrm/QOabtJf+Y/keo3xeH1+iEZv0mdqO0l2CFG4cn/lEsWtFeMTGI+qHsTf3f KHtEIKQV2nQ5w== Message-ID: <6bdd805d-6a99-a1d5-f376-3d2d0c915d38@collabora.com> Date: Mon, 20 Feb 2023 12:15:31 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Cc: Muhammad Usama Anjum , David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Axel Rasmussen , Mike Rapoport , Andrew Morton , Andrea Arcangeli , Nadav Amit Subject: Re: [PATCH] mm/uffd: UFFD_FEATURE_WP_ZEROPAGE To: Peter Xu References: <20230215210257.224243-1-peterx@redhat.com> <7eb2bce9-d0b1-a0e3-8be3-f28d858a61a0@redhat.com> <4f64d62f-c21d-b7c8-640e-d41742bbbe7b@redhat.com> <456f8e2e-9554-73a3-4fdb-be21f9cc54b6@redhat.com> <427298c4-0da9-059f-02ff-c5147d317c87@collabora.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B262E4000E X-Stat-Signature: am76jdtg5j449yhgmahcj69cbqnjc91i X-HE-Tag: 1676877339-864382 X-HE-Meta: U2FsdGVkX193KBPHAjfO3GsC48AyVV1QzDhd8L3fyHno+Fce2gjvuYQ2Z4qkjhKuwXSIyJxRt8v0tjSchDGcvI5epIlTXvQ12IgtVFF4iJjkFkh/K5j9IIqi4OyZgf57TcGzfTw2DjMTHgC4TkjASXXMnW6Byf1K7tk+lVTTVIjtRerLhx78/HzHsJOeLPHPcqENEdJrnB694XuHt287euRV7qPwlUvxr3ahvz37b1CQfGzFdBgTcHfUbupevyrjF7OqJMS8oIudXLhl9tCTUaCpivGCPQFio4mZupqph/BjHoQsp7dAAHnqledCcHFSn45z4a12bE1IVpEy73424ySfxmTpSLTwt1aob6jKkCX9OyJUPQzIf8FlLLTYZbGQI3UPNqoxq2KJc5KtuvPkiXOptMUKQ+sqZYfyzUZRn2dM4AIB1NQbclfDFMh2iBSnyu/ZawAODeTns0BDtwEPJdl+ISyotGEx244+55qGFHYpeeNhl23qryRMyGv8HuT4jUyRyo+Ij9kmonFWxFJRkq8yOPdeT9KiWQjwjF8Qc7VMNMM7SWbZMI6M9cUpjk3Mzx8XvPdIfZg/sZIAM3XGalZQJLs5D5uLWl9sGB/hvHurwUoB4og2Qi/eztUBI4JBpP95610vIvUiIkOcBZgoYuKcpUmsDO7uOJ9PIRtIeNvjP2G7ck+TZrvFtBulN2W+heJKnvhI4ochLAto3E7Pf+9ORztSC1oGOH+H8AqR8+7EqUv/LCNbHqToOqSTm0yv9iLYIcozrjRgtgYIip5cKEJUebEcRFJvnbl/6nt9WdiCUkFKfQuWFmpa3jGQbEjgzIuIY4ixtucdPpGalL1mzpijq3jB4i47L1icvnwoK4YrCGAiUvETrw3FsMzQplEyQTq6Z7JG9v0+MLjjzalQszDQgawf4kErDUvyyre6hbqLKrE5xB5cNXQyZGIXjYvgNzK0HMWWsm7fC4rv88I eihoa8SR CD9+2FzM9fUGGLVbXjcOFDYLobhcJiuj5CAVJrhKdiSpJ8rPjQNPwr4+i3iraKUgBqisEVp/8kiT4l9Kv6NCgn3OuoRq3DfoXNFRFkvHh+8Y8rU2AseAKbin9vLKX7xeQ2cGstFLDPfoXW2kyG2+9SOrc7DpJfX8IEua803XqYCzboyqRE1t4+TMp9Y0PEvG06nB9x+LVW30slWV7PKk8/NYMeqMIvvtgEehnTxgmfhpUVUePGz8ykatjFNaLRoN3R9AhvZItpD+QiU9P3wMYyWnN1n5B35U9zCX3qfPnbrufpKVugq1EMUJm7u/4emDCJA2rhGec3gK/BS4XnplVut1P4Qb63MMkVp+0M54q6xNToTMQn/m08SqtgEH1GsKhZbmGDXwV9+DtIaHPOSA/xMdgZ1STBAdv9xvGGGM3KPR/tufCk+V2DN10lfjqZFoorZ4D X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Peter, Thank you so much for working on this. On 2/18/23 4:10 AM, Peter Xu wrote: > Hi, Muhammad, > > On Fri, Feb 17, 2023 at 05:31:19PM +0500, Muhammad Usama Anjum wrote: >> I've just ran my single threaded selftest [1] over an over again to get >> some numbers. >> >> Without zeropage >> qemu has 6 cores: 26.0355 > > Did you count in the time of read prefault? Or did you not prefault at > all? No, pre-faulting is not being done in both of the runs. Without zeropage, I'm checking pte_none() to decide if page is dirty. With zeropage, I'm just checking if WP flag isn't set to decide if page is dirty. > >> With zeropage >> qemu has 6 cores: 39.203 >> >> 33% worse performance with zero pages >> >> Definitely, there can be better benchmark application. Please let me know >> if I should write better benchmarks on my end. >> >> [1] >> https://lore.kernel.org/all/20230202112915.867409-7-usama.anjum@collabora.com > > I'll have a closer look too next week. > > Thanks, > -- BR, Muhammad Usama Anjum