From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6284BC433C1 for ; Fri, 19 Mar 2021 18:59:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DBA9B61931 for ; Fri, 19 Mar 2021 18:59:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBA9B61931 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4F2E26B006E; Fri, 19 Mar 2021 14:59:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 47C166B0070; Fri, 19 Mar 2021 14:59:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CFB86B0071; Fri, 19 Mar 2021 14:59:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0215.hostedemail.com [216.40.44.215]) by kanga.kvack.org (Postfix) with ESMTP id 0D1076B006E for ; Fri, 19 Mar 2021 14:59:21 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B64998771 for ; Fri, 19 Mar 2021 18:59:20 +0000 (UTC) X-FDA: 77937536880.18.530A1BF Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf29.hostedemail.com (Postfix) with ESMTP id 1F0BE3D0 for ; Fri, 19 Mar 2021 18:59:10 +0000 (UTC) Received: by mail-lf1-f48.google.com with SMTP id a198so11566962lfd.7 for ; Fri, 19 Mar 2021 11:59:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8ELWO0rVxFoEW/cBhQY2SU43VC88bV8HiGiltIwNbNU=; b=WSoSWgPZfb6wMXT11SchmcKZBcjgH73N/Lbq4btmZ0Shz9AF5WurjtECp2zeUeXV/U khxjCywE5IlWSlzB+Z+W1UGdhapRnGBi10RNB74adftfCDJH9WmB5hWAUi+ViH9igQPa oKgxRfeJcsMknIqpd6kAPSHBYrAfMGkQUggG7x5gb/hLdC51f9F0WDCAIOCzDEwr6c8s qMEHkbpN3mulJZALdlMb1gCgzdBmS8K0XQqrUD+vteA5cato+QOfmd4E4S7ZmLFbAHSw TXGgfa+W8F5mqI/V/mGxgg68Kkf73FtdcLI317F2ZT4JLuGfDVLHGhba0c5CyBvmaw9R dEDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8ELWO0rVxFoEW/cBhQY2SU43VC88bV8HiGiltIwNbNU=; b=M9TDr5XVl3EhaMxWRGhubZ3182r1pprfTzS6L2DqR/CdNeFUQU960pra8Osf8h/7rt 6z4I9Vjo6k0O6G0tEX8ij56J4CNtlWhQkoitJQC7b5UJ6k651iXCN3F/5cNG+aaYLtBH U0n6Ur66f1Czqp9JFiwmjL+4xH683PpROPKtJgdqQSMIals84riAC1N6FDVwQjsETV8F qL/DrQtT01Y8CerysHUJUf5PCr5OcSLTq/zAtl4Ad0KPpuh4ColaP9bSOkgAkL6eBCmZ kteGrrO/Vhb64JaDjZDtPStJbCV9Z3NycrBlRuMduTQ2XTNpQr91gX90/cMng8+sz2eP rvVg== X-Gm-Message-State: AOAM531VJ+N9CYktPpisuaOCWHjnr84GiO0XbQckJ/OP2klCuPcBSMq9 weiqfc/PsW6OBKn4IjyPDQs= X-Google-Smtp-Source: ABdhPJw8v0oEhuDJ520G3SV0TRU+uI+6hLIpfSKS9xMSBcDku1/MTCCrwStY9n0G+orUdsEfAsedmQ== X-Received: by 2002:a19:ee16:: with SMTP id g22mr1571911lfb.513.1616180349313; Fri, 19 Mar 2021 11:59:09 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-52.dynamic.spd-mgts.ru. [109.252.193.52]) by smtp.googlemail.com with ESMTPSA id x4sm876461ljj.91.2021.03.19.11.59.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Mar 2021 11:59:09 -0700 (PDT) Subject: Re: [PATCH v4] mm: cma: support sysfs To: Minchan Kim Cc: Greg Kroah-Hartman , Andrew Morton , linux-mm , LKML , joaodias@google.com, willy@infradead.org, david@redhat.com, surenb@google.com, John Hubbard , Nicolas Chauvet , "linux-tegra@vger.kernel.org" References: <33ec18ef-8652-643a-1a53-ff7c3caf4399@gmail.com> <78883205-e6da-5bc4-dcec-b6eb921567b1@gmail.com> <72db59eb-75dc-d1ed-7a83-17052e8f22a8@gmail.com> <82bde114-60c0-3fde-43f4-844522b80673@gmail.com> From: Dmitry Osipenko Message-ID: <6bc141d2-ca07-7f03-c306-683f0f630605@gmail.com> Date: Fri, 19 Mar 2021 21:59:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Stat-Signature: xnjqtr64iur1e6bmio9w7n49z7nfpqux X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1F0BE3D0 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf29; identity=mailfrom; envelope-from=""; helo=mail-lf1-f48.google.com; client-ip=209.85.167.48 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616180350-551823 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 19.03.2021 21:18, Minchan Kim =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>> + if (ZERO_OR_NULL_PTR(cma_kobjs)) >>> + goto out; >>> + >>> + do { >>> + cma =3D &cma_areas[i]; >>> + cma->kobj =3D &cma_kobjs[i]; >> Does cma really need are pointer to cma_kobj? > Do you mean something like this? >=20 > struct cma { > .. > .. > struct kobject *kobj; > }; >=20 > Then, how could we we make kobject dynamic model? >=20 > We need to get struct cma from kboj like below. >=20 > static ssize_t alloc_pages_success_show(struct kobject *kobj, > struct kobj_attribute *attr, ch= ar *buf) > { > struct cma_kobject *cma_kobj =3D container_of(kobj, > struct cma_kobject,= kobj); > struct cma *cma =3D cma_kobj->cma; >=20 > return sysfs_emit(buf, "%llu\n", > atomic64_read(&cma->nr_pages_succeeded)); > } >=20 > So kobj should be not a pointer in the container struct. > Am I missing your point? Otherwise, it would be great if you suggest > better idea. I meant that cma_kobj->cma is okay, but cma->kobj wasn't really used anywhere since struct cma can't be released. I.e. we could write kobject_put(&cma->kobj->kobj) as kobject_put(&cma_kobjs[i].kobj); But since we won't use the array anymore and maybe will get back to use the cma_stat, then it will be fine to add the pointer.