From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F53AE67A6B for ; Tue, 3 Mar 2026 06:47:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61E6A6B0005; Tue, 3 Mar 2026 01:47:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CC116B0088; Tue, 3 Mar 2026 01:47:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CB326B0089; Tue, 3 Mar 2026 01:47:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 39B1C6B0005 for ; Tue, 3 Mar 2026 01:47:57 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B7EB059E37 for ; Tue, 3 Mar 2026 06:47:56 +0000 (UTC) X-FDA: 84503821752.10.B52FE0B Received: from fout-b1-smtp.messagingengine.com (fout-b1-smtp.messagingengine.com [202.12.124.144]) by imf02.hostedemail.com (Postfix) with ESMTP id AC66D80010 for ; Tue, 3 Mar 2026 06:47:54 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="AXXg/CFs" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1772520474; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mRH/PWo0ni49zRq5vJ+tSuO3ez7RUwLeHV5wwaIGxBQ=; b=f3Y63YOxoSrsWE22UOySzMIZq4brMxEX3+u8DIrQBaEQW4JdEmpHMbumnaYHbnviJG58I3 BbKeTaTDHi2SnQrOoWxEQuZO6Pu+LwMBtj02YrypWUM4BhjpmEdPMPofDKXQSOJ7I6VXkN Z3AzQidhSwQ4vgG4EFuaUGE8n74LB9Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1772520475; a=rsa-sha256; cv=none; b=3UxKQoakjZw7sQiOR6OuDjL25MiG4kDQsIW7hcVFw1Nk/otrS3bBl6Z2YL0DFkbDHi6z6O Pl3OdqmYqf6KSJc8+5oTMm3gxGI5hKUUSE1VL0nrs2bkR5AD3geGFP8v0vU5yzVNe1kI6a vXEPMiQhDuPeQ87Nzrln9GFoayN9GfQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="AXXg/CFs"; spf=none (imf02.hostedemail.com: domain of fthain@linux-m68k.org has no SPF policy when checking 202.12.124.144) smtp.mailfrom=fthain@linux-m68k.org; dmarc=none Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfout.stl.internal (Postfix) with ESMTP id 3D9DF1D0028F; Tue, 3 Mar 2026 01:47:53 -0500 (EST) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Tue, 03 Mar 2026 01:47:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1772520473; x=1772606873; bh=mRH/PWo0ni49zRq5vJ+tSuO3ez7RUwLeHV5 wwaIGxBQ=; b=AXXg/CFseOA+QHxm0YznyljfnGwkZ8cxJVAsw7zMeVW11jTDhm7 OKN4x+dDzo31n435ccwiD9pTQGULQQW3cBYO/O0df4fhj0oVSpRo8wsa+xBxE9i7 8AObCXKtFEaiH1MR6nixnh552+n/oUcKS2RhWmPjwJCPgAJU4a9OSC66bJzhXGU8 Xd33sBtvtIgyqqqoQpAexyjiuna+WiVu4dTkUbORo2m3Z/lzzglTIJkE4cgTyboG +53fP+DH/qgDKdYmeDETsg0z6NuvUI3rNmiVTP+Gp4TBs4tC03f6huszR8sGpDk5 eToTx19H1KcxID6eaz8HgeGOA5Er0eoS/ZA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddvheelkeelucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevufgjkfhfgggtsehttdertddttddvnecuhfhrohhmpefhihhnnhcuvfhh rghinhcuoehfthhhrghinheslhhinhhugidqmheikehkrdhorhhgqeenucggtffrrghtth gvrhhnpefhhfdtheejlefgieffhffhfeffgfejfeeluedufeeuhfevtdeiheehudfhgeeh ueenucffohhmrghinhepkhgvrhhnvghlrdhorhhgpddtuddrohhrghenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehfthhhrghinheslhhinhhu gidqmheikehkrdhorhhgpdhnsggprhgtphhtthhopeejpdhmohguvgepshhmthhpohhuth dprhgtphhtthhopehnjhgrvhgrlhhisehmrghrvhgvlhhlrdgtohhmpdhrtghpthhtohep rghrnhgusegrrhhnuggsrdguvgdprhgtphhtthhopegrkhhpmheslhhinhhugidqfhhouh hnuggrthhiohhnrdhorhhgpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgv rhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqmhhmsehkvhgrtghkrd horhhgpdhrtghpthhtohepohgvqdhksghuihhlugdqrghllheslhhishhtshdrlhhinhhu gidruggvvhdprhgtphhtthhopehlkhhpsehinhhtvghlrdgtohhm X-ME-Proxy: Feedback-ID: i58a146ae:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 3 Mar 2026 01:47:49 -0500 (EST) Date: Tue, 3 Mar 2026 17:48:48 +1100 (AEDT) From: Finn Thain To: Nilesh Javali cc: Arnd Bergmann , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, oe-kbuild-all@lists.linux.dev, lkp@intel.com Subject: Re: include/linux/compiler_types.h:631:38: error: call to '__compiletime_assert_431' declared with attribute error: BUILD_BUG_ON failed: offsetof(struct qla_tgt_sess_op, atio) + sizeof(u->atio) != sizeof(*u) In-Reply-To: <202603030747.VX0v4otS-lkp@intel.com> Message-ID: <6bc11e2f-393d-16a2-9664-a20e2f1d3767@linux-m68k.org> References: <202603030747.VX0v4otS-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Stat-Signature: 5ox4x67zjq7wkp1gwxyqcnjzngg4tt7u X-Rspam-User: X-Rspamd-Queue-Id: AC66D80010 X-Rspamd-Server: rspam12 X-HE-Tag: 1772520474-241916 X-HE-Meta: U2FsdGVkX18os/a7YoVJKlTQlStj4OtJKyEEKa9c73MHb3Vz1Q05VYWgzxJVhCBAQfuua+LTvYMJo2bBaLY1/EqquVlsTcxlPRyQrScZm0Pk2Gzcwr2DLt78KN4KLOZCeGnr/HvjwSA2G8kXCDHxpghSrH4XIc9d7ndRSqu03QR1XumxQQuEqbpPB8GIrNfYFKCtVAjsW59jfexrEA/kdmiRIoqKEqVHplSGpLtnXUvgq2RQqxlARjMnBGxYautIMdMZKI0hHUmlQx5BeEVRvqU51tcxYfa/+gFXwn5WQyEPYNprjPBs4Sli3J36fLXoxXTsCshDgeN6Wyf/oL0U1jmU8Vqrs3973oXniVmzJWaWMhqmrpm+lYHa1R7h/kXD7868ADPquzoVnJpFO3AbsTR6oAsPUQ4o/7R15WhYjwhI4VwqlBunE9ZWajgI3WrYvWwDwGyneartdfRZM94m1SR+pPXshKjn0OoBBR7Kpdm3DmDvXUGCehZSwyBFl1oarCscGM4qhGp8oTEp+lAfAjTCcU7YMSHPGy3hyRixZK/OlO31jXZnUfDBhvGo6JBeAPRRU//VPo1ZhHAKCdWlGuwvX6IqwWYvOIFzhzRQ6o11ptWae5P1SIO5ZSNvp5gcP46BQoRuuUeqnt4L1OHZLsKHICC16SMb0thWKc+Lxrl3qC+nmeIek1gASCPsN/kzQOfw5azB+hRizR4SMgSFN2y7jUkOrvRla61qBAIJnU3lBChfemrrMvzoEJrNLx6S9XE6eQUFCECCJnyupKLbg2MNDsbBnQWayt7LrB3zt/0Jgjct/Wc6uwV1kCWIca7hfeTtbYBOz5Zcd912Z9DOrxYA6TSjdjin20Y1ubaPuAt/vxDjG4W0V1OiZEexMo2rrwzthtGNUhSJuZ96V6L71hwgUjZZxWVdQKyrBrtizXqXcMrBJiaSI5JKVql3Nl9nXl/C0VZahr6dvNX0jvp 4G5W5FGB kkxP2iVu/O3UOwmOAoBb8LLwzXQicNE90TAPCvBhJ855EShZL/KfxWgSd0ebIQIQAA7GjUZsqD7EQfFXlYGtB4gd0ocLo7x4qDEgMQITXWvuZGgAa+WVVrtndlCUxG07AL6/8kWufmpYgcoWKCIXp2iAbwcfDeO7QTvyBDecI8G5eEYt6P9kR4nbl3JVPCD9tjjPQPixaD8gHkTZTrSd3G9YhxSwepV+6y9nlVK8+/tVxSjzDz9SIlvC+Fjz9RqNwQX/M1fyQHCQTB1R8+78FTX7r9A8FnKnUSSvxfM2d/upwlQAel5+3xwPTsaj/6/CHx4ENoAdoIw8R6axQgz4cWxxTVMRVw/cf7r7GZqhY9VEg4mKpwlVi3TcHycbMwwKTy5URcf6bUu7GlAVZYfr/AqR3pWujXman+CNpVWAgGI3EIc6t3Bw9c/zubQ== Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 3 Mar 2026, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > head: af4e9ef3d78420feb8fe58cd9a1ab80c501b3c08 > commit: e428b013d9dff30f7a65509e33047ba975cce8ba atomic: specify alignment for atomic_t and atomic64_t > date: 5 weeks ago > config: m68k-randconfig-r133-20260303 (https://download.01.org/0day-ci/archive/20260303/202603030747.VX0v4otS-lkp@intel.com/config) > compiler: m68k-linux-gcc (GCC) 8.5.0 > sparse: v0.6.5-rc1 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260303/202603030747.VX0v4otS-lkp@intel.com/reproduce) This config is an unlikely one (fibre channel storage with a coldfire processor) which is probably why 'make randconfig' was needed in order to expose the problem. It's essentially a theoretical bug but I will try to patch it anyway. What's happening here is that the patch that naturally aligned atomic_t caused some new padding to appear at the end of this struct: --- a/pahole.out +++ b/pahole.out @@ -1,16 +1,18 @@ struct qla_tgt_sess_op { struct scsi_qla_host * vha; /* 0 4 */ uint32_t chip_reset; /* 4 4 */ - struct work_struct work; /* 8 16 */ + struct work_struct work __attribute__((__aligned__(4))); /* 8 16 */ struct list_head cmd_list; /* 24 8 */ bool aborted; /* 32 1 */ /* XXX 1 byte hole, try to pack */ struct rsp_que * rsp; /* 34 4 */ struct atio_from_isp atio; /* 38 64 */ - /* size: 102, cachelines: 2, members: 7 */ + /* size: 104, cachelines: 2, members: 7 */ /* sum members: 101, holes: 1, sum holes: 1 */ - /* last cacheline: 38 bytes */ -}; + /* padding: 2 */ + /* forced alignments: 1 */ + /* last cacheline: 40 bytes */ +} __attribute__((__aligned__(4))); The BUILD_BUG_ON assertion checks the size of the struct, which doesn't seem right, because any padding at the end of the struct does not interfere with the subsequent kzalloc() and memcpy() in qlt_queue_unknown_atio(). I suppose the assertion could be motivated by some code elsewhere but I haven't yet found it. So perhaps the assertion can simply be removed. An alternative solution could be to increase the 1 byte hole to 3 bytes, and prevent tail padding that way. But padding should be irrelevant to the real requirement -- struct qla_tgt_sess_op { struct scsi_qla_host *vha; uint32_t chip_reset; struct work_struct work; struct list_head cmd_list; bool aborted; struct rsp_que *rsp; struct atio_from_isp atio; /* DO NOT ADD ANYTHING ELSE HERE - atio must be last member */ }; And yet, there's already a precedent in this driver for padding a struct in order to satisfy a BUILD_BUG_ON -- struct atio7_fcp_cmnd { uint64_t lun; uint8_t cmnd_ref; uint8_t task_attr:3; uint8_t reserved:5; uint8_t task_mgmt_flags; #define FCP_CMND_TASK_MGMT_CLEAR_ACA 6 #define FCP_CMND_TASK_MGMT_TARGET_RESET 5 #define FCP_CMND_TASK_MGMT_LU_RESET 4 #define FCP_CMND_TASK_MGMT_CLEAR_TASK_SET 2 #define FCP_CMND_TASK_MGMT_ABORT_TASK_SET 1 uint8_t wrdata:1; uint8_t rddata:1; uint8_t add_cdb_len:6; uint8_t cdb[16]; /* * add_cdb is optional and can absent from struct atio7_fcp_cmnd. Size 4 * only to make sizeof(struct atio7_fcp_cmnd) be as expected by * BUILD_BUG_ON in qlt_init(). */ uint8_t add_cdb[4]; /* __le32 data_length; */ } __packed; So I'm undecided. Any thoughts, Nilesh? > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202603030747.VX0v4otS-lkp@intel.com/ > > All errors (new ones prefixed by >>): > > In file included from : > In function 'qlt_queue_unknown_atio', > inlined from 'qlt_24xx_atio_pkt_all_vps' at drivers/scsi/qla2xxx/qla_target.c:331:4, > inlined from 'qlt_24xx_process_atio_queue' at drivers/scsi/qla2xxx/qla_target.c:7903:4: > >> include/linux/compiler_types.h:631:38: error: call to '__compiletime_assert_431' declared with attribute error: BUILD_BUG_ON failed: offsetof(struct qla_tgt_sess_op, atio) + sizeof(u->atio) != sizeof(*u) > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) > ^ > include/linux/compiler_types.h:612:4: note: in definition of macro '__compiletime_assert' > prefix ## suffix(); \ > ^~~~~~ > include/linux/compiler_types.h:631:2: note: in expansion of macro '_compiletime_assert' > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) > ^~~~~~~~~~~~~~~~~~~ > include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' > #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) > ^~~~~~~~~~~~~~~~~~ > include/linux/build_bug.h:50:2: note: in expansion of macro 'BUILD_BUG_ON_MSG' > BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) > ^~~~~~~~~~~~~~~~ > drivers/scsi/qla2xxx/qla_target.c:216:2: note: in expansion of macro 'BUILD_BUG_ON' > BUILD_BUG_ON(offsetof(struct qla_tgt_sess_op, atio) + sizeof(u->atio) != sizeof(*u)); > ^~~~~~~~~~~~ >