From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00826C7115A for ; Tue, 17 Jun 2025 09:49:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93E6B6B00A4; Tue, 17 Jun 2025 05:49:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 915666B00A5; Tue, 17 Jun 2025 05:49:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 804676B00A6; Tue, 17 Jun 2025 05:49:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 719636B00A4 for ; Tue, 17 Jun 2025 05:49:29 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2B3E91D77CA for ; Tue, 17 Jun 2025 09:49:29 +0000 (UTC) X-FDA: 83564420058.11.4136CD4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id D4E74140008 for ; Tue, 17 Jun 2025 09:49:26 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iBErrbNK; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750153766; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lg0mFUm80r9X0igLB1pMrSxygF5fgmEE/5oZN4jlRBc=; b=19QyOvLTKo2wm1FGKDN39ipVlWyTgA0N1wlbLFK6RGIOs9l7wbCOIRo4AXH/p1imCaDWPR hkDStJ+m7vIQ+UVcSGJeiK5eGkvI7ac5upMVRg3F7qR5sZH7wzfTYjBSwpzgHTV/6olOb8 kP6sxd0jSXucYwNcqUjQbfzvJLQ5RuQ= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iBErrbNK; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750153766; a=rsa-sha256; cv=none; b=Bv0QmM8HWacnetIQMQ2CpYnj+Zy2+Pm3DymvTUR0o1S1z1sLqMphayHyF2jcixAG7mpS6O q0talp2sP+kcuzr5xW+6JOG1zXk8BLFt4oxXX8LLk5eu8ezyO9Li8MhX3o2xWCE2KgCfvO TqPtPKvHNI0INLeOBxcxiRokLjqXO/s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750153766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=lg0mFUm80r9X0igLB1pMrSxygF5fgmEE/5oZN4jlRBc=; b=iBErrbNKlmtjetKK+iFsXDU57pjKmN8U3pGYIv4v288qM9jnzGlUBJj4X1I0g91iyNUjsV auikdCYW7W9It5DVCkwPMPKKlXy3nQusvu5Ox+M71OL+521oFtUommxGp1QlFOUlm5Lm9Z TZ4MXgXDAldQiIstu/jB37+vjTcprs0= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-478-RzRokj6mP9a-VhsMctwSZg-1; Tue, 17 Jun 2025 05:49:24 -0400 X-MC-Unique: RzRokj6mP9a-VhsMctwSZg-1 X-Mimecast-MFC-AGG-ID: RzRokj6mP9a-VhsMctwSZg_1750153763 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4535011d48eso9257495e9.3 for ; Tue, 17 Jun 2025 02:49:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750153763; x=1750758563; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=lg0mFUm80r9X0igLB1pMrSxygF5fgmEE/5oZN4jlRBc=; b=T+JAjARFmqDoaNVEEnPOWRpUgmt7mp1xDCIOEYts2MSiemPkLTvAzVK/mPxzghh70B vnoZBQ95Y2QdCR4Ho+we6q6sf6wL0SnmQoprjBTA6OGemtofBejSylKmHArUvj4XasWW 4icH05w93n0BRbQHeVY7/+fau8Nhx972oHxC2mZZLGEOEMUwXh8aVdK8bl4HorZYnKng vpxqEwoht5mKXKzZPFGlFNPJrupxvU32pYN/QMLTqpH6rP0pNBsPQAADz4KU/pgCyfM+ 7GV47NqLQDwmSwwW8r6GkXAqYGjiYoVDWA7XNBxQE9E8k0AGFKX0nOseS/CThh22mxll emwA== X-Gm-Message-State: AOJu0YxXGEUQvZFqlZYGLekSAvwGxb3d9UVogVjtby9GLepMolItAWe3 WWWglI9XxbhaHb7cmdtXLmj8PPnvXFdSLCh++T5hfwVTu2EBYwflnZ6fk6dvagJbNT5BgPE2Ze3 hBwIMQlMzvbvKlm+nzwR8TJJE5T9HkxUxZbD7dVFNtCif3AiA2YVi X-Gm-Gg: ASbGncu5Yji4ybaqC6DFeiCx4h45TFx/upixzHosaC1sqOskElfd+qhqEbuuUjd6lwj gg4fVYtBDDoZje2jxcMYzZtmYvkYW9P6HM8lrW247zw0IFx8ASqjjPFzmyl33N4wSkm49vzFn6I MrjOOHQV8YAD89os6GRNwdFlEffsjExjtDYlh9QCrnF614hreAy53olAERxIad9LG5Wv1rZGfex JyDrrbKJmAmJLMbKvJnbLBW2FcixMPmWrpbpYUo73RnVw87CkMGHapTF548xYporTC6hbDNkN+0 Vaya9SuoaM4AHe7AdUcWPzawgh5snM9CyGqUnaL31BnkTX1DvC0tTaW4yrEOMw71DXD5MeXZbhx /XVDkX/5TPHPByo2G5X4U62ha9GKFWPuZUrcI5rn0x9n1SIs= X-Received: by 2002:a05:600c:8b66:b0:43d:1b74:e89a with SMTP id 5b1f17b1804b1-4533ca71c4cmr120176355e9.9.1750153763453; Tue, 17 Jun 2025 02:49:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFXZNQ8PD9qufR5L3UGiEianFrRGislf+YnSmpb1KcTqInns51iN3qzkWWM7hMwKXRBlIkEGg== X-Received: by 2002:a05:600c:8b66:b0:43d:1b74:e89a with SMTP id 5b1f17b1804b1-4533ca71c4cmr120175955e9.9.1750153763021; Tue, 17 Jun 2025 02:49:23 -0700 (PDT) Received: from ?IPV6:2003:d8:2f31:700:3851:c66a:b6b9:3490? (p200300d82f3107003851c66ab6b93490.dip0.t-ipconnect.de. [2003:d8:2f31:700:3851:c66a:b6b9:3490]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a578510edcsm9430995f8f.8.2025.06.17.02.49.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Jun 2025 02:49:22 -0700 (PDT) Message-ID: <6bb233ef-5e56-4546-b571-6a5f052d8b45@redhat.com> Date: Tue, 17 Jun 2025 11:49:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 06/14] mm/huge_memory: Remove pXd_devmap usage from insert_pXd_pfn() To: Alistair Popple , akpm@linux-foundation.org Cc: linux-mm@kvack.org, gerald.schaefer@linux.ibm.com, dan.j.williams@intel.com, jgg@ziepe.ca, willy@infradead.org, linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, zhang.lyra@gmail.com, debug@rivosinc.com, bjorn@kernel.org, balbirs@nvidia.com, lorenzo.stoakes@oracle.com, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-cxl@vger.kernel.org, dri-devel@lists.freedesktop.org, John@Groves.net, m.szyprowski@samsung.com References: <67bc382c49ed8b165cfbd927886372272c35f508.1750075065.git-series.apopple@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <67bc382c49ed8b165cfbd927886372272c35f508.1750075065.git-series.apopple@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: wuM5cQc04WaW2FyfUx60ucnPV_NP1hEzsc3GiAP-93I_1750153763 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D4E74140008 X-Stat-Signature: zic81tujqkdt4xzosufw37ewxju34jib X-Rspam-User: X-HE-Tag: 1750153766-74188 X-HE-Meta: U2FsdGVkX1+dxlSmwIXcqtbNSNPO7h2c3i8akVq+1ZRggSUGMBluSnhIUMcZ9Sa7WA8Wdqdp2MVz1mpc9IpTeNKEezZxBB01jiQA4r7xevha4MgUGStpUBcmZ4jUFPzs65QpC/qUgS25fIhxGjAgq0Zmd9DsOTTJJOtwWEjL0wzO57RBPUFG2+7qpP3MbmOxd9j99YbY6+6MOAp951/oOtF+9GSBzFYATzAObojvu+fB9XBsgZAD97XJfetAh+8xfrKWea6tjMJGxl5UUkBBoX1moDNReKGEKtxQzdSDahTVByiv6iA1qAFKCytiU5jkcBEYvgbIZkDoUxutlJkoYi/lw6vTol5ElVN0B/HJPb2tdmqKhzse6E11lxles7sgAtUZllHFZ5R40tiuZatVtzcZ8dbEdWKmmng+XUbq8ru3H8VCNMk9ykr957mivUaO+aG6RPYrDo/Nyp6ZMHFk6LEmmgm8JkbOk41sX+Bc0ud3Vj/TK0R+rrJSevNkHURdpjiTAWW6G3/HEghTW9QeuKgW4co7Obow7ZcC2sViC6V6clYMkMRMaTdXU7VaXks4ZmqG5NnQP6jfiftOFX2thwJoiX45iNcv7MPw/IiXF1ztn2quUinxTKqa/YdGHQTdYBti6Sn+nCIuNDguyAXZ0X8NWlGdmWYYcw9xN5ZUoeNW25nn3AfpVXUrF3S2D7YeDKs10c31vKknJe8UDyOiRWQIr7uHm3H6hMIBFWzNIN/J5bGj2QGoEjbhiCOLLQiM4cz1r1u/k3lwcQv0VAJktZ9MBSYmf47sE0MFhMYGM/89NrEZdSblIuRYwztQ2Chl8ICJolABsr6F5kv7yIOnVlt2D4yzt8BylbyaQrITO/rjCwY6B76xmHvwRVg2Mj643oevl4pRsBAtSqA0svvRh1NwBaHvTOQ4eNFmi5thpSjZkt17TSavHONnX97kg5lBDhREaPfRL1LW+yVcC73 KHwZu+p5 ylIpmvFxlP46LrAotuoY7KHGCQ4heq5rvT7Gy263loCTigqhVRZFn7YHqLz+xz99Dw2Cvd4z0JmA3iTNKf4QSmu5K2a08HnJTZ7FmQVAE0tU9X8MFoNG0VOENdZNKwRm4uE+OmsLhB8wtIYf0A3LRxTQ01nlVme8jFJyH3oshJ3/jnV8J3c4Agv9PD0NLZAmzSajecuqRuwM2yWZnIzX+UHxfA+IfOKZbDG1Fzu1NfvwwBrb0ny2km9P8YqgSON64by2uNEVyKwvVC9Waaglio6lCJMPE8Pk7QcU4Q6eo9JgcSB+lYsvvu75nL9fHSJ0+EVun44H4jQzwNymkB0SgktPiVAmOhGMvYTs9ZMwPCe8mho+6qwBtMy2MIXUbnPR7OY8c6FZcq1n2qhpCl8idwxeFPqJzzEMdguupk+TVBPq85VzTVbwKGuFd12+09zJH2kIDBdgMrzbpfzkF0Unw35m8VuWk4VMAiCtar5WPjcBKQXdqzRW389KdokO/dqGuDqNUZcgs2YoP0LBsCBkFnmXn/Rw69XQJ5xTiHMVWD0PLRUA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.06.25 13:58, Alistair Popple wrote: > Nothing uses PFN_DEV anymore so no need to create devmap pXd's when > mapping a PFN. Instead special mappings will be created which ensures > vm_normal_page_pXd() will not return pages which don't have an > associated page. This could change behaviour slightly on architectures > where pXd_devmap() does not imply pXd_special() as the normal page > checks would have fallen through to checking VM_PFNMAP/MIXEDMAP instead, > which in theory at least could have returned a page. > > However vm_normal_page_pXd() should never have been returning pages for > pXd_devmap() entries anyway, so anything relying on that would have been > a bug. > > Signed-off-by: Alistair Popple > > --- > > Changes since v1: > > - New for v2 > --- > mm/huge_memory.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index b096240..6514e25 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1415,11 +1415,7 @@ static int insert_pmd(struct vm_area_struct *vma, unsigned long addr, > add_mm_counter(mm, mm_counter_file(fop.folio), HPAGE_PMD_NR); > } else { > entry = pmd_mkhuge(pfn_t_pmd(fop.pfn, prot)); > - > - if (pfn_t_devmap(fop.pfn)) > - entry = pmd_mkdevmap(entry); > - else > - entry = pmd_mkspecial(entry); > + entry = pmd_mkspecial(entry); > } > if (write) { > entry = pmd_mkyoung(pmd_mkdirty(entry)); > @@ -1565,11 +1561,7 @@ static void insert_pud(struct vm_area_struct *vma, unsigned long addr, > add_mm_counter(mm, mm_counter_file(fop.folio), HPAGE_PUD_NR); > } else { > entry = pud_mkhuge(pfn_t_pud(fop.pfn, prot)); > - > - if (pfn_t_devmap(fop.pfn)) > - entry = pud_mkdevmap(entry); > - else > - entry = pud_mkspecial(entry); > + entry = pud_mkspecial(entry); > } > if (write) { > entry = pud_mkyoung(pud_mkdirty(entry)); Why not squash this patch into #3, and remove the pmd_special() check from vm_normal_page_pmd() in the same go? Seems wrong to handle the PMD/PUD case separately. But now I am confused why some pte_devmap() checks are removed in patch #3, while others are removed in #7. Why not split it up into (a) stop setting p*_devmap() and (b) remove p*_devmap(). Logically makes more sense to me ... :) -- Cheers, David / dhildenb