From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD03EE77188 for ; Tue, 14 Jan 2025 20:32:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B8AA280005; Tue, 14 Jan 2025 15:32:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 64177280004; Tue, 14 Jan 2025 15:32:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 492AD280005; Tue, 14 Jan 2025 15:32:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 228B3280004 for ; Tue, 14 Jan 2025 15:32:07 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C7B571A0D90 for ; Tue, 14 Jan 2025 20:32:06 +0000 (UTC) X-FDA: 83007204252.14.14F942D Received: from flow-b6-smtp.messagingengine.com (flow-b6-smtp.messagingengine.com [202.12.124.141]) by imf25.hostedemail.com (Postfix) with ESMTP id A71F7A0015 for ; Tue, 14 Jan 2025 20:32:04 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=coelacanthus.name header.s=fm3 header.b=FUu2prLJ; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="D FgmAYn"; dmarc=pass (policy=quarantine) header.from=coelacanthus.name; spf=pass (imf25.hostedemail.com: domain of uwu@coelacanthus.name designates 202.12.124.141 as permitted sender) smtp.mailfrom=uwu@coelacanthus.name ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736886724; a=rsa-sha256; cv=none; b=HfQaQ/ZW98s/2lUYr1uH7MFnfYSwSZDde7aV3ZlQpvrNzFX/5X1uzpnhVoSKw0y2XObT4m 3fgp+NF5E60GWucrP86qLmxkeuADtqquBuQiwnlk7gpd8Iu/a1zepshp+4Ca9Tv7uwBiRq el58ImMuxiltsV8CmoGupoAo3/9vVwY= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=coelacanthus.name header.s=fm3 header.b=FUu2prLJ; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="D FgmAYn"; dmarc=pass (policy=quarantine) header.from=coelacanthus.name; spf=pass (imf25.hostedemail.com: domain of uwu@coelacanthus.name designates 202.12.124.141 as permitted sender) smtp.mailfrom=uwu@coelacanthus.name ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736886724; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k3aK0yvw6s3XgHhobmGdwD1q9qT+ce2iJbSudHfZEug=; b=ZW34AAgDXl+c/0/3ZNNt73zczDsvQldMoKCjlGwHH166KOrac59jJQ/CdjdLtBEWQ/loHF WbpPOP9vYCKimUHYNGb8dbhZ2oCISKXTzOOoLql/MOMZVmsYikWSnIqbS0tH8iRtzYWsSb N9U9l4jUCXjqyTT9jfL/hqK2cQnYccM= Received: from phl-compute-04.internal (phl-compute-04.phl.internal [10.202.2.44]) by mailflow.stl.internal (Postfix) with ESMTP id 14FC91D40844; Tue, 14 Jan 2025 15:32:03 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Tue, 14 Jan 2025 15:32:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= coelacanthus.name; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1736886722; x=1736893922; bh=k3aK0yvw6s 3XgHhobmGdwD1q9qT+ce2iJbSudHfZEug=; b=FUu2prLJ1is+E6pfAnsUuGSgwu F2PNTmouhWFckCjs7RP2LXWUbMWmQP861AX7k699XzNt+GIDaThA9BaonOyr0wB3 iOBNfyQNFbIzTXgMB3H+ppZH5/W6rQz4weA10Hc/AtNEvIYMKnecZbn8hzNawett e5k0Svbmqo02Pz6x2DLFtXN5gkhamNCZXES/bGFC0DF2EN4wKhon+GiTeaabqU1i tg9/r3WaEzNbr/gjzcLugNmDc7KgTA0ki683cFHSSVDIFnDVWapEVt5HqT3XShYb AWOgP8mq+fdSDaesmeuadnycx3PzjfS93whEaDRwdC8JjUnWS/1yQ+/kDctA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1736886722; x= 1736893922; bh=k3aK0yvw6s3XgHhobmGdwD1q9qT+ce2iJbSudHfZEug=; b=D FgmAYnt5ayLH5wRYBsYb9NOkdf0VuWsBSxpJYNWxtSLbZkROUVUjE98RK+5YnLuS NdNPZ2jddAQkFsSM2L7MbdmZ6TlrfmUB8iA7B4Ha5zgsdlb8zGLyyo+HwfuxR/GE hmxQ2Z2iqyikGW+/td2nta7C6xy2eeIG+5jVs3Xy1RrYPzRbrDDTufXkBp3eaI3R Hw/1e7CpXB3+A3dNpaqxc1vstFlua9yP/s2bbeAU0ltCJ3YR/tf83yvHaE2jQ3cV WJiOYY7lBf2hBuwT4le0zSu3DJYTn8q581pqZRks905uKxgPo/ZDjktp8sORvKjb iOihm+YdBxecJbouyxGVA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudehiedgudefiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfevfhfhjggtgfesthekredttddv jeenucfhrhhomhepvegvlhgvshhtvgcunfhiuhcuoehufihusegtohgvlhgrtggrnhhthh hushdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeefffdujedtleetieffleehjeffudet feeghfdtieeiheevueeggfeuiefgvdekvdenucffohhmrghinhepkhgvrhhnvghlrdhorh hgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepuhif uhestghovghlrggtrghnthhhuhhsrdhnrghmvgdpnhgspghrtghpthhtohepvdeipdhmoh guvgepshhmthhpohhuthdprhgtphhtthhopegthhgrrhhlihgvsehrihhvohhsihhntgdr tghomhdprhgtphhtthhopehlughvsehsthhrrggtvgdrihhopdhrtghpthhtohepohhlvg hgsehrvgguhhgrthdrtghomhdprhgtphhtthhopehprghulhdrfigrlhhmshhlvgihsehs ihhfihhvvgdrtghomhdprhgtphhtthhopehprghlmhgvrhesuggrsggsvghlthdrtghomh dprhgtphhtthhopegvsghivgguvghrmhesgihmihhsshhiohhnrdgtohhmpdhrtghpthht ohepkhgvvghssehkvghrnhgvlhdrohhrghdprhgtphhtthhopehshhhurghhsehkvghrnh gvlhdrohhrghdprhgtphhtthhopegrohhusegvvggtshdrsggvrhhkvghlvgihrdgvughu X-ME-Proxy: Feedback-ID: i95c648bc:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 14 Jan 2025 15:31:53 -0500 (EST) Message-ID: <6bacd2ec-fd86-41c9-b5dc-e14796737b4b@coelacanthus.name> Date: Wed, 15 Jan 2025 04:31:50 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/2] riscv: selftests: Add a ptrace test to verify syscall parameter modification Content-Language: en-GB-large To: Charlie Jenkins Cc: "Dmitry V. Levin" , Oleg Nesterov , Paul Walmsley , Palmer Dabbelt , Eric Biederman , Kees Cook , Shuah Khan , Albert Ou , Alexandre Ghiti , Andrea Bolognani , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Thomas Gleixner , Ron Economos , Andrew Jones , Quan Zhou , Felix Yan , Ruizhe Pan , Guo Ren , Yao Zi , Eugene Syromyatnikov , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= References: <20241226-riscv-new-regset-v4-0-4496a29d0436@coelacanthus.name> <20241226-riscv-new-regset-v4-2-4496a29d0436@coelacanthus.name> <20241226133459.GA30481@strace.io> <2e09aedc-44ba-40e3-ae93-1d6dc21b5eb1@coelacanthus.name> From: Celeste Liu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A71F7A0015 X-Stat-Signature: i939fuk8eynzeznf4iwh46jkfewxqyuc X-HE-Tag: 1736886724-995771 X-HE-Meta: U2FsdGVkX19eQGkQsHLYELQJADO1PtdLhRVgITIbhfXhdWy5yOK/y4JDSXLunuzXeqOMOHmR2/23MsdA5N3FqNHGeNn9coKxMGrD3PdjehDFk/g+cOnvim732TGFJSB9g02JfPNpiWSDtL8L1PgbTykMV+kKEWJ3+rCpIDAmz0zBPaqKm4QSlRXC9FiQBO3qj+NkHpkBPHYXktxzQA3TnYx0F3XyvYfZ5FfJYvneInDLDPTIn9Feb/tb4oq2r1daV4b0pPELUeQCeS+Gi9hUTFnSj7VjFUqNH5qJkTdblUYuM6VqbM6Kn8kpXFEs7OmViRfoHlP88fLWWIsTvCjqx4U8IfLsslwR6wdIt6JLurUiJNXHNsEirO8erQzUiGbZpIEH2hCuRWxdGFG+t/V4NLLfVW4PKByCDGbr+LN9PxrTbggi7G/ANkbgY4c7E/LsIGZmuWK3/itT2HQX7iXJNFhvH46vMnLKuJUX3pjqiPcDedPT45Qoynrika0cQKuI01xrwu2xNdneL2mjvQiCgyFhzkt3vCptrqLa7Y5OwJpfSmNzBpveSBxACwlsr8c4nejSkDvTuFbBap+8nidHtqHs70OQaMnkvdgVTzwpN30WIkUN1tlJ2m9nn7lFqo8y0IG6ajDus8+F1ZxSA7DGrzjO1gHeFIPLCDFDrlm63530tTyzHA2lshUgGARe/hnWfPXrzt6oNdECE0Xs7RSDo9+loqL5FKoTWeHwdp2kDpwRtnMhIOmLYAgFYI0HEcH/GUHvulU/9jVvwpa8DS50DViGw5goNtqaF7/jwfm1wFKKGpTWV5H2g2chox/jUjySuXS602VxASwmfq6leQwri+q7ZCRYNyyRc+u7SagRZCq0ErnmSpEGxXbQRWYBB1Qet286BZb59zRFOKnlT7RZyXkFlnQZQnx3wNOvIZ1y5YIsB08aW0LwW1iTigQcQQletMcKLW61WfsknDPYJoG jLj/ItPf eLJPHNE2fx1BE8C7OdbTCpSLxh0LcOuwrKoyU6S7/TESG9jPEI7GlpsXlOMYeFp9K6puyS7GPDJsbKXtXyvVKV6HIG74PjJAx/q56HQZl00/U/xP0UR2CMoiejyEAgL3pov6HM7TyRrYHZqHfkC6j/ljMdgS/kEcyP4MfpnpZ4lfM3Ynd2Sb7u7xBkRaIIdnottX5xUn//LJUasTXxFbPiC/pYaK+NcBTAmcMA9BRuCB8CJ5snqPeN1IFJ0nfVnr41dKVqXzwqWEP78FZuwL8NaNf0Tqns9yNeO/rPAZTte0Ll2k8VmCVixn1E07Yi2Z2DY7pl3FkVI/0NCSJjChJr1g2fCTrpdCCrPiARMB1VkEKweQI6d+slsRvzxFvvIpq/Erw1WVkhVniRtat56LQbM/yzFKO37+CzM9yrvoIUmzXNC1enS5eGravE1fueQVB1bCU7GdG03uhCkSjtiay+i7DzDUsSmx+MT5XX9YATwbxdkgyCscMXlwTmsvwiWoyvskM2DnyvtOWgTqcVR6Kqcwn2ULF89OnoMZhdIyddCf03FnG8+r+PJg099s7vCkaAVdrxyM6EVZyvKFYy0jmnyF51Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025-01-10 11:34, Charlie Jenkins wrote: > On Thu, Dec 26, 2024 at 11:21:59PM +0800, Celeste Liu wrote: >> >> On 2024-12-26 21:35, Dmitry V. Levin wrote: >>> On Thu, Dec 26, 2024 at 06:52:52PM +0800, Celeste Liu wrote: >>>> This test checks that orig_a0 allows a syscall argument to be modified, >>>> and that changing a0 does not change the syscall argument. >>>> >>>> Co-developed-by: Quan Zhou >>>> Signed-off-by: Quan Zhou >>>> Co-developed-by: Charlie Jenkins >>>> Signed-off-by: Charlie Jenkins >>>> Reviewed-by: Björn Töpel >>>> Signed-off-by: Celeste Liu >>> [...] >>>> diff --git a/tools/testing/selftests/riscv/abi/ptrace.c b/tools/testing/selftests/riscv/abi/ptrace.c >>>> new file mode 100644 >>>> index 0000000000000000000000000000000000000000..023695352215bb5de3f91c1a6f5ea3b4f9373ff9 >>>> --- /dev/null >>>> +++ b/tools/testing/selftests/riscv/abi/ptrace.c >>> [...] >>>> + if (ptrace(PTRACE_GET_SYSCALL_INFO, pid, PTRACE_SYSCALL_INFO_ENTRY, &syscall_info_entry)) >>>> + perr_and_exit("failed to get syscall info of entry\n"); >>>> + result->orig_a0 = syscall_info_entry->entry.args[0]; >>>> + if (ptrace(PTRACE_GET_SYSCALL_INFO, pid, PTRACE_SYSCALL_INFO_EXIT, &syscall_info_exit)) >>>> + perr_and_exit("failed to get syscall info of exit\n"); >>>> + result->a0 = syscall_info_exit->exit.rval; >>> >>> I'm sorry but this is not how PTRACE_GET_SYSCALL_INFO should be used. >>> >>> PTRACE_GET_SYSCALL_INFO operation takes a pointer and a size, >>> and in this example instead of size you pass constants 1 and 2, which >>> essentially means that both syscall_info_entry->entry.args[0] and >>> syscall_info_exit->exit.rval are not going to be assigned >>> and would just contain some garbage from the stack. >>> >>> Also, PTRACE_GET_SYSCALL_INFO operation returns the number of bytes >>> available to be written by the kernel, which is always nonzero on any >>> PTRACE_GET_SYSCALL_INFO-capable kernel. In other words, this example >>> will always end up with perr_and_exit() call. >>> >>> I wonder how this test was tested before the submission. >> >> Oops... It seems I forget sync the code to test board so it runs with the old code... >> The code is completely not tested... >> I'm so sorry for my mistake. >> >> I will correct it and test it carefully later... > > It would be great to get this into 6.14. Let me know if you would like > any help! v5 has been sent. Sorry for delay. My test environment was broken yesterday so I have to spend time to repair it first... https://lore.kernel.org/lkml/20250115-riscv-new-regset-v5-0-d0e6ec031a23@coelacanthus.name/T/ > > - Charlie > >> >>> >>> >>