From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFEF8C25B45 for ; Mon, 23 Oct 2023 19:48:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C5436B0155; Mon, 23 Oct 2023 15:48:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 075846B0156; Mon, 23 Oct 2023 15:48:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E7EFB6B0157; Mon, 23 Oct 2023 15:48:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D902C6B0155 for ; Mon, 23 Oct 2023 15:48:53 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B2068B5D07 for ; Mon, 23 Oct 2023 19:48:53 +0000 (UTC) X-FDA: 81377764146.04.2F783EF Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) by imf17.hostedemail.com (Postfix) with ESMTP id D31F04001B for ; Mon, 23 Oct 2023 19:48:51 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=hsYWCv04; spf=pass (imf17.hostedemail.com: domain of hughd@google.com designates 209.85.128.177 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698090531; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wjX0MTPG3PvWqJGdMc/rfblXRp2Xo1J9VRn/MIM6Ez4=; b=f23lBqVt0g70h8TQBKWngo3AYsuCaFep/2ml1nNt2owuqTIfeUG/KkjOWFe8P48yWLMmws uCimbAAXvj8PX6ZNb719cRFDZqtMVfbfMGVaZ1etTL+VRbzOyJJUU0DEqAAU9qTmuxjU13 5ZGVMNyDKaJt7YrWf41KKDclCeY8o0E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698090531; a=rsa-sha256; cv=none; b=VbH7/+qgZBZF5bvitG0Bi3l2VbAL9mQfMh1OqZqN/YEftv1t/mj/zBhy3RFydybTxJXcKv xv8/vuGR2UJt3M7JP/tLJhY6dprK0iQ3XWr1PIFfbowRcmDQlMddc7+kKzBHNsgTB93Avo dlJBzEkrg0GasRPd8nsJwzyczF2R3Uo= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=hsYWCv04; spf=pass (imf17.hostedemail.com: domain of hughd@google.com designates 209.85.128.177 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-5a7eef0b931so38885067b3.0 for ; Mon, 23 Oct 2023 12:48:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698090531; x=1698695331; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=wjX0MTPG3PvWqJGdMc/rfblXRp2Xo1J9VRn/MIM6Ez4=; b=hsYWCv049hreUxOCK0Es7qdW3EXLboTfLHyxQ24yCWp1LDjDkH2sWtjpBzGdpqA4FE hPs0ARzeLdv2W6I4Yga7FMX3JUuJQHG2vQhQFCYmAvkikDZdrjsq5Z+5Xm5bvggmJyul 0z1t2UVM+8LiFVdSgUOaGRXN7tX3FcXqesoaBmgTHOH1lNKtCEfaC8+t+vILLOr45VoT vYjaJO7q7i4GZhtnevV6TngWo5vmv58Nw2PM4d4X1446BhHdu+yfoEaDziga5RDhYGNS 8U3Q7hDO6XkyCCVlBal7+rHfCOTyuzMtrkF7ZdI/vvXIXtCaMYUIKHoKxlkFJc+LKlv0 MJyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698090531; x=1698695331; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wjX0MTPG3PvWqJGdMc/rfblXRp2Xo1J9VRn/MIM6Ez4=; b=olIHq918ncf06r2EkSKgKBiir7nmjlQz28klQj9B7wmmR2RGlOSp4tD0t2WSgv8eN3 1iA8pwsKKRe3BLQz83JhLHbtsJ3/Q7yW6opKjnniKKbB32Ywsp2RhpjjWdY/F7Fkvwoj KNBjxai18amRreXjg6+35A8kc0isP7Fcg8yTs4EZaisOt0NVL5drPL22HtoF/7/viaGy JXpnzo0PYsE5v20KhAeyEQ7POBYH52tu9eXq2iQ11kn5QzBCM8SWTxyc73PQn4g6B7eh /rEDJnZqx3gkbW0ZQKOFAFc1dipK/A0TeZKdG4NeU+KIjN6mtVI5zLNRWtcUdFB9lBAM JjyA== X-Gm-Message-State: AOJu0YzDUzFTcB6M3x4Z/JtjdRBbKRjvRmbhPoxAKp/qENVJicIvevQX UszHYBjXqPfcvvTmRvM6v1p47Q== X-Google-Smtp-Source: AGHT+IFYKLdrk053cTnoXaOGENG9pRtf7WBSlPFQ6vHTErcVoRWV6bqSTpECx/yl0nSpWdBhZllXow== X-Received: by 2002:a05:690c:f8d:b0:5a8:dbb1:f73b with SMTP id df13-20020a05690c0f8d00b005a8dbb1f73bmr11384273ywb.14.1698090530827; Mon, 23 Oct 2023 12:48:50 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id d136-20020a814f8e000000b005a7d9fca87dsm3354999ywb.107.2023.10.23.12.48.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 12:48:49 -0700 (PDT) Date: Mon, 23 Oct 2023 12:48:38 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Johannes Weiner cc: domenico cerasuolo , Andrew Morton , Hugh Dickins , Andi Kleen , Christoph Lameter , Matthew Wilcox , Mike Kravetz , David Hildenbrand , Suren Baghdasaryan , Yang Shi , Sidhartha Kumar , Vishal Moola , Kefeng Wang , Greg Kroah-Hartman , Tejun Heo , Mel Gorman , Michal Hocko , "Huang, Ying" , Nhat Pham , Yosry Ahmed , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 10/12] mempolicy: alloc_pages_mpol() for NUMA policy without vma In-Reply-To: <20231023190555.GA1964810@cmpxchg.org> Message-ID: <6b9b1256-f9ab-c418-ec7f-8fc74449cd68@google.com> References: <74e34633-6060-f5e3-aee-7040d43f2e93@google.com> <1738368e-bac0-fd11-ed7f-b87142a939fe@google.com> <20231023105331.311373ed33a0dfe78ddaa9e5@linux-foundation.org> <20231023190555.GA1964810@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Stat-Signature: u5r3s64okcbnq5uj3qucoc3gqxeb97mp X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: D31F04001B X-Rspam-User: X-HE-Tag: 1698090531-427252 X-HE-Meta: U2FsdGVkX1/t71v9sNOO9zTdjCuiSgOgREPEw2XbhIF43WFRHYkhM9K8DFkMUtOf89sNGfuC0LdvUKogB/2Uk8eY5Vx1a8ZxbDmoYuQtdBCIvVR48KXR7ipwqd3CEAx4V+0Cg47J54j1e8aPKS/REAOqult0SfjCJiWUT68YpxSmlRo3F8RPVJTMkHxq8uxl7t05DKskrzLq72/OjsTw6MUKC38rMR7WO0XG7fEy94SkuSvNF9juh3q6Xdfg58iAJwU/SUIhQsZmoAROLRrb6+QkjdGJvILnA56lnt9cOo7RzGYWpXgrResDLg8CgQzeJ0yg0XCdC4kpaz5gJ55G8OZhspB5Vd3cIdch2/R+2IMnXOmfkxYU+YkQRRCDTwkc8pb8o0VImfKBSj2+6jGLTiESu37OHJXvtYxbrH11laYg88kS4Eo+TaEZK/EzeP5YE8RTJkVSc2RAE6TD3kCLXPeTfZqlkRJ+VlHPe3N+iCzoW3CW4Xw6ZliHanUAEpwjx5rJqEILlaGCu0yWX7LxSPxuHWYCowWjO0RfFVWvY+RnyoAgVbeW75ntXxVr0K7wIAhenV4bSSN+6qRW6abnfKiJL7Jthndi9TMOoEzHL7guBxMKm44zYyKuu6S42J6Eo8Da4NBEMNlx0kx53BklOQuuqRqwOLU2EzZp3ls0ZuAO8JJZgn4ESooaycne/jaHcYP1PyaZHhxw5IZT+99WchxVPi30rUkhOSWAPvWshY2SynprciVbU7hMjO1cUR5OIgYwnc01kSNY/Ij6Vk8dOJ7WPBN+cZonwOzNxXHx26viEd3IA/BqsSb4SiRdvjNeitEGjqzf9CdZyjYZYw85JZ55hs2j0t/HuhQlVOvRQ0yJtUTl/71cWcv8+EHWVmOykoX3c8PcJpbcA/RNAjyC+pkcsjxoDe/v8c28/1C4PpYs4Qg0vmmTAWiFas4GYWDPdUG2hPJMDSq0Ri9qdBg GiQXKqle vUZSrkZnWqU7KQbryHh0cc05S96E5jKWeQf/3i4DUIugj9EnwYsl6rUqNzquT4IE6prAF8mPjA4z9k47JIwQFHxuL3gScg0WOeoWt+9yNVYfRBcPooWUFR6RXJaAiPvJzxnYcZ9bnSEalUA6fCxOQ7JgXQHdeb4ZHHiY0b/YheaM63cOaePcb4qwwjQI6OnXf0q0Yzp21akAxH8VimlNSfTRicRZ9ZP27yIbLyWMdGBmhPZjJawO5yM9u74iEIAncmCcGWfGo9FVDb+55UaaIYT1FYEtk1b9FqgUN1AUQaiCKAj61qZ0ZzUyR6bF8CEKwMXdAOZHx1RGxGeZzkx09YsVB8e8uRCnd81AmsSgtNrXj7YjV+JOA8HcawDXydNMIc4fGdTTVurZnxvcZ4WMa1qzFZ8JPwjlPcR2abOdbPhmEAscRHHXmxm/P1CZ80m5pMMIkgFU9ZIUam+m9+egV5Fr1fOgyYP9vL6O71PAb4OvUS2s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 23 Oct 2023, Johannes Weiner wrote: > On Mon, Oct 23, 2023 at 08:10:32PM +0200, domenico cerasuolo wrote: > > Il giorno lun 23 ott 2023 alle ore 19:53 Andrew Morton > > ha scritto: > > > > > > On Mon, 23 Oct 2023 18:53:26 +0200 domenico cerasuolo wrote: > > > > > > > > Rebased to mm.git's current mm-stable, to resolve with removal of > > > > > vma_policy() from include/linux/mempolicy.h, and temporary omission > > > > > of Nhat's ZSWAP mods from mm/swap_state.c: no other changes. > > > > > > > > Hi Hugh, > > > > > > > > not sure if it's the rebase, but I don't see an update to > > > > __read_swap_cache_async invocation in zswap.c at line 1078. Shouldn't we pass a > > > > mempolicy there too? > > > > > > No change needed. zswap_writeback_entry() was passing a NULL for arg > > > `vma' and it's now passing a NULL for arg `mpol'. Andrew's answer was indeed my thinking, and why none of us got a build error. > > > > Problem is that alloc_pages_mpol is dereferencing mpol, when I test the zswap > > writeback at 397148729f21edcf700ecb2a01749dbce955d09e it crashes, not sure if > > I'm missing something. > > I don't think you are. The NULL vma used to go to get_vma_policy(), > which fell back to > > pol = get_task_policy(current); > > Now the NULL pol gets passed to alloc_pages_mpol() directly, which > dereferences it. Oops. Yes, I failed to think it through that far. > > I think Hugh's patch needs zswap to pass get_task_policy(current) > instead of NULL. That sounds the likely fix, thank you Domenico, Andrew, Johannes. I'll check it out and send a fix patch later today. I don't know who runs that zswap_writeback_entry() code, but I presume that task's mempolicy is unlikely to be relevant to the swap cache page in question: but a whole lot better than oopsing, and will reproduce the previous behaviour (and the assumption at this writeback point would be that the page is unlikely to be reused after writeback anyway, so its node unimportant). Hugh