From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5FEDC77B7A for ; Wed, 7 Jun 2023 09:06:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 330A78E0001; Wed, 7 Jun 2023 05:06:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E13C6B0072; Wed, 7 Jun 2023 05:06:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A8758E0001; Wed, 7 Jun 2023 05:06:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0DE026B0071 for ; Wed, 7 Jun 2023 05:06:40 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CCCAFC01A7 for ; Wed, 7 Jun 2023 09:06:39 +0000 (UTC) X-FDA: 80875371318.24.5F3BB08 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf21.hostedemail.com (Postfix) with ESMTP id 9C5C31C0016 for ; Wed, 7 Jun 2023 09:06:37 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=G13vVfv2; spf=pass (imf21.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686128797; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b1yPBwGT+cE9xc3w7Ie4GBXa4DqL39GefXKyCYfp7sc=; b=5NFa8iZLb9UjPnA/ubRMHKN6NXMyN7bEO7cn3kd5JyNTnll6rr4Ng4Egc9vFijEL30C4q6 i7m4vDYcjSz2dUx9OMiT6xGUTl4dSp6t+YNkLBg1xKhN6iUkXnqVbWd1YkVKHMU9WUrtl2 c16hDBylpiEkGDk2YEVXX5REEVk/n9Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686128797; a=rsa-sha256; cv=none; b=vbtw8BJ1x1rxx2NJkg/rCHk2FOfMGWDbIblPr8Z+IQmJjE+/FET31bteBkeavyfeCt1xXz T3K3mkEUldCzkFcDBQeMrUJXHNVsDWFIxGpWOfzXrsbA/Q4zFIq9T5LrMAPsAw9TIn5VNf +7TrVAbem+Juzaj0CmlVqpIyYDHLJUE= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=G13vVfv2; spf=pass (imf21.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-977d6aa3758so582221166b.0 for ; Wed, 07 Jun 2023 02:06:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686128796; x=1688720796; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=b1yPBwGT+cE9xc3w7Ie4GBXa4DqL39GefXKyCYfp7sc=; b=G13vVfv2s4+jbiS40NG5KXlo0wZxHuL1McyNyiyJSXbO7UKKecj1ga33sqRb0tEUUR Q9PmJTGmDRaUsxZjhhniOfWSPjidgTX2/fSFgPX8h/sUsvYD33WEkZORIvj5lR2Pu7sf 6JGCx2jt1ScrWBpE8ziZoat5XZj7/cnW8Ui/r4N2Up3bjfFuEghhEJik57N4DYwJ0obI zxj2YE7e6oaYd1ZeQ9WTya4VPgyQy2VynjgknzHFeIaCMGEWdU/Xd1eImUELUoFIa/Cu V/0mldWzbyRO8wrj2zeS1k4aj77lx2bJoZnKO6x0ys3ehbW+WoVAUnHzrH6TCNAxb/uY FkNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686128796; x=1688720796; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=b1yPBwGT+cE9xc3w7Ie4GBXa4DqL39GefXKyCYfp7sc=; b=CfjwKFyhC6mf/XLGS3VARAoxJ51jAVNFXLzwTsKDx308693eorqg4gGzLJzkBgORkt AZ/bKrwCkz/1N1+pW0P49IeojZNpBXDa2G6ABVQQ3As4TSOiK+ZYWHdvF1bJexXiziZc st2/b4UA84LtMXbsRshs3iye75oJ8UQ87+eMe4ft90KDQ3HLCrorduCAqlLqoK6zSSKL eU+i5WkKNBetBo1S8zyDmita+zE+3ljqNrKNaWM+2qW6SnkajvapsJHhhuSp5kCUs6H+ Hhrmzr2HkB8y2QPIb1LP+hCP4ke+nfcmHSmrX1aOMmIV1zqJueoReGNGEGPRF+tViZ8z YhCA== X-Gm-Message-State: AC+VfDweq5ADZ2jljbx8wyErrB0JX/8m+mcMqt5o5Nm89RAqL84WJ/Z2 HdBk0niYTosc0MuNLBTar1c= X-Google-Smtp-Source: ACHHUZ5WzoU4UWUf+EtpfSUhNP0tIHdENFW/vh3iFUKUX/mDlTP7BvVvbn2bjMji0qwe+c3ZocWFog== X-Received: by 2002:a17:907:980d:b0:96f:a891:36cb with SMTP id ji13-20020a170907980d00b0096fa89136cbmr5652727ejc.0.1686128795700; Wed, 07 Jun 2023 02:06:35 -0700 (PDT) Received: from localhost ([2a00:23c5:dc8c:8701:1663:9a35:5a7b:1d76]) by smtp.gmail.com with ESMTPSA id l5-20020a1c7905000000b003f7f475c3c7sm163166wme.8.2023.06.07.02.06.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jun 2023 02:06:34 -0700 (PDT) Date: Wed, 7 Jun 2023 10:06:34 +0100 From: Lorenzo Stoakes To: Vlastimil Babka Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Baoquan He , Uladzislau Rezki , Christoph Hellwig , Bagas Sanjaya , Linux btrfs , Linux Regressions , Chris Mason , Josef Bacik , David Sterba , a1bert@atlas.cz, Forza , Linus Torvalds , Song Liu , Nicholas Piggin , Matthew Wilcox Subject: Re: [PATCH] mm/vmalloc: do not output a spurious warning when huge vmalloc() fails Message-ID: <6b954be8-c7be-436b-996d-92b0469ef74d@lucifer.local> References: <20230605201107.83298-1-lstoakes@gmail.com> <2a6fa9d6-53b8-93cd-16c8-309ce2b8e3ac@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2a6fa9d6-53b8-93cd-16c8-309ce2b8e3ac@suse.cz> X-Rspamd-Queue-Id: 9C5C31C0016 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 6s9aoyjihpk1ykqwc58rr3u5tiqzgxad X-HE-Tag: 1686128797-612937 X-HE-Meta: U2FsdGVkX1/P+KcJum9pELj4qdqyeOMI7nhlUO5tpOR9fZMW7Qu62AIxZVWX0G7GhWrRII9b2VOiGC80A9hUIGlBIQXU+BSlw3UHQiVC07PClvf91f3gauqQKHoEvUh1E48BBIwbkWbe9VSaQHDZa4of/oEyimB02aB2uIwGetCS+hKLNBWfZBzbRx9nZh7kHykDNySKkeBqKx99bgXwHJ6FRBuY1OdUvYYGpx0oAi/A6iKY2p1NfY6bnpsMiQ3OjrHOG6KIh+ZOSOi4B1GNeAYhSh77YBUX57GyxSfDN1wDUHLCdwRyDBRxRaQLvKjsnJZvnbPouua463mltCBdFtKnPKIKNNNwGiR0bTPsEJcWzzxp9i2J5OFhC/rUhLfAf4y9YXBgVlAtb1MAuCreX7NJCegvrxjlKXb8gffYTTQktVfm16nzhQDCWOSbX2Hiuv+r2SGFM9vxrbB1McCw3dZAqNHykmkmHiGjXx1s01Z7AeVOuKfaStyHEZmj8dU8jLC8xR5JIV6xj1rR+hGzpoBVOtYWNV1hyEjOkY/HnOK5Pp1+XFCHqjfvOoiYKw6tKpCEboi2fsAGgVhYBmrIGBsHLnzAAiY5wbtr+l1INrFAul9cKWscsCTzE/AkA20XBCUpdqsxWrvm54hYnV4KuIsteySoRauIdWFgmt+GKQz5LD1qAoLd3tLILPYP1udd+TfEU/HbsIqWviCaHluRL6BCptdtSV5HZZR9YvNkvo6kzgAGLd1QYsIPezsGjSQVAjbW4gmg1+ApnUL3aKdE2O53AONBkm7K/jkhaPQwjoDCcm+UNrLsbpQKPetaxRojB+l6H+5u9Cke/pms/IRzk0rWQ5xBhIvTNnkVTXMOXj0BHM3P/nIwvW4fx4aPkX0NJFxz4vxkfkUgpDdcZ8ooATt0FAOUBeQ2GB3hUlOC7miADlr9+T8X6PMtryHV/3PEY21d3VKed95F7m3BXJR BLzxt50L IUox92oqZ/lfcMUQyUYhrNQ7AaEpA0PsIQr4stqnMMC5Zs5PKnUath9KQBKtT5a1MCplqrE7XgtuFxjekt4b673pCd/37tOz26XewcJknKV4ZdsCnwAkXUdSsoghqUKjOXSegNPjQ7qeWmzUiIZVpApFcg8ACLx1HqOKLZEtJzR5ww8sIvwuReelqmHk+Z00D4JWcNi0105m86pDSbWXMzlatyBqUtpheAX66ZhVCPqzymwjoSEO1J/SsJljUfXynyLof1E0oG/ENdQ+hv88oVa67xLEeyqykJd6d2w3tmetSYNHEqZyIgBsOryuWmyVpHlEs26enu0vDJ4POmNLOHrU52V68/Qa5IfYmY7R3uv9631CS7S2pkPDVwTPI7RAvDEW0H+hgZtamlq1Wq8iucgLB76nPcUZ6saTRQe8FKitqXvbQV0Fx3beNMLh2PU4kQIxqq+OP4j4LcE0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000027, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 07, 2023 at 10:58:40AM +0200, Vlastimil Babka wrote: > I think I found the commit from 6.3 that effectively exposed this warning. > As this is a tracked regression I would really suggest moving the fix to > mm-hotfixes instead of mm-unstable, and > > Fixes: 80b1d8fdfad1 ("mm: vmalloc: correct use of __GFP_NOWARN mask in __vmalloc_area_node()") > Cc: Yeah, ugh. What's irritating is that this is not incorrect - invoking warn_alloc() in such a way that it does literally nothing is not right, so that fix was required, but it simply exposed another issue. But completely agree this is technically a regression, and yes Andrew it'd be great if we could move this to hotfixes and append the stable cc if possible thanks! (We definitely need to refactor a lot of this code!)