From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FED4C48BCF for ; Wed, 9 Jun 2021 10:56:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AA0E661287 for ; Wed, 9 Jun 2021 10:56:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA0E661287 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 499766B0070; Wed, 9 Jun 2021 06:56:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4491B6B0071; Wed, 9 Jun 2021 06:56:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29BE46B0072; Wed, 9 Jun 2021 06:56:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0070.hostedemail.com [216.40.44.70]) by kanga.kvack.org (Postfix) with ESMTP id E853C6B0070 for ; Wed, 9 Jun 2021 06:56:05 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8F282181AEF23 for ; Wed, 9 Jun 2021 10:56:05 +0000 (UTC) X-FDA: 78233880690.22.5ECDD59 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 0582E5001703 for ; Wed, 9 Jun 2021 10:56:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623236164; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1eqcq/7KVFIFfww4JdqqnK/TUbif/qCxlnaAkIZ26tg=; b=XhbkTzLIxP/kCPYbdPkz2lNjcWWrTTwywSkuukPJX/ZGLAYCdC1RPoHuQWS0UbqoDw+MHH zHDpk7smthFA9q0TfeDrDNVCaxlhFEUKjKiwLCRw6HYWaBAwW6ECJIbHwP6wu40yxFzrK1 x3ggkJKDQZ3GflUqR9fny9V7F4193AU= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-68-3DXsjsI3PA-Xdqf1l7pM6w-1; Wed, 09 Jun 2021 06:56:03 -0400 X-MC-Unique: 3DXsjsI3PA-Xdqf1l7pM6w-1 Received: by mail-wr1-f71.google.com with SMTP id z3-20020adfdf830000b02901198337bc39so10026546wrl.0 for ; Wed, 09 Jun 2021 03:56:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=1eqcq/7KVFIFfww4JdqqnK/TUbif/qCxlnaAkIZ26tg=; b=HY3PtJ81Bw/TIItXtUsN7ixxE0XMnM9RaN6DONpxdg1I57frX76/mumwzP/aAZ70vi DwxHBPpeFqa+IQ2F6gV/HgrzNhGZ6hW0Ky++VyXx5Lja+aIGtt6iCr77mKvm/qTPk/ca 5aCoc4u4TCf6313IeNmnul1cGpByh+V4iCvgI1GSm4t840ymLsqkZxnaoF0yyVUMWREe NqWmTrP4VG7/snQN6T6QaXhw/GeKsUAdc3LqLG4jS3jZByvYpMiaWmbBniZeCOT58yU2 /37dOhMeB3YNdfM/l/VUyzyTxWxp47ZtVDGji+yf6PZH6HNKcElsPQ8RnXki4zeoL38h sUrw== X-Gm-Message-State: AOAM531S2CaTIltwCB+gtj4Vt12bg6my//lFCrUbuS7gCwcmYaeXrWgp 2TAfA0DylYzqZFf3HHiE1J3VmAxGpizosmroSKAryI1+iJejm6boP7/miSroPCXcvrJWZs4BGDt nf6xy12XyIAY= X-Received: by 2002:adf:ee46:: with SMTP id w6mr28365901wro.345.1623236162280; Wed, 09 Jun 2021 03:56:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQ49r+tRbGd1wOHU0mXbY7urMjvAihHVmP4oVaZtHRm+k2OFRov+Lj+Vo8CLpAoo+a81y7uQ== X-Received: by 2002:adf:ee46:: with SMTP id w6mr28365871wro.345.1623236162032; Wed, 09 Jun 2021 03:56:02 -0700 (PDT) Received: from [192.168.3.132] (p5b0c611d.dip0.t-ipconnect.de. [91.12.97.29]) by smtp.gmail.com with ESMTPSA id a4sm21295711wme.45.2021.06.09.03.56.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 03:56:01 -0700 (PDT) Subject: Re: [PATCH 7/9] docs: remove description of DISCONTIGMEM To: Mike Rapoport , Andrew Morton Cc: Arnd Bergmann , Geert Uytterhoeven , Ivan Kokshaysky , Jonathan Corbet , Matt Turner , Mike Rapoport , Richard Henderson , Vineet Gupta , kexec@lists.infradead.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org References: <20210602105348.13387-1-rppt@kernel.org> <20210602105348.13387-8-rppt@kernel.org> From: David Hildenbrand Organization: Red Hat Message-ID: <6b92d273-dd0b-d67f-c2f6-cce13a33afd1@redhat.com> Date: Wed, 9 Jun 2021 12:56:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210602105348.13387-8-rppt@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 0582E5001703 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XhbkTzLI; spf=none (imf01.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: ioongca8ttsf95w4prwhnrmqfoeowkmd X-HE-Tag: 1623236160-104396 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02.06.21 12:53, Mike Rapoport wrote: > From: Mike Rapoport > > Remove description of DISCONTIGMEM from the "Memory Models" document and > update VM sysctl description so that it won't mention DISCONIGMEM. > > Signed-off-by: Mike Rapoport > --- > Documentation/admin-guide/sysctl/vm.rst | 12 +++---- > Documentation/vm/memory-model.rst | 45 ++----------------------- > 2 files changed, 8 insertions(+), 49 deletions(-) > > diff --git a/Documentation/admin-guide/sysctl/vm.rst b/Documentation/admin-guide/sysctl/vm.rst > index 586cd4b86428..ddbd71d592e0 100644 > --- a/Documentation/admin-guide/sysctl/vm.rst > +++ b/Documentation/admin-guide/sysctl/vm.rst > @@ -936,12 +936,12 @@ allocations, THP and hugetlbfs pages. > > To make it sensible with respect to the watermark_scale_factor > parameter, the unit is in fractions of 10,000. The default value of > -15,000 on !DISCONTIGMEM configurations means that up to 150% of the high > -watermark will be reclaimed in the event of a pageblock being mixed due > -to fragmentation. The level of reclaim is determined by the number of > -fragmentation events that occurred in the recent past. If this value is > -smaller than a pageblock then a pageblocks worth of pages will be reclaimed > -(e.g. 2MB on 64-bit x86). A boost factor of 0 will disable the feature. > +15,000 means that up to 150% of the high watermark will be reclaimed in the > +event of a pageblock being mixed due to fragmentation. The level of reclaim > +is determined by the number of fragmentation events that occurred in the > +recent past. If this value is smaller than a pageblock then a pageblocks > +worth of pages will be reclaimed (e.g. 2MB on 64-bit x86). A boost factor > +of 0 will disable the feature. > > > watermark_scale_factor > diff --git a/Documentation/vm/memory-model.rst b/Documentation/vm/memory-model.rst > index ce398a7dc6cd..30e8fbed6914 100644 > --- a/Documentation/vm/memory-model.rst > +++ b/Documentation/vm/memory-model.rst > @@ -14,15 +14,11 @@ for the CPU. Then there could be several contiguous ranges at > completely distinct addresses. And, don't forget about NUMA, where > different memory banks are attached to different CPUs. > > -Linux abstracts this diversity using one of the three memory models: > -FLATMEM, DISCONTIGMEM and SPARSEMEM. Each architecture defines what > +Linux abstracts this diversity using one of the two memory models: > +FLATMEM and SPARSEMEM. Each architecture defines what > memory models it supports, what the default memory model is and > whether it is possible to manually override that default. > > -.. note:: > - At time of this writing, DISCONTIGMEM is considered deprecated, > - although it is still in use by several architectures. > - > All the memory models track the status of physical page frames using > struct page arranged in one or more arrays. > > @@ -63,43 +59,6 @@ straightforward: `PFN - ARCH_PFN_OFFSET` is an index to the > The `ARCH_PFN_OFFSET` defines the first page frame number for > systems with physical memory starting at address different from 0. > > -DISCONTIGMEM > -============ > - > -The DISCONTIGMEM model treats the physical memory as a collection of > -`nodes` similarly to how Linux NUMA support does. For each node Linux > -constructs an independent memory management subsystem represented by > -`struct pglist_data` (or `pg_data_t` for short). Among other > -things, `pg_data_t` holds the `node_mem_map` array that maps > -physical pages belonging to that node. The `node_start_pfn` field of > -`pg_data_t` is the number of the first page frame belonging to that > -node. > - > -The architecture setup code should call :c:func:`free_area_init_node` for > -each node in the system to initialize the `pg_data_t` object and its > -`node_mem_map`. > - > -Every `node_mem_map` behaves exactly as FLATMEM's `mem_map` - > -every physical page frame in a node has a `struct page` entry in the > -`node_mem_map` array. When DISCONTIGMEM is enabled, a portion of the > -`flags` field of the `struct page` encodes the node number of the > -node hosting that page. > - > -The conversion between a PFN and the `struct page` in the > -DISCONTIGMEM model became slightly more complex as it has to determine > -which node hosts the physical page and which `pg_data_t` object > -holds the `struct page`. > - > -Architectures that support DISCONTIGMEM provide :c:func:`pfn_to_nid` > -to convert PFN to the node number. The opposite conversion helper > -:c:func:`page_to_nid` is generic as it uses the node number encoded in > -page->flags. > - > -Once the node number is known, the PFN can be used to index > -appropriate `node_mem_map` array to access the `struct page` and > -the offset of the `struct page` from the `node_mem_map` plus > -`node_start_pfn` is the PFN of that page. > - > SPARSEMEM > ========= > > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb