From: David Hildenbrand <david@redhat.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>,
yangge1116@126.com, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
21cnbao@gmail.com, hannes@cmpxchg.org, liuzixing@hygon.cn,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH V2] mm: compaction: skip memory compaction when there are not enough migratable pages
Date: Mon, 13 Jan 2025 11:16:32 +0100 [thread overview]
Message-ID: <6b8ba92f-84df-4476-bc2c-985fc0cb254d@redhat.com> (raw)
In-Reply-To: <324bf85f-442a-4388-a8f4-55d60e57b914@linux.alibaba.com>
>> + /*
>> + * Gup-pinned pages are non-migratable. After subtracting these pages,
>> + * we need to check if the remaining pages are sufficient for memory
>> + * compaction.
>> + */
>> + if ((sum - nr_pinned) < (1 << order))
>> + return false;
>> +
>
> Looks reasonable to me, but let's see if other people have any comments.
>
Noting that Barry had some concerns as reply to v3.
--
Cheers,
David / dhildenb
prev parent reply other threads:[~2025-01-13 10:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 8:37 yangge1116
2025-01-13 8:11 ` Baolin Wang
2025-01-13 10:16 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b8ba92f-84df-4476-bc2c-985fc0cb254d@redhat.com \
--to=david@redhat.com \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuzixing@hygon.cn \
--cc=vbabka@suse.cz \
--cc=yangge1116@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox