From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF8CCD2E03C for ; Wed, 23 Oct 2024 09:57:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D3076B007B; Wed, 23 Oct 2024 05:57:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 183F46B0082; Wed, 23 Oct 2024 05:57:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3F896B0083; Wed, 23 Oct 2024 05:57:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D93766B007B for ; Wed, 23 Oct 2024 05:57:26 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CB0D3120802 for ; Wed, 23 Oct 2024 09:57:10 +0000 (UTC) X-FDA: 82704414156.04.8457BEE Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf30.hostedemail.com (Postfix) with ESMTP id B4DF580003 for ; Wed, 23 Oct 2024 09:56:51 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hK3IXF42; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=LF+KR+6I; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hK3IXF42; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=LF+KR+6I; dmarc=none; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729677406; a=rsa-sha256; cv=none; b=oUl+q3QTz/Don+eaoEGZ1DYE1DKSyMq7RV4wDcfNXOR9BZ64fyHp2HB7v7Xo61vXI6RPFm zk0czIjtz83RboGQbkkjnPQvd1SeWJs7A7nHPUyDsQwvxojjnYUFbQXXNRLuiM0rzZk83m SHofFnfysu9bchN+Fg4ijdysvDznVPo= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hK3IXF42; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=LF+KR+6I; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hK3IXF42; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=LF+KR+6I; dmarc=none; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729677406; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ju7oFyhjG+dSslSQ1Heid9n1pC8kCUnW8cflFowvQm0=; b=Wrg3QhP/gpxMJ+GPEUwyDR4S9XwS/yAEp7w63H09J0k4RoqkJtGCFjYycxnn1iI2MEed2x XuP8IV5iNcS/0Vw14r8cTTMCvggLOpOMfc4Qod7MyiKOAJi4WI4C6D1tNQdsRLvaQe3tPW H2d/O/Qxc53FV0j+fMB8e0zffItdBmE= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8811A1FD9A; Wed, 23 Oct 2024 09:57:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1729677442; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Ju7oFyhjG+dSslSQ1Heid9n1pC8kCUnW8cflFowvQm0=; b=hK3IXF42wGY19xER12GRRdI+Qh4/AKT8Bbo+TOvnYmrJXUygnq8zdyW0ssIp8/QaN8/fIm HNz0tFZWFlrW+VIPdPCMbbAlXGG9nLQwRS8NI41oNhqElQ46CMxEvscxdo/SncisZs+IG5 FM8zUsE8XX9rdNAISf2usnpaAu943+c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1729677442; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Ju7oFyhjG+dSslSQ1Heid9n1pC8kCUnW8cflFowvQm0=; b=LF+KR+6INzRw8iGSOdVxAJU7v8RZKuGsnNbhlKrNDomhSy4shb+5Hel1TtpX3s624lmKtl 0uM41VG5lqImj9Cg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1729677442; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Ju7oFyhjG+dSslSQ1Heid9n1pC8kCUnW8cflFowvQm0=; b=hK3IXF42wGY19xER12GRRdI+Qh4/AKT8Bbo+TOvnYmrJXUygnq8zdyW0ssIp8/QaN8/fIm HNz0tFZWFlrW+VIPdPCMbbAlXGG9nLQwRS8NI41oNhqElQ46CMxEvscxdo/SncisZs+IG5 FM8zUsE8XX9rdNAISf2usnpaAu943+c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1729677442; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Ju7oFyhjG+dSslSQ1Heid9n1pC8kCUnW8cflFowvQm0=; b=LF+KR+6INzRw8iGSOdVxAJU7v8RZKuGsnNbhlKrNDomhSy4shb+5Hel1TtpX3s624lmKtl 0uM41VG5lqImj9Cg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7241D13AD3; Wed, 23 Oct 2024 09:57:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id D2+RG4LIGGekNgAAD6G6ig (envelope-from ); Wed, 23 Oct 2024 09:57:22 +0000 Message-ID: <6b6fe750-4f59-446f-ad8c-71468e2d9a7a@suse.cz> Date: Wed, 23 Oct 2024 11:57:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH hotfix 6.12 3/8] mm: refactor map_deny_write_exec() Content-Language: en-US To: Lorenzo Stoakes , Andrew Morton Cc: "Liam R . Howlett" , Jann Horn , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Linus Torvalds , Peter Xu References: From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: xjkuhqy44sp34f4a8wknmgud3apztbe5 X-Rspamd-Queue-Id: B4DF580003 X-Rspamd-Server: rspam02 X-HE-Tag: 1729677411-377277 X-HE-Meta: U2FsdGVkX1/sXJxxvzV6V/OTr2Cjua6wH7ityLOPXMoSOx975imSZAy3dQVWqS6Ogs8KnKxtDBImTw8Cgs1y2qBiZGD+0LWhttpvJAS7Q9K5rdhQoQjPRnwR4x3/FluuuFH006EzjuJmyYREU1fI017UWKUe1hcoF134DMpZycgLu7whjmIAd4svuAgowXzOm5mK+s3NkG3oZUwzTVpFDz3HPL+o1BKYIuwfuSvGn7M8FdBBTqcOXmN3StUPwjS8z7o3jPRi7JsIme/vvAVSFkJ+PzmLHmrwiejfKDjM0eVqUv/0aakvDBig/nBkOTXg6zi87zicHpuqYVra/QV+/aQNZ52TKzkxjGtD/SyEpWw2sI5jVcYHzzf1TGSbgYr9rRZS3CJZ7KCnCG4JZ0qvadJshT354O8se5L/F6d+lZZOHjwMMJVENzu9m0PwQZtCvKhXpJvWi1EEumcn1HKVCoeYH9fNy045Vod4rvQI1W4xQizT/y5k9Ze+rPMyqMcL90KEiNVIu+RqWZbjpIVlxEEi2NVuJJqfPYT0sTJWONBnjKNeDz63yY/3h9LU/33pPMywVLqHSSv1KmNrQB+p/ZrZtwVgXpBBKEOhYL0S1Fwh2HdtxvaeB5oX+omT+5c+j2ytr4oEi66NB/hOimHcSTx5K1wYAVL9aWueHW4NpBLZb/hrxUnbLhsKQCfJWWyBWeqQqyVKIQEjdtt/dqCMd6IGD/eBwUI6xeE8mdKxWeW06REyGqPnPUnYt0AYETtJj20aOQSbA0fXLa3how28W4s21OUzcNmWFMVshBwSdSA5GzMMKELvK7AJVfrMZuxnbRqvXye7mw4qWIXX7VhhSlG5nJFEpdHhw43tv9VmaukJw/D3uLDCt4ngMFoitHS3lmnCRyN5XqzIuEHlWIKNRPN7AzyFt0udc2MuxWa0Sw7Sdm+bbKKOahKK+yfxjTiuN9H8gYhlK/1kliheJck EmfSSUar DadHMUjiHAcNVy7SlltRQ+d5llWs2xW8tFa9lGljyJLWiq9Gu0zkUwFw1mx0fv+JrhfTSt7YDezfHpH4oPGsyx+EGnfNW8H2lB7KSyWGn/yD/vXpiR2/jFU/6Ys2XByGhcSMMVqYH6jvWxUDwOqU2yBc04U/zlqVguaRLi+TrTmzzddKcPYcwwaUedDt2oyFYqfpFrKiH/exchG8zsYeJtuyXS5LtuwBjnIKlF7CDUPRp6ft+pAa0yrK6hMMp7kq5U/xnY3sWAPIlxGq+RjFj9mGjLPww8b9yJWtsdI7CDqIJzADUH/oLVXIEHDOTl6kGwvp2MtsBCTEb3RSTvdnUaWlR7Ji/C1os1w6GIDTE+g48hkkWCsUFSDwzNK3tC4mWml7EDNlgdEfAu/mzlgntOh8qFg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/22/24 22:40, Lorenzo Stoakes wrote: > Refactor the map_deny_write_exec() to not unnecessarily require a VMA > parameter but rather to accept VMA flags parameters, which allows us to use > this function early in mmap_region() in a subsequent commit. > > While we're here, we refactor the function to be more readable and add some > additional documentation. > > Reported-by: Jann Horn > Fixes: deb0f6562884 ("mm/mmap: undo ->mmap() when arch_validate_flags() fails") > Cc: stable > Signed-off-by: Lorenzo Stoakes Reviewed-by: Vlastimil Babka