From: Vlastimil Babka <vbabka@suse.cz>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: "Liam R . Howlett" <Liam.Howlett@oracle.com>,
Jann Horn <jannh@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH hotfix 6.12 3/8] mm: refactor map_deny_write_exec()
Date: Wed, 23 Oct 2024 11:57:22 +0200 [thread overview]
Message-ID: <6b6fe750-4f59-446f-ad8c-71468e2d9a7a@suse.cz> (raw)
In-Reply-To: <e67b7f6c682bddbea2fe8b2d87b8441e4d2ea6e6.1729628198.git.lorenzo.stoakes@oracle.com>
On 10/22/24 22:40, Lorenzo Stoakes wrote:
> Refactor the map_deny_write_exec() to not unnecessarily require a VMA
> parameter but rather to accept VMA flags parameters, which allows us to use
> this function early in mmap_region() in a subsequent commit.
>
> While we're here, we refactor the function to be more readable and add some
> additional documentation.
>
> Reported-by: Jann Horn <jannh@google.com>
> Fixes: deb0f6562884 ("mm/mmap: undo ->mmap() when arch_validate_flags() fails")
> Cc: stable <stable@kernel.org>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
next prev parent reply other threads:[~2024-10-23 9:57 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 20:40 [PATCH hotfix 6.12 0/8] fix error handling in mmap_region() and refactor Lorenzo Stoakes
2024-10-22 20:40 ` [PATCH hotfix 6.12 1/8] mm: avoid unsafe VMA hook invocation when error arises on mmap hook Lorenzo Stoakes
2024-10-22 21:14 ` Jann Horn
2024-10-23 16:56 ` Lorenzo Stoakes
2024-10-23 9:11 ` Vlastimil Babka
2024-10-23 14:22 ` Liam R. Howlett
2024-10-22 20:40 ` [PATCH hotfix 6.12 2/8] mm: unconditionally close VMAs on error Lorenzo Stoakes
2024-10-22 21:15 ` Jann Horn
2024-10-23 17:00 ` Lorenzo Stoakes
2024-10-23 9:24 ` Vlastimil Babka
2024-10-23 16:58 ` Lorenzo Stoakes
2024-10-23 14:26 ` Liam R. Howlett
2024-10-23 14:41 ` Liam R. Howlett
2024-10-22 20:40 ` [PATCH hotfix 6.12 3/8] mm: refactor map_deny_write_exec() Lorenzo Stoakes
2024-10-22 21:15 ` Jann Horn
2024-10-23 16:35 ` Lorenzo Stoakes
2024-10-23 9:57 ` Vlastimil Babka [this message]
2024-10-23 14:30 ` Liam R. Howlett
2024-10-23 16:25 ` Linus Torvalds
2024-10-23 16:37 ` Lorenzo Stoakes
2024-10-22 20:40 ` [PATCH hotfix 6.12 4/8] mm: resolve faulty mmap_region() error path behaviour Lorenzo Stoakes
2024-10-23 12:58 ` Vlastimil Babka
2024-10-23 14:20 ` Liam R. Howlett
2024-10-23 17:11 ` Lorenzo Stoakes
2024-10-23 15:02 ` Liam R. Howlett
2024-10-22 20:40 ` [PATCH hotfix 6.12 5/8] tools: testing: add additional vma_internal.h stubs Lorenzo Stoakes
2024-10-22 20:40 ` [PATCH hotfix 6.12 6/8] mm: insolate mmap internal logic to mm/vma.c Lorenzo Stoakes
2024-10-22 20:40 ` [PATCH hotfix 6.12 7/8] mm: refactor __mmap_region() Lorenzo Stoakes
2024-10-23 14:38 ` Vlastimil Babka
2024-10-23 15:21 ` Liam R. Howlett
2024-10-23 17:39 ` Lorenzo Stoakes
2024-10-23 18:12 ` Liam R. Howlett
2024-10-23 17:30 ` Lorenzo Stoakes
2024-10-23 17:19 ` Liam R. Howlett
2024-10-23 17:52 ` Lorenzo Stoakes
2024-10-22 20:40 ` [PATCH hotfix 6.12 8/8] mm: do not attempt second merge for file-backed VMAs Lorenzo Stoakes
2024-10-23 15:01 ` Vlastimil Babka
2024-10-23 15:16 ` Lorenzo Stoakes
2024-10-23 18:16 ` Liam R. Howlett
2024-10-23 18:20 ` Lorenzo Stoakes
2024-10-22 20:58 ` [PATCH hotfix 6.12 0/8] fix error handling in mmap_region() and refactor Lorenzo Stoakes
2024-10-23 8:37 ` Vlastimil Babka
2024-10-23 8:45 ` Lorenzo Stoakes
2024-10-23 10:22 ` Andrew Morton
2024-10-23 10:25 ` Andrew Morton
2024-10-23 10:26 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b6fe750-4f59-446f-ad8c-71468e2d9a7a@suse.cz \
--to=vbabka@suse.cz \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=peterx@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox