From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB4D3C433F5 for ; Thu, 28 Apr 2022 10:47:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 397716B0071; Thu, 28 Apr 2022 06:47:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 31F2E6B0072; Thu, 28 Apr 2022 06:47:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 199C36B0073; Thu, 28 Apr 2022 06:47:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 0752F6B0071 for ; Thu, 28 Apr 2022 06:47:53 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CF0CC21DB1 for ; Thu, 28 Apr 2022 10:47:52 +0000 (UTC) X-FDA: 79405962384.13.4C82E2A Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf22.hostedemail.com (Postfix) with ESMTP id 01BF5C0053 for ; Thu, 28 Apr 2022 10:47:50 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Kpsl4245BzhYgY; Thu, 28 Apr 2022 18:47:28 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 28 Apr 2022 18:47:47 +0800 Subject: Re: [hnaz-mm:master 214/410] mm/madvise.c:632:8: error: call to undeclared function 'is_swapin_error_entry'; ISO C99 and later do not support implicit function declarations From: Miaohe Lin To: kernel test robot CC: , , , Johannes Weiner , Naoya Horiguchi , Andrew Morton , Linux Memory Management List References: <202204281452.cEOGcf4p-lkp@intel.com> Message-ID: <6b55693d-24ab-a0bb-5289-8ca917680088@huawei.com> Date: Thu, 28 Apr 2022 18:47:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------43CAAC4E840AE9593F2FCC06" Content-Language: en-US X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Stat-Signature: fyck6s6x5axkhcmanbbj7wqgstyap7if X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 01BF5C0053 X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-HE-Tag: 1651142870-867214 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --------------43CAAC4E840AE9593F2FCC06 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit On 2022/4/28 15:48, Miaohe Lin wrote: > On 2022/4/28 14:54, kernel test robot wrote: >> tree: https://github.com/hnaz/linux-mm master >> head: bf4803abaa3e9d2fa207c0675a2d2abf0fd44f66 >> commit: fe343091405131f91dcb9230ae7649bb1ee7fe9a [214/410] mm/madvise: free hwpoison and swapin error entry in madvise_free_pte_range >> config: i386-randconfig-a005-20220425 (https://download.01.org/0day-ci/archive/20220428/202204281452.cEOGcf4p-lkp@intel.com/config) >> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 1cddcfdc3c683b393df1a5c9063252eb60e52818) >> reproduce (this is a W=1 build): >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> # https://github.com/hnaz/linux-mm/commit/fe343091405131f91dcb9230ae7649bb1ee7fe9a >> git remote add hnaz-mm https://github.com/hnaz/linux-mm >> git fetch --no-tags hnaz-mm master >> git checkout fe343091405131f91dcb9230ae7649bb1ee7fe9a >> # save the config file >> mkdir build_dir && cp config build_dir/.config >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot >> >> Note: the hnaz-mm/master HEAD bf4803abaa3e9d2fa207c0675a2d2abf0fd44f66 builds fine. >> It only hurts bisectability. >> >> All errors (new ones prefixed by >>): >> >>>> mm/madvise.c:632:8: error: call to undeclared function 'is_swapin_error_entry'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] >> is_swapin_error_entry(entry)) { >> ^ >> 1 error generated. > > I browsed the config file and found that CONFIG_SWAP is not set. But when I test it on my env, it works. > And I'm somewhat confused now: > > is_swapin_error_entry and pte_to_swp_entry are both defined in include/linux/swapops.h. But pte_to_swp_entry > can be used normally but is_swapin_error_entry breaks the compile. > > Will take a more close look later. Thanks for report! I'm sorry but I can't reproduce it in my env. It's very kind of you if you can help test the attached patch. Or should I send this patch directly? Thanks! > >> >> >> vim +/is_swapin_error_entry +632 mm/madvise.c >> >> 587 >> 588 static int madvise_free_pte_range(pmd_t *pmd, unsigned long addr, >> 589 unsigned long end, struct mm_walk *walk) >> 590 >> 591 { >> 592 struct mmu_gather *tlb = walk->private; >> 593 struct mm_struct *mm = tlb->mm; >> 594 struct vm_area_struct *vma = walk->vma; >> 595 spinlock_t *ptl; >> 596 pte_t *orig_pte, *pte, ptent; >> 597 struct page *page; >> 598 int nr_swap = 0; >> 599 unsigned long next; >> 600 >> 601 next = pmd_addr_end(addr, end); >> 602 if (pmd_trans_huge(*pmd)) >> 603 if (madvise_free_huge_pmd(tlb, vma, pmd, addr, next)) >> 604 goto next; >> 605 >> 606 if (pmd_trans_unstable(pmd)) >> 607 return 0; >> 608 >> 609 tlb_change_page_size(tlb, PAGE_SIZE); >> 610 orig_pte = pte = pte_offset_map_lock(mm, pmd, addr, &ptl); >> 611 flush_tlb_batched_pending(mm); >> 612 arch_enter_lazy_mmu_mode(); >> 613 for (; addr != end; pte++, addr += PAGE_SIZE) { >> 614 ptent = *pte; >> 615 >> 616 if (pte_none(ptent)) >> 617 continue; >> 618 /* >> 619 * If the pte has swp_entry, just clear page table to >> 620 * prevent swap-in which is more expensive rather than >> 621 * (page allocation + zeroing). >> 622 */ >> 623 if (!pte_present(ptent)) { >> 624 swp_entry_t entry; >> 625 >> 626 entry = pte_to_swp_entry(ptent); >> 627 if (!non_swap_entry(entry)) { >> 628 nr_swap--; >> 629 free_swap_and_cache(entry); >> 630 pte_clear_not_present_full(mm, addr, pte, tlb->fullmm); >> 631 } else if (is_hwpoison_entry(entry) || >> > 632 is_swapin_error_entry(entry)) { >> 633 pte_clear_not_present_full(mm, addr, pte, tlb->fullmm); >> 634 } >> 635 continue; >> 636 } >> 637 >> 638 page = vm_normal_page(vma, addr, ptent); >> 639 if (!page) >> 640 continue; >> 641 >> 642 /* >> 643 * If pmd isn't transhuge but the page is THP and >> 644 * is owned by only this process, split it and >> 645 * deactivate all pages. >> 646 */ >> 647 if (PageTransCompound(page)) { >> 648 if (page_mapcount(page) != 1) >> 649 goto out; >> 650 get_page(page); >> 651 if (!trylock_page(page)) { >> 652 put_page(page); >> 653 goto out; >> 654 } >> 655 pte_unmap_unlock(orig_pte, ptl); >> 656 if (split_huge_page(page)) { >> 657 unlock_page(page); >> 658 put_page(page); >> 659 orig_pte = pte_offset_map_lock(mm, pmd, addr, &ptl); >> 660 goto out; >> 661 } >> 662 unlock_page(page); >> 663 put_page(page); >> 664 orig_pte = pte = pte_offset_map_lock(mm, pmd, addr, &ptl); >> 665 pte--; >> 666 addr -= PAGE_SIZE; >> 667 continue; >> 668 } >> 669 >> 670 VM_BUG_ON_PAGE(PageTransCompound(page), page); >> 671 >> 672 if (PageSwapCache(page) || PageDirty(page)) { >> 673 if (!trylock_page(page)) >> 674 continue; >> 675 /* >> 676 * If page is shared with others, we couldn't clear >> 677 * PG_dirty of the page. >> 678 */ >> 679 if (page_mapcount(page) != 1) { >> 680 unlock_page(page); >> 681 continue; >> 682 } >> 683 >> 684 if (PageSwapCache(page) && !try_to_free_swap(page)) { >> 685 unlock_page(page); >> 686 continue; >> 687 } >> 688 >> 689 ClearPageDirty(page); >> 690 unlock_page(page); >> 691 } >> 692 >> 693 if (pte_young(ptent) || pte_dirty(ptent)) { >> 694 /* >> 695 * Some of architecture(ex, PPC) don't update TLB >> 696 * with set_pte_at and tlb_remove_tlb_entry so for >> 697 * the portability, remap the pte with old|clean >> 698 * after pte clearing. >> 699 */ >> 700 ptent = ptep_get_and_clear_full(mm, addr, pte, >> 701 tlb->fullmm); >> 702 >> 703 ptent = pte_mkold(ptent); >> 704 ptent = pte_mkclean(ptent); >> 705 set_pte_at(mm, addr, pte, ptent); >> 706 tlb_remove_tlb_entry(tlb, pte, addr); >> 707 } >> 708 mark_page_lazyfree(page); >> 709 } >> 710 out: >> 711 if (nr_swap) { >> 712 if (current->mm == mm) >> 713 sync_mm_rss(mm); >> 714 >> 715 add_mm_counter(mm, MM_SWAPENTS, nr_swap); >> 716 } >> 717 arch_leave_lazy_mmu_mode(); >> 718 pte_unmap_unlock(orig_pte, ptl); >> 719 cond_resched(); >> 720 next: >> 721 return 0; >> 722 } >> 723 >> > --------------43CAAC4E840AE9593F2FCC06 Content-Type: text/plain; charset="UTF-8"; name="0001-mm-swap-fix-implicit-function-declarations-of-is_swa.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-mm-swap-fix-implicit-function-declarations-of-is_swa.pa"; filename*1="tch" RnJvbSBjN2IzZDZlMGExNWZkNGU4NWE4ZjczMzNhYmIyMjIwYTU0YzA1MmU1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNaWFvaGUgTGluIDxsaW5taWFvaGVAaHVhd2VpLmNv bT4KRGF0ZTogVGh1LCAyOCBBcHIgMjAyMiAxNzoyMTo1NSArMDgwMApTdWJqZWN0OiBbUEFU Q0hdIG1tL3N3YXA6IGZpeCBpbXBsaWNpdCBmdW5jdGlvbiBkZWNsYXJhdGlvbnMgb2YKIGlz X3N3YXBpbl9lcnJvcl9lbnRyeQoKS2VybmVsIHRlc3Qgcm9ib3QgcmVwb3J0ZWQgdGhlIGVy cm9yIG9mIGNhbGxpbmcgdG8gdW5kZWNsYXJlZCBmdW5jdGlvbgppc19zd2FwaW5fZXJyb3Jf ZW50cnkuIEZpeCBpdCBieSB3cmFwcGluZyB1cCBpc19zd2FwaW5fZXJyb3JfZW50cnkgd2l0 aApDT05GSUdfU1dBUC4KClJlcG9ydGVkLWJ5OiBrZXJuZWwgdGVzdCByb2JvdCA8bGtwQGlu dGVsLmNvbT4KU2lnbmVkLW9mZi1ieTogTWlhb2hlIExpbiA8bGlubWlhb2hlQGh1YXdlaS5j b20+Ci0tLQogaW5jbHVkZS9saW51eC9zd2FwLmggICAgfCA0ICsrKysKIGluY2x1ZGUvbGlu dXgvc3dhcG9wcy5oIHwgNyArKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDExIGluc2VydGlv bnMoKykKCmRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L3N3YXAuaCBiL2luY2x1ZGUvbGlu dXgvc3dhcC5oCmluZGV4IGI4MmMxOTZkODg2Ny4uZjNkNDQyNTJlNDc3IDEwMDY0NAotLS0g YS9pbmNsdWRlL2xpbnV4L3N3YXAuaAorKysgYi9pbmNsdWRlL2xpbnV4L3N3YXAuaApAQCAt NTUsMTAgKzU1LDE0IEBAIHN0YXRpYyBpbmxpbmUgaW50IGN1cnJlbnRfaXNfa3N3YXBkKHZv aWQpCiAgKiBhY3Rpb25zIG9uIGZhdWx0cy4KICAqLwogCisjaWZkZWYgQ09ORklHX1NXQVAK ICNkZWZpbmUgU1dQX1NXQVBJTl9FUlJPUl9OVU0gMQogI2RlZmluZSBTV1BfU1dBUElOX0VS Uk9SICAgICAoTUFYX1NXQVBGSUxFUyArIFNXUF9IV1BPSVNPTl9OVU0gKyBcCiAJCQkgICAg IFNXUF9NSUdSQVRJT05fTlVNICsgU1dQX0RFVklDRV9OVU0gKyBcCiAJCQkgICAgIFNXUF9Q VEVfTUFSS0VSX05VTSkKKyNlbHNlCisjZGVmaW5lIFNXUF9TV0FQSU5fRVJST1JfTlVNIDAK KyNlbmRpZgogLyoKICAqIFBURSBtYXJrZXJzIGFyZSB1c2VkIHRvIHBlcnNpc3QgaW5mb3Jt YXRpb24gb250byBQVEVzIHRoYXQgYXJlIG1hcHBlZCB3aXRoCiAgKiBmaWxlLWJhY2tlZCBt ZW1vcmllcy4gIEFzIGl0cyBuYW1lICJQVEUiIGhpbnRzLCBpdCBzaG91bGQgb25seSBiZSBh cHBsaWVkIHRvCmRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L3N3YXBvcHMuaCBiL2luY2x1 ZGUvbGludXgvc3dhcG9wcy5oCmluZGV4IGZmYzlmMTlhYjZmYi4uYWY2ZTZmYjRiOGU2IDEw MDY0NAotLS0gYS9pbmNsdWRlL2xpbnV4L3N3YXBvcHMuaAorKysgYi9pbmNsdWRlL2xpbnV4 L3N3YXBvcHMuaApAQCAtMTA4LDYgKzEwOCw3IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCAqc3dw X3RvX3JhZGl4X2VudHJ5KHN3cF9lbnRyeV90IGVudHJ5KQogCXJldHVybiB4YV9ta192YWx1 ZShlbnRyeS52YWwpOwogfQogCisjaWZkZWYgQ09ORklHX1NXQVAKIHN0YXRpYyBpbmxpbmUg c3dwX2VudHJ5X3QgbWFrZV9zd2FwaW5fZXJyb3JfZW50cnkoc3RydWN0IHBhZ2UgKnBhZ2Up CiB7CiAJcmV0dXJuIHN3cF9lbnRyeShTV1BfU1dBUElOX0VSUk9SLCBwYWdlX3RvX3Bmbihw YWdlKSk7CkBAIC0xMTcsNiArMTE4LDEyIEBAIHN0YXRpYyBpbmxpbmUgaW50IGlzX3N3YXBp bl9lcnJvcl9lbnRyeShzd3BfZW50cnlfdCBlbnRyeSkKIHsKIAlyZXR1cm4gc3dwX3R5cGUo ZW50cnkpID09IFNXUF9TV0FQSU5fRVJST1I7CiB9CisjZWxzZQorc3RhdGljIGlubGluZSBp bnQgaXNfc3dhcGluX2Vycm9yX2VudHJ5KHN3cF9lbnRyeV90IGVudHJ5KQoreworCXJldHVy biAwOworfQorI2VuZGlmCiAKICNpZiBJU19FTkFCTEVEKENPTkZJR19ERVZJQ0VfUFJJVkFU RSkKIHN0YXRpYyBpbmxpbmUgc3dwX2VudHJ5X3QgbWFrZV9yZWFkYWJsZV9kZXZpY2VfcHJp dmF0ZV9lbnRyeShwZ29mZl90IG9mZnNldCkKLS0gCjIuMjMuMAoK --------------43CAAC4E840AE9593F2FCC06--