From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25203C433FE for ; Sat, 15 Oct 2022 01:32:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8AC806B0072; Fri, 14 Oct 2022 21:32:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 85D516B0075; Fri, 14 Oct 2022 21:32:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 724AF6B0078; Fri, 14 Oct 2022 21:32:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5D51C6B0072 for ; Fri, 14 Oct 2022 21:32:51 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3075B40576 for ; Sat, 15 Oct 2022 01:32:51 +0000 (UTC) X-FDA: 80021459742.27.7F5F49C Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf15.hostedemail.com (Postfix) with ESMTP id 2DEE0A0027 for ; Sat, 15 Oct 2022 01:32:49 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Mq5Kc2bnFzDsSP; Sat, 15 Oct 2022 09:30:12 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 15 Oct 2022 09:32:46 +0800 Subject: Re: [PATCH 2/3] hugetlb: take hugetlb vma_lock when clearing vma_lock->vma pointer To: Mike Kravetz , , CC: Muchun Song , David Hildenbrand , Sven Schnelle , Michal Hocko , Peter Xu , Naoya Horiguchi , "Aneesh Kumar K . V" , Andrea Arcangeli , "Kirill A . Shutemov" , Davidlohr Bueso , Prakash Sangappa , James Houghton , Mina Almasry , Pasha Tatashin , Axel Rasmussen , Ray Fucillo , Andrew Morton References: <20221005011707.514612-1-mike.kravetz@oracle.com> <20221005011707.514612-3-mike.kravetz@oracle.com> From: Miaohe Lin Message-ID: <6b2d8b41-1989-b28a-d558-3423432848fe@huawei.com> Date: Sat, 15 Oct 2022 09:32:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665797570; a=rsa-sha256; cv=none; b=Dr4JcmxySWuee+FE6YbHtCnSGHTNWoK4wWA00cPRWJ4hpFTQvEgBk2V7ALJLob7ZRwosr5 0bgbbQb93CC1WLTd2DD+Lf5lP/8YSQN/g9z69IR6hmavwCrJWSiIOKc0TsgVH5yVLeqpLv aupGeieKWYUVntTuxYerDaL2KOLY/Ew= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665797570; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DVky4Hbpi7xqgHA3mNsJldduEtsybquGBRMhxsw4wlY=; b=IuFemMZBQTWvP5b8z3C0vzm/brsbDuASvPfQI4FgH9NHfKHbvpkJpIb74SF5wXGCwWGNmz M5d35Ot52QhdvQGgYeGFVVu5+S/fYVHnKp5GxBaGBlMTABhThVuGt13tnBe53rV/x6qzCs vNiuBbKDldvRBEmHSXzBx2sm+moLMOQ= X-Stat-Signature: d5asrbqdddmfxyqaey1unwzhtadtk7gu X-Rspamd-Queue-Id: 2DEE0A0027 Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Rspam-User: X-Rspamd-Server: rspam03 X-HE-Tag: 1665797569-958011 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/10/6 11:30, Mike Kravetz wrote: > To address build issues: > > >>>From b6d359f77d32c7734fe4f00806a0ed1e99925534 Mon Sep 17 00:00:00 2001 > From: Mike Kravetz > Date: Wed, 5 Oct 2022 20:26:19 -0700 > Subject: [PATCH 2/3] hugetlb: take hugetlb vma_lock when clearing > vma_lock->vma pointer > > hugetlb file truncation/hole punch code may need to back out and take > locks in order in the routine hugetlb_unmap_file_folio(). This code > could race with vma freeing as pointed out in [1] and result in > accessing a stale vma pointer. To address this, take the vma_lock when > clearing the vma_lock->vma pointer. > > [1] https://lore.kernel.org/linux-mm/01f10195-7088-4462-6def-909549c75ef4@huawei.com/ > > Fixes: "hugetlb: use new vma_lock for pmd sharing synchronization" > Signed-off-by: Mike Kravetz This patch looks good to me. Thanks. Reviewed-by: Miaohe Lin Thanks, Miaohe Lin