From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 065CFC433ED for ; Wed, 14 Apr 2021 16:20:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 55927611B0 for ; Wed, 14 Apr 2021 16:20:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55927611B0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C2FC56B0072; Wed, 14 Apr 2021 12:20:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C069C6B0073; Wed, 14 Apr 2021 12:20:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD15E6B0075; Wed, 14 Apr 2021 12:20:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8F2D66B0072 for ; Wed, 14 Apr 2021 12:20:40 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 46FF1182152F5 for ; Wed, 14 Apr 2021 16:20:40 +0000 (UTC) X-FDA: 78031485840.28.C969C73 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf16.hostedemail.com (Postfix) with ESMTP id 31B1180192E6 for ; Wed, 14 Apr 2021 16:20:39 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A2135AF0E; Wed, 14 Apr 2021 16:20:38 +0000 (UTC) Subject: Re: [PATCH 04/11] mm/vmstat: Inline NUMA event counter updates To: Mel Gorman , Linux-MM , Linux-RT-Users Cc: LKML , Chuck Lever , Jesper Dangaard Brouer , Thomas Gleixner , Peter Zijlstra , Ingo Molnar , Michal Hocko References: <20210414133931.4555-1-mgorman@techsingularity.net> <20210414133931.4555-5-mgorman@techsingularity.net> From: Vlastimil Babka Message-ID: <6b25af48-9c6e-2c55-03d5-763de4aba149@suse.cz> Date: Wed, 14 Apr 2021 18:20:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210414133931.4555-5-mgorman@techsingularity.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 31B1180192E6 X-Stat-Signature: urbn5qr1jztks3fjy64xcqofcxn1ygkn Received-SPF: none (suse.cz>: No applicable sender policy available) receiver=imf16; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: none/none X-HE-Tag: 1618417239-940115 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/14/21 3:39 PM, Mel Gorman wrote: > __count_numa_event is small enough to be treated similarly to > __count_vm_event so inline it. > > Signed-off-by: Mel Gorman Acked-by: Vlastimil Babka > --- > include/linux/vmstat.h | 9 +++++++++ > mm/vmstat.c | 9 --------- > 2 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/include/linux/vmstat.h b/include/linux/vmstat.h > index fc14415223c5..dde4dec4e7dd 100644 > --- a/include/linux/vmstat.h > +++ b/include/linux/vmstat.h > @@ -237,6 +237,15 @@ static inline unsigned long zone_page_state_snapshot(struct zone *zone, > } > > #ifdef CONFIG_NUMA > +/* See __count_vm_event comment on why raw_cpu_inc is used. */ > +static inline void > +__count_numa_event(struct zone *zone, enum numa_stat_item item) > +{ > + struct per_cpu_zonestat __percpu *pzstats = zone->per_cpu_zonestats; > + > + raw_cpu_inc(pzstats->vm_numa_event[item]); > +} > + > extern void __count_numa_event(struct zone *zone, enum numa_stat_item item); > extern unsigned long sum_zone_node_page_state(int node, > enum zone_stat_item item); > diff --git a/mm/vmstat.c b/mm/vmstat.c > index 63bd84d122c0..b853df95ed0c 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -902,15 +902,6 @@ void drain_zonestat(struct zone *zone, struct per_cpu_zonestat *pzstats) > #endif > > #ifdef CONFIG_NUMA > -/* See __count_vm_event comment on why raw_cpu_inc is used. */ > -void __count_numa_event(struct zone *zone, > - enum numa_stat_item item) > -{ > - struct per_cpu_zonestat __percpu *pzstats = zone->per_cpu_zonestats; > - > - raw_cpu_inc(pzstats->vm_numa_event[item]); > -} > - > /* > * Determine the per node value of a stat item. This function > * is called frequently in a NUMA machine, so try to be as >