From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AD42EB64DD for ; Thu, 29 Jun 2023 14:32:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D0438D0003; Thu, 29 Jun 2023 10:32:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 880B98D0001; Thu, 29 Jun 2023 10:32:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7495B8D0003; Thu, 29 Jun 2023 10:32:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 670548D0001 for ; Thu, 29 Jun 2023 10:32:28 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CD2F4140C2F for ; Thu, 29 Jun 2023 14:32:27 +0000 (UTC) X-FDA: 80956025934.19.B4E2E39 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.86.151]) by imf23.hostedemail.com (Postfix) with ESMTP id D559C140027 for ; Thu, 29 Jun 2023 14:32:17 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of david.laight@aculab.com designates 185.58.86.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com; dmarc=pass (policy=none) header.from=aculab.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688049138; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ch3ScGyh52zc65er2zOJWk+Dm2ZHPkLTHUaOcDWKL14=; b=5vVVDdRAVOar3UkosSOKupfZ/qX0pXB2QOByKxoXdirSrr04njdRW8kmgtZxOEGcx40Q8n oT59nGvU8rLLXDAxxJh0ZHPReVeOTaMuH1mTco2n7TjfhUdVk5PPNi3MK3T06vA/aGeukC lZ3V/MOx/lP4CF27uhB6XAQqcqsmBTk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688049138; a=rsa-sha256; cv=none; b=JVXUDf9lIFDmbxbxWr040YX/OdgZPczXm79NVaArIxBg5A7PoLTomPNcA4Ds5zAFczhhCx YoVLnAehKrtbwZwaAqXZp9xCtVYtWYU/HXfPc9pXPAWp4nKuOdjnbJiLnoYLMEIjxmGtqB YREBG7G8tKu1wOJ9duNxLIbUrRyVxeY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of david.laight@aculab.com designates 185.58.86.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com; dmarc=pass (policy=none) header.from=aculab.com Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with both STARTTLS and AUTH (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-109-zbBpsLNbOwCDzi8T2c0qSg-1; Thu, 29 Jun 2023 15:32:14 +0100 X-MC-Unique: zbBpsLNbOwCDzi8T2c0qSg-1 Received: from AcuMS.Aculab.com (10.202.163.6) by AcuMS.aculab.com (10.202.163.6) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Thu, 29 Jun 2023 15:32:13 +0100 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.048; Thu, 29 Jun 2023 15:32:13 +0100 From: David Laight To: 'Andy Shevchenko' , Andrew Morton , "kasan-dev@googlegroups.com" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" CC: Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino Subject: RE: [PATCH v1 1/1] kasan: Replace strreplace() with strchrnul() Thread-Topic: [PATCH v1 1/1] kasan: Replace strreplace() with strchrnul() Thread-Index: AQHZqdYu4WwBl+H04Ei+qjwMbhdjFK+h2Qxw Date: Thu, 29 Jun 2023 14:32:13 +0000 Message-ID: <6b241f45a61f40fe9b221696289fd658@AcuMS.aculab.com> References: <20230628153342.53406-1-andriy.shevchenko@linux.intel.com> In-Reply-To: <20230628153342.53406-1-andriy.shevchenko@linux.intel.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Stat-Signature: hnizie6frz7zfkk34wh4fkoj47qwxc3x X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: D559C140027 X-Rspam-User: X-HE-Tag: 1688049137-951292 X-HE-Meta: U2FsdGVkX1/0CrfBKpH4eu8CWs7JtpcXj6tN6RJ/KyUm8B+pkfl5c+hz2F4wx+Q7PdNtii2upch82veJXJb5X/YfFl6Y9JTsKHGHOUaAQDpxHuCXPGl4jVs19XNw+6xPRGHiYk5yU1Gk8+hbzimSxHTQwOepAmOIzQhudPmKhzWYdJjfbz5JlqH2zNlRyJ/IbXycLqTQlORfg1zQgCpNkHUOVscNW08pUQsX9bX8s8YiaXijWg3lXmpuoLug/ruQROnY071d/NSg7vr+oQHVgFA4u0Dcifqi1M2xfQe8cwL5oZVtmeDEch7MhMVyzNYCBd/co2UZGO1bmI3bGAo8umVzh4R2R4KrSjzcIv+l7resarvqYn+nXbxRdXyYcOYxTBZ/LvjX0nv4URbV6TM85TeVEcgO6qQ5vhbzOtGDW4VjeQBvP1Q0hh2wlKwVIAmtfGc37amElWbFVJJRRCHdBbicCyqPrbEi94bOnKRMZek18SkYYxDscuXnjDF5Iq8peH5SFTm5rFc2J7jAfk99+A08nrj3huCf/l/UuGOrisK7b0AB0NqYGFhtZG34L+jFxJ2HEKHr8omDnzsGy8pfHvc/Z/iMBpgz5AivFeI90Q0DqauXVJ9vLSpqIEf7nn3DsQT6/+aKOr13/fHn6B4GwmxE8VM+ld8qkPXdutO3KkI+691f4mb0ICvHKuA/ECDspN2JHVepbjKvin/N7lC+a3O8Qx6Lxf0uA3zxh1rCu82cfgeSBB42GrzIX0m+aVy6k1eFPy+Oo4NYIu3zp5S713hBn8qZdgXfvPBckDR09rQAMknRNWpNB5cGHE20gAQ4us6ZMDeJYdjXCTGwkrYuPjop9uhDRtP9oLFgEujTJV+lq3I37pEFglaXPSfbXpC7j72mBiyxwwOEN0HMv3ssWjeICO5OmojYwCA8xdPFjpLGRu228IiGIM6fH/hk75ZKv7CIAxf7SMSAIVNhMxK 1Eio/hvS QaF4612cHHfrT0eb2D8T5OK2W16UqqM70oG7aIQZDi0hxwGYkEtqyyk7attw6xNj3pyiBH/+lYc2JvVurreR5FH2NT1a9PBOph+by8bGTjPwStdHTwplEgFcCVzHqDr80SBklD7tFpB0pC9uifgnxUSSoytdpeX+L8kAl5kCYYXVjELBLGBY8yCb05v5UO7LJGL0AZFh+VxOXXLC4z4dMrMJGyHNlnRsVJIovtHd9ICDiL0xIBuplCNLHe5H6q+uVC2eHqwa+go1774EDZDXlZefPGdDlqfrFv1HqkD1QlbT1oqtF7tcfCUPm827xkW/8TwkefL7vBkuqwo4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Andy Shevchenko > Sent: 28 June 2023 16:34 >=20 > We don't need to traverse over the entire string and replace > occurrences of a character with '\0'. The first match will > suffice. Hence, replace strreplace() with strchrnul(). >=20 > Signed-off-by: Andy Shevchenko > --- > mm/kasan/report_generic.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/mm/kasan/report_generic.c b/mm/kasan/report_generic.c > index 51a1e8a8877f..63a34eac4a8c 100644 > --- a/mm/kasan/report_generic.c > +++ b/mm/kasan/report_generic.c > @@ -264,6 +264,7 @@ static void print_decoded_frame_descr(const char *fra= me_descr) > =09while (num_objects--) { > =09=09unsigned long offset; > =09=09unsigned long size; > +=09=09char *p; >=20 > =09=09/* access offset */ > =09=09if (!tokenize_frame_descr(&frame_descr, token, sizeof(token), > @@ -282,7 +283,7 @@ static void print_decoded_frame_descr(const char *fra= me_descr) > =09=09=09return; >=20 > =09=09/* Strip line number; without filename it's not very helpful. */ > -=09=09strreplace(token, ':', '\0'); > +=09=09p[strchrnul(token, ':') - token] =3D '\0'; Isn't 'p' undefined here? =09David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1= PT, UK Registration No: 1397386 (Wales)