From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3946C25B78 for ; Tue, 4 Jun 2024 12:31:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F0ED6B00AE; Tue, 4 Jun 2024 08:31:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A1716B00C3; Tue, 4 Jun 2024 08:31:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 342166B00C4; Tue, 4 Jun 2024 08:31:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 168F06B00AE for ; Tue, 4 Jun 2024 08:31:10 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B17E516059D for ; Tue, 4 Jun 2024 12:31:09 +0000 (UTC) X-FDA: 82193141058.29.212690B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 5370E140010 for ; Tue, 4 Jun 2024 12:31:07 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MbeQq4Bk; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717504267; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pxBbH0lhXHJMihWPKVtSiFVLyKo1HrHgO+/fn5W2KeM=; b=HHlI3zftUjFlu1UhsMd3chaPOfeXiudcoHnEutbwbfZf9xwLTNGvWqe91k4MWtiekjNPhw lDLh5m559UWDGVfGZIKKAfN1LaOQCWcynE6gxqq9Wjnom5SZY6jLLAJ+9xkQ4x+T+9Icyk hgnbbUcI4NaUywSHjbbaqMwxn+Gq8UE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717504267; a=rsa-sha256; cv=none; b=zeKiu/D2cfyuBE7nis5iy9QHYZ8kkNVF8EuriCo/BXngMHSKbqV14VeAKfSiTKQqrUMszN e1HToTP2X0UvAaY2heZVJdY1Psj08oB5ntKaTr/6X3PVGUsA4o47OURD9fjt0ENZYR2yRg jgnbOjumu2fWR9eiSnZ66PxmwM43bJU= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MbeQq4Bk; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717504266; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=pxBbH0lhXHJMihWPKVtSiFVLyKo1HrHgO+/fn5W2KeM=; b=MbeQq4BkzNU/QmF5vjvs+43vxJ+T/8pKHnonlxBK/8XP+vzPKN5WwUMnrgpfXMs1bUNM52 a5Yp2KdCNzzFzQ6XteZDV3VY3JmwBQZbI5KjrN9SmLteqXLl3NuYvbwAi5oF5DAjebvL4V nKUSg4bzxb32gz4V7e0rdeifc2OCWDg= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-120-0q8kzV2CN12zt9d8Ksb1sw-1; Tue, 04 Jun 2024 08:31:03 -0400 X-MC-Unique: 0q8kzV2CN12zt9d8Ksb1sw-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-52b86cce7d6so3252157e87.3 for ; Tue, 04 Jun 2024 05:31:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717504261; x=1718109061; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=pxBbH0lhXHJMihWPKVtSiFVLyKo1HrHgO+/fn5W2KeM=; b=bAwvQA2J9NnzF8JySDHyR06BmCkCS+3JchtWafCrMTpKrBRe6RmPkpM+CMH0iYb9GI 4GyhjIp+9lR2sOWT1GEa/lUa9dcXiv4mEAq2Dz3PsXDZgJdMQRYNd4QkJQU4ScpYaeBR waqIEGJ4fAmTAus7rWPKnrQKhi6uRLidiab17WUQQznix0N8tQo41MfBZtphtnOS6PMM u4DQ5Gy3eeTPhLwChqsrhbg13INyaNSwKAl/y9YLY5WEDx7GWlOK07urUtUphrx2HDt+ DfW4MA8QsxxV0reOV4QQojURZOBt1GFg+qtAWhBQmH/DQyaSG7MnwTs8J/mluH+bx8H5 GH7w== X-Forwarded-Encrypted: i=1; AJvYcCWNqc9R/t4uH/khgPPgoPDUbLWl6CkYqQnex9nlxzd3K+b/cNTGh4pob7+prgHSZW2Lqa2IWSEfZYAHrAU8UIpjvA8= X-Gm-Message-State: AOJu0YyICWCFnK3NYGZFcRDwMnG59kFaDvGyU+kVMaIFcxtNSNpARAR6 V4Jg6zuky0EyOFbowZ9Et1oczjCb0cVNMjUX74EcUiElMh53qGwm/ZTlLOp2u6CRO4P9lZdQX9L NMO4RLhFxHzZJeRfhBXH9eBD/7Ickln2Z812IiteIbjYp3XqQ X-Received: by 2002:a05:6512:3b81:b0:52b:88b1:4808 with SMTP id 2adb3069b0e04-52b8949e166mr11394375e87.0.1717504261600; Tue, 04 Jun 2024 05:31:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHaSazEaFcheN/uDwxGwrBRJEA+oxIKfmfu94LgsHzsJ7VYktNu58dqlseBmvrFCVXDeQ/9PQ== X-Received: by 2002:a05:6512:3b81:b0:52b:88b1:4808 with SMTP id 2adb3069b0e04-52b8949e166mr11394348e87.0.1717504261085; Tue, 04 Jun 2024 05:31:01 -0700 (PDT) Received: from ?IPV6:2003:cb:c73a:3a00:a025:9b06:549e:c16b? (p200300cbc73a3a00a0259b06549ec16b.dip0.t-ipconnect.de. [2003:cb:c73a:3a00:a025:9b06:549e:c16b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35dd04caf50sm11446760f8f.41.2024.06.04.05.31.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jun 2024 05:31:00 -0700 (PDT) Message-ID: <6b1485b6-c2a1-45b8-8afe-7b211689070b@redhat.com> Date: Tue, 4 Jun 2024 14:30:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] mm: clear pte for folios that are zero filled To: Usama Arif , akpm@linux-foundation.org Cc: hannes@cmpxchg.org, willy@infradead.org, yosryahmed@google.com, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com References: <20240604105950.1134192-1-usamaarif642@gmail.com> <20240604105950.1134192-2-usamaarif642@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240604105950.1134192-2-usamaarif642@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: mnkk4yugo9xdwz9dpwytppyzbjrjk51g X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 5370E140010 X-HE-Tag: 1717504267-579296 X-HE-Meta: U2FsdGVkX19pI+np1+Nrn5vaS9hg7IkysHRD/zZtXhzugHORZd4BVME+TQFRTk/Y8rrq50XoWmCb7aa7CBj4sEL/2kQZefCHaS4JSWNGc6/26TPrSqD4u09cnALwn8QRCUGTa0hlEINqN5BHKowG2szTPTEAmr8+TSE6GGYqZ+etLEUTbJqfNM1MavHbiXbrCdAdXJmvOmUWOGEaJZBOVrgB0BeW7dGBLxnn0wdewORI+uHkyz18/j4BGU47L7IIKbvsvflne5lILIYGkNGUpHF+pv24GXQ+ShbOONtctynmrDk8k2Yd+smdtqQwIRTfLvaIVbTT6FJvZqY8FG53NTATfBqa1hXXSRiW8DebnpRY1jM+WzmkAQsj9qPXyXGwpteBkYhnLS+TxSBZo2OYbZvezF/rQVd1cFwmUs2gykNGO/1mvscsPMLJKuN6chII1wUm9lS47VXRCd7xqQFo9O3Yi5gZ6CVQSDkU0KLU773Kg7Ct4PN87ruPUg6UQzpnJ/Dfc2KRZOJRNhtxmnX2E0oCBVGUM37cYfZvNtZat1DcpWl1N6OKaXCNLJXNysBARdgjkVGJx0itAapHYQTvwSGICJWztuvv5hM6yGz3Qa8EE3xrqnWLnbcE5a5ZJkvAf5bTORFt84YOSlnZxDMCL9I73/2jbfC0ppl1O+EvhFTLC2AMdCiccRAi0OL8qCnuIuyDxQqUommpJDUYX/nITEXg1WZt2rl9PW1fUfxA0w6EOg6+BgVA3An6tS/jjaPvIFG0e5X5UUjozerbuUGQLVb7aOg7M6xhMgFymq/1CE8+DL4XnlrzDblmELd4t1tRnHx1O2fEmpVaFiiIhcuPj0jH26BsgZXJ4S6hRooQ1tMoH803d3XDBNrHZo4h4538hqSHqWjqSfMAAZ3W9nZfCnv75xXrTJa3HM/gwzwAQE7Mlxvd12xo0oKg8HWSXOMM2ZvlqOQOosNoE1ws5Ti Zkda+mgz K0k/jdhfa33qDlxS3emU1A8nPmrf0FjQxyBpkQ954p1jk4fOep1laCtC8h9/gllC6gtVsWjmhK5Ykf5ZAJFa1bUY2lrc+nwrhFtsbhpwfE19QYHKPh1YIKRr3hCj/oKK3JKQU4Ny3ipDqHTSnuoxylAY9pBQoB1ybuch3FEypUCeSLAHLztqZYGPYk5+j6JhRR/xmocXoxRCGcYAe9TPI3g9AO2QIXtZfyNeNXE/X68AmfqBzNsUAyhnqghBq5pFpS4TBOIZbioDCZ+SNNgPPwFU5eiVfHrajT+eiFA6w5AuR6jQkA6Fh53gYVbxcjjClINjdKltwBnOJDy5+t+VYrNDWo2ylWhYm2u0H1jjU4Ru7Eu3DEuDurSuLVjxYg2lvHVFLYSRjXYk1GUqjyGhly8fVj78K5yjkbpmLGIxXo+sbfnnTj8mLoZ+babG3CqlWtB2UuQyquqN3G3KWOvJji3C/Ord4XAaR2C/jQU9H35RlAhWDwBi2UTwOEvJzKyFdoEtPEBVlS8MOFiUaD7rN/XWLCIYd+GVfe7y02ECQCrFG0jg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.06.24 12:58, Usama Arif wrote: > Approximately 10-20% of pages to be swapped out are zero pages [1]. > Rather than reading/writing these pages to flash resulting > in increased I/O and flash wear, the pte can be cleared for those > addresses at unmap time while shrinking folio list. When this > causes a page fault, do_pte_missing will take care of this page. > With this patch, NVMe writes in Meta server fleet decreased > by almost 10% with conventional swap setup (zswap disabled). > > [1] https://lore.kernel.org/all/20171018104832epcms5p1b2232e2236258de3d03d1344dde9fce0@epcms5p1/ > > Signed-off-by: Usama Arif > --- > include/linux/rmap.h | 1 + > mm/rmap.c | 163 ++++++++++++++++++++++--------------------- > mm/vmscan.c | 89 ++++++++++++++++------- > 3 files changed, 150 insertions(+), 103 deletions(-) > > diff --git a/include/linux/rmap.h b/include/linux/rmap.h > index bb53e5920b88..b36db1e886e4 100644 > --- a/include/linux/rmap.h > +++ b/include/linux/rmap.h > @@ -100,6 +100,7 @@ enum ttu_flags { > * do a final flush if necessary */ > TTU_RMAP_LOCKED = 0x80, /* do not grab rmap lock: > * caller holds it */ > + TTU_ZERO_FOLIO = 0x100,/* zero folio */ > }; > > #ifdef CONFIG_MMU > diff --git a/mm/rmap.c b/mm/rmap.c > index 52357d79917c..d98f70876327 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -1819,96 +1819,101 @@ static bool try_to_unmap_one(struct folio *folio, struct vm_area_struct *vma, > */ > dec_mm_counter(mm, mm_counter(folio)); > } else if (folio_test_anon(folio)) { > - swp_entry_t entry = page_swap_entry(subpage); > - pte_t swp_pte; > - /* > - * Store the swap location in the pte. > - * See handle_pte_fault() ... > - */ > - if (unlikely(folio_test_swapbacked(folio) != > - folio_test_swapcache(folio))) { > + if (flags & TTU_ZERO_FOLIO) { > + pte_clear(mm, address, pvmw.pte); > + dec_mm_counter(mm, MM_ANONPAGES); Is there an easy way to reduce the code churn and highlight the added code? Like } else if (folio_test_anon(folio) && (flags & TTU_ZERO_FOLIO)) { } else if (folio_test_anon(folio)) { Also to concerns that I want to spell out: (a) what stops the page from getting modified in the meantime? The CPU can write it until the TLB was flushed. (b) do you properly handle if the page is pinned (or just got pinned) and we must not discard it? -- Cheers, David / dhildenb