From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72F38CD37A9 for ; Tue, 3 Sep 2024 17:18:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C16508D01B0; Tue, 3 Sep 2024 13:18:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC6308D018A; Tue, 3 Sep 2024 13:18:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB6978D01B0; Tue, 3 Sep 2024 13:18:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8D53A8D018A for ; Tue, 3 Sep 2024 13:18:35 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5114C14072A for ; Tue, 3 Sep 2024 17:18:35 +0000 (UTC) X-FDA: 82524086190.22.B814FAF Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by imf19.hostedemail.com (Postfix) with ESMTP id E54CD1A0007 for ; Tue, 3 Sep 2024 17:18:32 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu; dmarc=pass (policy=quarantine) header.from=csgroup.eu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725383838; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E6rVrw28lQjxJVfoXcBiTrAsfiC6FfVhGXY+ztmNnoc=; b=A0tzj6/Z+ysdKqgXmyKc1n+UF9EFp+AWkFHwbFmk1RngkuWsVbd6SBddMNU9xCwyrdNkCV g2J8LRfklllEfqDqBKxhU4Q80Cc+JDkHscuo1wLEzLcJ10MWK9nUysUURVWVpENaw8NMiH y6FmbY3YHKwy50xVciHDVsP+LJrFjWc= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu; dmarc=pass (policy=quarantine) header.from=csgroup.eu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725383838; a=rsa-sha256; cv=none; b=YkbyM3mKOvGPXczJjrbrE6YPSdPIiX9+HzrtXZegub3zYnEHbI4jf8yB1JL9C/HjW4r92c /hNtHWcFXlg+/saE8D8xyRgbt75SxQCVZq8qrsX21VjmFRZ2cFmSpd/qhJOpmAp5LkcH+/ hSLKOH0JMAhIG2cBSRiRPoE1l0h19NM= Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4Wyslp6shpz9sSC; Tue, 3 Sep 2024 19:18:30 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hEi4N-oS1BVW; Tue, 3 Sep 2024 19:18:30 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4Wysln4fbCz9sSH; Tue, 3 Sep 2024 19:18:29 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 7E91E8B779; Tue, 3 Sep 2024 19:18:29 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id pxEcRzUEidZI; Tue, 3 Sep 2024 19:18:29 +0200 (CEST) Received: from [192.168.234.228] (unknown [192.168.234.228]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 3CEB98B774; Tue, 3 Sep 2024 19:18:27 +0200 (CEST) Message-ID: <6b07c48d-656f-4e42-bfa7-0ecead72a7b8@csgroup.eu> Date: Tue, 3 Sep 2024 19:18:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v2 2/4] mm: Add hint and mmap_flags to struct vm_unmapped_area_info To: Charlie Jenkins , Arnd Bergmann , Richard Henderson , Ivan Kokshaysky , Matt Turner , Vineet Gupta , Russell King , Guo Ren , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Andreas Larsson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Muchun Song , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , Shuah Khan Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20240829-patches-below_hint_mmap-v2-0-638a28d9eae0@rivosinc.com> <20240829-patches-below_hint_mmap-v2-2-638a28d9eae0@rivosinc.com> Content-Language: fr-FR From: Christophe Leroy In-Reply-To: <20240829-patches-below_hint_mmap-v2-2-638a28d9eae0@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: tdmbxfkh766r9ctrc81k5ped16pbjoaf X-Rspam-User: X-Rspamd-Queue-Id: E54CD1A0007 X-Rspamd-Server: rspam02 X-HE-Tag: 1725383912-616450 X-HE-Meta: U2FsdGVkX18wXX+4hUjGs+vZNttTco+7Y4ISUILneTJxO+GvoG4zlDoh0szK+37qzsYROhCrnJ8/H3xnPt8YzrOuPhOvTYjgCkRBrmg03YEZP1KWTKca7sl4uH1ovWJlxqN7iI97tjxDg9V9zz8Yt8vDh4nDex4UGd/pDVnVKvcpskkT9nTK3/xZq6mNgsS8xWqEjC/2dpAIP5TQhiNkv7ZoF4P52H5LomJNMw+tyEjs2WmQoyxaF8RdTmL1P/2FEJruDbId8GrnPHZcz4i8Rq7cGBmdYgSgmF9w+hV6hHdGa8aM6w8mSW4qe4m4mlfgn0+438U9Ok5NmXVs2HXJ2pI6S9+6Gv1Fn6Zf1I6tQJUBnqJIFRbV+MU5GXjJ3BGxF6jMC1IUPhotP11FKn3Y2tJq7gcEUNDi/MUGza4D8K41Zd3R31ZPqUaj6kxtCKK6f8KmJT8fcr8tGKWxfddkQ6Vxu5TvODjT7zN3LKJgjk8fbPl+8wKNLO7Rww6mAWQTNkV1wD+0HqOlUb+pm+d4LGIPqoeKVHK0WgyFs+cyFEBwemQsKf3fWIfOcWPijT/uyOIPCpxRh0jJsNuKpWPKFs+XZ3JtHpJ9Cjz9snv7zSapSmz602KLLLNC6S0C3JrAC+rQudR9+JbjhESLdP8j8xO0REOe8SBSlPwTwKkNnCBqSsDaWF7aX5fnnQZeBWyQGIX7h25CJFBFSK/WhZe+rQ/6YdulN/Qs9rlzN4aCmIEdFfvMpl4+GcTWH3n3eek7gYXbOV9LMWK5sO8/a5pNT3+Lxx5zQ2eHepBYs1xzq5fmgX++0AQ3iUY7vT+77W6pPhlYvjpW9jmMpf8XfgjVuAofQpUijiBlYPUd5wm+zH3GGYzCClifQ9EOCnNEshvW037V5nRsjYQqgZMi8pB+J8j1FZrzP4LjltO23bJPgSXHiYvqgXkMjAcwoMIQB4K1Clu5ki3ze8+Vx2U6Iif qR/y4pvI /59sbPa6ftWhsB8mKy1guGy0Eoo3BxOXbm6uPO909BCNyse+KbX11C7Pq6/Bz0uR58C+odP92XJeCTrU44WnK2D+Lj9j6tAdZtaujFPJP0DKLEMR9N3gigaXDNbjp7k8TmPO/GCrwEKW/A7iJXIxSAWB7leq3Ns7PnO4rwC2v88bYmeg4ITrXRe2+SpW19eK1THGy2n0NP6ERX3UemDhG2HlsW+XaED0E3tqqurLw9R7veg0L5UHhFj4wAw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Charlie, Le 29/08/2024 à 09:15, Charlie Jenkins a écrit : > The hint address and mmap_flags are necessary to determine if > MAP_BELOW_HINT requirements are satisfied. > > Signed-off-by: Charlie Jenkins > --- > arch/alpha/kernel/osf_sys.c | 2 ++ > arch/arc/mm/mmap.c | 3 +++ > arch/arm/mm/mmap.c | 7 +++++++ > arch/csky/abiv1/mmap.c | 3 +++ > arch/loongarch/mm/mmap.c | 3 +++ > arch/mips/mm/mmap.c | 3 +++ > arch/parisc/kernel/sys_parisc.c | 3 +++ > arch/powerpc/mm/book3s64/slice.c | 7 +++++++ > arch/s390/mm/hugetlbpage.c | 4 ++++ > arch/s390/mm/mmap.c | 6 ++++++ > arch/sh/mm/mmap.c | 6 ++++++ > arch/sparc/kernel/sys_sparc_32.c | 3 +++ > arch/sparc/kernel/sys_sparc_64.c | 6 ++++++ > arch/sparc/mm/hugetlbpage.c | 4 ++++ > arch/x86/kernel/sys_x86_64.c | 6 ++++++ > arch/x86/mm/hugetlbpage.c | 4 ++++ > fs/hugetlbfs/inode.c | 4 ++++ > include/linux/mm.h | 2 ++ > mm/mmap.c | 6 ++++++ > 19 files changed, 82 insertions(+) > > > diff --git a/arch/powerpc/mm/book3s64/slice.c b/arch/powerpc/mm/book3s64/slice.c > index ef3ce37f1bb3..f0e2550af6d0 100644 > --- a/arch/powerpc/mm/book3s64/slice.c > +++ b/arch/powerpc/mm/book3s64/slice.c > @@ -286,6 +286,10 @@ static unsigned long slice_find_area_bottomup(struct mm_struct *mm, > .length = len, > .align_mask = PAGE_MASK & ((1ul << pshift) - 1), > }; > + > + info.hint = addr; > + info.mmap_flags = flags; > + > /* > * Check till the allow max value for this mmap request > */ > @@ -331,6 +335,9 @@ static unsigned long slice_find_area_topdown(struct mm_struct *mm, > }; > unsigned long min_addr = max(PAGE_SIZE, mmap_min_addr); > > + info.hint = addr; > + info.mmap_flags = flags; > + > /* > * If we are trying to allocate above DEFAULT_MAP_WINDOW > * Add the different to the mmap_base. ppc64_defconfig: CC arch/powerpc/mm/book3s64/slice.o arch/powerpc/mm/book3s64/slice.c: In function 'slice_find_area_bottomup': arch/powerpc/mm/book3s64/slice.c:291:27: error: 'flags' undeclared (first use in this function) 291 | info.mmap_flags = flags; | ^~~~~ arch/powerpc/mm/book3s64/slice.c:291:27: note: each undeclared identifier is reported only once for each function it appears in arch/powerpc/mm/book3s64/slice.c: In function 'slice_find_area_topdown': arch/powerpc/mm/book3s64/slice.c:339:27: error: 'flags' undeclared (first use in this function) 339 | info.mmap_flags = flags; | ^~~~~ make[5]: *** [scripts/Makefile.build:244: arch/powerpc/mm/book3s64/slice.o] Error 1