From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B317EC54E66 for ; Wed, 13 Mar 2024 16:53:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B9D180041; Wed, 13 Mar 2024 12:53:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 46A0F940010; Wed, 13 Mar 2024 12:53:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E38980041; Wed, 13 Mar 2024 12:53:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1E02E940010 for ; Wed, 13 Mar 2024 12:53:32 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DEB261C0AA9 for ; Wed, 13 Mar 2024 16:53:31 +0000 (UTC) X-FDA: 81892611822.21.54A1828 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 88063180002 for ; Wed, 13 Mar 2024 16:53:29 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XeVTi803; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710348809; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9subfqZjR0a+NiaN6uyBhsEQ5FjGQByI++lZ7kQPwm8=; b=1wrerNr6ugzPzFytd22aav0gaR/JsQgu45LfYIYczICjyGL5Y7iRT4KR5ZdxPOAvpaWLyc kEvCOjzgMhXwZLOfrjUydxMtqc+55Qzrgul3iNDvNlUelbU+21bQtLYDF8kWcYQGucDC9I kGiNW9wKBlnnqDodCYsvXALuHF9I650= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XeVTi803; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710348809; a=rsa-sha256; cv=none; b=THnGuSSxlDWBAyPM57NaZ6iFhsBbAZ1ayruYn+0oa7SlnrM+E6ZWKwlyzpTd79XwrpebpX LNiT8nMCESYmd5E+i5ElHNtFTPREq+cfjuNADO9ocJHRVd/50JKxF5sSjbxjWFv9x990ns g8bafDv3a8sY4J1rrUn16rtuv1VfZ0w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710348808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9subfqZjR0a+NiaN6uyBhsEQ5FjGQByI++lZ7kQPwm8=; b=XeVTi803U8UTn5FbbQlkOCZJW1A2z7thMAC2Pn5OsH49Y36L6VxtoHw+bPjYibOIi/JF9l lKEnEDsbBR36rCPDIZUUAKTtzidYkxnrblQxxv6L8qZHXJ5tO/4yjgdELzEuPnL7Nho3nj lzYHf4oIJ8asLr9JpFgnKftWU1Jutl4= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-608-n3eJWlPWNmmaFX-KuVxdHw-1; Wed, 13 Mar 2024 12:53:27 -0400 X-MC-Unique: n3eJWlPWNmmaFX-KuVxdHw-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-33e67c6b7bdso3709329f8f.2 for ; Wed, 13 Mar 2024 09:53:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710348806; x=1710953606; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9subfqZjR0a+NiaN6uyBhsEQ5FjGQByI++lZ7kQPwm8=; b=pzEP2aDXVUj/Cncxb5+NaXQoxNbXGNenx5iPZsBSFpUC5vp12gyjVuL59AhTVFzmFP pVXm2aI3Nquw2MoxpaKGomLD5Bmaz70nBd0svvd3YgLRqUFBSAehpHGOt/5zOW5OI6/f OdcPtvAXQZf0dhlsK/sGKWDvtcT2zJYfgr/IyTVbid1+1lFZaQpU0wqIKzbEvY5rS+vo r+t4or+5+gWKuZfuyUdRd2216QjCJkXvAFFnuS6QnSnqO/UUj5oIusHbUQPU/iEu5bcX Dmsb8S+xGmRd/vF2qHgYRpqIZenzQoI+D8DSB3Ag7aVG7cjOMH+o8bySFeAhPigA496F Yc/g== X-Forwarded-Encrypted: i=1; AJvYcCWFjP7BYwohIthDAdOPL/EfsfOvL2jQeTf6peD+igFdA/EEuKhSU2j7HfEEL0KcWbGYIB8FDaQcvofOmbbX2nULj7w= X-Gm-Message-State: AOJu0YzIpOX7jDMgKp/l4M7ElX4zACBbXQzS7w9yi/MiTfSFBmCUNd2T f+AlfcLqBXwy4rnjtbOWX7xSduFXaPPklAsfOh9aN8vPIZv6q9T0kg76iFyZX6HYyWgsKlsZSHo h7kaB09o+rFPCTUSQYaKt3m5X09Yk47NOfDD6xhE/HTAO9HZ3 X-Received: by 2002:a5d:4110:0:b0:33e:5fb9:af21 with SMTP id l16-20020a5d4110000000b0033e5fb9af21mr2226617wrp.56.1710348806169; Wed, 13 Mar 2024 09:53:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH0mNM/TvZQtDiwS2JETN3sNsL4XHCHpckBw5moYJUt6aXZTqnxy6jXPmQLCO98+74XZESKWw== X-Received: by 2002:a5d:4110:0:b0:33e:5fb9:af21 with SMTP id l16-20020a5d4110000000b0033e5fb9af21mr2226607wrp.56.1710348805755; Wed, 13 Mar 2024 09:53:25 -0700 (PDT) Received: from ?IPV6:2003:cb:c70e:2600:cd60:7701:f644:b131? (p200300cbc70e2600cd607701f644b131.dip0.t-ipconnect.de. [2003:cb:c70e:2600:cd60:7701:f644:b131]) by smtp.gmail.com with ESMTPSA id a17-20020adffad1000000b0033dc7e50488sm12000899wrs.96.2024.03.13.09.53.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Mar 2024 09:53:25 -0700 (PDT) Message-ID: <6af71fb7-5376-4d5b-beef-78c2b2359b0a@redhat.com> Date: Wed, 13 Mar 2024 17:53:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Splitting pinned folios To: Matthew Wilcox Cc: Jane Chu , linux-mm@kvack.org, John Hubbard References: <57c9e228-9aca-4da6-a714-f175f053ff50@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 88063180002 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: bjws9t6eybzs9bo8nfichbsabh8ibrdo X-HE-Tag: 1710348809-167992 X-HE-Meta: U2FsdGVkX18HI2hFmqM9RBBNxBVh+DPg9H4IrfeTXX8veZZHPUmM5hI2HlAPZM6n5DoXQyM759HfV7SjeM2kG0TYm+VzYwWmNEUBsZTLRJopz86KXBLANhl6eaw8es33NZEQJfqsS72uZ+e5XmsTtvd7peU2O16DN3yO3L5PaNh94RXflv/TC5th5YUG6XXVZFUo7mUTvX+vS+lEgA4Jf4oHC95t05L/xzsYoBGoEDPsmAlYMspgKo1SLREYbWffoIoHWqZVug9jDs8VRyqemWHkiQThtQnjYebTkBybOhbEbuwD30d2/pvr15m2Ewng33qsY+6Ji2N3KdqEDJu5/hT3bx2OxmhxHnyxMlMifEUZzNZNcqzVKNsJg0UWIkkFoCpvG667offK28bgfTyKOZ2QLQ0evhGVDKzjWaw71qgOYlqHzhdZkRouXzZL40cmz4Wg4RUCDQRTHNFH1GzXyc+Y1eRK86xM3dwXiYyyYxOw6qQgvbHS6QRjD2JuJBiPRm7g0OrthyXvfLNSxihtCbosM4mpCJa9QCBK8EyLCnpGYAM1mmSPBIha78G/J/WDinGeBv3oURiWBqAQHUVI0XhMAHIaJx7ycU3NtH3ASu+C/0J+hxmaCBoQAxODBiyyYLOlDUOUWIjq8xQ09wkHlyfAwFFnJuwPUTzJT83WUVZMURvXLvMijCZskon+2/CrWKH7RFETMEB0oe0ORaD71fqOmUa8utQzhFV0U5tuCPoU6fKZcGD60ivFCn2tMf0xYN4SCqsL/3NXxsIYL2d1ki43VitNpaHTBnqkRRiJXfpwC0aXh9j9PR0Cq384UIy/W/MUQuB0yDuP6O8Up0DH6XG+yyGJ5LQ7upoxRjKwQH8whc1zyF1e2lBqMMdpxTUKR4/U0Vb4Zcc7h0ez1r591xxgo87vmqD61/KUuac6lM27ZQqe8PMq7QIVqQOqtTHXoSYncormHoQJ108kLrI BTFB1GlB 87epFJ/XnMtdbMOgW7A+le0WAd3vOTcXjq8UcHzBN3U8wk9uObz6zWrcNNKhDMWgZqliCiSFLIaupeH34T26UX6hVRxzkyvAYE/AKC8vwQvpSF69OM6JudtCfjfSXaJk8GqhZMak56IMYen4bg54z0Ifq66ElabxhTDxX9F/+3twFjbaDuiZrPFwns30Srfba3xHx9H2QWv+ywU6AmJ2sxNvUxkjD0gBd8HNzofCec6vhMQIps1+S/zir0AyzkhVB9tDJyqf2GnRh8h8h3cTRZISMMn8HJBYVMZiJqNjpxpNdBc4B9vsZ4p5x9Qrul/SmJD6qC1H7cJAX/qt5OZOJjvh3eRtInenXz21wKHdQEquAxu12nTsI+q5jOi95CBH7VDo7opd8bfGbUyjOIIdv1FhndQj/Orm2TssR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > * 1 reference if the folio has private data (thank you, bufferheads) > > Oh. Is that the bug? can_split_folio() doesn't know that. This > usually isn't a problem because, eg, truncate_inode_partial_folio() > will remove the private data before calling split_folio(). But > memory-failure doesn't know about that rule ... The worst thing that could happen is that splitting the folio would fail (because one more unexpected reference), not that we would split where we shouldn't, right? > > No, that's not it. shmem doesn't use the folio private flag. It's > still a bug, but it's not Jane's bug. Maybe *something* really accidentally dropped a page reference :/ Reproducer + details would be great. -- Cheers, David / dhildenb