From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A325C83F17 for ; Thu, 10 Jul 2025 13:10:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C1E66B0088; Thu, 10 Jul 2025 09:10:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 672F16B0089; Thu, 10 Jul 2025 09:10:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 562296B008C; Thu, 10 Jul 2025 09:10:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 46D5F6B0088 for ; Thu, 10 Jul 2025 09:10:56 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9A33C10A2C2 for ; Thu, 10 Jul 2025 13:10:55 +0000 (UTC) X-FDA: 83648390070.29.7777F1B Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf07.hostedemail.com (Postfix) with ESMTP id 0E02040004 for ; Thu, 10 Jul 2025 13:10:52 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KsdKWddc; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=l0sr89q+; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="kBf7Qp/c"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=CUW2n3DK; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752153053; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LupMhjkB/uDWbTEKht+Z/h5iHNYORAW774wAwpd9RY4=; b=Yy57eDolmOXO1YhEpzL+tkdMoigOh3XDzszY9WLKTBlBQ4cHb+ASX1tAhh5lZEgLp009eR VlJTSrP4B2U261DbaSw2QeBFcoxaAFrD8h5lO8DifZyN5R3V85fgKlhuDO9QMbnQTAg3Qa kRRuRf14Pb63FsCu53G3Xn5AsiBiP3I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752153053; a=rsa-sha256; cv=none; b=lt9JGiyCmOe4BznDus/4/5EVLpYTlNSt3ArmYYEfkaE8Sfpi/jLIXN+HhwiSu1B3tf/zYD XGJ/LyaLz0wn3QJeKXLYRtad1s1HMBMC4onvA8tqZbC8ru9AJw8gyGBQvu+6KdRbKJ5nzx jRoV4Xic0CBvaEuDjR/rbAINVbELjDM= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KsdKWddc; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=l0sr89q+; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="kBf7Qp/c"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=CUW2n3DK; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 40EB821195; Thu, 10 Jul 2025 13:10:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1752153051; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LupMhjkB/uDWbTEKht+Z/h5iHNYORAW774wAwpd9RY4=; b=KsdKWddcUuQH5t3bCSjGyGfNniWANQv+siXnEuVPW3/OwGA7eN5GwQHXp//2/gXHNoS1Cx qGVDCHt7IkK85YaNpSv/1y3iRu4v6BGuUb9povPCIjA6nStte8wIaDHq8Fe5QiSNCJS+tw LA4yh5inHOwDPGzDWZwvz9hQrNVhcL4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1752153051; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LupMhjkB/uDWbTEKht+Z/h5iHNYORAW774wAwpd9RY4=; b=l0sr89q+KBqqQkH6cE6QikTwTnHYZgySlmD415AD0w37JuhottHnqhpmNyxoj2fejQm7JM TV74Ir9gTszs5qDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1752153049; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LupMhjkB/uDWbTEKht+Z/h5iHNYORAW774wAwpd9RY4=; b=kBf7Qp/cBduUresleKEkNAtEuRcKSzdAQPepvT4MEQIbplycaUxvOM2kI9718xuINxi3+o iyWq2Z/BLDn4/EOdfhkBydllwjKfYydzqRcwJYKvKX80NBVwllcNzGyHjlB4l2ZiFCgt9+ F4WCqGdBdnkh/vcVY1DUU1Tsr3bCBo0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1752153049; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LupMhjkB/uDWbTEKht+Z/h5iHNYORAW774wAwpd9RY4=; b=CUW2n3DKhjlww7xXsik0Ded+2T1pbKCAPtc2a2wYnnWDKwGraiGSQ9+Iv+a7kVAZr2OUyQ 2o9R+vwKjA/XhvAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 264B4136CB; Thu, 10 Jul 2025 13:10:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id eBT9CNm7b2j4GQAAD6G6ig (envelope-from ); Thu, 10 Jul 2025 13:10:49 +0000 Message-ID: <6ad9d952-dffc-4766-ad07-de31ede0889a@suse.cz> Date: Thu, 10 Jul 2025 15:10:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/10] mm/mremap: put VMA check and prep logic into helper function Content-Language: en-US To: Lorenzo Stoakes , Andrew Morton Cc: Peter Xu , Alexander Viro , Christian Brauner , Jan Kara , "Liam R . Howlett" , Jann Horn , Pedro Falcato , Rik van Riel , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org References: From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0E02040004 X-Stat-Signature: wmp4oracg949o6tiifx1rmtnooacyp95 X-HE-Tag: 1752153052-297974 X-HE-Meta: U2FsdGVkX1+mW8jN0RlMMZVVHQqng1x25wAebEEDnOAVzE0+HOw8gthYXU+wJyXcJSOErueN0fMQxcaYYiWgJZRpxY2NqFNOpideGmXmbeCQnN/bWm07pbQKaHNl8zs/izwFX/9S5vTomlx50pOftGuxxcmZ7LY9W454l5zzX6pnEIFwijbT7DBp9m6AKAzeyBQPMuM5GvZYrx4ijMAYb1FaQm6nYkvITxtCWBi8mdRXjfAR5tIouH6YAtk+n6xmBtWz7SMiX7j94QM7P14TNY1Ek6yiSUSj+LivpgPMFBb+fNTaWvBFmd1vaJTF7CnE3Hk4bYVufzoSdiaCL3mBIxOua1urMifPNlCYEjS973I2JclEgnK1ovReoSniJ9/irPDnN1Uy5yX7XtDZpdTkU+o+pNLk5C5TzsSnCufS0tRdFQkqULU67e4b/QpLeIvk5UT0JSQnIaU8H71sEZF9Y5ywfADdzAnSR7yCvkm4vbp++RvAO9Sc5LuACJGgZ/ibYvw8FxRuA8R7+FLmUp8Lxe3Z3vX5ZWZPNsFQrIv/4BpQmNs5LlCv8hUMr/ykQIeFSZEZhpSegouXP0f6oke9yxavRYbChT4rOVnm2cb0/CUOlZXR09syLx7IoHwFhNXWO1k6AieYPyzy6+n8x25btmpUMMzY8WlVcpsKYPDwojJAM+wZ8pVBPpTvVc+5qeWgK1lVxX7mZv5ohcM3pHufzLZsEaHipDFO0CkKbJWHcKxx+2F6eAZ6HmXjsZXVYjTSnF5aRquCkXArdEqmwyqVIR85xLbZym0SJRdMsOh7NE+yrHL7SKCkny/xbaT/IyhaVWlQ171lSYm3xWMvoqqgPylVPkJ+gsNXWqTh6ZWyrZj7HC4+PsHqHDwWbFlLgIGoKHpV1wJOYIJqeEYclV2qb2j5DfZjhem5HK7zxnhaDod0mFwnvKBhCsci7Ij/lyVdHDldlDeZFXl3qEndtu0 6ZEsHkrO 9zNaWKyp4VI0pM3Nq4n0VfR02tLXyqlm/7eQiONClOqK3Zn8VIsgxkqSxA8lhJNMH/Q74W8WdKFif8KyDWIYti8/9BxFx0/7YOlSbTLsFscwgOjlbraVp0vpJhwnKi4cPM+JPzYPiVRd2YiHAsPIwZVQBONco5guB7nm7uO0RLPMP2881Kldos0Rd03r2v4VKpU58WrZEDsP/QKH30CKzu4cLKBtrEGx9+1Bw/mpbLuO5OLFnGhVlDehpB0jt4DTfBoWHSFEznn4viGNTPgIaNPdn8gkdlzruWn0x8XqxhJYmBoILmZBSworPGg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/7/25 07:27, Lorenzo Stoakes wrote: > Rather than lumping everything together in do_mremap(), add a new helper > function, check_prep_vma(), to do the work relating to each VMA. > > This further lays groundwork for subsequent patches which will allow for > batched VMA mremap(). > > Additionally, if we set vrm->new_addr == vrm->addr when prepping the VMA, > this avoids us needing to do so in the expand VMA mlocked case. > > No functional change intended. > > Signed-off-by: Lorenzo Stoakes Reviewed-by: Vlastimil Babka