From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F4DCC77B70 for ; Mon, 17 Apr 2023 10:55:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA0B58E0003; Mon, 17 Apr 2023 06:55:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E29E98E0001; Mon, 17 Apr 2023 06:55:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA6848E0003; Mon, 17 Apr 2023 06:55:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B74DA8E0001 for ; Mon, 17 Apr 2023 06:55:38 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7906D1A0572 for ; Mon, 17 Apr 2023 10:55:38 +0000 (UTC) X-FDA: 80690577156.02.224A775 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 59EF318000A for ; Mon, 17 Apr 2023 10:55:35 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i1zmsvJd; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681728935; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lQP0jhHOILHGUYqqiFPFEP0oFPfgZ69ufmXe3pOVD4k=; b=4mT6xKw4tsT63DYV3ZyseeKbXvOXblFU32QcbV2ckhYvaKHVXkDKXVY/bHgOnX0V0A7LNR 2G5MOF9TtKIicwH+hQQIq5oxiLBgFA/Grql6lp9f9al8otaP2RmXcpLUHMFQSMH4N2ZNt3 By2cGUINhdrTXQ+A8XYtKXr+PEnOPOo= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i1zmsvJd; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681728935; a=rsa-sha256; cv=none; b=F0eynAt6OSPAVj2AKX6i12VMlFk+FEw0zC6YJHimbs0TNV9tn0H9y4Ty1PyrCYvcHRQl6u XXkfusiOWlwJVZXILEqg9VTRKuxqssxc9jeqPfa6pB9aAB/Tfi37JN1ccItShhRAA0b2XP qWFC3acOXImpRrj2mJToZq81HRTDe+o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681728934; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lQP0jhHOILHGUYqqiFPFEP0oFPfgZ69ufmXe3pOVD4k=; b=i1zmsvJd27coxJB92ZPlcAYb6rfqQM1HiaHAaplldQOmQ2AFMf1Si7PIweQeL45jhNBDTr Fe7eBX4mfWCcnB2/t918VJm58faX9i4kOh1HT0I5wOZnPBRP9JLyUQgTRK6e25HUMJJsED YuJJ4MZucH/V0I/MPZIdvC5pXuHlecA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-205-Pfnfsn8bN_K8oL2P98eo3g-1; Mon, 17 Apr 2023 06:55:33 -0400 X-MC-Unique: Pfnfsn8bN_K8oL2P98eo3g-1 Received: by mail-wm1-f72.google.com with SMTP id c20-20020a05600c171400b003f173d94427so1129412wmn.1 for ; Mon, 17 Apr 2023 03:55:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681728932; x=1684320932; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lQP0jhHOILHGUYqqiFPFEP0oFPfgZ69ufmXe3pOVD4k=; b=MeNBwj0KZeed+kOubhgk8kedschNl3xY5caekL93LglPQQbE2rb56TCNo9jjNVYwCI n3m1HjSbJu9LtjSx8Ni9q0DI3u8Mo3xc7OMEn2VyX/Vh5ho7dCMhkp7HALj60U0QC6+A dGg9MpMjV3+nDNluqEPG2mKt7l3IlqFtYyMq2WHDiFPw1vCKKdzejIzGpevpFcnYux9Y NjgAM3lXJns4+wP5NUZ0IU0Qr0OfZrmDENcMPg937/8QbKLLEFgS02r6/PToogBRmwsY PBNh9V3WjoboIG7SGvUXF6ikU1su7U86Z08dE9Y0K25+Bxyeqnt6cBtS8cVw9mmbCkmV /K8w== X-Gm-Message-State: AAQBX9fDu68LOndel+NUKF1dA5LJlEFTPkLIDDKboUYBeH/yVE9IfQgu agY6JRjvzGGaxI28GHy3UNRv3UgvxNLmHsn/JF4z/Xh/qVVgvN18cM1UXuJLUguUiuPJUjMYkq0 ohyBpMzMHwb8= X-Received: by 2002:a05:600c:3793:b0:3f1:71b3:c6b5 with SMTP id o19-20020a05600c379300b003f171b3c6b5mr3472220wmr.26.1681728932428; Mon, 17 Apr 2023 03:55:32 -0700 (PDT) X-Google-Smtp-Source: AKy350YH/86qIG88Tj0beqaD/3sOrt9ZF/SdVSy4Z1Oma4C+GIauFs3qJA38myjmhj9zrBrycpWLBQ== X-Received: by 2002:a05:600c:3793:b0:3f1:71b3:c6b5 with SMTP id o19-20020a05600c379300b003f171b3c6b5mr3472203wmr.26.1681728932040; Mon, 17 Apr 2023 03:55:32 -0700 (PDT) Received: from ?IPV6:2003:cb:c700:fc00:db07:68a9:6af5:ecdf? (p200300cbc700fc00db0768a96af5ecdf.dip0.t-ipconnect.de. [2003:cb:c700:fc00:db07:68a9:6af5:ecdf]) by smtp.gmail.com with ESMTPSA id c10-20020a7bc2aa000000b003f0ad8d1c69sm10484005wmk.25.2023.04.17.03.55.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Apr 2023 03:55:31 -0700 (PDT) Message-ID: <6ad9509c-11b6-9ada-0ee8-26cf40b3ac14@redhat.com> Date: Mon, 17 Apr 2023 12:55:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v3 1/7] mm/gup: remove unused vmas parameter from get_user_pages() To: Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Cc: Matthew Wilcox , x86@kernel.org, linux-sgx@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, kvm@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Jarkko Sakkinen , "H . Peter Anvin" , Xinhui Pan , David Airlie , Daniel Vetter , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman , Paolo Bonzini References: <28967f170eceeebf2591a5e4370d0642e0516f9b.1681558407.git.lstoakes@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <28967f170eceeebf2591a5e4370d0642e0516f9b.1681558407.git.lstoakes@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 59EF318000A X-Rspam-User: X-Stat-Signature: cgwhbrau4o1e9ch3w6m4gt3kn6uq87s6 X-HE-Tag: 1681728935-347982 X-HE-Meta: U2FsdGVkX1+Fy/sEackwxlKATum0u01/1IMcyZmiwcvRY4Oc4/07k5w5TCloCgDhFryM7X8CbLWwog1autZmBSxrpslHu5gZM/NBMN0wOSd0McTG9G986AVu5hoKqiDLKvKpfmbMVN3icgzshPfHs+/UGR1Lrh5iOH+agV37HDwEKn4NiD7vGHdA5i2WelXsWhxBcBc3dBz/QoFf7JVUm/wvBAkgQEczDduTNbYVrZ2a1eNRRxgVqRxLUite1axj5dP61XjeoeCJzmm47AGPbn+LKKPYzaPxNubrF3Uin6OUmooaly5teMMp7nz0jzTQFnNxTj1pEBabBuJ/NTLK10i3RmcHx/9XfAwD+Yng3m9qMXef8z1AZfSKmf2wbyqY5Xd8hlnHDCd60vv/gGgLS+NlIYCNGGHkR9iv2wbBQg6QdPzHsDJ1jtoz3eU3DY/bpjb58sQPODzHm0dCpDtGtuznVdXoakTFSoac6ERvF80wsqfydnxqCGttnqMHvNW7NapPbkjywJ7IjW6RFbNo2wz9ierQWk1W+GyvSLjsw0V7vUPDEM4IShHyFgG40Q520JpjfInrW0e7Gpw8pZBQGysaHtNm1xhdMh2XIW3LwN9Ra95BIOGwstuH7mpQh9pNdbHopNwEUH2bDsi6Yzi7fmJtznenlcHM1HjErfOEl8PtLmjcOTVTWV8MAc4YLrlkJpQ0VfImwqXTQBW/mxJO1NxToq7Ko8WAMm1YVyaC9HDbSxnpqfoAh0F5qcX/tb0F4e9ujyl+NfR9ayA7Nws6avYnuAFwMz9JAiYTHHqJNQavqfmUudVAH9eTpBCkrQ6UaNEhVCj8vdpvl4SDWKK64HLIiTaZEFzMukEJly9iaf1d9x3Yg3y1uksKNVVGkqOTdljJT58rNNVhGp/egJprQ1sLbBWToGiidXi10B4FYfl4JRaMXhq2Xg3Y92nffRH3Dv8/cKDoqYLP5kdHmEm dqZyP6Ra DtqxxOYnRedEfiOyzj9sienb78eGsdPXZsR3Gweu0UklXTkn//Hq4MQy2UeiUYWvFt+HUw343nxWHUHxH/8VVJveovQmi0r/jqofylWmj0iICwK3a1OSV/t1TUGwPj72gJDI6NLxr0yOyDZSEnxOUp65a1hJbjfo80hmePbRpeauXkZskxs9B5cyA4/svZd+UigGpt6xr9kqp2jlu/xeCVS8BpSDvBzfNxC6OAgXcNyFZV93nCpXwMQvvvP+PHu+LV2Dmj2MmLgmWynu1phHl2HYwECmDg8RxGoOEFZpTGgqtzsEChZKb3diobWdhqazYCo4/bh5F7yAy/rMPdyLdC23QqKexNHPnpDENzj1j5lTFb7PJBrufgQP/YKL4E36akfZ+wc8nbdng8jZkmq79TobPOSBu37G/potne0miFLh0HsTVtx1bl3BQMJLGEanYR9hAPJ10ybZEVElvtf1vhlbJynFub0rT0/ExcKghTbr7ummC59a4SRWbusHa3U0iV02OZCM8PjtfWsQ4wHBk+AQSSzwTWgfSv0CGb+mwtKfXMsxD/eLqJwK9QR//1ojEE2Hjnj8bmIMzt4xX5wlT1P1LS0qE928+Tm8s9oD3PxtbGBY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.04.23 14:09, Lorenzo Stoakes wrote: > No invocation of get_user_pages() uses the vmas parameter, so remove > it. > > The GUP API is confusing and caveated. Recent changes have done much to > improve that, however there is more we can do. Exporting vmas is a prime > target as the caller has to be extremely careful to preclude their use > after the mmap_lock has expired or otherwise be left with dangling > pointers. > > Removing the vmas parameter focuses the GUP functions upon their primary > purpose - pinning (and outputting) pages as well as performing the actions > implied by the input flags. > > This is part of a patch series aiming to remove the vmas parameter > altogether. > > Signed-off-by: Lorenzo Stoakes > Suggested-by: Matthew Wilcox (Oracle) > Acked-by: Greg Kroah-Hartman > --- Acked-by: David Hildenbrand -- Thanks, David / dhildenb