From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7C0CC4332F for ; Tue, 22 Nov 2022 12:38:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F096E6B0071; Tue, 22 Nov 2022 07:38:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EB65E6B0073; Tue, 22 Nov 2022 07:38:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D58858E0001; Tue, 22 Nov 2022 07:38:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C54E06B0071 for ; Tue, 22 Nov 2022 07:38:45 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8B74BC0977 for ; Tue, 22 Nov 2022 12:38:45 +0000 (UTC) X-FDA: 80161032210.09.0B4B056 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 20F4020009 for ; Tue, 22 Nov 2022 12:38:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669120723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TlBwJNp/jitu4dnjNvCRWCp8vuWXGMZrB45QP9OtTb4=; b=IpzmBLNyACs49jY7lgm++c8lhjtDTgOXfwTpMANdyIWb3BfgSbDCeyxhy1qhFETXdDsd0G An5awmOQ49LKZxGh5izikymF4VR9bXLTXwERrsalSCWWgRSGPg0Pw+ndj60IUPIGdPJpKh EWzeYEpE3ou6yA2Us7yJHfSCe5bm1GU= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-185-CIeBf4cdNjO5f9t_kWqKqg-1; Tue, 22 Nov 2022 07:38:42 -0500 X-MC-Unique: CIeBf4cdNjO5f9t_kWqKqg-1 Received: by mail-wm1-f69.google.com with SMTP id h4-20020a1c2104000000b003d01b66fe65so3905957wmh.2 for ; Tue, 22 Nov 2022 04:38:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TlBwJNp/jitu4dnjNvCRWCp8vuWXGMZrB45QP9OtTb4=; b=oqNo4epCoLsM36zNz9teacIeCEKwGo2I2EHI3wuVMMmI8ZQOfpt+80+8HKLYBuFb62 1jqEVAxRAFctd/f5A2Brs6830yLO7ROz7n9FVmSUbt0X61eFyT9jCPq/JYwUBixEV0nW ylWIB7RFVMqcx2M2nhFommo3hcl1Z1ooyWqknaAIqWEwIMIj1npy7dVqkpLOy0qJgQGS lkXtmb55rBidT0c7v6xD7GT+NlUu2AUPZUuopZBTzKIg7GzvdKGGrlAMovYTr7VQBjad QB/zLedjXW0dVs+pqyKtvTsPzhuZ8BbNDaq9wUmN4XIx9Pf+CyK/8hDnK6nJXDyjXxWc itSQ== X-Gm-Message-State: ANoB5pkRAKzh9H03MtK1dNqYG1aPw6Z2Kp+Are8CaQ0LYvYuXG11e3LT 8Oos7tc53KwZt1jSYYUreCDYjO6T0/J9kuY8dk1CQvJjmlGcKoFZwLyDWRzi1evpQbR1TI1KHn3 pB4SuzmJ6Srs= X-Received: by 2002:adf:e844:0:b0:241:bfc9:5975 with SMTP id d4-20020adfe844000000b00241bfc95975mr6721671wrn.605.1669120721074; Tue, 22 Nov 2022 04:38:41 -0800 (PST) X-Google-Smtp-Source: AA0mqf7FQCDctLOc6CMomYnGKvCTF1tBw+hwXPXd04O7+t428MWI9RvMvJ15rLs2ESKiQpMYCXYY+g== X-Received: by 2002:adf:e844:0:b0:241:bfc9:5975 with SMTP id d4-20020adfe844000000b00241bfc95975mr6721629wrn.605.1669120720555; Tue, 22 Nov 2022 04:38:40 -0800 (PST) Received: from ?IPV6:2003:cb:c706:c300:b066:75e3:f1d2:b69b? (p200300cbc706c300b06675e3f1d2b69b.dip0.t-ipconnect.de. [2003:cb:c706:c300:b066:75e3:f1d2:b69b]) by smtp.gmail.com with ESMTPSA id e18-20020a5d5952000000b00236883f2f5csm13821707wri.94.2022.11.22.04.38.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Nov 2022 04:38:40 -0800 (PST) Message-ID: <6ace6cd4-3e13-8ec1-4c2a-49e2e14e81a6@redhat.com> Date: Tue, 22 Nov 2022 13:38:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 To: Hans Verkuil , Tomasz Figa , Marek Szyprowski Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-kselftest@vger.kernel.org, Linus Torvalds , Andrew Morton , Jason Gunthorpe , John Hubbard , Peter Xu , Greg Kroah-Hartman , Andrea Arcangeli , Hugh Dickins , Nadav Amit , Vlastimil Babka , Matthew Wilcox , Mike Kravetz , Muchun Song , Lucas Stach , David Airlie , Oded Gabbay , Arnd Bergmann , Mauro Carvalho Chehab References: <20221107161740.144456-1-david@redhat.com> <20221107161740.144456-17-david@redhat.com> <6175d780-3307-854c-448a-8e6c7ad0772c@xs4all.nl> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH RFC 16/19] mm/frame-vector: remove FOLL_FORCE usage In-Reply-To: <6175d780-3307-854c-448a-8e6c7ad0772c@xs4all.nl> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IpzmBLNy; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669120724; a=rsa-sha256; cv=none; b=sy82XL85+HGvRCDFJHbkbRmZVYMrv/UA9KTggkz/CPj1AyggUicoT62OlNK0aIsBhYjDG9 bVtxaahCmcis04bvnri3XuSt5hvmEjVYX1mofhDZgplx7M8krJNKolJZQMMkyBsnqJnApj y0wj0Ae0SHlDW9R4L5i88FIbfdz9vTE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669120724; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TlBwJNp/jitu4dnjNvCRWCp8vuWXGMZrB45QP9OtTb4=; b=OtDF00WJIR+gNgvrEKgoUvf9T8De1ajh9APjEQYfFPNb87sQYRmzzVNeIhtMDKhU4IPmgB 7VmDTVLp8hUNuVhHDB47SNuhotPSoXftj0FTxKRuqHohP4iiz4jjPHyYpl6zgC0bUYAjKx l4qX2rnLUpPli2njDsU2a2zQFJjkmvs= X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IpzmBLNy; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: zw7umrkio6is7jy4e3ybnuo9emui7x5o X-Rspamd-Queue-Id: 20F4020009 X-Rspamd-Server: rspam09 X-HE-Tag: 1669120723-508382 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 22.11.22 13:25, Hans Verkuil wrote: > Hi Tomasz, David, > > On 11/8/22 05:45, Tomasz Figa wrote: >> Hi David, >> >> On Tue, Nov 8, 2022 at 1:19 AM David Hildenbrand wrote: >>> >>> FOLL_FORCE is really only for debugger access. According to commit >>> 707947247e95 ("media: videobuf2-vmalloc: get_userptr: buffers are always >>> writable"), the pinned pages are always writable. >> >> Actually that patch is only a workaround to temporarily disable >> support for read-only pages as they seemed to suffer from some >> corruption issues in the retrieved user pages. We expect to support >> read-only pages as hardware input after. That said, FOLL_FORCE doesn't >> sound like the right thing even in that case, but I don't know the >> background behind it being added here in the first place. +Hans >> Verkuil +Marek Szyprowski do you happen to remember anything about it? > > I tracked the use of 'force' all the way back to the first git commit > (2.6.12-rc1) in the very old video-buf.c. So it is very, very old and the > reason is lost in the mists of time. > > I'm not sure if the 'force' argument of get_user_pages() at that time > even meant the same as FOLL_FORCE today. From what I can tell it has just > been faithfully used ever since, but I have my doubt that anyone understands > the reason behind it since it was never explained. > > Looking at this old LWN article https://lwn.net/Articles/28548/ suggests > that it might be related to calling get_user_pages for write buffers > (non-zero write argument) where you also want to be able to read from the > buffer. That is certainly something that some drivers need to do post-capture > fixups. > > But 'force' was also always set for read buffers, and I don't know if that > was something that was actually needed, or just laziness. > > I assume that removing FOLL_FORCE from 'FOLL_FORCE|FOLL_WRITE' will still > allow drivers to read from the buffer? Yes. The only problematic corner case I can imagine is if someone has a VMA without write permissions (no PROT_WRITE/VM_WRITE) and wants to pin user space pages as a read buffer. We'd specify now FOLL_WRITE without FOLL_FORCE and GUP would reject that: write access without write permissions is invalid. There would be no way around "fixing" this implementation to not specify FOLL_WRITE when only reading from user-space pages. Not sure what the implications are regarding that corruption that was mentioned in 707947247e95. Having said that, I assume such a scenario is unlikely -- but you might know better how user space usually uses this interface. There would be three options: 1) Leave the FOLL_FORCE hack in for now, which I *really* want to avoid. 2) Remove FOLL_FORCE and see if anybody even notices (this patch) and leave the implementation as is for now. 3) Remove FOLL_FORCE and fixup the implementation to only specify FOLL_WRITE if the pages will actually get written to. 3) would most probably ideal, however, I am no expert on that code and can't do it (707947247e95 confuses me). So naive me would go with 2) first. -- Thanks, David / dhildenb