From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 644E5D1356A for ; Sun, 27 Oct 2024 21:05:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E1B9A6B0082; Sun, 27 Oct 2024 17:05:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCB8D6B0085; Sun, 27 Oct 2024 17:05:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C47046B0089; Sun, 27 Oct 2024 17:05:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A11AA6B0082 for ; Sun, 27 Oct 2024 17:05:55 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6DFBCC0F5C for ; Sun, 27 Oct 2024 21:05:31 +0000 (UTC) X-FDA: 82720613724.15.9D6EF86 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf30.hostedemail.com (Postfix) with ESMTP id 17CFA80006 for ; Sun, 27 Oct 2024 21:05:09 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="WGNQlg/S"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9+AQM1qQ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="WGNQlg/S"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9+AQM1qQ; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730062944; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JJewF0+M7DZ1KsQ9HNlZe4k9AkbzHxEr9f0YzDD14+U=; b=Cq/q9euza2E71ZZUUxisu56LKxqyi5LnQiZEaqktOcascuBOyO7be22mcNM+B3ebtrkAQT 0VZCjyy/HHBcmB9pFiCWVrJWXZmV7xugjtKq8MSeaFQPsUZDZ/gL08N55qLkoIfcnLS1AS vfcCWM/QcT8sVr3xinp15OU+eDNAjIE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="WGNQlg/S"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9+AQM1qQ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="WGNQlg/S"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9+AQM1qQ; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730062944; a=rsa-sha256; cv=none; b=Y3jOSB5FnNd+5Trkh2nnvjub2IuA9GnMnzarVtYLUd5N0ObHVkP4seulJz53733yJ3tX5w gFsKC9IEISD+rt3Yy5BGYmxxndL83QIOLuXO1w4TlpFaFQdJTGJfACQwkgUNhjb/799GfN y7rj1n9Y0l4Qno4xv59ec2GL9lnGhas= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0D43421A4E; Sun, 27 Oct 2024 21:05:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1730063151; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JJewF0+M7DZ1KsQ9HNlZe4k9AkbzHxEr9f0YzDD14+U=; b=WGNQlg/SWzv5QibzDlND5uKg23OAxa3jMyuCIxUhEtFCDSWyi5QtAtJdxji/F6mWNC05Hx ccLpg0paFybRySAuRzKTaq0dpInUlrRFlNySIgQo2Z8h6hzspwCCG83H9zOYBLcBhIo192 u1aq5Wzwov+DtVC1LF72Svq23PjO6yQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1730063151; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JJewF0+M7DZ1KsQ9HNlZe4k9AkbzHxEr9f0YzDD14+U=; b=9+AQM1qQnkWHvZ8syEMfdVXqgyB+Vcm/s7V35BB0iZp6dzn6YFYyAlgCXOgdzWNb2pRq/P 5ZS07stqQjYi40BA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1730063151; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JJewF0+M7DZ1KsQ9HNlZe4k9AkbzHxEr9f0YzDD14+U=; b=WGNQlg/SWzv5QibzDlND5uKg23OAxa3jMyuCIxUhEtFCDSWyi5QtAtJdxji/F6mWNC05Hx ccLpg0paFybRySAuRzKTaq0dpInUlrRFlNySIgQo2Z8h6hzspwCCG83H9zOYBLcBhIo192 u1aq5Wzwov+DtVC1LF72Svq23PjO6yQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1730063151; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JJewF0+M7DZ1KsQ9HNlZe4k9AkbzHxEr9f0YzDD14+U=; b=9+AQM1qQnkWHvZ8syEMfdVXqgyB+Vcm/s7V35BB0iZp6dzn6YFYyAlgCXOgdzWNb2pRq/P 5ZS07stqQjYi40BA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E56AD137D4; Sun, 27 Oct 2024 21:05:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 7OZcNy6rHmdfdwAAD6G6ig (envelope-from ); Sun, 27 Oct 2024 21:05:50 +0000 Message-ID: <6ac7a38f-30df-4403-8723-a43829bcdba5@suse.cz> Date: Sun, 27 Oct 2024 22:05:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH mm-unstable v2] mm/page_alloc: keep track of free highatomic Content-Language: en-US To: Yu Zhao Cc: Andrew Morton , Johannes Weiner , Zi Yan , Mel Gorman , Matt Fleming , David Rientjes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Link Lin References: <20241026033625.2237102-1-yuzhao@google.com> <37a28ef7-e477-40b0-a8e4-3d74b747e323@suse.cz> <8459b884-5877-41bd-a882-546e046b9dad@suse.cz> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 17CFA80006 X-Stat-Signature: a5qd3frhcac58i94syyytn3m76gq9hj1 X-Rspam-User: X-HE-Tag: 1730063109-131113 X-HE-Meta: U2FsdGVkX1/+Zp4rLrPJ6fkD2Cx59nWVHZH8Z6jrfbdAI+RLgISn57rNDY6jGzbma1P26duwOBEdpOw7u/N8tn87HKzqB7ZyMJ86xkiDXvmpCDwGeMWyPkcOccm6E1Tbphr9/NqLvEJeTpIcG3jt3ojs8yf9nzf0wWsFI5yhtevnm57qVlpVKHkbDkJ6WI/Y9FAyt2RPfCA7noNzSo7tBC+5imZVJ0lVirj8oVG95lRZ6pf7qV+Q2xiiUHVQMsduX1BmLoS5wPg0VBdSnEcGeIMuGFWOIYWbM1gKLlWU/rbu+ypu6rUtYK175Ad8aP3kiSFY8EvIgjqYNQhlXlQyVmS8VMZZNolFYtDSSyIPhWVoA2RujM626FXg1k/fPJXekCgxrtVOBLwA8iF5N20jHSYFI5xxXWVrEqFR2SZOS5gwzU+gOq1grPTxN6cUDq5s0S3mtf5BLgzZ3OdkjujKJHigssBn5EV5Ts/j/YG6BY39X6nRkMO3NzFInBNdZPvs3WprTJkGNmumGTr8ZF2GoDct134GkeW7wI+wipU08kL0Z43GGCzT15HlZoAvf3iXUrTyj4jnDgWXYJo2/6T/tZg9AwmMF0tD8K69SBaKQJZSaoQTunOsUNuPSvrkbSnJ+BHUTcnG8g/K4GAcfu/4QBzZuUsc7deLz0xZXEz1rGFVsnMepf6BmV/orGQNeBbvUEA32v5CgqpK1NLYhattBOnbkm0MMTcZFVver4h6KkdKTE+BNY1GLDVvnem9vAo8QdtOpfWWF4PrRY6kZypNedqfoMu62yF9rG5SNFdFiatnXzGhrVDVFu9pgekfy5dHx7UCeiQvXhZSPBJMqiW3ZfZRQTo6RrAxNzhuUym8OwP+EmEhnwcuKLFfrzOBRRaFpH3+L7LMKYx2YvHB+tpx4NqyPFLNuUlUyHF0VyQ6dLJY0pjTMuMOZxRh8J6AyIPyro+lHBaJ1q5+yi50DPV 6G0JOORb 2WiGb76/L37XwnDsKoLlPYO35/uTkGFok9dsswsiyouRTvjK+Hkes65SB6dI6iohtRZRvoQWWcW0CHR/umdQplxl7IWiuzYORi9egL1tkHA2/XftA2dT7vo1nCrSCyEw+Z1qS24vHdp6iJ8bzqAFJfHTvnFdXZhsM2++7YUTEdWzGgh/D7WIlNgDIaNFPhd0dEkIRnMRYr+zewpURFjnT9J2PDIEmP4qTRW3v+FK+9iKxeT9kXLottnu34TTJQME7Wpo5jsSePBsiZARGDuf2Ywo1Y+C7h0SEMCBaRICeLC8ThnupipVXtu9qGFifhUAZU0CqDQAudQ+Ak6x0Po7O/CplGg2ivCJcGoTVKJ+vbvWJguc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000111, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/27/24 21:51, Yu Zhao wrote: > On Sun, Oct 27, 2024 at 2:36 PM Vlastimil Babka wrote: >> >> On 10/27/24 21:17, Yu Zhao wrote: >> > On Sun, Oct 27, 2024 at 1:53 PM Vlastimil Babka wrote: >> >> >> >> For example: >> >> - a page is on pcplist in MIGRATE_MOVABLE list >> - we reserve its pageblock as highatomic, which does nothing to the page on >> the pcplist >> - page above is flushed from pcplist to zone freelist, but it remembers it >> was MIGRATE_MOVABLE, merges with another buddy/buddies from the >> now-highatomic list, the resulting order-X page ends up on the movable >> freelist despite being in highatomic pageblock. The counter of free >> highatomic is now wrong wrt the freelist reality > > This is the part I don't follow: how is it wrong w.r.t. the freelist > reality? The new nr_free_highatomic should reflect how many pages are > exactly on free_list[MIGRATE_HIGHATOMIC], because it's updated > accordingly. You'd have to try implementing your change in the kernel without that migratetype hygiene series, and see how it would either not work, or you'd end up implementing the series as part of that. > (My current understanding is that, in this case, the reservation > itself is messed up, i.e., under-reserved.) > >> The series has addressed various scenarios like that, where page can end up >> on the wrong freelist.