linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Harry Yoo <harry.yoo@oracle.com>, David Rientjes <rientjes@google.com>
Cc: Christoph Lameter <cl@linux.com>, linux-mm@kvack.org
Subject: Re: [RFC v1 1/2] mm/slab: add sheaves_enabled read-only sysfs file
Date: Wed, 23 Apr 2025 16:24:23 +0200	[thread overview]
Message-ID: <6ac29f1c-3c4c-4e47-9927-89f89216b2c6@suse.cz> (raw)
In-Reply-To: <Z_hG5QqL0zCAXo_C@harry>

On 4/11/25 00:32, Harry Yoo wrote:
> On Tue, Apr 08, 2025 at 07:45:38PM -0700, David Rientjes wrote:
>> On Mon, 7 Apr 2025, Harry Yoo wrote:
>> 
>> > For user-space tools like slabinfo, it is difficult to determine whether
>> > a cache has sheaves enabled. Expose a read-only 'sheaves_enabled' sysfs
>> > file to indicate whether sheaves are enabled for a given cache.
>> > 
>> 
>> Thoughts on adding an entry to Documentation/ABI/testing/sysfs-kernel-slab 
>> for this one?
> 
> That makes sense, thanks!
> 
> New stats added by the sheaves series should also be there.
> 
> ...By the way I'm a bit unsure about the name.
> 'sheaves', 'has_sheaves' or 'sheaves_enabled'?

How about reporting sheaf_capacity isntead?


  reply	other threads:[~2025-04-23 14:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07  4:18 [RFC v1 0/2] slabinfo: sheaves statistics support Harry Yoo
2025-04-07  4:18 ` [RFC v1 1/2] mm/slab: add sheaves_enabled read-only sysfs file Harry Yoo
2025-04-09  2:45   ` David Rientjes
2025-04-10 22:32     ` Harry Yoo
2025-04-23 14:24       ` Vlastimil Babka [this message]
2025-04-07  4:18 ` [RFC v1 2/2] tools/mm/slabinfo: add support for sheaves stats Harry Yoo
2025-04-07  4:37 ` [RFC v1 0/2] slabinfo: sheaves statistics support Harry Yoo
2025-04-23 14:28   ` Vlastimil Babka
2025-04-25  8:16     ` Harry Yoo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ac29f1c-3c4c-4e47-9927-89f89216b2c6@suse.cz \
    --to=vbabka@suse.cz \
    --cc=cl@linux.com \
    --cc=harry.yoo@oracle.com \
    --cc=linux-mm@kvack.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox