From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73B80E7718D for ; Mon, 23 Dec 2024 07:16:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C66C76B0083; Mon, 23 Dec 2024 02:16:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C16426B0088; Mon, 23 Dec 2024 02:16:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADDCD6B0089; Mon, 23 Dec 2024 02:16:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8FDED6B0083 for ; Mon, 23 Dec 2024 02:16:13 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EE3DF120B79 for ; Mon, 23 Dec 2024 07:16:12 +0000 (UTC) X-FDA: 82925363808.23.761A4FA Received: from xry111.site (xry111.site [89.208.246.23]) by imf01.hostedemail.com (Postfix) with ESMTP id 81A3540010 for ; Mon, 23 Dec 2024 07:15:42 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=xry111.site header.s=default header.b=dYLhBand; dmarc=pass (policy=reject) header.from=xry111.site; spf=pass (imf01.hostedemail.com: domain of xry111@xry111.site designates 89.208.246.23 as permitted sender) smtp.mailfrom=xry111@xry111.site ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734938154; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ecGpjQJ+dPTMtl9IS6T8Zx3DPG9sUHrYzmuZ6ugsSWw=; b=S1NNVVkHJyLQjLmsC1ALEzNn1OtoUGFgnq0zL2dbui0PCls7tKCkH6yx2PsZ09RavhsmsF yp+7YqvgjUdg0FsdUQ4LasnxKLYNPS0IXRw0zyei5/v4t413MgRvILFYif1ZLVmCkleqCN gaXr6EpqirCA7QscLWJ+R4JtkGMovRM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734938154; a=rsa-sha256; cv=none; b=YIR8+opqBedx/mb0lJz5ChOh+yzfqwhLRgahfdvK7fDqXhPOXLdjL48I+64LsrFO4T78YV wUU3/ogut0awHnve12MwUrwtnl3B70MZZzcbys4soJxeL0aU1OhpJ6ExTsjMD9hQNFSeev RYKIgUe4YmrC2hZXvRoF850CoiLoAWI= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=xry111.site header.s=default header.b=dYLhBand; dmarc=pass (policy=reject) header.from=xry111.site; spf=pass (imf01.hostedemail.com: domain of xry111@xry111.site designates 89.208.246.23 as permitted sender) smtp.mailfrom=xry111@xry111.site DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xry111.site; s=default; t=1734938153; bh=ecGpjQJ+dPTMtl9IS6T8Zx3DPG9sUHrYzmuZ6ugsSWw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=dYLhBandMXiOWoijdab1gHiwxN4eR/VOe1BsVjVz9qXmRVOFQ3esRLy431bdS1dZk XfvgNo/mfzBUiJSkzYWjXUz9VNZqGIoxmAEmuMRQld4Umwy3a2m4Fwo8gIpR4U1JmC QNQagNSSgXTyOhRij3RWOWxKAWCl+3mSvRV2S1v8= Received: from [127.0.0.1] (unknown [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (secp384r1) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 1944F67671; Mon, 23 Dec 2024 02:15:35 -0500 (EST) Message-ID: <6ac0e0f71990e5a8dc52f00c737cdf56916e0d4e.camel@xry111.site> Subject: Re: [PATCH v7] mm/memblock: Add memblock_alloc_or_panic interface From: Xi Ruoyao To: Mike Rapoport , Guo Weikang Cc: Andrew Morton , Geert Uytterhoeven , Dennis Zhou , Tejun Heo , Christoph Lameter , Thomas Bogendoerfer , Sam Creasey , Huacai Chen , Will Deacon , Catalin Marinas , Oreoluwa Babatunde , rafael.j.wysocki@intel.com, Palmer Dabbelt , Hanjun Guo , Easwar Hariharan , Johannes Berg , Ingo Molnar , Dave Hansen , Christian Brauner , KP Singh , Richard Henderson , Matt Turner , Russell King , WANG Xuerui , Michael Ellerman , Stefan Kristiansson , Stafford Horne , Helge Deller , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Geoff Levand , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, kasan-dev@googlegroups.com, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org Date: Mon, 23 Dec 2024 15:15:34 +0800 In-Reply-To: References: <20241222111537.2720303-1-guoweikang.kernel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.2 MIME-Version: 1.0 X-Stat-Signature: zbgr3tbcfrodha5yyh9nnwooauc1jkdi X-Rspamd-Queue-Id: 81A3540010 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1734938142-417630 X-HE-Meta: U2FsdGVkX1+dZ+dDsa7E7qcGe5T5WnAdCBCLZTrDJGuDUUFxD+mQ1zHd2dZ0V9o+KiqOLA41jzwB0YcJqX0bzSDaTmmXGTiinWAx0b2xCeHyp/oswqgkuydtp+If8xQxE1k4wY5WTqY6MSbRAOgSQmvWOSXH4CcVwDEWUQNU3WC0v2JfLIbAPKJffhdBTj1HPlPqfede75CvJz8Cvyd2dIHnk7gL6/gtCk/C0fDAmdUVrl/vx7k4j5n+V6ohSk1tT1FoN0UZa3hw7ZvY4jrCN3ZQX+6eOZsB7cSk9+RRi7LJGEKzhpZhzwGPBErmW76+71IlGbIyt2E1vmIAPMHkYRdUzK/XNX3F9Vsni50QahF/kOMX3hqzZyD6N50yuXe6aQZR76a7Bz072ODKvcOmPkGLz1+acG4oaZNhBEXaNc4Nrh+ymWXyBitYGFy19Jd+NpoY4OWVjvVXb3N7SNMf1fjFzR9iVnJve6usLyomW0tFM8Xfu4zg/uo75kkMNtA5EfHQcuDOSq4X784t212QnYmaHbq6dw5D9D4OvM8TEuA3R1WdUiJVLJbLEPazdEy5twZuHA+Wr2a/lnNnrpOFE6riCdH/8fqZynschvVvIGTmSjX04pbECmb909bjfxFkR2fpwFku24F3ZaZ9StTCEWUhUU5yle5RNAd9L3Yk/KuXr9w4L8ZDSPgPILJLUEszG8AD/vTuJqVndXYMmq3/PeM271TcKgVMLHb/omWAYcZbSXiQviNekBjzPqq4s7cZeRln7Ny2kSLZjxez/dcEG9ukGABnlUcnhE3bGArfLen9YjMNElAEYNNm9C6CCIW3E9tkVRT9sMlN9BnABNTjexTkDzpeYomF9eyUWgzYegby2cA3V7zBvyioCmUO1QsinXTKcvVM7nJMPQrw0/yNyVXLG2qCswqQMzTVQeGPU8b1g1jgupfScXOujzlQjLi5bkGA8VZWGwv2VkZ2vDo 0QVEi66+ 0vtjIN9GLVSNMJcORd6Q94n/LKuJILUITv/2HgN2aMRhb+gUjG5iFzqchmGDupPWVe69b+PO786h4l57MCZ2c9jXoLTpQ26iD1pfqxVsHmsLlrbwTJOIApMBVr0gwL0mUK4QooJ422auwZGYOVB57IQlq2Ek41/aA5W4v4lMYaTT2ie+I5+MY1nyY9lgNU22rF25z6zgcbotoy6iqSLwaHGFU3A6quNpkbvTjBezUXE79DQEIfnm5YaBGIRHr5or0AuyvEo5QfOwoA01hlK45XztT9L4XPPIc2oU7cXN6S3f1onMOvrbc3E9vyzbhgmN8yhPQj6XVC+hAO9ZmmAcJBNasl0pIrOqzpzCMKRyNHl5wyI/SseAbjggVPjnMduhERjThjo7We+SbvjNUO2EBcSwZ9nldwHhRGrQzV5D3+MAL6LoGj2QdQVsGwY7yk34Og7ds7ukrQ0uwHnWMjcQE8jLfxshr96BcfYEu51r6qUIoxapvZ08w/MQif9jEZkLV3vw7refan8b2eIq5aynMszolA2mkQBnG9D0oZTGRu8A9tSQ/7HGxwepXTzT6UJAR+WH3nZGFQJkUCCgpp6WeOQoKaJcYZG5jPXKE66DNfLRlgiWsHQWQKlkC5ZdgcpSTqWuVc4EcVSM5gyAUKsCEs5A6ix+HpvhCdQuw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 2024-12-23 at 09:12 +0200, Mike Rapoport wrote: > On Sun, Dec 22, 2024 at 07:15:37PM +0800, Guo Weikang wrote: > > Before SLUB initialization, various subsystems used memblock_alloc to > > allocate memory. In most cases, when memory allocation fails, an immedi= ate > > panic is required. To simplify this behavior and reduce repetitive chec= ks, > > introduce `memblock_alloc_or_panic`. This function ensures that memory > > allocation failures result in a panic automatically, improving code > > readability and consistency across subsystems that require this behavio= r. > >=20 > > Changelog: > > ---------- > > v1: initial version > > v2: add __memblock_alloc_or_panic support panic output caller > > v3: panic output phys_addr_t use printk's %pap > > v4: make __memblock_alloc_or_panic out-of-line, move to memblock.c > > v6: Fix CI compile error > > Links to CI: https://lore.kernel.org/oe-kbuild-all/202412221000.r1NzXJU= O-lkp@intel.com/ > > v6: Fix CI compile warinigs > > Links to CI: https://lore.kernel.org/oe-kbuild-all/202412221259.JuGNAUC= q-lkp@intel.com/ > > v7: add chagelog and adjust function declaration alignment format > > ---------- > >=20 > > Signed-off-by: Guo Weikang > > Reviewed-by: Andrew Morton > > Reviewed-by: Geert Uytterhoeven > > Reviewed-by: Mike Rapoport (Microsoft) > > Acked-by: Xi Ruoyao >=20 > If people commented on your patch it does not mean you should add > Reviewed-by or Acked-by tags for them. Wait for explicit tags from the > reviewers. And: - Acked-by: indicates an agreement by another developer (often a maintainer of the relevant code) that the patch is appropriate for inclusion into the kernel.=20 I'm not a maintainer so I even don't have the right to use Acked-by :). --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University